Sure, I can do that.
Iago
On Tue, 2017-09-26 at 06:32 -0400, Ilia Mirkin wrote:
> Perhaps a debug message would be warranted in such a situation? I
> suspect it would be difficult to debug, esp if it came up in a
> regular application.
> On Sep 26, 2017 3:50 AM, "Iago Toral Quiroga"
> wrote:
> we
It works now, thanks!
Also
Reviewed-by: Bas Nieuwenhuizen
for this patch.
On Tue, Sep 26, 2017 at 4:38 PM, Dylan Baker wrote:
> This builds, installs, and has been tested on a r290x (Hawaii) with the Vulkan
> CTS. It dies horribly in a fire at the same point for the meson build as the
> autot
Reviewed-by: Bas Nieuwenhuizen
On Tue, Sep 26, 2017 at 7:52 AM, Samuel Pitoiset
wrote:
> We are pushing 16-bytes of constants, so we have to save/restore
> the same amount of data to avoid data corruption.
>
> Signed-off-by: Samuel Pitoiset
> Cc: 17.2
> ---
> src/amd/vulkan/radv_query.c | 4 +
For the series:
Reviewed-by: Bas Nieuwenhuizen
On Tue, Sep 26, 2017 at 2:26 PM, Samuel Pitoiset
wrote:
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_meta.h | 12 ---
> src/amd/vulkan/radv_meta_bufimage.c | 42
> -
> src/amd/
Commit 259fc505454ea6a67aeacf6cdebf1398d9947759 added linker error for
mismatching uniform precision, as required by GLES 3.0 specification and
conformance test-suite.
Several Android applications, including Forge of Empires, have shaders
which violate this rule, on uniforms that are declared but
On Wed, Sep 27, 2017 at 9:29 AM, Ian Romanick wrote:
> NAK.
>
> You mention varyings in the commit message, but then you quote spec text
> about uniforms.
Sorry, the part about varyings was a bad copy paste from the old
workaround patch on the bugzilla. The problem here is about uniforms.
> This
NAK.
You mention varyings in the commit message, but then you quote spec text
about uniforms. This bugged me, so I actually went and looked at the
GLSL ES 1.00 specification.
Section 4.3.5 (Varying) of the GLSL ES 1.00 specification says:
The precision of varying variables does not need to
Am 27.09.2017 um 01:03 schrieb Brian Paul:
> Silences a compiler warning.
> ---
> src/gallium/drivers/svga/svga_screen.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/gallium/drivers/svga/svga_screen.c
> b/src/gallium/drivers/svga/svga_screen.c
> index 16e350c..4cf12c5 100644
>
On Wed, Sep 27, 2017 at 2:32 AM, Juan A. Suarez Romero
wrote:
> On Mon, 2017-09-25 at 16:25 +0900, Tomasz Figa wrote:
>> On Fri, Aug 11, 2017 at 1:31 PM, Tomasz Figa wrote:
>> > On Fri, Aug 11, 2017 at 2:29 AM, Emil Velikov
>> > wrote:
>> > > On 10 August 2017 at 14:59, Tomasz Figa wrote:
>> >
Silences a compiler warning.
---
src/gallium/drivers/svga/svga_screen.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/drivers/svga/svga_screen.c
b/src/gallium/drivers/svga/svga_screen.c
index 16e350c..4cf12c5 100644
--- a/src/gallium/drivers/svga/svga_screen.c
+++ b/src/galliu
This builds, installs, and has been tested on a r290x (Hawaii) with the Vulkan
CTS. It dies horribly in a fire at the same point for the meson build as the
autotools build.
v2: - enable radv by default
- add shader cache support and enforce that it's built for radv
v3: - Fix typo in meson_opti
This allows building and installing the Intel "anv" Vulkan driver using
meson and ninja, the driver has been tested against the CTS and has
seems to pass the same series of tests (they both segfault when the CTS
tries to run wayland wsi tests).
There are still a mess of TODO, XXX, and FIXME commen
Meson doesn't allow setting environment variables for custom targets, so
we either need to not pass this as an environment variable or use a
shell script to wrap the invocation. The chosen solution has the
advantage of working for both autotools and meson.
v2: - put rules back in top scope (Ken)
It is possible to have DEBUG disabled but asserts on (NDEBUG(, which
cannot build because these asserts work on members that are only present
when DEBUG is on.
Reviewed-by: Kenneth Graunke
Signed-off-by: Dylan Baker
---
src/util/ralloc.c | 8
1 file changed, 8 insertions(+)
diff --git
This should save us some round trips while resizing.
Cc: mesa-sta...@lists.freedesktop.org
---
src/vulkan/wsi/wsi_common_wayland.c | 39 +++--
1 file changed, 33 insertions(+), 6 deletions(-)
diff --git a/src/vulkan/wsi/wsi_common_wayland.c
b/src/vulkan/wsi/wsi_c
We convert it over to an inti/finish model and make create/destroy
wrappers for the former.
Cc: mesa-sta...@lists.freedesktop.org
---
src/vulkan/wsi/wsi_common_wayland.c | 47 ++---
1 file changed, 33 insertions(+), 14 deletions(-)
diff --git a/src/vulkan/wsi/wsi_
Cc: mesa-sta...@lists.freedesktop.org
---
src/vulkan/wsi/wsi_common_wayland.c | 59 -
1 file changed, 38 insertions(+), 21 deletions(-)
diff --git a/src/vulkan/wsi/wsi_common_wayland.c
b/src/vulkan/wsi/wsi_common_wayland.c
index b0f58b3..ec90894 100644
--- a/s
We originally implemented caching to avoid unneeded round-trips to the
compositor when querying surface capabilities etc. to set up the
swapchain. Unfortunately, this doesn't work if vkDestroyInstance is
called after the Wayland connection has been dropped. In this case, we
end up trying to clean
`_EGLDriver *drv` is a freshly calloc()'ed object, memset(0)'ing some of
it is a no-op.
Signed-off-by: Eric Engestrom
---
src/egl/main/eglfallbacks.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/egl/main/eglfallbacks.c b/src/egl/main/eglfallbacks.c
index 1575ab5f79..2d4851f757 100644
Signed-off-by: Eric Engestrom
---
src/egl/drivers/dri2/egl_dri2.c | 101 +++-
src/egl/drivers/dri2/egl_dri2.h | 5 --
2 files changed, 49 insertions(+), 57 deletions(-)
diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
index a8f4
Signed-off-by: Eric Engestrom
---
src/egl/drivers/haiku/egl_haiku.cpp | 34 ++
1 file changed, 14 insertions(+), 20 deletions(-)
diff --git a/src/egl/drivers/haiku/egl_haiku.cpp
b/src/egl/drivers/haiku/egl_haiku.cpp
index a98470f62d..fea38e76ed 100644
--- a/src/e
Bonus: fixes a memleak on haiku when unloading the driver
Signed-off-by: Eric Engestrom
---
src/egl/drivers/dri2/egl_dri2.c | 9 -
src/egl/drivers/haiku/egl_haiku.cpp | 9 -
src/egl/main/egldriver.c| 5 +
src/egl/main/egldriver.h| 7 ---
4 file
Note: dropping the EGL_BAD_ALLOC in egl_haiku because it's
overwritten by the EGL_NOT_INITIALIZED in eglInitialize().
Signed-off-by: Eric Engestrom
---
src/egl/drivers/dri2/egl_dri2.c | 13 ++---
src/egl/drivers/haiku/egl_haiku.cpp | 13 ++---
src/egl/main/README.txt
There's no reason to store this there, it doesn't depend on the driver.
Signed-off-by: Eric Engestrom
---
src/egl/drivers/dri2/egl_dri2.c | 44 ++---
src/egl/drivers/dri2/egl_dri2.h | 2 --
2 files changed, 19 insertions(+), 27 deletions(-)
diff --git a/src/
This series is based on top of Emil's "egl/dri: link directly to
libglapi.so":
https://lists.freedesktop.org/archives/mesa-dev/2017-September/170160.html
It moves code out of a struct it doesn't belong to, then replaces
a complicated callback with a simple free(), drops two empty structs,
deduplic
On Tue 26 Sep 2017, Tomasz Figa wrote:
> Commit 259fc505454ea6a67aeacf6cdebf1398d9947759 added linker error for
> mismatching uniform precision, as required by GLES 3.0 specification and
> conformance test-suite.
>
> Several Android applications, including Forge of Empires, have shaders
> which vi
On Tuesday, September 26, 2017 4:31:46 AM PDT Eero Tamminen wrote:
> Hi,
>
> On 26.09.2017 12:04, Timothy Arceri wrote:
> > On 26/09/17 17:50, Kenneth Graunke wrote:
> [...]
> >> 2. It would be great to use this in anv as well, especially given that
> >> it has no GLSL IR linking to do this so
D'oh. :( Series is
Reviewed-by: Ian Romanick
On 09/24/2017 03:09 PM, Kenneth Graunke wrote:
> Embarassingly, someone enabled the ARB_shader_atomic_counter_ops
> extension for Gen7+ but never added the intrinsics to the switch
> statement in the vec4 backend, so they just hit an unreachable()
>
Jan Vesely writes:
> On Wed, 2017-09-20 at 19:10 -0500, Aaron Watry wrote:
>> [SNIP]
>>
>> Not trying to rain on your parade, but I've been thinking that we
>> might need to be able to query the installed libclc version or
>> possibly consider querying the libclc library for information about
>>
Ah,
this one works. Sorry Nicolai, I've tried the patchwork (rev 1) version
last week, but it didn't apply clean. Soo.
For the series
Tested-by: Dieter Nützel
Should I run any special app?
Notice any speedup?
Greetings,
Dieter
Am 16.09.2017 13:27, schrieb Nicolai Hähnle:
If you want to t
It's safer and more elegant.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_meta.c| 15 +--
src/amd/vulkan/radv_meta.h| 4 ++--
src/amd/vulkan/radv_meta_buffer.c | 4 ++--
src/amd/vulkan/radv_meta_clear.c | 2 +-
src/amd/vulkan/radv_meta_co
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_meta.h | 12 ---
src/amd/vulkan/radv_meta_bufimage.c | 42 -
src/amd/vulkan/radv_meta_clear.c| 4 ++--
src/amd/vulkan/radv_meta_copy.c | 13 ++--
4 files changed, 9 inserti
Adam Jackson writes:
> Ugh the GLX code. __GLX_MAX_CONTEXT_PROPS is 3 because glxproto.h is
> just a pile of ancient runes, so when the server begins sending more
> than 3 context properties this code refuses to work _at all_. Which is
> all just silly. If _XReply succeeds, it will have buffered
Hi,
On 20 September 2017 at 19:02, Emil Velikov wrote:
> Krzysztof Sobiecki (sobkas) provided a more elaborate fix on IRC,
> which I've applied ~15 minutes before this patch went out.
>
> Sorry about breaking things :-(
Even with the compile fix, this made Wayland compositors instantly die
when
Ugh the GLX code. __GLX_MAX_CONTEXT_PROPS is 3 because glxproto.h is
just a pile of ancient runes, so when the server begins sending more
than 3 context properties this code refuses to work _at all_. Which is
all just silly. If _XReply succeeds, it will have buffered the whole
reply, we can just w
https://bugs.freedesktop.org/show_bug.cgi?id=103002
Bug ID: 103002
Summary: string_buffer_test.cpp:43: error: ISO C++ forbids
initialization of member ‘str1’
Product: Mesa
Version: git
Hardware: Other
OS: Al
Quoting Rogovin, Kevin (2017-09-26 10:35:44)
> Hi,
>
> Attached to this message are the following:
> 1. a file giving example usage of the tool with a modified apitrace to
> produce json output
>
> 2. the patches to apitrace to make it BatchbufferLogger aware
>
> 3. the JSON fi
On Tue, 2017-09-26 at 11:59 -0700, Eric Anholt wrote:
> Instead of magic numbers, couldn't we just malloc the proplist here and
> free it after the loop?
Fine. You tyrant.
Actually I have a better idea. We've buffered the entire reply by this
point, we can just read two dwords at a time until we
Quoting Nirbheek Chauhan (2017-09-26 12:58:12)
> On Wed, Sep 27, 2017 at 1:11 AM, Dylan Baker wrote:
> > Quoting Nirbheek Chauhan (2017-09-26 12:29:30)
> >> On Tue, Sep 26, 2017 at 9:46 PM, Dylan Baker wrote:
> >> > This builds and installs, but I haven't had a chance to test it yet.
> >> >
> >>
Quoting Eric Anholt (2017-09-26 11:46:50)
> Dylan Baker writes:
>
> > This allows building and installing the Intel "anv" Vulkan driver using
> > meson and ninja, the driver has been tested against the CTS and has
> > seems to pass the same series of tests (they both segfault when the CTS
> > tri
On Wed, Sep 27, 2017 at 1:11 AM, Dylan Baker wrote:
> Quoting Nirbheek Chauhan (2017-09-26 12:29:30)
>> On Tue, Sep 26, 2017 at 9:46 PM, Dylan Baker wrote:
>> > This builds and installs, but I haven't had a chance to test it yet.
>> >
>> > v2: - enable radv by default
>> > - add shader cache
Quoting Nirbheek Chauhan (2017-09-26 12:29:30)
> On Tue, Sep 26, 2017 at 9:46 PM, Dylan Baker wrote:
> > This builds and installs, but I haven't had a chance to test it yet.
> >
> > v2: - enable radv by default
> > - add shader cache support and enforce that it's built for radv
> > v3: - Fix t
On 26.09.2017 20:34, Ian Romanick wrote:
I'm hoping to land my patch series that removes ir_assignment::condition
either today or tomorrow. I believe that series deletes all of this
code... but this patch would still be useful for stable.
Yep, that series is much appreciated. If it weren't for
On Tue, Sep 26, 2017 at 9:46 PM, Dylan Baker wrote:
> This builds and installs, but I haven't had a chance to test it yet.
>
> v2: - enable radv by default
> - add shader cache support and enforce that it's built for radv
> v3: - Fix typo in meson_options (Nicholas)
> - strip trailing 'svn
This seems reasonable to me, and gets myReviewed-by: Kenneth Graunke but I would wait to hear back from Ian since he's been looking at this too.Thanks for researching this carefully!___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.fr
Adam Jackson writes:
> Ugh the GLX code. __GLX_MAX_CONTEXT_PROPS is 3 because glxproto.h is
> just a pile of ancient runes, so when the server begins sending more
> than 3 context properties this code refuses to work _at all_.
>
> This extension is pretty obscure, so this probably isn't a big dea
Dylan Baker writes:
> This allows building and installing the Intel "anv" Vulkan driver using
> meson and ninja, the driver has been tested against the CTS and has
> seems to pass the same series of tests (they both segfault when the CTS
> tries to run wayland wsi tests).
>
> There are still a me
Hi,
XDC was a really great conference and loved the fact that it was
in just one room which kept all the hallway conversations in that room resulting
into more networking.
But I agree with Andres that for the videos, it would be great to split the
huge youtube video stream per presentation and hav
On 09/26/2017 10:27 AM, Juan A. Suarez Romero wrote:
> On Thu, 2017-09-21 at 10:39 -0500, Ian Romanick wrote:
>> On 09/20/2017 03:12 AM, Juan A. Suarez Romero wrote:
>>> On Sat, 2017-07-08 at 02:03 +0300, Andres Gomez wrote:
Ian, it looks like we could want this patch (and the others from the
I'm hoping to land my patch series that removes ir_assignment::condition
either today or tomorrow. I believe that series deletes all of this
code... but this patch would still be useful for stable.
On 09/26/2017 07:42 AM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> Overriding the default (
On Tuesday, 2017-09-26 07:48:37 +, Boris Brezillon wrote:
> cleared_and_retried is always reset to false when jumping to the retry
> label, thus leading to an infinite retry loop.
>
> Fix that by moving the cleared_and_retried variable definitions at the
> beginning of the function.
Reviewed-
Reviewed-by: Bruce Cherniak
> On Sep 25, 2017, at 5:28 PM, George Kyriazis
> wrote:
>
> No need to check if screen->pipe != pipe, so we can just assign it. Just do
> it.
> ---
> src/gallium/drivers/swr/swr_state.cpp | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/
Reviewed-by: Bruce Cherniak
> On Sep 25, 2017, at 5:28 PM, George Kyriazis
> wrote:
>
> Swr caches fb contents in tiles. Those tiles are stored on a per-context
> basis.
>
> When switching contexts that share resources we need to make sure that
> the tiles of the old context are being store
Ugh the GLX code. __GLX_MAX_CONTEXT_PROPS is 3 because glxproto.h is
just a pile of ancient runes, so when the server begins sending more
than 3 context properties this code refuses to work _at all_.
This extension is pretty obscure, so this probably isn't a big deal (if
it was we'd need to hack t
On 26.09.2017 18:55, Gustaw Smolarczyk wrote:
2017-09-26 16:46 GMT+02:00 Nicolai Hähnle :
From: Nicolai Hähnle
This fixes the extremely unlikely case that an application uses
0x8000 or 0x3f80 as border color for an integer texture and
helps in the also, but perhaps slightly less, unlik
On Mon, 2017-09-25 at 16:25 +0900, Tomasz Figa wrote:
> On Fri, Aug 11, 2017 at 1:31 PM, Tomasz Figa wrote:
> > On Fri, Aug 11, 2017 at 2:29 AM, Emil Velikov
> > wrote:
> > > On 10 August 2017 at 14:59, Tomasz Figa wrote:
> > > > dri2_fallback_swap_interval() currently used to stub out swap int
On Thu, 2017-09-21 at 10:39 -0500, Ian Romanick wrote:
> On 09/20/2017 03:12 AM, Juan A. Suarez Romero wrote:
> > On Sat, 2017-07-08 at 02:03 +0300, Andres Gomez wrote:
> > > Ian, it looks like we could want this patch (and the others from the
> > > series when they land) in -stable (?)
> > >
> >
Hi,
A small piece of feedback from those of us watching remotely. It would
be nice to have a simple to access index for the long livestream videos.
I think the XDC 2017 wiki page would be a good place for this
information. A brief example:
Presentation Title | Presenter Name | Link with tim
On Tue, 2017-09-26 at 19:11 +0200, Samuel Pitoiset wrote:
>
> On 09/26/2017 06:57 PM, Juan A. Suarez Romero wrote:
> > On Tue, 2017-07-25 at 17:56 +0200, Samuel Pitoiset wrote:
> > >
> > > On 07/25/2017 05:51 PM, Nicolai Hähnle wrote:
> > > > On 25.07.2017 15:29, Samuel Pitoiset wrote:
> > > > >
On 09/26/2017 06:57 PM, Juan A. Suarez Romero wrote:
On Tue, 2017-07-25 at 17:56 +0200, Samuel Pitoiset wrote:
On 07/25/2017 05:51 PM, Nicolai Hähnle wrote:
On 25.07.2017 15:29, Samuel Pitoiset wrote:
This is a workaround which fixes a rendering issue with Dawn
Of War III in full bindless m
On Wed, 2017-09-06 at 15:07 +0100, Emil Velikov wrote:
> On 5 August 2017 at 00:25, Emil Velikov wrote:
> > From: Emil Velikov
> >
> > As mentioned in previous commit the negative tests in dEQP expect the
> > arguments to be evaluated in particular order.
> >
> > Namely - first the dpy, then th
On Tue, 2017-08-22 at 09:20 +0100, Daniel Stone wrote:
> Hi,
>
> On 21 August 2017 at 18:30, Emil Velikov wrote:
> > On 21 August 2017 at 15:44, Daniel Stone wrote:
> > > My take on it is that the visual types are defined by the platform,
> > > and 0 is a perfectly sensible visual type for a pla
On Tue, 2017-07-25 at 17:56 +0200, Samuel Pitoiset wrote:
>
> On 07/25/2017 05:51 PM, Nicolai Hähnle wrote:
> > On 25.07.2017 15:29, Samuel Pitoiset wrote:
> > > This is a workaround which fixes a rendering issue with Dawn
> > > Of War III in full bindless mode because a depth texture most
> > > l
Hi all,
First again big thanks to Stéphane and Jennifer for organizing a great XDC.
Like last year we'd like to hear feedback on how this year's XDC went,
both the good (and what you'd like to see more of) and the not so
good. Talk selection, organization, location, scheduling of talks,
anything
2017-09-26 16:46 GMT+02:00 Nicolai Hähnle :
> From: Nicolai Hähnle
>
> This fixes the extremely unlikely case that an application uses
> 0x8000 or 0x3f80 as border color for an integer texture and
> helps in the also, but perhaps slightly less, unlikely case that 1 is
> used as a border co
On Tue, 2017-07-25 at 11:43 +0100, Emil Velikov wrote:
> On 25 July 2017 at 09:12, Nicolai Hähnle wrote:
> > On 21.07.2017 16:57, Emil Velikov wrote:
> > >
> > > From: Emil Velikov
> > >
> > > The correct offset is 322 as opposed to 332.
> > > Broken since the rework of GET_DISPATCH back in ~20
I've now pushed the series, so feel free to rebase =)
2017-09-22 16:10 GMT+02:00 Ian Romanick :
> This patch is
>
> Reviewed-by: Ian Romanick
>
> I have a couple patches that go on top of this particular patch, and I'd
> rather rebase before I send them out for review. :)
>
> On 09/14/2017 03:39
On Tue, 2017-07-11 at 15:42 +0300, Ville Syrjälä wrote:
> On Mon, Jul 10, 2017 at 11:42:18PM +0300, Andres Gomez wrote:
> > Ville, has this patch fallen through the cracks ?
>
> Nope. I've still been looking into the issue whenever I've had a
> few minutes to spare. I think I have it more or les f
This allows building and installing the Intel "anv" Vulkan driver using
meson and ninja, the driver has been tested against the CTS and has
seems to pass the same series of tests (they both segfault when the CTS
tries to run wayland wsi tests).
There are still a mess of TODO, XXX, and FIXME commen
This builds and installs, but I haven't had a chance to test it yet.
v2: - enable radv by default
- add shader cache support and enforce that it's built for radv
v3: - Fix typo in meson_options (Nicholas)
- strip trailing 'svn' from llvm version before setting the version
preprocesso
Meson doesn't allow setting environment variables for custom targets, so
we either need to not pass this as an environment variable or use a
shell script to wrap the invocation. The chosen solution has the
advantage of working for both autotools and meson.
v2: - put rules back in top scope (Ken)
It is possible to have DEBUG disabled but asserts on (NDEBUG(, which
cannot build because these asserts work on members that are only present
when DEBUG is on.
Reviewed-by: Kenneth Graunke
Signed-off-by: Dylan Baker
---
src/util/ralloc.c | 8
1 file changed, 8 insertions(+)
diff --git
On Tuesday, September 26, 2017 1:13:18 AM PDT Alejandro Piñeiro wrote:
> On 26/09/17 09:39, Kenneth Graunke wrote:
> > diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c
> > b/src/mesa/drivers/dri/i965/genX_state_upload.c
> > index 612761601a2..2a99376e3c2 100644
> > --- a/src/mesa/drivers
On Tuesday, September 26, 2017 2:54:28 AM PDT Timothy Arceri wrote:
> On 26/09/17 17:50, Kenneth Graunke wrote:
> > A couple more thoughts:
> >
> > 1. We're calling brw_nir_optimize even more now...it might make sense to
> > drop it from brw_preprocess_nir, drop it here, and put it once in the
The crash is in GLU, and I'm 99% sure that it has to do with the format
of that texture.
I saw a patch from Miklòs Màté a while ago that changed something in
src/mesa/state_tracker/st_atom_sampler.c to fix this (link:
https://patchwork.freedesktop.org/patch/68298/). It never made it to
master,
On 26/09/17 12:20, Ilia Mirkin wrote:
On Tue, Sep 26, 2017 at 7:07 AM, Jose Fonseca wrote:
On 25/09/17 14:30, Eric Engestrom wrote:
I pushed the rest of the series.
See below for discussion on this patch.
On Wednesday, 2017-09-20 17:05:21 +, Jose Fonseca wrote:
On 19/09/17 15:14, Eric
From: Nicolai Hähnle
It leads to surprising states with integer inputs and outputs on
vertex processing stages (e.g. geometry stages). Instead, rely on the
driver to choose smooth interpolation by default.
We still allow varyings to match when one stage declares it as smooth
and the other declar
The function pipe_buffer_map() is only for linear pipe buffer,
with height as 0, and it's not for any 2D textures.
Signed-off-by: Leo Liu
Cc: mesa-sta...@lists.freedesktop.org
Cc: Mark Thompson
---
src/gallium/state_trackers/va/buffer.c | 12 +---
1 file changed, 9 insertions(+), 3 dele
We are pushing 16-bytes of constants, so we have to save/restore
the same amount of data to avoid data corruption.
Signed-off-by: Samuel Pitoiset
Cc: 17.2
---
src/amd/vulkan/radv_query.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/amd/vulkan/radv_query.c b/src/am
Hi Ken,
Thank you so much for reviewing and helping me out with this! I'll make the
changes you suggested
to both patches and resubmit.
Thanks,
Pam
On Tue, Sep 26, 2017 at 3:32 AM, Kenneth Graunke
wrote:
> On Tuesday, August 29, 2017 9:24:01 AM PDT Plamena Manolova wrote:
> > We can implement A
From: Nicolai Hähnle
The hardware usually does this automatically. However, we upgrade
depth to Z32_FLOAT to enable TC-compatible HTILE, which means the
hardware no longer clamps the comparison value for us.
The only way to tell in the shader whether a clamp is required
seems to be to communicat
From: Nicolai Hähnle
The hardware does this automatically for unorm formats, but we need to
do it manually for unorm depth formats that have been upgraded to
Z32_FLOAT.
Fixes
dEQP-GLES31.functional.texture.border_clamp.range_clamp.nearest_unorm_depth
and others.
Fixes: d4d9ec55c589 ("radeonsi:
From: Nicolai Hähnle
This fixes the extremely unlikely case that an application uses
0x8000 or 0x3f80 as border color for an integer texture and
helps in the also, but perhaps slightly less, unlikely case that 1 is
used as a border color.
---
src/gallium/drivers/radeonsi/si_descriptors.c
Hi all,
radeonsi can transparently upgrade unorm depth textures to float,
which means that some of the depth value clamping that is usually
performed in hardware must be done manually.
Also, setting the border color for integer textures properly
requires doing it slightly differently. This is som
From: Nicolai Hähnle
Fix the custom cube coord selection sequence to be identical to
the hardware v_cubesc/tc and OpenGL spec. Affects texture sampling
with user-provided derivatives.
Fixes dEQP-GLES3.functional.shaders.texture_functions.texturegrad.*
Cc: mesa-sta...@lists.freedesktop.org
---
From: Nicolai Hähnle
Not that those are super common or useful, but hey! Fun corner cases
of the API...
Fixes dEQP-GLES31.functional.geometry_shading.emit.*
Cc: mesa-sta...@lists.freedesktop.org
---
src/gallium/drivers/radeonsi/si_state_shaders.c | 8 +---
1 file changed, 5 insertions(+),
From: Nicolai Hähnle
Found by address sanitizer.
The loop here tries to be safe, but in doing so, it ends up doing
exactly the wrong thing: the safe foreach is for when the loop
variable (inst) could be deleted and nothing else. However, this
particular can delete inst's successor, but not inst
From: Nicolai Hähnle
Avoid a v_cndmask: the absolute value is free due to input modifiers.
---
src/amd/common/ac_llvm_build.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c
index 8c050f31a76..71468df
From: Nicolai Hähnle
Overriding the default (no-op) swizzle is clearly counter-productive,
since the whole point is putting the destination register as one of
the source operands so that it remains unmodified when the assignment
condition is false.
Fragment depth and stencil outputs are a specia
Hi all,
There isn't much of a theme to this series, except that all those
patches are vaguely compiler-related.
Please review!
Thanks,
Nicolai
--
src/amd/common/ac_llvm_build.c| 17 +
.../drivers/radeonsi/si_state_shaders.c | 8 +---
src/mesa/state_tra
From: Nicolai Hähnle
---
src/gallium/drivers/radeon/cayman_msaa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeon/cayman_msaa.c
b/src/gallium/drivers/radeon/cayman_msaa.c
index 33f1040185a..ec6c49bafa0 100644
--- a/src/gallium/drivers/radeon/cayman
From: Nicolai Hähnle
It has to happen after descriptor uploads since otherwise we'll print out
the wrong GPU list / incorrectly claim descriptor corruption.
---
src/gallium/drivers/radeonsi/si_compute.c| 7 +++
src/gallium/drivers/radeonsi/si_state_draw.c | 7 +++
2 files changed, 6
From: Nicolai Hähnle
Redundant with the recently added ac_llvm_context::chip_class.
---
src/amd/common/ac_nir_to_llvm.c | 21 ++---
src/amd/common/ac_shader_abi.h | 2 --
src/gallium/drivers/radeonsi/si_shader.c | 2 --
3 files changed, 10 insertions(+), 15 d
Ping.
On 16.09.2017 13:23, Nicolai Hähnle wrote:
Hi all,
This series was motivated by radeonsi failing some ldexp tests due to
not handling denorms correctly and not handling overflows (which GLSL
doesn't require, but GLSL ES does).
The first patch fixes the GLSL IR lowering of ldexp() to hand
Hello Lucas,
On Fri, Sep 22, 2017 at 11:27:36AM +0200, Lucas Stach wrote:
> It seems that newer cores don't use the PA_ATTRIBUTES to decide if the
> varying should bypass the flat shading, but derive this from the component
> use. This fixes flat shading on GC880+.
>
> VARYING_COMPONENT_USE_POINT
On September 26, 2017 4:05:04 AM Timothy Arceri wrote:
On 26/09/17 17:50, Kenneth Graunke wrote:
On Monday, September 25, 2017 6:23:13 PM PDT Timothy Arceri wrote:
For now linking is just removing unused varyings between stages.
shader-db results BDW:
total instructions in shared programs:
On Mon, Sep 25, 2017 at 7:36 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> %9903 = OpImageSampleDrefExplicitLod %float %14616 %14315 %16081 Lod
> %float_0
> %14616 = OpSampledImage %510 %8499 %13137
>
> %278 = OpTypeImage %float 2D 1 0 0 1 Unknown
> %510 = OpTypeSampledImage %278
>
> %8499 = Op
Reviewed-by: Jason Ekstrand
On Tue, Sep 26, 2017 at 1:14 AM, Gwan-gyeong Mun wrote:
> To check a valid usage requirement.
>
> Signed-off-by: Mun Gwan-gyeong
> ---
> src/intel/vulkan/genX_cmd_buffer.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/intel/vulkan/genX_cmd_buffer.c
>
On 09/26/2017 12:45 PM, Nicolai Hähnle wrote:
Gert's suggestion makes sense. Apart from that, the series is
Yeah, I will add an assert over there, thanks!
Reviewed-by: Nicolai Hähnle
On 22.09.2017 09:22, Samuel Pitoiset wrote:
That's unnecessary to double-check that dcc_offset is not 0
On Tuesday, 2017-09-19 17:19:59 +, Emil Velikov wrote:
> From: Emil Velikov
>
> In order to build EGL, one has to use shared glapi - libglapi.so.
>
> Thus the dlopen/dlsym dance is no longer needed and we can link to the
> library directly.
>
> This allows us to remove a handful of platform
1 - 100 of 135 matches
Mail list logo
