Re: [Mesa-dev] [PATCH v2 0/9] Introduce supporting of Tizen to mesa's egl platform

Hi, Emil Thank you for reviewing patches in detail. > A couple of high level questions: > - there seems to be no EGL platform extension for Tizen > Pretty much every serious platform has one + most even made it as part > of EGL 1.5* As you mentioned, (as far as I know) for now, Tizen Platform d

[Mesa-dev] [Bug 103062] Error starting game FS17

https://bugs.freedesktop.org/show_bug.cgi?id=103062 --- Comment #6 from alexander --- (In reply to Emil Velikov from comment #5) > That's not it works. Can you provide a more complete log/output from the > game? I'm in the conclusion of starting the game I downloaded the new version. The game now

[Mesa-dev] [PATCH v3 21/22] egl/android: apply dri2_egl_surface_get_image_front() helper

Signed-off-by: Mun Gwan-gyeong --- src/egl/drivers/dri2/platform_android.c | 35 + 1 file changed, 1 insertion(+), 34 deletions(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c index a8e33fb3e2..ba7ab4cd98 100644 -

[Mesa-dev] [PATCH v3 12/22] egl: add dri2_egl_surface_destroy_image_back() helper

To share common destroy dri_image_back code. Signed-off-by: Mun Gwan-gyeong --- src/egl/drivers/dri2/egl_dri2.c | 14 ++ src/egl/drivers/dri2/egl_dri2.h | 3 +++ 2 files changed, 17 insertions(+) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 8

[Mesa-dev] [PATCH v3 18/22] egl/android: apply dri2_egl_surface_update_buffer_age() helper

Signed-off-by: Mun Gwan-gyeong --- src/egl/drivers/dri2/platform_android.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c index d5ce48a34c..5c014268b1 100644 --- a/src/egl/drivers/d

[Mesa-dev] [PATCH v3 15/22] egl/tizen: add support of dri_image_loader (v2)

It adds support of dri_image_loader to egl dri2 tizen backend. - referenced a basic buffer flow and management implementation from android's. It adds dri_image_back/dri_image_back member variables to dri_egl_surface for a management of back/front buffers. v2: - Fixes from Emil's review:

[Mesa-dev] [PATCH v3 14/22] egl: add dri2_egl_surface_get_image_front() helper

To share common get and create dri_image_front code. Signed-off-by: Mun Gwan-gyeong --- src/egl/drivers/dri2/egl_dri2.c | 36 src/egl/drivers/dri2/egl_dri2.h | 3 +++ 2 files changed, 39 insertions(+) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/d

[Mesa-dev] [PATCH v3 11/22] egl/tizen: add EGL_NATIVE_SURFACE_TIZEN target of eglCreateImageKHR()

It adds TIZEN_image_native_surface extension string to _EGLExtensions. And it adds a routine of creating an EGLImage from a tbm_surface. - section overview from https://www.khronos.org/registry/EGL/extensions/TIZEN/EGL_TIZEN_image_native_surface.txt "Tizen Buffer Manager (TBM) is a use

[Mesa-dev] [PATCH v3 22/22] docs: add a high level info about Tizen / Tizen Porting Layer (TPL) for EGL / Tizen Buffer Manager (TBM) / etc

It gives a quick overview and references of developing OpenGLES / EGL Driver for Tizen. Signed-off-by: Mun Gwan-gyeong --- docs/systems.html | 1 + docs/tizen.html | 245 ++ 2 files changed, 246 insertions(+) create mode 100644 docs/tizen.

[Mesa-dev] [PATCH v3 20/22] egl/android: apply dri2_egl_surface_destroy_image_front() helper

Signed-off-by: Mun Gwan-gyeong --- src/egl/drivers/dri2/platform_android.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c index 8dda0a8734..a8e33fb3e2 100644 --- a/src/egl/drivers/dri2/pl

[Mesa-dev] [PATCH v3 19/22] egl/android: apply dri2_egl_surface_destroy_image_back() helper

Signed-off-by: Mun Gwan-gyeong --- src/egl/drivers/dri2/platform_android.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c index 5c014268b1..8dda0a8734 100644 --- a/src/egl/drivers/d

[Mesa-dev] [PATCH v3 10/22] egl/tizen: add tizen specific implementation for EGL_WAYLAND_BUFFER_WL target of eglCreateImageKHR() (v2)

In the tizen platform, a wl_buffer wraps a tbm_surface. The tbm_surface contains gem name or prime fd. For creating dri_image, we need to extract the tbm_surface from the wl_buffer and we use tpl_display_get_buffer_from_native_pixmap() api for that. v2: a) Add switch's default case to return on

[Mesa-dev] [PATCH v3 13/22] egl: add dri2_egl_surface_destroy_image_front() helper

To share common destroy dri_image_front code. Signed-off-by: Mun Gwan-gyeong --- src/egl/drivers/dri2/egl_dri2.c | 14 ++ src/egl/drivers/dri2/egl_dri2.h | 3 +++ 2 files changed, 17 insertions(+) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index

[Mesa-dev] [PATCH v3 17/22] egl/android: apply dri2_egl_surface_record_buffers_and_update_back_buffer() helper

Signed-off-by: Mun Gwan-gyeong --- src/egl/drivers/dri2/platform_android.c | 25 ++--- 1 file changed, 2 insertions(+), 23 deletions(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c index 0acbb38bd8..d5ce48a34c 100644 --- a/sr

[Mesa-dev] [PATCH v3 16/22] egl/android: apply dri2_egl_surface_free_outdated_buffers_and_update_size() helper

Signed-off-by: Mun Gwan-gyeong --- src/egl/drivers/dri2/platform_android.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c index e390365b8b..0acbb38bd8 100644 --- a/src/egl/drivers/dri2

[Mesa-dev] [PATCH v3 09/22] egl/tizen: add tizen specific implementations for BindWaylandDisplayWL/UnbindWaylandDisplayWL/QueryWaylandBufferWL (v2)

Tizen platform (actually WL_TBM protocol) internally processes similiar actions such as mesa's BindWaylandDisplayWL/UnbindWaylandDisplayWL/QueryWaylandBufferWL. So the platform_tizen.c needs to implemment BindWaylandDisplayWL, UnbindWaylandDisplayWL and QueryWaylandBufferWL apart from mesa's. -

[Mesa-dev] [PATCH v3 07/22] egl: add dri2_egl_surface_update_buffer_age() helper

To share common update buffer age code. This updates old buffer's age and sets current back buffer's age to 1. Signed-off-by: Mun Gwan-gyeong --- src/egl/drivers/dri2/egl_dri2.c | 19 +++ src/egl/drivers/dri2/egl_dri2.h | 3 +++ 2 files changed, 22 insertions(+) diff --git a/sr

[Mesa-dev] [PATCH v3 06/22] egl: add dri2_egl_surface_record_buffers_and_update_back_buffer() helper

To share common record buffers and update back buffer code. This records all the buffers created by ANativeWindow [Android] or tpl_surface (tbm_surface_queue) [TIZEN] and update back buffer for updating buffer's age in swap_buffers. Signed-off-by: Mun Gwan-gyeong --- src/egl/drivers/dri2/egl_dri

[Mesa-dev] [PATCH v3 05/22] egl: add dri2_egl_surface_free_outdated_buffers_and_update_size() helper

To share common free outdated buffers and update size code. This compares width and height arguments with current egl surface dimension, if the compared surface dimension is differ, then it free local buffers and updates dimension. Signed-off-by: Mun Gwan-gyeong --- src/egl/drivers/dri2/egl_dri2

[Mesa-dev] [PATCH v3 08/22] egl/tizen: add support of dri2_loader (v2)

It adds support of dri2_loader to egl dri2 tizen backend. - referenced a basic buffer flow and management implementation from android. And it implements a query buffer age extesion for tizen and turn on swap_buffers_with_damage extension. - it add color buffer related member variables to dri_e

[Mesa-dev] [PATCH v3 04/22] configure.ac: Add tizen to supported platforms (v2)

It checks tpl-egl/libtbm/libtdm packages and defines HAVE_PLATFORM_TIZEN. This feature is enabled by the config option '--with-platforms=tizen' v2: Fixes from Emil's review: - Add require_libdrm to tizen platform Signed-off-by: Mun Gwan-gyeong --- configure.ac | 10 -- 1 file changed,

[Mesa-dev] [PATCH v3 02/22] egl/dri2: Add some member variables for tizen platform on dri2_egl_display and dri2_egl_surface

It adds some member variables for tizen platform on dri2_egl_display and dri2_egl_surface. - tpl_display stores a object which encapsulates native disply (wl_display, gbm_device, tbm_bufmgr) for tizen platfom. - native_win stores native window (wl_surface, gbm_surface, tbm_surface_queue_h

[Mesa-dev] [PATCH v3 03/22] egl/tizen: add support of the swrast related features for tizen platform (v2)

It implements the egl swrast related features for tizen platform on platform_tizen.c It works with libtpl-egl (Tizen Porting Layer for egl) and libtbm (Tizen Buffer Manager) where back buffers of windows are backed by GEM objects. In Tizen a native window has a queue (tbm_surface_queue) of back

[Mesa-dev] [PATCH v3 01/22] egl: add a treatment of tizen platform on egl display (v2)

It adds a _EGL_PLATFORM_TIZEN enum value to _EGLPlatformType for tizen platform. It adds a detecting routine of tizen platform to _eglNativePlatformDetectNativeDisplay() and _eglGetNativePlatform(). - As tizen platform internally distinguishes native displays of tbm, drm/gbm and wayland cl

[Mesa-dev] [Bug 103078] MATLAB broken with mesa software rendering

https://bugs.freedesktop.org/show_bug.cgi?id=103078 --- Comment #2 from sergio.calleg...@gmail.com --- Hi, I totally understand the difficulty in looking into an issue related to (expensive) commercial, that - as such - is hard to reproduce. Thanks for the suggestion, even if - on a machine that

Re: [Mesa-dev] [PATCH 1/7] egl: Support IMG_context_priority

FYI I've tested this series using your 'preemption' branch on KBL and 'egl-context-priority' test passes. The other Piglit test I sent ('egl-context-priority-runtime') does not always pass but I think the problem is actually in the test itself, it's making assumptions that are not true. I will

Re: [Mesa-dev] [PATCH] radv: emit fmuladd instead of fma to llvm.

Reviewed-by: Bas Nieuwenhuizen On 4 Oct 2017 04:11, "Dave Airlie" wrote: From: Dave Airlie For Vulkan SPIR-V the spec states fma() Inherited from OpFMul followed by OpFAdd. Matt says the backend will do the right thing depending on the hardware being compiled for, if you use the fmuladd intr

Re: [Mesa-dev] [PATCH] Replace byte-swapping code with builtins in pack.c

On Tue, Oct 3, 2017 at 11:01 AM, Jochen Rollwagen wrote: > From 4cebe50a9bade6717923e104c954f3fad75f71bb Mon Sep 17 00:00:00 2001 > From: Jochen Rollwagen > Date: Tue, 3 Oct 2017 19:54:10 +0200 > Subject: [PATCH] Replace byte-swapping code with builtins in pack.c > > This patch replaces some code

Re: [Mesa-dev] [PATCH v2 10/11] anv: enable multiple planes per image/imageView

On 04/10/17 02:16, Jason Ekstrand wrote: Ok, maybe I'm being a bit dense, but doesn't the aspect imply the plane?  Why can't we just use anv_image_aspect_to_plane here?  That would reduce the churn by a good bit.                               enum isl_aux_usage aux_usage,            

[Mesa-dev] [PATCH] radv: enable tc compatible htile for d32s8 also.

From: Dave Airlie This enables tc compatible htile for stencil surfaces as well. This gives a 3-5fps boost on Mad Max on high@4k. It also depends on Bas's tc-compat htile patch. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_image.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [Mesa-dev] [PATCH] Replace byte-swapping code with builtins in pack.c

On 10/03/2017 12:01 PM, Jochen Rollwagen wrote: From 4cebe50a9bade6717923e104c954f3fad75f71bb Mon Sep 17 00:00:00 2001 From: Jochen Rollwagen Date: Tue, 3 Oct 2017 19:54:10 +0200 Subject: [PATCH] Replace byte-swapping code with builtins in pack.c This patch replaces some code for byte-swapping

[Mesa-dev] [PATCH] Replace byte-swapping code with builtins in pack.c

From 4cebe50a9bade6717923e104c954f3fad75f71bb Mon Sep 17 00:00:00 2001 From: Jochen Rollwagen Date: Tue, 3 Oct 2017 19:54:10 +0200 Subject: [PATCH] Replace byte-swapping code with builtins in pack.c This patch replaces some code for byte-swapping in pack.c with the builtin functions allowing th

[Mesa-dev] [PATCH] radv: emit fmuladd instead of fma to llvm.

From: Dave Airlie For Vulkan SPIR-V the spec states fma() Inherited from OpFMul followed by OpFAdd. Matt says the backend will do the right thing depending on the hardware being compiled for, if you use the fmuladd intrinsic. Using the Mad Max pts test, on high settings at 4K: CHP: 55->60 HGDD:

Re: [Mesa-dev] [PATCH] radv: Implement TC compatible HTILE.

On 4 October 2017 at 10:51, Bas Nieuwenhuizen wrote: > The situations where we enable it are quite limitied, but it works, > even for madmax, so lets just enable it. Let's land it, then we can work out where it needs tuning. Reviewed-by: Dave Airlie Dave. > --- > src/amd/vulkan/radv_device.c

Re: [Mesa-dev] [PATCH 1/6] meson: Build i965 and dri stack

On 10/03/2017 05:26 PM, Dylan Baker wrote: diff --git a/meson_options.txt b/meson_options.txt index eccd5c10d59..568903f1a0a 100644 --- a/meson_options.txt +++ b/meson_options.txt +option('valgrind', type : 'boolean', vaule : true, "vaule" typo. "[PATCH 5/6] meson_options: Remove ext

Re: [Mesa-dev] [PATCH 2/6] meson: build glx

On 10/03/2017 05:26 PM, Dylan Baker wrote: diff --git a/meson_options.txt b/meson_options.txt index 568903f1a0a..62d6b593f88 100644 --- a/meson_options.txt +++ b/meson_options.txt +option('glvnd', type : 'boolean', vaule : false, "vaule" again, although you fix this in "[PATCH 4/6]

[Mesa-dev] [PATCH] radv: Implement TC compatible HTILE.

The situations where we enable it are quite limitied, but it works, even for madmax, so lets just enable it. --- src/amd/vulkan/radv_device.c | 28 ++-- src/amd/vulkan/radv_image.c | 21 + src/amd/vulkan/radv_meta_clear.c | 18 ++

[Mesa-dev] [PATCH 2/6] meson: build glx

This gets GLX and the loader building. The resulting GLX and i965 have been tested on piglit and seem to work fine. This patch leaves a lot of todo's in it's wake, GLX is quite complicated, and the build options involved are many, and the goal at the moment is to get dri and gallium drivers buildin

[Mesa-dev] [PATCH 1/6] meson: Build i965 and dri stack

This gets pretty much the entire classic tree building, as well as i965, including the various glapis. There are some workarounds for bugs that are fixed in meson 0.43.0, which is due out on October 8th. I have tested this with piglit using glx. Signed-off-by: Dylan Baker --- bin/install_megadr

[Mesa-dev] [PATCH 6/6] meson: build classic swrast

This adds support for building the classic swrast implementation. This driver has been tested with glxinfo and glxgears. Signed-off-by: Dylan Baker --- meson.build | 2 ++ meson_options.txt | 2 +- src/mesa/drivers/dri/meson.build

[Mesa-dev] [PATCH 0/6] Meson round 3, classic drivers

This series adds support for building the two classic drivers that I could readily test, i965 and swrast. The main point is not to turn on drivers atm, but to demonstrate that the underlying stack is being compiled correctly and that the meson is correct and understandable; and to allow others want

[Mesa-dev] [PATCH 4/6] meson: build gbm

This doesn't include egl support, just dri support. Signed-off-by: Dylan Baker --- meson.build | 49 +--- meson_options.txt | 14 + src/{loader => gbm}/meson.build | 63 - src/glx/meson.

[Mesa-dev] [PATCH 3/6] meson: Add support for configuring dri drivers directory.

Signed-off-by: Dylan Baker --- meson.build | 6 ++ meson_options.txt| 14 -- src/glx/meson.build | 2 +- src/mesa/drivers/dri/meson.build | 2 +- 4 files changed, 16 insertions(+), 8 deletions(-) diff --git a/meson.build b/meso

[Mesa-dev] [PATCH 5/6] meson_options: Remove extra whitespace between parameters

Originally I had these all colomized and pretty, then I wrote descriptions for the options, and they ceased to be pretty. Signed-off-by: Dylan Baker --- meson_options.txt | 43 +-- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/meson_optio

Re: [Mesa-dev] [PATCH v2 3/3] glsl: make loop unrolling more like the nir unrolling path

Ping on patches 1 & 3 On 21/09/17 20:55, Timothy Arceri wrote: The old code assumed that loop terminators will always be at the start of the loop, resulting in otherwise unrollable loops not being unrolled at all. For example the current code would unroll: int j = 0; do { if (j > 5)

Re: [Mesa-dev] [PATCH v2 09/11] anv: add nir lowering pass for ycrcb textures

On Tue, Oct 3, 2017 at 4:54 PM, Jason Ekstrand wrote: > On Tue, Oct 3, 2017 at 9:29 AM, Lionel Landwerlin < > lionel.g.landwer...@intel.com> wrote: > >> This pass implements all the implicit conversions required by the >> VK_KHR_sampler_ycbcr_conversion specification. >> >> It also inserts plane

Re: [Mesa-dev] [PATCH v2 09/11] anv: add nir lowering pass for ycrcb textures

On Tue, Oct 3, 2017 at 9:29 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > This pass implements all the implicit conversions required by the > VK_KHR_sampler_ycbcr_conversion specification. > > It also inserts plane sources onto sampling instructions that we then > let the pipelin

Re: [Mesa-dev] [PATCH v2 01/11] vulkan: util: add macros to extract extension/offset number from enums

On Tue 03 Oct 2017, Jason Ekstrand wrote: > > On Tue, Oct 3, 2017 at 3:18 PM, Lionel Landwerlin <[1] > lionel.g.landwer...@intel.com> wrote: > > On 03/10/17 21:21, Chad Versace wrote: > > On Tue 03 Oct 2017, Lionel Landwerlin wrote: > > On 03/10/17 19:13, Jason Ekstrand

Re: [Mesa-dev] [PATCH v2 05/11] anv: modify the internal concept of format to express multiple planes

I made some comments on v1 of this patch which appear to have gone unanswered. The two I think are important are 1) Naming. Should it be plane_format or format_plane? I think I mildly prefer the later but coulbe be confinced. 2) I don't think anv_get_isl_format needs to be renamed. It alread

Re: [Mesa-dev] [PATCH 4/4] util: include string.h in u_string.h

For the series, Reviewed-by: Charmaine Lee From: Brian Paul Sent: Tuesday, October 3, 2017 1:04:16 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH 4/4] util: include string.h in u_string.h To fix MinGW compiler warnin

[Mesa-dev] [PATCH] egl/wayland: restore WAYLAND_CLIENT_CFLAGS

From: Slava Grigorev that is required to include wayland-egl.h header file if it is not in /usr/include Signed-off-by: Slava Grigorev Signed-off-by: Marek Olšák --- src/egl/wayland/wayland-egl/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/egl/wayland/wa

Re: [Mesa-dev] [PATCH v2 01/11] vulkan: util: add macros to extract extension/offset number from enums

On Tue, Oct 3, 2017 at 3:18 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 03/10/17 21:21, Chad Versace wrote: > >> On Tue 03 Oct 2017, Lionel Landwerlin wrote: >> >>> On 03/10/17 19:13, Jason Ekstrand wrote: >>> >>> On Tue, Oct 3, 2017 at 9:43 AM, Chad Versace <[1] >>> ch

Re: [Mesa-dev] [PATCH v2 01/11] vulkan: util: add macros to extract extension/offset number from enums

On 03/10/17 21:21, Chad Versace wrote: On Tue 03 Oct 2017, Lionel Landwerlin wrote: On 03/10/17 19:13, Jason Ekstrand wrote: On Tue, Oct 3, 2017 at 9:43 AM, Chad Versace <[1]chadvers...@chromium.org> wrote: On Tue 03 Oct 2017, Lionel Landwerlin wrote: > v2: Simplify

Re: [Mesa-dev] [PATCH] radv: lower ffma in nir.

Am 03.10.2017 um 22:58 schrieb Dave Airlie: > From: Dave Airlie > > So it appears the Vulkan SPIR-V fma opcode can be equivalent to a > mad operation, and the fma hw opcode on AMD hw is issued like a double > opcode so is slower. Also the radeonsi stack does this. > > This appears to improve per

Re: [Mesa-dev] [PATCH] radv: lower ffma in nir.

> On Oct 3, 2017, at 13:58, Dave Airlie wrote: > > From: Dave Airlie > > So it appears the Vulkan SPIR-V fma opcode can be equivalent to a > mad operation, and the fma hw opcode on AMD hw is issued like a double > opcode so is slower. Also the radeonsi stack does this. > > This appears to imp

[Mesa-dev] [PATCH] radv: lower ffma in nir.

From: Dave Airlie So it appears the Vulkan SPIR-V fma opcode can be equivalent to a mad operation, and the fma hw opcode on AMD hw is issued like a double opcode so is slower. Also the radeonsi stack does this. This appears to improve performance on a number of games from Feral, and thanks to Fe

[Mesa-dev] [PATCH 2/2] swr/rast: use proper alignment for debug transposedPrims

Causing a crash in ParaView waveletcontour.py test when _DEBUG defined due to vector aligned copy with unaligned address. --- src/gallium/drivers/swr/rasterizer/core/clip.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/clip.h b/src

[Mesa-dev] [PATCH 1/2] configure.ac: add _DEBUG to strip_unwanted_llvm_flags

Assert-enabled builds of llvm add _DEBUG to the LLVM_CFLAGS. This was causing a crash with swr running the ParaView waveletcontour.py test, due to a bug in our _DEBUG code. --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index 903a3979d4..b2768f46c

Re: [Mesa-dev] [PATCH v2 01/11] vulkan: util: add macros to extract extension/offset number from enums

On Tue 03 Oct 2017, Lionel Landwerlin wrote: > On 03/10/17 19:13, Jason Ekstrand wrote: > > On Tue, Oct 3, 2017 at 9:43 AM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > On Tue 03 Oct 2017, Lionel Landwerlin wrote: > > v2: Simplify offset enum computation (Jason)

[Mesa-dev] [PATCH 4/4] util: include string.h in u_string.h

To fix MinGW compiler warning about missing strlen() prototype. Not sure how I missed this when fixing the malloc() / stdlib.h issue. --- src/util/u_string.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/u_string.h b/src/util/u_string.h index 5a2a3e9..fa0241e 100644 --- a/src/util/u

[Mesa-dev] [PATCH 2/4] mesa: silence 'variable may be used uninitialized' warning in teximage.c

Found with MinGW optimized build. --- src/mesa/main/teximage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 0a3025a..bb22b9a 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -4885,7 +4885,7 @@ c

[Mesa-dev] [PATCH 3/4] llvmpipe: silence 'variable may be used uninitialized' warnings

--- src/gallium/auxiliary/gallivm/lp_bld_format_aos.c | 2 +- src/gallium/drivers/llvmpipe/lp_state_fs.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_format_aos.c b/src/gallium/auxiliary/gallivm/lp_bld_format_aos.c index 2f7238

[Mesa-dev] [PATCH 1/4] mesa: silence 'variable may be used uninitialized' warning in bufferobj.c

Found with MinGW optimized build. --- src/mesa/main/bufferobj.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 2da2128..0b98483 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -3287,6 +3287,7 @@ get_map_buff

Re: [Mesa-dev] [PATCH 14/15] build: Remove HAVE_DLOPEN

On Mon, Oct 2, 2017 at 1:59 AM, Matt Turner wrote: > --- > Android.common.mk | 1 - Reviewed-by: Rob Herring > configure.ac| 4 ++-- > meson.build | 1 - > src/mesa/SConscript | 4 > 4 files changed, 2 insertions(+), 8 deletions(-) > > diff --git a/Android.common.mk b/An

Re: [Mesa-dev] [PATCH 04/10] radv: do not rebind the same pipeline when doing meta operations

On 10/03/2017 08:55 PM, Bas Nieuwenhuizen wrote: Doesn't it make more sense to do the check in radv_CmdBindPipeline? It does. On Tue, Oct 3, 2017 at 8:52 PM, Samuel Pitoiset wrote: This might save some usless state changes, and it improves consistency with the other meta operations. Sig

Re: [Mesa-dev] [PATCH 04/10] radv: do not rebind the same pipeline when doing meta operations

Doesn't it make more sense to do the check in radv_CmdBindPipeline? On Tue, Oct 3, 2017 at 8:52 PM, Samuel Pitoiset wrote: > This might save some usless state changes, and it improves > consistency with the other meta operations. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_me

[Mesa-dev] [PATCH 03/10] radv: remove unused RADV_META_VERTEX_BINDING_COUNT

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/amd/vulkan/radv_meta.h b/src/amd/vulkan/radv_meta.h index 20b4498ab3..252514540e 100644 --- a/src/amd/vulkan/radv_meta.h +++ b/src/amd/vulkan/radv_meta.h @@ -33,8 +33,6 @@ exter

[Mesa-dev] [PATCH 02/10] radv: select the pipeline outside of the loop when decompressing htile

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_decompress.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/amd/vulkan/radv_meta_decompress.c b/src/amd/vulkan/radv_meta_decompress.c index c68be27f1f..8abbcb6723 100644 --- a/src/amd/

[Mesa-dev] [PATCH 07/10] radv: merge radv_meta_{save, restore}_pass() with RADV_META_SAVE_PASS

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta.c| 40 +++ src/amd/vulkan/radv_meta.h| 8 --- src/amd/vulkan/radv_meta_decompress.c | 6 ++ src/amd/vulkan/radv_meta_fast_clear.c | 7 +++--- 4 files changed, 22 insertio

[Mesa-dev] [PATCH 10/10] radv: convert all COMPUTE operations to the RADV_META_SAVE_XXX flags

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta.c| 31 src/amd/vulkan/radv_meta.h| 15 -- src/amd/vulkan/radv_meta_buffer.c | 17 +++ src/amd/vulkan/radv_meta_clear.c | 24 +++- src/amd/vulkan/radv_meta_

[Mesa-dev] [PATCH 08/10] radv: add radv_meta_save() helper

And merge radv_meta_save_novertex() with radv_meta_save_graphics_reset_vport_scissor_novertex(). Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta.c| 33 - src/amd/vulkan/radv_meta.h| 7 +++ src/amd/vulkan/radv_meta_blit.c

[Mesa-dev] [PATCH 01/10] radv: add radv_htile_enabled() helper

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 5 ++--- src/amd/vulkan/radv_private.h | 6 ++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 402c948e52..0e4a83d612 100644 --- a/src/amd/vulkan

[Mesa-dev] [PATCH 05/10] radv: introduce the concept of meta save flags

This will allow us to save/restore the different states on-demand based on the meta operation. For now, this saves/restores all states. Compute will follow once the graphics part is done. The main idea is to merge all save/restore helpers. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_

[Mesa-dev] [PATCH 09/10] radv: add RADV_META_SAVE_COMPUTE flag

This will allow use to merge the compute save/restore helpers. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta.c | 23 +-- src/amd/vulkan/radv_meta.h | 1 + 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_meta.c b/src/amd/vulka

[Mesa-dev] [PATCH 06/10] radv: convert all GFX operations to the RADV_META_SAVE_XXX flags

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_blit.c | 5 - src/amd/vulkan/radv_meta_clear.c | 20 src/amd/vulkan/radv_meta_copy.c | 11 +-- src/amd/vulkan/radv_meta_decompress.c | 3 ++- src/amd/vulkan/radv_meta_fast_clear.c | 3

[Mesa-dev] [PATCH 04/10] radv: do not rebind the same pipeline when doing meta operations

This might save some usless state changes, and it improves consistency with the other meta operations. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_buffer.c | 18 -- src/amd/vulkan/radv_meta_resolve_fs.c | 7 +-- 2 files changed, 17 insertions(+), 8 deleti

Re: [Mesa-dev] [PATCH 1/5] ac: properly document a buffer.store LLVM workaround

2-5 are: Reviewed-by: Samuel Pitoiset On 10/03/2017 07:30 PM, Marek Olšák wrote: From: Marek Olšák --- src/amd/common/ac_llvm_build.c | 13 - src/amd/common/ac_llvm_build.h | 2 +- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/amd/common/ac_llvm_build.c

Re: [Mesa-dev] [PATCH] radeonsi: add a drirc workaround for HTILE corruption in ARK: Survival Evolved

Figured the same fix locally yesterday, let's go this way for now. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102955 Reviewed-by: Samuel Pitoiset On 10/03/2017 07:32 PM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/driinfo_radeonsi.h | 4 src/gal

Re: [Mesa-dev] [PATCH v2 04/11] anv: prepare formats to handle disjoints sets

On Tue, Oct 3, 2017 at 10:16 AM, Chad Versace wrote: > On Tue 03 Oct 2017, Lionel Landwerlin wrote: > > Newer format enums start at offset 10, making it impossible to > > have them all in one table. This change splits the formats into sets > > that we then access through indirection. > >

Re: [Mesa-dev] [PATCH] configure.ac: bump Clover LLVM requirement to 3.9

On Tue, 2017-10-03 at 17:51 +0100, Emil Velikov wrote: > From: Emil Velikov > > The only driver that utilises Clover already depends on LLVM 3.9. > Additionally close to every supported distribution has said version. > > Additionally libclc requires LLVM 4.0 these days. support for llvm-3.9 has

Re: [Mesa-dev] [PATCH v2 01/11] vulkan: util: add macros to extract extension/offset number from enums

On 03/10/17 19:13, Jason Ekstrand wrote: On Tue, Oct 3, 2017 at 9:43 AM, Chad Versace > wrote: On Tue 03 Oct 2017, Lionel Landwerlin wrote: > v2: Simplify offset enum computation (Jason) > > Signed-off-by: Lionel Landwerlin mailto:lionel.g.landwer

Re: [Mesa-dev] [PATCH v2 01/11] vulkan: util: add macros to extract extension/offset number from enums

On Tue, Oct 3, 2017 at 9:43 AM, Chad Versace wrote: > On Tue 03 Oct 2017, Lionel Landwerlin wrote: > > v2: Simplify offset enum computation (Jason) > > > > Signed-off-by: Lionel Landwerlin > > --- > > src/vulkan/util/vk_util.h | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git a

Re: [Mesa-dev] [PATCH 2/2] egl/surfaceless: Use KMS swrast fallback

I mostly ran other tests suites. We actually don't run dEQP on VMs since our current swrast-based implementation would segfault. We would need a patch like: https://lists.freedesktop.org/archives/mesa-dev/2017-August/164922.html for it to work. However, I was able to verify dEQP successfully runs

Re: [Mesa-dev] [PATCH v2 3/3] etnaviv: optimize RS transfers

2017-09-22 11:31 GMT+02:00 Lucas Stach : > Currently we are blitting the whole resource when the RS is used to > de-/tile a resource. This can be very inefficient for large resources > where the transfer is only changing a small part of the resource > (happens a lot with glTexSubImage2D). > > Optim

Re: [Mesa-dev] [PATCH v2 2/3] etnaviv: add resource subregion copy

2017-09-22 11:31 GMT+02:00 Lucas Stach : > This is useful if we only need to copy part of a larger resource, mostly > when using the RS engine to de-/tile on pipe transfers. > > Signed-off-by: Lucas Stach > Reviewed-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner > --- > src/galli

Re: [Mesa-dev] [PATCH] etnaviv: update HW headers and fix provoking vertex

Hi Lucas, patch does not apply to master - could you rebase it? Applying: etnaviv: update HW headers and fix provoking vertex error: patch failed: src/gallium/drivers/etnaviv/hw/state_3d.xml.h:8 error: src/gallium/drivers/etnaviv/hw/state_3d.xml.h: patch does not apply Patch failed at 0001 etnavi

Re: [Mesa-dev] [PATCH] intel: compiler: vec4: add missing default 0 lod

On Tue, Oct 3, 2017 at 8:05 AM, Lionel Landwerlin wrote: > We handle similar default valid for LOD in the fs backend for TXS/TXL. > Without this we end up generating invalid MOV with a null src. > > Signed-off-by: Lionel Landwerlin > Cc: "17.2 17.1" > --- > src/intel/compiler/brw_vec4_nir.cpp |

Re: [Mesa-dev] [PATCH 1/3] loader/dri3: Use local blits and local buffers when resizing

On Tue, Oct 03, 2017 at 02:16:42PM +0200, Thomas Hellstrom wrote: > Hi! > > Could anyone please review this series? > > Thanks, > Thomas Minor typo in the commit message of 1/3: [Mesa-dev] [PATCH 1/3] loader/dri3: Use local blits and local buffers when resizing When a drawable is resized, and

Re: [Mesa-dev] [PATCH 0/4] i965: ARB_indirect_parameters

Thank you Ken! On Tue, Oct 3, 2017 at 2:26 AM, Kenneth Graunke wrote: > On Monday, October 2, 2017 1:58:23 PM PDT Plamena Manolova wrote: > > A series of patches introducing ARB_indirect_parameters > > for i965. We can implement ARB_indirect_parameters for i965 > > by taking advantage of the con

[Mesa-dev] [PATCH] radeonsi: add a drirc workaround for HTILE corruption in ARK: Survival Evolved

From: Marek Olšák --- src/gallium/drivers/radeonsi/driinfo_radeonsi.h | 4 src/gallium/drivers/radeonsi/si_blit.c | 14 ++ src/gallium/drivers/radeonsi/si_pipe.c | 2 ++ src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/util/drirc

[Mesa-dev] [PATCH 5/5] radeonsi: inline struct si_sampler_views

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_blit.c| 12 +++ src/gallium/drivers/radeonsi/si_debug.c | 2 +- src/gallium/drivers/radeonsi/si_descriptors.c | 51 +-- src/gallium/drivers/radeonsi/si_pipe.h| 6 +++- src/gallium/drivers/ra

[Mesa-dev] [PATCH 3/5] radeonsi: fold needs_*_decompress_mask update into si_set_sampler_view

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 100 -- 1 file changed, 46 insertions(+), 54 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index 1afdfbe..3835046 100644 --- a

[Mesa-dev] [PATCH 2/5] radeonsi: simplify a loop in si_update_fb_dirtiness_after_rendering

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 4965a83..f5abbf3 100644 --- a/src/gallium/driver

[Mesa-dev] [PATCH 4/5] radeonsi: rename si_textures_info -> si_samplers, si_images_info -> si_images

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_blit.c| 10 +- src/gallium/drivers/radeonsi/si_descriptors.c | 22 +++--- src/gallium/drivers/radeonsi/si_pipe.h| 8 3 files changed, 20 insertions(+), 20 deletions(-) diff --git a/src/galliu

[Mesa-dev] [PATCH 1/5] ac: properly document a buffer.store LLVM workaround

From: Marek Olšák --- src/amd/common/ac_llvm_build.c | 13 - src/amd/common/ac_llvm_build.h | 2 +- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index 51fb009..0cebaa7 100644 --- a/src/amd/common/ac_ll

Re: [Mesa-dev] [PATCH v2 03/11] isl: fill out layout descriptions for yuv formats

On 03/10/17 18:09, Chad Versace wrote: On Tue 03 Oct 2017, Lionel Landwerlin wrote: Some description was missing. Signed-off-by: Lionel Landwerlin --- src/intel/isl/isl_format_layout.csv | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/intel/isl/isl_format_lay

Re: [Mesa-dev] [PATCH v2 04/11] anv: prepare formats to handle disjoints sets

On Tue 03 Oct 2017, Lionel Landwerlin wrote: > Newer format enums start at offset 10, making it impossible to > have them all in one table. This change splits the formats into sets > that we then access through indirection. > > Signed-off-by: Lionel Landwerlin > --- > src/intel/vulkan/an

Re: [Mesa-dev] [PATCH 03/44] i965/fs/nir: Use the nir_src_bit_size helper

Reviewed-by: Lionel Landwerlin On 05/09/17 16:12, Jason Ekstrand wrote: --- src/intel/compiler/brw_fs_nir.cpp | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index d760946..18c5fc6 100644

Re: [Mesa-dev] [PATCH 02/44] nir: Get rid of the variable on vote intrinsics

Reviewed-by: Lionel Landwerlin On 05/09/17 16:12, Jason Ekstrand wrote: This looks like a copy+paste error. They don't actually write into that variable as would be implied by putting the return there. --- src/compiler/glsl/glsl_to_nir.cpp | 2 -- src/compiler/nir/nir_intrinsics.h | 6 +++--

Re: [Mesa-dev] [PATCH] configure.ac: bump Clover LLVM requirement to 3.9

On 3 October 2017 at 18:05, Eric Engestrom wrote: > On Tuesday, 2017-10-03 16:51:16 +, Emil Velikov wrote: >> From: Emil Velikov >> >> The only driver that utilises Clover already depends on LLVM 3.9. >> Additionally close to every supported distribution has said version. >> >> Additionally l

  1   2   >