Re: [Mesa-dev] [PATCH mesa] i965: remove unused variable

2017-10-30 Thread Kenneth Graunke
On Monday, October 30, 2017 3:37:40 AM PDT Eric Engestrom wrote: > Fixes: 2c873060d3578c7004c0 "i965: Delete unused >brw_vs_prog_data::nr_attributes field." > Cc: Kenneth Graunke > Signed-off-by: Eric Engestrom > --- >

Re: [Mesa-dev] [PATCH v2] wayland-drm: static inline wayland_drm_buffer_get

2017-10-30 Thread Dylan Baker
for the meson bits: Reviewed-by: Dylan Baker Please do make sure that Daniel or someone else with wayland expertise looks at this tool, I am not qualified to review that. Dylan Quoting Emil Velikov (2017-10-27 16:50:25) > On 24 October 2017 at 17:14, Emil Velikov

Re: [Mesa-dev] Mesa 17.2.4 release candidate

2017-10-30 Thread Andres Gomez
On Mon, 2017-10-30 at 11:39 -0400, Ilia Mirkin wrote: > On Mon, Oct 30, 2017 at 11:29 AM, Emil Velikov > wrote: > > On 28 October 2017 at 21:35, Andres Gomez wrote: > > > On Fri, 2017-10-27 at 14:14 -0400, Ilia Mirkin wrote: > > > > On Fri, Oct 27,

Re: [Mesa-dev] [PATCH v2] wayland-drm: static inline wayland_drm_buffer_get

2017-10-30 Thread Dylan Baker
Quoting Eric Engestrom (2017-10-30 07:12:32) > On Monday, 2017-10-30 13:39:00 +, Emil Velikov wrote: > > On 30 October 2017 at 12:02, Eric Engestrom > > wrote: > > > On Tuesday, 2017-10-24 17:14:20 +0100, Emil Velikov wrote: > > >> From: Emil Velikov

Re: [Mesa-dev] [PATCH 0/3] Gallium: Signed VBO offsets to fix SPECviewperf stability

2017-10-30 Thread Marek Olšák
I use SPECviewperf from the phoronix test suite. See the gl31 branch in my repo. Marek On Mon, Oct 30, 2017 at 2:18 PM, Dieter Nützel wrote: > Hello Marek, > > running with this since it appears. > Which SPECviewperf version (self compiled) are you using? > I've read that

Re: [Mesa-dev] [PATCH] st/program: fix compute shader nir references

2017-10-30 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Oct 30, 2017 at 3:36 PM, Rob Clark wrote: > In case the IR is NIR, the driver takes reference to the nir_shader. > Also, because there are no variants, we need to clone the shader, > instead of sharing the

[Mesa-dev] [PATCH 16/19] etnaviv: GC7000: Factor out incompatible texture handling logic

2017-10-30 Thread Wladimir J. van der Laan
This will be shared with the texture descriptor path. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_texture.c | 40 +-- src/gallium/drivers/etnaviv/etnaviv_texture.h | 5 2 files changed, 30 insertions(+), 15

[Mesa-dev] [PATCH 18/19] etnaviv: GC7000: Move etna_coalesce to emit header file

2017-10-30 Thread Wladimir J. van der Laan
Want to be able to emit state from the texture implementation. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 83 -- src/gallium/drivers/etnaviv/etnaviv_emit.h | 83 ++ 2 files

[Mesa-dev] [PATCH 15/19] etnaviv: GC7000: Track dirty sampler views

2017-10-30 Thread Wladimir J. van der Laan
Need this to efficiently emit texture descriptor invalidations. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_context.c | 1 + src/gallium/drivers/etnaviv/etnaviv_context.h | 1 + src/gallium/drivers/etnaviv/etnaviv_emit.c| 1 +

[Mesa-dev] [PATCH 19/19] etnaviv: GC7000: Split off current texture code

2017-10-30 Thread Wladimir J. van der Laan
Prepare for two texture handling paths, the descriptor-based path will be added in a future commit. These are structured so that the texture implementation handles its own state emission. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/Makefile.sources

[Mesa-dev] [PATCH 13/19] etnaviv: GC7000: State changes for HALTI3..5

2017-10-30 Thread Wladimir J. van der Laan
Update state objects to add new state, and emit function to emit new state. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 247 +++-- src/gallium/drivers/etnaviv/etnaviv_internal.h | 4 +

[Mesa-dev] [PATCH 17/19] etnaviv: GC7000: Move active_samplers_bits to texture

2017-10-30 Thread Wladimir J. van der Laan
This needs to be shared between texture_plain and texture_desc. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_emit.c| 12 src/gallium/drivers/etnaviv/etnaviv_texture.c | 6 ++ src/gallium/drivers/etnaviv/etnaviv_texture.h

[Mesa-dev] [PATCH 14/19] etnaviv: GC7000: Make point sprites work on HALTI5

2017-10-30 Thread Wladimir J. van der Laan
Track varying component offset of the point size output, as well as provide the offset of the point coord input. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_compiler.c | 7 ++- src/gallium/drivers/etnaviv/etnaviv_compiler.h | 1 +

[Mesa-dev] [PATCH 12/19] etnaviv: GC7000: Update screen specs for HALTI5

2017-10-30 Thread Wladimir J. van der Laan
- This core must load shaders from memory (AFAIK) - Yet another new location for UNIFORMS Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 11/19] etnaviv: GC7000: Update context reset for ..HALTI5

2017-10-30 Thread Wladimir J. van der Laan
Update context reset for HALTI3..HALTI5, sorting states for the HALTI version that has them. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_context.c | 37 +++ 1 file changed, 32 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH 10/19] etnaviv: GC7000: No RS align when using BLT

2017-10-30 Thread Wladimir J. van der Laan
RS align is not necessary and might even be harmful when using the BLT engine for blitting. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 15 + src/gallium/drivers/etnaviv/etnaviv_surface.c | 41 +

[Mesa-dev] [PATCH 07/19] etnaviv: GC7000: Add etnaviv_blt

2017-10-30 Thread Wladimir J. van der Laan
Add a low-level library for using the BLT engine from the etnaviv driver. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/Makefile.sources | 2 + src/gallium/drivers/etnaviv/etnaviv_blt.c| 219 +++

[Mesa-dev] [PATCH 09/19] etnaviv: GC7000: BLT engine blitting support

2017-10-30 Thread Wladimir J. van der Laan
Add an implemenation of key clear_blit functions using the BLT engine that replaced the RS on GC7000. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/Makefile.sources | 1 + src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 7 +-

[Mesa-dev] [PATCH 03/19] etnaviv: Put HALTI level in specs

2017-10-30 Thread Wladimir J. van der Laan
The HALTI level is an indication of the gross architecture of the GPU. It determines for significant part what feature level the GPU has, what state (especially frontend state) is there, and where it is located. Signed-off-by: Wladimir J. van der Laan ---

[Mesa-dev] [PATCH 06/19] etnaviv: GC7000: Support BLT as recipient for etna_stall

2017-10-30 Thread Wladimir J. van der Laan
When the BLT is involved as source or target, add an extra BLT enable/disable sequence around the sync sequence. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 08/19] etnaviv: GC7000: Split off RS blit functions

2017-10-30 Thread Wladimir J. van der Laan
Prepare for BLT-based blitting path by moving RS-based blitting to its own implementation file. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/Makefile.sources | 1 + src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 553 +--

[Mesa-dev] [PATCH 05/19] etnaviv: Use only DRAW_INSTANCED on GC3000+

2017-10-30 Thread Wladimir J. van der Laan
The blob does this, as DRAW_INSTANCED can replace fully all the other draw commands - the other path is only there for compatibility and will go away (or at least rot to become buggy due to dis-use) in newer hardware. Preparation for GC7000 support. Signed-off-by: Wladimir J. van der Laan

[Mesa-dev] [PATCH 04/19] etnaviv: Emit SCALE for vertex attributes

2017-10-30 Thread Wladimir J. van der Laan
This is used by HALTI2+ (GC3000+) when drawing with DRAW_INSTANCED. It is also necessary when switching between integer and floating point vertex element formats. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 5 +

[Mesa-dev] [PATCH 01/19] etnaviv: Update from rnndb

2017-10-30 Thread Wladimir J. van der Laan
Updated as of etnav_viv commit 8255e4b. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 2 +- src/gallium/drivers/etnaviv/etnaviv_format.c | 9 +- src/gallium/drivers/etnaviv/etnaviv_state.c | 2 +-

[Mesa-dev] [PATCH 00/19] GC7000 preparation

2017-10-30 Thread Wladimir J. van der Laan
This is the entire patch set needed for GC7000 support in Mesa, except the implementation of texture descriptors. There is a DRM kernel interface issue to resolve there [1]. I'm sending this early to get some eyes on it, and because it is quite a large patch-set and will be challenging to keep

[Mesa-dev] [PATCH 02/19] etnaviv: Const-correctness etnaviv_emit.h

2017-10-30 Thread Wladimir J. van der Laan
The relocation structure is never changed by submitting it. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_emit.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_emit.h

Re: [Mesa-dev] [PATCH v2] etnaviv: Allow clearing constant buffer using buffer==NULL user_buffer==NULL

2017-10-30 Thread Wladimir J. van der Laan
On Mon, Oct 30, 2017 at 02:21:07PM +0100, Lucas Stach wrote: > I would prefer the shorter expression (!cb->buffer && !cb->user_buffer) > here, which seems more consistent with the rest of the codebase. Well, I mimiced the style from other assertion in the function which compares explicitly with

[Mesa-dev] [PATCH] radv: bail out when binding the same index buffer

2017-10-30 Thread Samuel Pitoiset
DOW3 appears to hit this path. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 9 + src/amd/vulkan/radv_private.h| 5 + 2 files changed, 14 insertions(+) diff --git a/src/amd/vulkan/radv_cmd_buffer.c

Re: [Mesa-dev] [PATCH v3 19/43] i965/fs: Support push constants of 16-bit types

2017-10-30 Thread Chema Casanova
El 30/10/17 a las 07:44, Pohjolainen, Topi escribió: > On Sun, Oct 29, 2017 at 11:17:11PM +0100, Chema Casanova wrote: >> On 29/10/17 19:55, Pohjolainen, Topi wrote: >>> On Thu, Oct 12, 2017 at 08:38:08PM +0200, Jose Maria Casanova Crespo wrote: We enable the use of 16-bit values in push

Re: [Mesa-dev] [PATCH] Android: move drivers' symlinks to /vendor (v2)

2017-10-30 Thread Emil Velikov
On 27 October 2017 at 20:54, Mauro Rossi wrote: > Having moved gallium_dri.so library to /vendor/lib/dri > also symlinks need to be coherently created using TARGET_OUT_VENDOR instead > of TARGET_OUT > or all non Intel drivers will not be loaded with Android N and earlier,

[Mesa-dev] [AppVeyor] mesa master #5988 completed

2017-10-30 Thread AppVeyor
Build mesa 5988 completed Commit fc7816fd4e by Emil Velikov on 10/30/2017 3:32 PM: Revert "foo"\n\nThis reverts commit 27d5a7bce09aef83d3349cca5f3777007b3b94b6.\n\nI fat fingered it, failing to reset the checkout before applying the\nsequential commit.

Re: [Mesa-dev] Mesa 17.2.4 release candidate

2017-10-30 Thread Ilia Mirkin
On Mon, Oct 30, 2017 at 11:29 AM, Emil Velikov wrote: > On 28 October 2017 at 21:35, Andres Gomez wrote: >> On Fri, 2017-10-27 at 14:14 -0400, Ilia Mirkin wrote: >>> On Fri, Oct 27, 2017 at 1:43 PM, Andres Gomez wrote: >>> >

Re: [Mesa-dev] Mesa 17.2.4 release candidate

2017-10-30 Thread Emil Velikov
On 28 October 2017 at 21:35, Andres Gomez wrote: > On Fri, 2017-10-27 at 14:14 -0400, Ilia Mirkin wrote: >> On Fri, Oct 27, 2017 at 1:43 PM, Andres Gomez wrote: >> > Rejected (6) >> > >> > >> > Ilia Mirkin (1): >> > glsl: fix derived cs

[Mesa-dev] [AppVeyor] mesa master #5987 failed

2017-10-30 Thread AppVeyor
Build mesa 5987 failed Commit 6997d222f5 by Emil Velikov on 10/30/2017 3:24 PM: docs/release-calendar: update - 17.3.0-rc2 is out\n\nSigned-off-by: Emil Velikov Configure your notification preferences

[Mesa-dev] [ANNOUNCE] mesa 17.3.0-rc2

2017-10-30 Thread Emil Velikov
The second release candidate for Mesa 17.3.0 is now available. Alex Smith (1): radv: Update code pointer correctly if a variant is already created Bas Nieuwenhuizen (1): radv: Fix truncation issue hexifying the cache uuid for the disk cache. Daniel Stone (1): meson:

[Mesa-dev] [ANNOUNCE] mesa 17.2.4

2017-10-30 Thread Andres Gomez
Mesa 17.2.4 is now available. In this release we have: In Mesa Core we have included a change to prevent KOTOR from breaking when in combination with the ATI fragment shader extension. Additionally, NIR has also received a correction. Mesa's state tracker has gotten a patch to avoid leaks in

[Mesa-dev] [PATCH] gallium: fix typos in README.portability

2017-10-30 Thread Ben Crocker
Cc: "17.2" Signed-off-by: Ben Crocker --- src/gallium/README.portability | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/README.portability b/src/gallium/README.portability index cf6cc36afb..cdc02bb36d

[Mesa-dev] [PATCH] st/program: fix compute shader nir references

2017-10-30 Thread Rob Clark
In case the IR is NIR, the driver takes reference to the nir_shader. Also, because there are no variants, we need to clone the shader, instead of sharing the reference with gl_program, which would result in a double free in _mesa_delete_program(). Signed-off-by: Rob Clark

Re: [Mesa-dev] [PATCH v2] wayland-drm: static inline wayland_drm_buffer_get

2017-10-30 Thread Eric Engestrom
On Monday, 2017-10-30 13:39:00 +, Emil Velikov wrote: > On 30 October 2017 at 12:02, Eric Engestrom wrote: > > On Tuesday, 2017-10-24 17:14:20 +0100, Emil Velikov wrote: > >> From: Emil Velikov > >> > >> The function is effectively a

Re: [Mesa-dev] [PATCH v2] wayland-drm: static inline wayland_drm_buffer_get

2017-10-30 Thread Emil Velikov
On 30 October 2017 at 12:02, Eric Engestrom wrote: > On Tuesday, 2017-10-24 17:14:20 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> The function is effectively a direct function call into >> libwayland-server.so. >> >> Thus GBM no

Re: [Mesa-dev] [PATCH v2] etnaviv: Allow clearing constant buffer using buffer==NULL user_buffer==NULL

2017-10-30 Thread Lucas Stach
Am Samstag, den 28.10.2017, 16:16 +0200 schrieb Wladimir J. van der Laan: > Prevents an assertion when using GALLIUM_HUD with ioquake3, > when cso_restore_constant_buffer_slot0 restores an empty > constant buffer in slot 0. > > > Signed-off-by: Wladimir J. van der Laan > --- >  

Re: [Mesa-dev] [PATCH 0/3] Gallium: Signed VBO offsets to fix SPECviewperf stability

2017-10-30 Thread Dieter Nützel
Hello Marek, running with this since it appears. Which SPECviewperf version (self compiled) are you using? I've read that 'latest' versions are Windows only. Only have a _very_ old 32-bit self compiled version here, currently...;-) BTW Do have a pointer to your OpenGL 3.1 Compatibility tree

Re: [Mesa-dev] [PATCH] etnaviv: Don't flush on transfer when UNSYNCHRONIZED

2017-10-30 Thread Lucas Stach
Am Samstag, den 28.10.2017, 16:01 +0200 schrieb Wladimir J. van der Laan: > Structure code to only flush when we will potentially call cpu_prep. This > prevents spurious flushes in applications that heavily rely on u_uploader. > > > Signed-off-by: Wladimir J. van der Laan > ---

Re: [Mesa-dev] [PATCH v3 00/48] nir, intel: Prerequisites for subgroups

2017-10-30 Thread Iago Toral
I posted comments in patches 39 and 43, but otherwise patches 39-48 are: Reviewed-by: Iago Toral Quiroga Iago On Fri, 2017-10-27 at 13:57 +0200, Iago Toral wrote: > I dropped a few more comments on patches 18-20, 23, 25, 29-31, 34 and > 38 but nothing major in general. > >

Re: [Mesa-dev] [PATCH 08/25] gallium/u_threaded: mark queries flushed only for non-deferred flushes

2017-10-30 Thread Marek Olšák
On Mon, Oct 30, 2017 at 2:57 AM, Marek Olšák wrote: > On Sun, Oct 22, 2017 at 9:07 PM, Nicolai Hähnle wrote: >> From: Nicolai Hähnle >> >> The driver uses (and must use) the flushed flag of queries as a hint that >> it does not have

Re: [Mesa-dev] [PATCH v3 44/48] nir, intel/compiler: Use a fixed subgroup size

2017-10-30 Thread Iago Toral
On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > The GL_ARB_shader_ballot spec says that gl_SubGroupSizeARB is > declared > as a uniform. I was a bit surprised that we can change this so easily, then realized that the name for this built-in is a bit misleading since this doesn't really

Re: [Mesa-dev] [PATCH v3 43/48] nir/lower_subgroups: Lower ballot intrinsics to the specified bit size

2017-10-30 Thread Iago Toral
On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > Ballot intrinsics return a bitfield of subgroups.  In GLSL and some > SPIR-V extensions, they return a uint64_t.  In SPV_KHR_shader_ballot, > they return a uvec4.  Also, some back-ends would rather pass around > 32-bit values because it's

Re: [Mesa-dev] [PATCH v2] wayland-drm: static inline wayland_drm_buffer_get

2017-10-30 Thread Eric Engestrom
On Tuesday, 2017-10-24 17:14:20 +0100, Emil Velikov wrote: > From: Emil Velikov > > The function is effectively a direct function call into > libwayland-server.so. > > Thus GBM no longer depends on the wayland-drm static library, making the > build more straight

Re: [Mesa-dev] [PATCH v3 39/48] nir: Add a new subgroups lowering pass

2017-10-30 Thread Iago Toral
On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > This commit pulls nir_lower_read_invocations_to_scalar along with > most > of the guts of nir_opt_intrinsics (which mostly does subgroup > lowering) > into a new nir_lower_subgroups pass.  There are various other bits of > subgroup

[Mesa-dev] [Bug 103505] RX 480, newest mesa, VULKAN Does not start

2017-10-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103505 --- Comment #4 from Valentin Novikov --- (In reply to Matias N. Goldberg from comment #3) > Sounds similar to this bug 99591: > https://bugs.freedesktop.org/show_bug.cgi?id=99591 > > Try export LD_BIND_NOW=1 before running

Re: [Mesa-dev] [PATCH mesa] i965: remove unused variable

2017-10-30 Thread Eduardo Lima Mitev
I saw it this morning as well. Thanks for fixing it. Reviewed-by: Eduardo Lima Mitev On 10/30/2017 11:37 AM, Eric Engestrom wrote: > Fixes: 2c873060d3578c7004c0 "i965: Delete unused >brw_vs_prog_data::nr_attributes field." > Cc: Kenneth Graunke > Signed-off-by:

[Mesa-dev] [PATCH mesa] i965: remove unused variable

2017-10-30 Thread Eric Engestrom
Fixes: 2c873060d3578c7004c0 "i965: Delete unused brw_vs_prog_data::nr_attributes field." Cc: Kenneth Graunke Signed-off-by: Eric Engestrom --- src/intel/compiler/brw_vec4.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git

[Mesa-dev] [Bug 103513] [build failure] radv_shader.c:683:2: error: format not a string literal and no format arguments [-Werror=format-security]

2017-10-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103513 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH] radv: Fix -Wformat-security issue

2017-10-30 Thread Samuel Pitoiset
Pushed, thanks! On 10/30/2017 09:38 AM, Alex Smith wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103513 Fixes: de889794134e ("radv: Implement VK_AMD_shader_info") Signed-off-by: Alex Smith --- src/amd/vulkan/radv_shader.c | 2 +- 1 file changed,

Re: [Mesa-dev] [PATCH] radv: Fix -Wformat-security issue

2017-10-30 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen Won't be in a position to push till the evening though. On 30 Oct 2017 09:38, "Alex Smith" wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103513 Fixes: de889794134e ("radv: Implement

[Mesa-dev] [PATCH] radv: Fix -Wformat-security issue

2017-10-30 Thread Alex Smith
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103513 Fixes: de889794134e ("radv: Implement VK_AMD_shader_info") Signed-off-by: Alex Smith --- src/amd/vulkan/radv_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [Bug 103513] [build failure] radv_shader.c:683:2: error: format not a string literal and no format arguments [-Werror=format-security]

2017-10-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103513 Bug ID: 103513 Summary: [build failure] radv_shader.c:683:2: error: format not a string literal and no format arguments [-Werror=format-security] Product: Mesa

[Mesa-dev] [PATCH] i965: Don't flag BRW_NEW_SURFACES unless some push constants are dirty.

2017-10-30 Thread Kenneth Graunke
Due to a gaffe on my part, we were re-emitting all binding table entries on every single draw call. The push_constant_packets atom listens to BRW_NEW_DRAW_CALL, but skips emitting 3DSTATE_CONSTANT_XS for each stage unless stage_state->push_constants_dirty is true. However, it flagged

Re: [Mesa-dev] [PATCH mesa] meson: wire up egl/android

2017-10-30 Thread Tomasz Figa
Hi everyone, On Sat, Oct 28, 2017 at 2:38 AM, Dylan Baker wrote: > Whooo! Thanks for doing this! > > Quoting Eric Engestrom (2017-10-27 07:40:17) >> Cc: Rob Herring >> Cc: Tomasz Figa >> Signed-off-by: Eric Engestrom

Re: [Mesa-dev] [PATCH v3 23/48] intel/fs: Assign constant locations if they haven't been assigned

2017-10-30 Thread Iago Toral
On Fri, 2017-10-27 at 12:43 -0700, Jason Ekstrand wrote: > On Fri, Oct 27, 2017 at 12:35 AM, Iago Toral > wrote: > > This sounds good to me, but I guess it is not really fixing > > anything, > > > > right? I ask because the subject claims that this patch does > > something > >

Re: [Mesa-dev] [PATCH v3 29/48] intel/cs: Rework the way thread local ID is handled

2017-10-30 Thread Iago Toral
On Fri, 2017-10-27 at 12:37 -0700, Jason Ekstrand wrote: > On Fri, Oct 27, 2017 at 2:11 AM, Iago Toral > wrote: > > On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > > > > > Previously, brw_nir_lower_intrinsics added the param and then > > emitted > > > > > a > > >

Re: [Mesa-dev] [PATCH v3 20/48] intel/fs: Protect opt_algebraic from OOB BROADCAST indices

2017-10-30 Thread Iago Toral
On Fri, 2017-10-27 at 12:28 -0700, Jason Ekstrand wrote: > On Fri, Oct 27, 2017 at 12:09 AM, Iago Toral > wrote: > > On Wed, 2017-10-25 at 16:25 -0700, Jason Ekstrand wrote: > > > > > --- > > > > >  src/intel/compiler/brw_fs.cpp | 10 -- > > > > >  1 file changed, 8

Re: [Mesa-dev] [PATCH v3 19/48] i965/fs/nir: Don't stomp 64-bit values to D in get_nir_src

2017-10-30 Thread Iago Toral
On Fri, 2017-10-27 at 12:21 -0700, Jason Ekstrand wrote: > On Thu, Oct 26, 2017 at 11:53 PM, Iago Toral > wrote: > > On Wed, 2017-10-25 at 16:25 -0700, Jason Ekstrand wrote: > > > > > --- > > > > >  src/intel/compiler/brw_fs_nir.cpp | 33 +-- > > > >

Re: [Mesa-dev] [PATCH v3 19/43] i965/fs: Support push constants of 16-bit types

2017-10-30 Thread Pohjolainen, Topi
On Sun, Oct 29, 2017 at 11:17:11PM +0100, Chema Casanova wrote: > On 29/10/17 19:55, Pohjolainen, Topi wrote: > > On Thu, Oct 12, 2017 at 08:38:08PM +0200, Jose Maria Casanova Crespo wrote: > >> We enable the use of 16-bit values in push constants > >> modifying the assign_constant_locations

<    1   2