Re: [Mesa-dev] [PATCH] mesa/gles: adjust internal format in glTexSubImage2D error checks

Forgot to add: Cc: "17.3" On 11/21/2017 08:35 AM, Tapani Pälli wrote: When floating point textures are created on OpenGL ES 2.0, driver is free to choose used internal format. Mesa makes this decision in adjust_for_oes_float_texture. Error checking for glTexImage2D properly checks that sized f

[Mesa-dev] [Bug 97852] Unreal Engine corrupted preview viewport

https://bugs.freedesktop.org/show_bug.cgi?id=97852 --- Comment #12 from Tapani Pälli --- Created attachment 135622 --> https://bugs.freedesktop.org/attachment.cgi?id=135622&action=edit wokaround since we now have another case (Observer_) here's a workaround suggestion. -- You are receiving t

[Mesa-dev] [PATCH] mesa/gles: adjust internal format in glTexSubImage2D error checks

When floating point textures are created on OpenGL ES 2.0, driver is free to choose used internal format. Mesa makes this decision in adjust_for_oes_float_texture. Error checking for glTexImage2D properly checks that sized formats are not used. We use same error checking path for glTexSubImage2D (s

[Mesa-dev] [PATCH 2/2] spirv: fix bug when OpSpecConstantOp calls a conversion

In that case, nir_eval_const_opcode() will evaluate the conversion but as it was using destination's bit_size, the resulting value was just a cast of the source constant value. By passing the source's bit size, it does the conversion properly. Fixes: dEQP-VK.spirv_assembly.instruction.*.opspeccon

[Mesa-dev] [PATCH 1/2] spirv: allow specialization constants with bitsize different than 32 bits

Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/spirv/spirv_to_nir.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 027efab88d7..2cc3c275ea9 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler

Re: [Mesa-dev] [PATCH 00/28] vulkan/wsi: Rework WSI to look a lot more like a layer

On 11/16/2017 01:28 PM, Jason Ekstrand wrote: This patch series is the combined brain-child of Dave and myself. The objective is to rewrite Vulkan WSI to look as much like a layer as possible and to reduce the driver <-> WSI interface. We try very hard to have as many of the WSI details as poss

Re: [Mesa-dev] [PATCH v2 15/17] util: Add Mesa ARB_get_program_binary helper functions

On 21/11/17 15:34, Jordan Justen wrote: On 2017-11-20 19:00:28, Timothy Arceri wrote: I don't think this belongs in util. disk cache is generic and used by both Vulkan and Opengl drivers. These function are specific to one OpenGL extension and have a dependency on OpenGL types. I think you shoul

Re: [Mesa-dev] NIR linking optimisations for Gallium drivers

On 21/11/17 15:35, Dieter Nützel wrote: Hello Tim, with both of your latest series I get this:   CC   state_tracker/st_program.lo state_tracker/st_program.c: In function ‘st_translate_geometry_program’: state_tracker/st_program.c:1435:25: error: implicit declaration of function ‘st_glsl

Re: [Mesa-dev] [AppVeyor] mesa master #6216 failed

Thanks Ilia. >-Original Message- >From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia Mirkin >Sent: Tuesday, November 21, 2017 10:11 AM >To: Marathe, Yogesh >Cc: mesa-dev@lists.freedesktop.org; Muthukumar, Aravindan > >Subject: Re: [Mesa-dev] [AppVeyor] mesa master #621

Re: [Mesa-dev] [AppVeyor] mesa master #6216 failed

Build started git clone -q --depth=100 --branch=master git://anongit.freedesktop.org/mesa/mesa C:\projects\mesa warning: Could not find remote branch master to clone. fatal: Remote branch master not found in upstream origin Command exited with code 128 Not your commit's fault. On Mon, Nov 20, 201

Re: [Mesa-dev] NIR linking optimisations for Gallium drivers

Hello Tim, with both of your latest series I get this: CC state_tracker/st_program.lo state_tracker/st_program.c: In function ‘st_translate_geometry_program’: state_tracker/st_program.c:1435:25: error: implicit declaration of function ‘st_glsl_to_nir’; did you mean ‘st_link_nir’? [-Wer

Re: [Mesa-dev] [PATCH v2 15/17] util: Add Mesa ARB_get_program_binary helper functions

On 2017-11-20 19:00:28, Timothy Arceri wrote: > I don't think this belongs in util. disk cache is generic and used by > both Vulkan and Opengl drivers. These function are specific to one > OpenGL extension and have a dependency on OpenGL types. I think you > should just move this inside the src/

Re: [Mesa-dev] [AppVeyor] mesa master #6216 failed

Don't know if this is a concern. The patch was built & tested with intel mesa CI and locally. Does this need attention or can be ignored? Please advise. -Yogesh. >From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On >Behalf Of AppVeyor >Sent: Tuesday, November 21, 2017 4:23 AM >To:

Re: [Mesa-dev] [PATCH 14/14] st/glsl_to_nir: enable NIR link time opts

On 21/11/17 15:02, Ilia Mirkin wrote: Should this work out of the box for freedreno and vc4 as well? Or will those need changes like radeonsi did? I'm hopeful they shouldn't need any big changes as the radeonsi changes are due to expecting everything to be a vec4 because it code shares with t

Re: [Mesa-dev] [PATCH 14/14] st/glsl_to_nir: enable NIR link time opts

Should this work out of the box for freedreno and vc4 as well? Or will those need changes like radeonsi did? On Mon, Nov 20, 2017 at 10:37 PM, Timothy Arceri wrote: > --- > src/mesa/state_tracker/st_glsl_to_nir.cpp | 77 > +++ > 1 file changed, 77 insertions(+) > > d

[Mesa-dev] [PATCH 13/14] radeonsi: use driver location when gathering tgsi info from nir

Otherwise we overflow the tgsi array because nir uses a separate var for component packing of varyings, while tgsi expects everything to be vec4. We also need to do our own count of the total number of varyings. --- src/gallium/drivers/radeonsi/si_shader_nir.c | 34 ++-- 1

[Mesa-dev] [PATCH 14/14] st/glsl_to_nir: enable NIR link time opts

--- src/mesa/state_tracker/st_glsl_to_nir.cpp | 77 +++ 1 file changed, 77 insertions(+) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp index 27e36bd306..53e07a78e2 100644 --- a/src/mesa/state_tracker/st_glsl_to_nir.

[Mesa-dev] [PATCH 07/14] st/glsl_to_nir: make st_glsl_to_nir() static

Here we also move the extern C functions to the bottom of the file. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 102 +++--- src/mesa/state_tracker/st_nir.h | 4 -- 2 files changed, 51 insertions(+), 55 deletions(-) diff --git a/src/mesa/state_tracker/st_gls

[Mesa-dev] [PATCH 09/14] st/glsl_to_nir: enable NIR opts

--- src/mesa/state_tracker/st_glsl_to_nir.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp index 7d66a85a10..e83b5dd2ef 100644 --- a/src/mesa/state_tracker/st_glsl_to_nir.cpp +++ b/sr

[Mesa-dev] [PATCH 11/14] st/glsl_to_nir: move some calls out of st_glsl_to_nir_post_opts()

NIR component packing will be inserted between these calls and the calling of st_glsl_to_nir_post_opts(). --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 67 +-- 1 file changed, 37 insertions(+), 30 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b

[Mesa-dev] [PATCH 12/14] radeonsi/nir: add support for packed inputs

Because NIR can create non vec4 variables when implementing component packing we need to make sure not to reprocess the same slot again. Also we can drop the fs_attr_idx counter and just use driver_location. --- src/gallium/drivers/radeonsi/si_shader_nir.c | 46 +++- 1 fil

[Mesa-dev] [PATCH 10/14] st/glsl_to_nir: call some lowering passes earlier

This is required so that we can enbale NIR linking optimisations. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp index e83b5dd2ef

[Mesa-dev] [PATCH 08/14] st/glsl_to_nir: add basic NIR opt loop helper

We need to be able to do these NIR opts in the state tracker rather than the driver in order for the NIR linking opts to be useful. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/mesa/state_tracker/st_glsl_to_n

[Mesa-dev] [PATCH 05/14] st/glsl_to_nir: split linking loop in two in prep of nir linking opts

--- src/mesa/state_tracker/st_glsl_to_nir.cpp | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp index bb0ba07012..8c22bde835 100644 --- a/src/mesa/state_tracker/st_

[Mesa-dev] [PATCH 04/14] st/glsl_to_nir: create set_st_program() helper

--- src/mesa/state_tracker/st_glsl_to_nir.cpp | 74 +-- 1 file changed, 40 insertions(+), 34 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp index 8b66f8277a..bb0ba07012 100644 --- a/src/mesa/state_tracke

[Mesa-dev] [PATCH 06/14] st/glsl_to_nir: split the st_glsl_to_nir() function in two

We want to be able to generate NIR then apply NIR optimisations. Once the optimisations are done we can then apply the new post opt function which assigns uniforms etc based on the optimised IR. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 30 -- 1 file changed, 20 i

[Mesa-dev] [PATCH 02/14] nir: fix support for scalar arrays in nir_lower_io_types()

This was just recreating the same vector type we alreay had and hitting an assert for scalars. --- src/compiler/nir/nir_lower_io_types.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/compiler/nir/nir_lower_io_types.c b/src/compiler/nir/nir_lower_io_types.c ind

[Mesa-dev] [PATCH 01/14] st/glsl_to_nir: add st_nir_assign_var_locations() helper

This avoids packed varyings being assigned different driver locations. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 43 --- 1 file changed, 34 insertions(+), 9 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_n

[Mesa-dev] NIR linking optimisations for Gallium drivers

This series depends on: https://patchwork.freedesktop.org/series/34131/ Tested without regression on radeonsi. Shader-db results (still limited to GLSL 1.40 so not to interesting): Totals from affected shaders: SGPRS: 29440 -> 30464 (3.48 %) VGPRS: 19620 -> 19584 (-0.18 %) Spilled SGPRs: 131 ->

[Mesa-dev] [PATCH 03/14] st/glsl: move nir linking loop to new function st_link_nir()

This will allow us to refactor linking and include some nir link time optimisations. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 25 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 26 +- src/mesa/state_tracker/st_nir.h| 7 +++ 3

[Mesa-dev] [PATCH 7/8] radv: enable nir varying array splitting

--- src/amd/vulkan/radv_pipeline.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index faffca8330..03a8bd8604 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd/vulkan/radv_pipeline.c @@ -1675,20 +1675,23 @@ radv_link_

[Mesa-dev] [PATCH 5/8] nir: add varying component packing helpers

v2: update shader info input/output masks when pack components v3: make sure interpolation loc matches, this is required for the radeonsi NIR backend. Reviewed-by: Bas Nieuwenhuizen (v1) --- src/compiler/nir/nir.h | 2 + src/compiler/nir/nir_linking_helpers.c | 302

[Mesa-dev] [PATCH 8/8] radv: enable nir component packing

SaschaWillems Vulkan demo tessellation: ~4000fps -> ~4600fps Reviewed-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_pipeline.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 03a8bd8604..5f07040915 100644 --- a/src/

[Mesa-dev] [PATCH 4/8] i965: call nir_lower_io_to_scalar() at link time for BDW and above

This will allow dead components of varyings to be removed. BDW shader-db results: total instructions in shared programs: 13190730 -> 13108459 (-0.62%) instructions in affected programs: 2110903 -> 2028632 (-3.90%) helped: 14043 HURT: 486 total cycles in shared programs: 541148990 -> 540544072 (-

[Mesa-dev] [PATCH 3/8] i965: enable varying array splitting

total instructions in shared programs: 13210579 -> 13199325 (-0.09%) instructions in affected programs: 89043 -> 77789 (-12.64%) helped: 430 HURT: 0 total cycles in shared programs: 539530190 -> 539493750 (-0.01%) cycles in affected programs: 584860 -> 548420 (-6.23%) helped: 437 HURT: 110 total

[Mesa-dev] [PATCH 6/8] i965: enable varying component packing for BDW+

shader-db results BDW: total instructions in shared programs: 13192895 -> 13182437 (-0.08%) instructions in affected programs: 827145 -> 816687 (-1.26%) helped: 5199 HURT: 116 total cycles in shared programs: 539249342 -> 539156566 (-0.02%) cycles in affected programs: 21894552 -> 21801776 (-0.42

[Mesa-dev] [PATCH 2/8] i965: move update_xfb_info() call out of loop

We can just call it once. Also a following patch will also introduce link time component packing which modifies the outputs_written bit mask, we want to avoid calling update_xfb_info() until after packing is completed. --- src/mesa/drivers/dri/i965/brw_link.cpp | 7 +-- 1 file changed, 5 inser

[Mesa-dev] [PATCH 1/8] nir: add varying array splitting pass

V2: fix matrix support, non-array matrices were being skipped in v1 --- src/compiler/Makefile.sources | 1 + src/compiler/nir/meson.build | 1 + src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_lower_io_arrays_to_elemen

[Mesa-dev] V3 More linking optimisations

V3: Some small fixes to allow these passes to work with the radeonsi nir backend. V2: This is a resend/rebddase of the series I sent a couple of weeks ago, its rebased on some of Jason's changes to i965 NIR linking that landed in master. This series adds a varying array splitting pass as well a p

Re: [Mesa-dev] [PATCH v2 15/17] util: Add Mesa ARB_get_program_binary helper functions

I don't think this belongs in util. disk cache is generic and used by both Vulkan and Opengl drivers. These function are specific to one OpenGL extension and have a dependency on OpenGL types. I think you should just move this inside the src/mesa, I can't see this being reused anywhere else. Ma

Re: [Mesa-dev] [PATCH 2/4] mesa: fix crash when an ATI_fs pass begins with an alpha inst

Am 21.11.2017 um 01:40 schrieb Ian Romanick: > On 11/20/2017 04:07 PM, Miklós Máté wrote: >> This fixes crash when: >> - first pass begins with alpha inst >> - first pass ends with color inst, second pass begins with alpha inst >> >> Also, use the symbolic name instead of a number. >> Piglit: spec/

[Mesa-dev] [PATCH 09/12] compiler: All leaf Makefile.am should use +=

From: Ian Romanick This slightly simplifies later changes that add more Makefile.*.am files. Signed-off-by: Ian Romanick --- src/compiler/Makefile.am | 1 + src/compiler/Makefile.glsl.am | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/Makefile.am b/src/c

[Mesa-dev] [PATCH 06/12] util: Add and use util_is_power_of_two_nonzero

From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/nir/nir_search_helpers.h | 13 - src/compiler/nir/nir_validate.c | 2 +- src/util/bitscan.h| 11 +++ 3 files changed, 16 insertions(+), 10 deletions(-) diff --git a/src/compiler/nir/n

[Mesa-dev] [PATCH 12/12] spirv: Generate SPIR-V builder infrastructure

From: Ian Romanick v2: Don't try to automatically set SpvCapabilityGeometry or SpvCapabilityTessellation. v3: Move some changes from a later patch back into this patch. They were only in the later patch because of rebase failure. Make version a parameter to emit_SpvHeader. Many Python style c

[Mesa-dev] [PATCH 03/12] spirv: Import the latest 1.2.2 header and JSON from Khronos

From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/spirv/spirv.core.grammar.json | 193 ++--- src/compiler/spirv/spirv.h | 23 +++- 2 files changed, 197 insertions(+), 19 deletions(-) diff --git a/src/compiler/spirv/spirv.core.grammar.json

[Mesa-dev] [PATCH 11/12] spirv: Generate code to track SPIR-V capability dependencies

From: Ian Romanick v2: Clean ups. Remove some functions that never ended up being used. v3: After updating spirv.core.grammar.json, fix the handling of ShaderViewportMaskNV. See the comment around line 71 of spirv_capabilities_h.py. v4: Many Python style changes based on feedback from Dylan.

[Mesa-dev] [PATCH 10/12] spirv: Move SPIR-V building to Makefile.spirv.am and spirv/meson.build

From: Ian Romanick Future changes will add generated files used only from src/compiler/glsl. These can't be built from Makefile.nir.am, and we can't move all the rules from Makefile.nir.am to Makefile.spirv.am (and it would be silly anyway). v2: Do it for meson too. Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 05/12] util: Move util_is_power_of_two to bitscan.h and rename to util_is_power_of_two_or_zero

From: Ian Romanick The new name make the zero-input behavior more obvious. The next patch adds a new function with different zero-input behavior. Signed-off-by: Ian Romanick Suggested-by: Matt Turner --- src/amd/common/ac_gpu_info.c | 4 ++-- src/amd/common/ac_su

[Mesa-dev] [PATCH 00/12 v2] The first of the real SPIR-V work

Almost every patch of the original send was modified, and a couple patches were added. I decided it was easier to re-send the whole thing as a group. This is the first block of patches to enable generating SPIR-V from Mesa's GLSL compiler. The initial use of this is for testing GL_ARB_spirv, but

[Mesa-dev] [PATCH 08/12] util: Include bitscan.h directly

From: Ian Romanick Previously bitset.h would include u_math.h to get bitscan.h. u_math.h lives in src/gallium/auxiliary/util while both bitset.h and bitscan.h live in src/util. Having the one file directly include another file that lives in the same directory makes much more sense. As a side-e

[Mesa-dev] [PATCH 04/12] spirv: Add SubgroupBallotKHR capability to SubgroupSize and SubgroupLocalInvocationId

From: Ian Romanick The SPV_KHR_shader_ballot spec says: (Add the SubgroupBallotKHR capability to SubgroupSize.) (Add the SubgroupBallotKHR capability to SubgroupLocalInvocationId.) Yet the annotations are missing from the JSON. See also https://github.com/KhronosGroup/SPIRV-Headers/is

[Mesa-dev] [PATCH 01/12] i965: Silence "enumeral and non-enumeral type in conditional expression" warnings

From: Ian Romanick compiler/brw_inst.h: In function ‘brw_reg_type brw_inst_dst_type(const gen_device_info*, const brw_inst*)’: compiler/brw_inst.h:801:55: warning: enumeral and non-enumeral type in conditional expression [-Wextra] unsigned file = __builtin_strcmp("dst", #reg) == 0 ?

[Mesa-dev] [PATCH 02/12] i965: Don't request GLSL IR lowering of gl_VertexID

From: Ian Romanick Let the lowering in NIR handle it instead. This hurts one shader that occurs twice in shader-db (SynMark GSCloth) on IVB and HSW. No other shaders or platforms were affected. total cycles in shared programs: 253438422 -> 253438426 (0.00%) cycles in affected programs: 412 ->

[Mesa-dev] [PATCH 07/12] util: Optimize util_is_power_of_two_nonzero

From: Ian Romanick Signed-off-by: Ian Romanick Suggested-by: Matt Turner --- src/util/bitscan.h | 17 + 1 file changed, 17 insertions(+) diff --git a/src/util/bitscan.h b/src/util/bitscan.h index a3f2d41..5cc75f0 100644 --- a/src/util/bitscan.h +++ b/src/util/bitscan.h @@ -38,

Re: [Mesa-dev] [PATCH 2/2] i965/cnl: Correctly sample from fast-cleared sRGB textures

On Mon, Nov 20, 2017 at 04:03:20PM -0800, Jason Ekstrand wrote: > On Mon, Nov 20, 2017 at 3:48 PM, Nanley Chery wrote: > > > On Mon, Nov 20, 2017 at 02:55:28PM -0800, Jason Ekstrand wrote: > > > On Mon, Nov 20, 2017 at 2:10 PM, Nanley Chery > > wrote: > > > > > > > On Mon, Nov 20, 2017 at 01:54:

[Mesa-dev] GBM and the Device Memory Allocator Proposals

As many here know at this point, I've been working on solving issues related to DMA-capable memory allocation for various devices for some time now. I'd like to take this opportunity to apologize for the way I handled the EGL stream proposals. I understand now that the development process fol

Re: [Mesa-dev] [PATCH 4/4] mesa: fix validate for secondary interpolator

On 11/20/2017 04:07 PM, Miklós Máté wrote: > This patch fixes multiple problems: > - the interpolator check was duplicated > - both had arg instead of argRep > - I split it into color and alpha for better readability and error msg > - the DOT4 check only applies to color instruction according to th

Re: [Mesa-dev] [Freedreno] [PATCH 1/2] nir: allow texture offsets with cube maps

On Mon, Nov 20, 2017 at 4:10 PM, Ilia Mirkin wrote: > On Mon, Nov 20, 2017 at 7:08 PM, Jason Ekstrand > wrote: > > On Mon, Nov 20, 2017 at 3:11 PM, Ilia Mirkin > wrote: > >> > >> On Mon, Nov 20, 2017 at 5:16 PM, Jason Ekstrand > >> wrote: > >> > On Sun, Nov 19, 2017 at 11:54 AM, Ilia Mirkin >

Re: [Mesa-dev] [PATCH 3/4] mesa: fix typo in ATI_fs dstMod error checking

On 11/20/2017 04:07 PM, Miklós Máté wrote: > Piglit: spec/ati_fragment_shader/error14-invalidmod > > Signed-off-by: Miklós Máté > --- > src/mesa/main/atifragshader.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/main/atifragshader.c b/src/mesa/main/atifragsha

[Mesa-dev] [PATCH 6/6] meson: replace with_*dri with with_dri_platform

This fixes the windows and macos stubs to be consistent with the *nix path. Signed-off-by: Dylan Baker --- meson.build| 4 src/glx/meson.build| 4 ++-- src/mapi/glapi/meson.build | 2 +- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/meson.build b/mes

[Mesa-dev] [PATCH 4/6] meson: Fix LLVM requires for radeonsi

Signed-off-by: Dylan Baker --- meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index c568fdb8785..52f2c1cb0d0 100644 --- a/meson.build +++ b/meson.build @@ -707,7 +707,7 @@ if with_gallium_freedreno endif llvm_modules = ['bitwriter

[Mesa-dev] [PATCH 0/6] meson: some non-linux OS work

This is a rough cross section of work to get the meson build working on macOS and on Haiku, with one radeonsi fixup added. Most of this work is pretty straight forward, turning some options that can be assumed on Linux into tri-states, fixing up some early windows and macos stubs that I put in duri

[Mesa-dev] [PATCH 5/6] meson: add logic to select apple and windows dri

This is still not fully correct (haiku and BSD are probably not correct), but Linux is not regressed and this should be correct for macOS and Windows. Signed-off-by: Dylan Baker --- meson.build | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/meson.build b/mes

[Mesa-dev] [PATCH 3/6] meson: convert llvm option to tristate

This option has been acting as a strange sort of half-tri state anyway. Signed-off-by: Dylan Baker --- meson.build | 48 +--- meson_options.txt | 5 +++-- 2 files changed, 28 insertions(+), 25 deletions(-) diff --git a/meson.build b/meson.build

[Mesa-dev] [PATCH 1/6] meson: Remove duplicate _GNU_SOURCE

There is one provided unconditionally, and one guarded by platform == linux. Remove the unconditional one. Signed-off-by: Dylan Baker --- meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/meson.build b/meson.build index 383ebb36662..ce2c8c2c1d0 100644 --- a/meson.build +++ b/meson.b

[Mesa-dev] [PATCH 2/6] meson: Convert platform to auto

This is necessary to support operating systems other than the *nix family (excluding macOS). For Linux nothing has changed, the defaults are still the same. Signed-off-by: Dylan Baker --- meson.build | 7 +++ meson_options.txt | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-)

Re: [Mesa-dev] [PATCH 2/4] mesa: fix crash when an ATI_fs pass begins with an alpha inst

On 11/20/2017 04:07 PM, Miklós Máté wrote: > This fixes crash when: > - first pass begins with alpha inst > - first pass ends with color inst, second pass begins with alpha inst > > Also, use the symbolic name instead of a number. > Piglit: spec/ati_fragment_shader/api-alphafirst > > Signed-off-b

Re: [Mesa-dev] GPU (and system) monitoring

On Mon, 20 Nov 2017 13:25:26 +0100 Nicolai Hähnle wrote: > ... umr does > that for the amdgpu kernel module I downloaded the source tree, compiled umr, mounted the debugfs to use umr, and ran umr --top switching to sensor mode, you could see loads. And I collected a few second of informatio

Re: [Mesa-dev] [RFC v5 02/19] i965: Only set planar_format if it's actually one

On Mon, Nov 6, 2017 at 2:02 PM, Louis-Francis Ratté-Boulianne < l...@collabora.com> wrote: > The planar_format image property was always set even for > non-planar formats. This was breaking CCS support as > intel_from_planar is now making sure we can't have both > a modifier and an planar format.

Re: [Mesa-dev] [Mesa-stable] [PATCH V2 1/4] i965/gen10: Implement WaSampleOffsetIZ workaround

Anuj, these 4 patches series landed in master without the "mesa-stable" tag, hence, just confirming that you dropped the nomination. Let me know if that was not the case. On Fri, 2017-10-06 at 16:30 -0700, Anuj Phogat wrote: > There are few other (duplicate) workarounds which have similar > rec

Re: [Mesa-dev] [PATCH 1/4] mesa: mesa: add fallback texture for SampleMapATI if there is nothing

Only need one mesa: in the subject. :) On 11/20/2017 04:07 PM, Miklós Máté wrote: > This fixes crash in the state tracker. > Piglit: spec/ati_fragment_shader/render-notexture > > Signed-off-by: Miklós Máté > --- > src/mesa/main/texstate.c | 35 +++ > 1 file chang

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Handle negating immediates on MADs when propagating saturates

On 11/20/2017 03:32 PM, Matt Turner wrote: > On Mon, Nov 20, 2017 at 2:50 PM, Ian Romanick wrote: >> On 11/20/2017 02:33 PM, Matt Turner wrote: >>> MADs don't take immediate sources, but we allow them in the IR since it >>> simplifies a lot of things. I neglected to consider that case. >>> >>> Fix

Re: [Mesa-dev] [PATCH 1/2] i965/bufmgr: Add a helper to mark a BO as external

Jason, this nominated series landed without mentioning any specific stable queue. From what I'm seeing, both depend on 2c4097aff1b which didn't make it for 17.2 so I'm dropping them for that queue. Let me know what you think. On Fri, 2017-11-17 at 17:02 -0800, Jason Ekstrand wrote: > --- > src/

Re: [Mesa-dev] [Freedreno] [PATCH 1/2] nir: allow texture offsets with cube maps

On Mon, Nov 20, 2017 at 7:08 PM, Jason Ekstrand wrote: > On Mon, Nov 20, 2017 at 3:11 PM, Ilia Mirkin wrote: >> >> On Mon, Nov 20, 2017 at 5:16 PM, Jason Ekstrand >> wrote: >> > On Sun, Nov 19, 2017 at 11:54 AM, Ilia Mirkin >> > wrote: >> >> >> >> GL doesn't have this, but some hardware support

Re: [Mesa-dev] [Freedreno] [PATCH 1/2] nir: allow texture offsets with cube maps

On Mon, Nov 20, 2017 at 3:11 PM, Ilia Mirkin wrote: > On Mon, Nov 20, 2017 at 5:16 PM, Jason Ekstrand > wrote: > > On Sun, Nov 19, 2017 at 11:54 AM, Ilia Mirkin > wrote: > >> > >> GL doesn't have this, but some hardware supports it. This is convenient > >> for lowering tg4 to plain texture call

[Mesa-dev] [PATCH 3/4] mesa: fix typo in ATI_fs dstMod error checking

Piglit: spec/ati_fragment_shader/error14-invalidmod Signed-off-by: Miklós Máté --- src/mesa/main/atifragshader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/atifragshader.c b/src/mesa/main/atifragshader.c index d6fc37ac8f..313ba0c66d 100644 --- a/src/mesa/ma

[Mesa-dev] [PATCH 0/4] Fixes for ATI_fragment_shader

These are fixes for the problems my WIP Piglit tests uncovered so far. After this series gallium drivers should pass all tests, but swrast has some issues that I'm still working on. Unfortunately I can't test on r200. Miklós Máté (4): mesa: mesa: add fallback texture for SampleMapATI if there is

[Mesa-dev] [PATCH 1/4] mesa: mesa: add fallback texture for SampleMapATI if there is nothing

This fixes crash in the state tracker. Piglit: spec/ati_fragment_shader/render-notexture Signed-off-by: Miklós Máté --- src/mesa/main/texstate.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c index 2146

[Mesa-dev] [PATCH 2/4] mesa: fix crash when an ATI_fs pass begins with an alpha inst

This fixes crash when: - first pass begins with alpha inst - first pass ends with color inst, second pass begins with alpha inst Also, use the symbolic name instead of a number. Piglit: spec/ati_fragment_shader/api-alphafirst Signed-off-by: Miklós Máté --- src/mesa/main/atifragshader.c | 6

[Mesa-dev] [PATCH 4/4] mesa: fix validate for secondary interpolator

This patch fixes multiple problems: - the interpolator check was duplicated - both had arg instead of argRep - I split it into color and alpha for better readability and error msg - the DOT4 check only applies to color instruction according to the spec - made the DOT4 check fatal, and improved the

Re: [Mesa-dev] [PATCH 2/2] i965/cnl: Correctly sample from fast-cleared sRGB textures

On Mon, Nov 20, 2017 at 03:48:54PM -0800, Nanley Chery wrote: > On Mon, Nov 20, 2017 at 02:55:28PM -0800, Jason Ekstrand wrote: > > On Mon, Nov 20, 2017 at 2:10 PM, Nanley Chery wrote: > > > > > On Mon, Nov 20, 2017 at 01:54:39PM -0800, Nanley Chery wrote: > > > > When sampling from fast-cleared

Re: [Mesa-dev] [PATCH 2/2] i965/cnl: Correctly sample from fast-cleared sRGB textures

On Mon, Nov 20, 2017 at 3:48 PM, Nanley Chery wrote: > On Mon, Nov 20, 2017 at 02:55:28PM -0800, Jason Ekstrand wrote: > > On Mon, Nov 20, 2017 at 2:10 PM, Nanley Chery > wrote: > > > > > On Mon, Nov 20, 2017 at 01:54:39PM -0800, Nanley Chery wrote: > > > > When sampling from fast-cleared sRGB t

Re: [Mesa-dev] [Mesa-stable] [PATCH 02/14] anv/cmd_buffer: Take bo_offset into account in fast clear state addresses

On Mon, Nov 20, 2017 at 3:51 PM, Andres Gomez wrote: > Jason, this nominated patch landed without mentioning any specific > stable queue. > > Similarly to the 01/14, from what I'm seeing, it depends on > a62a97933578 which didn't make it for 17.2 so I'm dropping it for that > queue. > > Let me kn

Re: [Mesa-dev] [Mesa-stable] [PATCH 02/14] anv/cmd_buffer: Take bo_offset into account in fast clear state addresses

Jason, this nominated patch landed without mentioning any specific stable queue. Similarly to the 01/14, from what I'm seeing, it depends on a62a97933578 which didn't make it for 17.2 so I'm dropping it for that queue. Let me know what you think. On Mon, 2017-11-13 at 08:12 -0800, Jason Ekstrand

Re: [Mesa-dev] [PATCH 2/2] i965/cnl: Correctly sample from fast-cleared sRGB textures

On Mon, Nov 20, 2017 at 02:55:28PM -0800, Jason Ekstrand wrote: > On Mon, Nov 20, 2017 at 2:10 PM, Nanley Chery wrote: > > > On Mon, Nov 20, 2017 at 01:54:39PM -0800, Nanley Chery wrote: > > > When sampling from fast-cleared sRGB textures on gen10, the hardware > > > will not decode the clear col

Re: [Mesa-dev] [Mesa-stable] [PATCH 01/14] anv/cmd_buffer: Advance the address when initializing clear colors

Jason, this nominated patch landed without mentioning any specific stable queue. From what I'm seeing, it depends on 3735af04152b which didn't make it for 17.2 so I'm dropping it for that queue, unless you want to provide a backport. Let me know what you think. On Mon, 2017-11-13 at 08:12 -0800,

Re: [Mesa-dev] [PATCH] i965: Support decoding INTERFACE_DESCRIPTOR_DATA with INTEL_DEBUG=bat

Jordan Justen writes: > This will dump the INTERFACE_DESCRIPTOR_DATA along with the associated > samplers & surfaces. > > Signed-off-by: Jordan Justen Reviewed-by: Scott D Phillips > --- > src/mesa/drivers/dri/i965/intel_batchbuffer.c | 24 > 1 file changed, 24 inser

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Handle negating immediates on MADs when propagating saturates

On Mon, Nov 20, 2017 at 2:50 PM, Ian Romanick wrote: > On 11/20/2017 02:33 PM, Matt Turner wrote: >> MADs don't take immediate sources, but we allow them in the IR since it >> simplifies a lot of things. I neglected to consider that case. >> >> Fixes: 4009a9ead490 ("i965/fs: Allow saturate propaga

[Mesa-dev] [Bug 103825] [glx][i965][regression][bisected] pigilt glx-query-renderer-coverage regression

https://bugs.freedesktop.org/show_bug.cgi?id=103825 Andrés Gómez García changed: What|Removed |Added QA Contact|mesa-dev@lists.freedesktop. |pig...@lists.freedesktop.or

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_texture_filter_minmax

Ian Romanick writes: > On 11/19/2017 01:31 AM, Kenneth Graunke wrote: >> On Thursday, November 16, 2017 11:50:48 AM PST Ian Romanick wrote: >>> On 11/14/2017 02:54 PM, Scott D Phillips wrote: On gen >= 9, minmax reduction modes are available as a flag in SAMPLER_STATE. --- do

[Mesa-dev] [PATCH 2/8] meson: fix test source name for static glapi

fixes: 43a6e84927e3 ("meson: build mesa test.") Signed-off-by: Dylan Baker --- src/mesa/main/tests/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/tests/meson.build b/src/mesa/main/tests/meson.build index 2c1d8e067e8..78bef00f61e 100644 --- a/src/mesa

[Mesa-dev] [PATCH 3/8] glapi/check_table: Remove 'extern "C"' block

This doesn't actually accomplish what it's meant to do, as extern C doesn't undefine __cplusplus, so the included headers define a template (because __cplusplus is defined), but then that code is in an 'extern "C"' block, and explosion. Signed-off-by: Dylan Baker --- src/mapi/glapi/tests/check_t

[Mesa-dev] [PATCH 4/8] glapi: remove APPLE extensions from test

Fixes: 7009955281260fbb ("mesa: Remove GL_APPLE_vertex_array_object stubs") Signed-off-by: Dylan Baker --- src/mapi/glapi/tests/check_table.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mapi/glapi/tests/check_table.cpp b/src/mapi/glapi/tests/check_table.cpp index 7cded8d352f..30f5

[Mesa-dev] [PATCH 6/8] state_tracker: Don't build st-renumerate-test without shared glapi

Signed-off-by: Dylan Baker --- src/mesa/state_tracker/tests/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/state_tracker/tests/Makefile.am b/src/mesa/state_tracker/tests/Makefile.am index 6c58d367694..18c0ce50621 100644 --- a/src/mesa/state_tracker/tests/Makefile.am +

[Mesa-dev] [PATCH 8/8] glapi: fix check_table test for non-shared glapi with meson

Signed-off-by: Dylan Baker --- src/mapi/glapi/meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mapi/glapi/meson.build b/src/mapi/glapi/meson.build index 892d8b35759..db6cd834511 100644 --- a/src/mapi/glapi/meson.build +++ b/src/mapi/glapi/meson.build @@ -7

[Mesa-dev] [PATCH 7/8] glapi: Don't search through subdirs from glapitable.h

Because meson won't put it in that folder. Signed-off-by: Dylan Baker --- src/mapi/glapi/tests/check_table.cpp | 2 +- src/mesa/main/tests/Makefile.am | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/tests/check_table.cpp b/src/mapi/glapi/tests/check_tab

[Mesa-dev] [PATCH 5/8] autotools: Fix includes for non-shared glapi tests.

Signed-off-by: Dylan Baker --- src/mapi/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mapi/Makefile.am b/src/mapi/Makefile.am index 015edc37cb3..5db888abddc 100644 --- a/src/mapi/Makefile.am +++ b/src/mapi/Makefile.am @@ -150,7 +150,8 @@ check_PROGRAMS += g

[Mesa-dev] [PATCH 1/8] glapi: don't walk backwards for includes

Instead just set the proper -I flags and include it from a more standard path. In this case we'll add -Isrc/mesa (which is common), and #include main/foo.h. --- src/mapi/Makefile.am | 3 ++- src/mapi/glapi/meson.build | 1 + src/mapi/glapi/tests/check_table.cpp | 2 +- 3

[Mesa-dev] [PATCH 0/8] Fix non-shared glapi path

There are two distinct set of problems this series addresses. 1) the meson build has never worked 2) the checks for this path have been broken in several different ways for a long time. Dylan Baker (8): glapi: don't walk backwards for includes meson: fix test source name for static glapi

Re: [Mesa-dev] [Freedreno] [PATCH 1/2] nir: allow texture offsets with cube maps

On Mon, Nov 20, 2017 at 5:16 PM, Jason Ekstrand wrote: > On Sun, Nov 19, 2017 at 11:54 AM, Ilia Mirkin wrote: >> >> GL doesn't have this, but some hardware supports it. This is convenient >> for lowering tg4 to plain texture calls, which is necessary on Adreno >> A4xx hardware. >> >> Signed-off-b

  1   2   3   >