[Mesa-dev] [PATCH] aubinator: Multiply count by 4 to compute buffer sizes

The count field is in terms of dwords and not bytes. --- src/intel/tools/aubinator_error_decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/tools/aubinator_error_decode.c b/src/intel/tools/aubinator_error_decode.c index 01c6a7a..2ef6595 100644 ---

Re: [Mesa-dev] [PATCH 00/21] anv: Follow the rules for vkGet*ProcAddr

I have comments on patch 2 and 18 (below). For the rest, Reviewed-by: Samuel Iglesias Gonsálvez On 20/01/18 20:11, Jason Ekstrand wrote: > Our previous scheme for Get*ProcAddr was to just return what we could and > not care about the details. This meant that

Re: [Mesa-dev] [PATCH v2 00/22] Introducing SPIR-V support to clover

Patches 1-2, 8-10, 14-19, 21 are Reviewed-by Karol Herbst For Patches 16-22 I looked inside your repository. regarding all Patches modifying the headers: shouldn't we just update those headers? I personally don't care much, because nobody will use mesa as the system OpenCL

Re: [Mesa-dev] [PATCH 02/21] anv: Split anv_extensions.py into two files

On 20/01/18 20:11, Jason Ekstrand wrote: > The new anv_extensions_gen.py is the code generator while the old > anv_extensions.py file is purely declarative. > --- > src/intel/Makefile.vulkan.am | 3 +- > src/intel/vulkan/anv_extensions.py | 154 --- >

Re: [Mesa-dev] [PATCH v2 13/22] clover: Handle the case when linking SPIR-V binaries together

On Tue, Jan 23, 2018 at 1:33 AM, Pierre Moreau wrote: > Signed-off-by: Pierre Moreau > --- > src/gallium/state_trackers/clover/core/program.cpp | 22 > +- > 1 file changed, 17 insertions(+), 5 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH v2 12/22] clover: Refuse to compile source code to SPIR-V

On Tue, Jan 23, 2018 at 1:33 AM, Pierre Moreau wrote: > Creating a program using clCreateProgramWithSource to SPIR-V requires a > non-upstreamed version of LLVM and clang, therefore it is currently not > supported. > > Signed-off-by: Pierre Moreau >

Re: [Mesa-dev] [PATCH v2 00/22] Introducing SPIR-V support to clover

there seem to be some patches missing? On Tue, Jan 23, 2018 at 1:33 AM, Pierre Moreau wrote: > Hello, > > Here is the second version of my initial series for adding SPIR-V support to > clover, after the RFC back in May 2017. > > For recap, the focus of this series is to

Re: [Mesa-dev] [PATCH v3 3/3] anv: implement VK_EXT_global_priority extension

On 01/22/2018 09:01 PM, Jason Ekstrand wrote: On Mon, Jan 22, 2018 at 4:29 AM, Tapani Pälli > wrote: v2: add ANV_CONTEXT_REALTIME_PRIORITY (Chris)     use unreachable with unknown priority (Samuel) v3: add stubs in

[Mesa-dev] [PATCH] radv: don't use hw resolves for r16g16 norm formats.

From: Dave Airlie radeonsi has a workaround for this, but it uses a R16A16 format, which vulkan doesn't have, we could probably come up with a work around but for now just avoid hw resolves. Fixes: dEQP-VK.renderpass.suballocation.multisample.r16g16_*norm* Signed-off-by:

[Mesa-dev] [PATCH 2/2] radv: don't use hw resolve for integer image formats

From: Dave Airlie From reading AMDVLK it currently never uses hw resolve paths. This patch takes from radeonsi which doesn't use hw resolve for integer formats, and does the same for radv. This fixes: dEQP-VK.renderpass.suballocation.multisample*uint tests. Signed-off-by:

[Mesa-dev] [PATCH 1/2] radv: add fs_key meta format support to resolve passes.

From: Dave Airlie Some of the hw resolve passes need the SPI color format setup correctly. This fixes lots of 16-bit and 32-bit format tests in dEQP-VK.renderpass.suballocation.multisample* Signed-off-by: Dave Airlie ---

[Mesa-dev] [PATCH] radv: don't use hw resolve for certain image formats. (v2)

From: Dave Airlie From reading AMDVLK it currently never uses hw resolve paths. This patch limits the paths we used the hw resolve for, and fixes a larger number of the: dEQP-VK.renderpass.suballocation.multisample* tests. radeonsi actually has the no-int and no-depth rules

[Mesa-dev] [PATCH] r600: increase number of samplers/views from 16 to 18 on eg

From: Roland Scheidegger Some apps are known to require more than 16. Albeit they probably still won't run with 18 (since all new hw/drivers support 32) it shouldn't hurt to at least support 18 (seemingly the hw limit on all r600-ni chips - the blob also supports 18, at least

[Mesa-dev] [PATCH] radv: don't use hw resolve for certain image formats.

From: Dave Airlie From reading AMDVLK it currently never uses hw resolve paths. This patch limits the paths we used the hw resolve for, and fixes a larger number of the: dEQP-VK.renderpass.suballocation.multisample* tests. It currently doesn't do hw resolves for integer or

[Mesa-dev] [PATCH] radv: fix sample_mask_in loading. (v2)

From: Dave Airlie This is ported from radeonsi and fixes: dEQP-VK.pipeline.multisample_shader_builtin.sample_mask.bit_* v2: don't call this path for radeonsi, it does it in the epilog. use the radeonsi code path. Signed-off-by: Dave Airlie ---

Re: [Mesa-dev] [PATCH v2 09/24] anv/cmd_buffer: Generalize transition_color_buffer

On Mon, Jan 22, 2018 at 5:50 PM, Jason Ekstrand wrote: > On Mon, Jan 22, 2018 at 11:31 AM, Nanley Chery > wrote: > >> On Fri, Jan 19, 2018 at 03:47:26PM -0800, Jason Ekstrand wrote: >> > This moves it to being based on layout_to_aux_usage instead of

[Mesa-dev] [Bug 104749] rasterizer/jitter/JitManager.cpp:252:91: error: no matching function for call to ‘llvm::DIBuilder::createBasicType(const char [8], int, llvm::dwarf::TypeKind)’

https://bugs.freedesktop.org/show_bug.cgi?id=104749 Bug ID: 104749 Summary: rasterizer/jitter/JitManager.cpp:252:91: error: no matching function for call to ‘llvm::DIBuilder::createBasicType(const char [8], int,

Re: [Mesa-dev] [PATCH v2 09/24] anv/cmd_buffer: Generalize transition_color_buffer

On Mon, Jan 22, 2018 at 11:31 AM, Nanley Chery wrote: > On Fri, Jan 19, 2018 at 03:47:26PM -0800, Jason Ekstrand wrote: > > This moves it to being based on layout_to_aux_usage instead of being > > hard-coded based on bits of a priori knowledge of how transitions > >

Re: [Mesa-dev] [PATCH] radv: fix sample_mask_in loading.

This breaks some piglit tests on radeonsi e.g. R600_DEBUG=nir ./bin/arb_sample_shading-samplemask 2 all all -auto -fbo On 23/01/18 12:08, Dave Airlie wrote: From: Dave Airlie This is ported from amdvlk, and fixes:

Re: [Mesa-dev] [PATCH v2 12/24] anv/cmd_buffer: Add a mark_image_written helper

On Mon, Jan 22, 2018 at 3:22 PM, Nanley Chery wrote: > On Fri, Jan 19, 2018 at 03:47:29PM -0800, Jason Ekstrand wrote: > > Currently, this helper does nothing but we call it every place where an > > image is written through the render pipeline. This will allow us to > >

[Mesa-dev] [Bug 104746] [swrast] piglit attribs regression

https://bugs.freedesktop.org/show_bug.cgi?id=104746 Bug ID: 104746 Summary: [swrast] piglit attribs regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Keywords:

Re: [Mesa-dev] [PATCH v2 19/24] anv/cmd_buffer: Move the mi_alu helper higher up

On Mon, Jan 22, 2018 at 2:24 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Jan 19, 2018 at 03:47:36PM -0800, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/genX_cmd_buffer.c | 34 +++--- > > > 1 file changed, 19 insertions(+), 15

Re: [Mesa-dev] [PATCH v2 17/24] anv: Use blorp_ccs_ambiguate instead of fast-clears

On Mon, Jan 22, 2018 at 2:18 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Jan 19, 2018 at 03:47:34PM -0800, Jason Ekstrand wrote: > > Even though the blorp pass looks a bit on the sketchy side, the end > > result in the Vulkan driver is very nice. Instead of having this

[Mesa-dev] [PATCH] radv: fix sample_mask_in loading.

From: Dave Airlie This is ported from amdvlk, and fixes: dEQP-VK.pipeline.multisample_shader_builtin.sample_mask.bit_* Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH v2 06/22] clover: Move device extensions definitions to core/device.cpp

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/device.cpp | 11 +-- src/gallium/state_trackers/clover/core/device.cpp | 14 ++ src/gallium/state_trackers/clover/core/device.hpp | 1 + 3 files changed, 16 insertions(+), 10

[Mesa-dev] [PATCH v2 07/22] clover: Move platform extensions definitions to clover/platform.cpp

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/platform.cpp | 4 ++-- src/gallium/state_trackers/clover/core/platform.cpp | 5 + src/gallium/state_trackers/clover/core/platform.hpp | 2 ++ 3 files changed, 9 insertions(+), 2 deletions(-) diff

[Mesa-dev] [PATCH v2 09/22] configure.ac, meson: Check for SPIRV-Tools

Signed-off-by: Pierre Moreau --- configure.ac | 5 + meson.build | 2 ++ 2 files changed, 7 insertions(+) diff --git a/configure.ac b/configure.ac index 7c1fbe0ed1..8c50ea6792 100644 --- a/configure.ac +++ b/configure.ac @@ -2373,6 +2373,11 @@

[Mesa-dev] [PATCH v2 10/22] clover/spirv: Import spirv.hpp11 version 1.0 (rev 12)

Signed-off-by: Pierre Moreau --- .../state_trackers/clover/spirv/spirv.hpp11| 997 + 1 file changed, 997 insertions(+) create mode 100644 src/gallium/state_trackers/clover/spirv/spirv.hpp11 diff --git

[Mesa-dev] [PATCH v2 08/22] include/pipe: Define SPIRV as an IR

Signed-off-by: Pierre Moreau --- src/gallium/include/pipe/p_defines.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h index b34e7a8570..082d4c4d87 100644 ---

[Mesa-dev] [PATCH v2 15/22] include/CL: Add cl_khr_il_program

Signed-off-by: Pierre Moreau --- include/CL/cl_ext.h | 34 ++ 1 file changed, 34 insertions(+) diff --git a/include/CL/cl_ext.h b/include/CL/cl_ext.h index 710bea8837..2e4845d27d 100644 --- a/include/CL/cl_ext.h +++ b/include/CL/cl_ext.h @@

[Mesa-dev] [PATCH v2 14/22] clover: Add a pointer property to return ILs

OpenCL 2.1, and cl_khr_il_program, gives the ability to query for a program’s IL, which is returned as a pointer. Signed-off-by: Pierre Moreau --- .../state_trackers/clover/core/property.hpp| 39 ++ 1 file changed, 39 insertions(+) diff --git

[Mesa-dev] [PATCH v2 05/22] clover: Track flags per module section

One flag that needs to be tracked is whether a library is allowed to received mathematics optimisations or not, as the authorisation is given when creating the library while the optimisations are specified when creating the executable. Signed-off-by: Pierre Moreau ---

[Mesa-dev] [PATCH v2 04/22] clover: Disallow creating libraries from other libraries

If creating a library, do not allow non-compiled object in it, as executables are not allowed, and libraries would make it really hard to enforce the "-enable-link-options" flag. Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/program.cpp | 19

[Mesa-dev] [PATCH v2 03/22] clover/api: Fail if trying to build a non-executable binary

From the OpenCL 1.2 Specification, Section 5.6.2 (about clBuildProgram: > If program is created with clCreateProgramWithBinary, then the > program binary must be an executable binary (not a compiled binary or > library). Signed-off-by: Pierre Moreau ---

[Mesa-dev] [PATCH v2 02/22] clover: Add additional functions to query supported IRs

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/core/device.cpp | 11 +++ src/gallium/state_trackers/clover/core/device.hpp | 3 +++ 2 files changed, 14 insertions(+) diff --git a/src/gallium/state_trackers/clover/core/device.cpp

[Mesa-dev] [PATCH v2 00/22] Introducing SPIR-V support to clover

Hello, Here is the second version of my initial series for adding SPIR-V support to clover, after the RFC back in May 2017. For recap, the focus of this series is to let clover accept SPIR-V binaries through the cl_khr_il_program extension (from OpenCL 1.2 and on), as well as through some core

[Mesa-dev] [PATCH v2 01/22] clover/api: Fix tab indentation to spaces

Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/device.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/device.cpp b/src/gallium/state_trackers/clover/api/device.cpp index

Re: [Mesa-dev] [PATCH] swr: refactor swr_create_screen to allow for proper cleanup on error

Chuck, Change verified on my end; check-in coming coming up soon. George On Jan 22, 2018, at 2:11 PM, Kyriazis, George > wrote: On Jan 22, 2018, at 12:02 PM, Chuck Atkins >

Re: [Mesa-dev] [PATCH v2 12/24] anv/cmd_buffer: Add a mark_image_written helper

On Fri, Jan 19, 2018 at 03:47:29PM -0800, Jason Ekstrand wrote: > Currently, this helper does nothing but we call it every place where an > image is written through the render pipeline. This will allow us to > properly mark the aux state so that we can handle resolves correctly. > --- >

[Mesa-dev] [PATCH] anv: correct a duplicate check in an assert

Looks like checking both sources was intended, instead of the first one twice. Found with Coccinelle, coccinellery/xand/xand.cocci semantic patch. Signed-off-by: Grazvydas Ignotas --- src/intel/vulkan/anv_nir_apply_pipeline_layout.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [PATCH] radeonsi: don't ignore pitch for imported textures

On Mon, Jan 22, 2018 at 2:09 PM, Nicolai Hähnle wrote: > On 10.01.2018 20:49, Marek Olšák wrote: >> >> From: Marek Olšák > > > Please add a bug report or reference to what fails without it. There is no bug report. I just noticed this in the code. Marek

[Mesa-dev] [Bug 104742] [swrast] piglit gl-1.4-dlist-multidrawarrays regression

https://bugs.freedesktop.org/show_bug.cgi?id=104742 Bug ID: 104742 Summary: [swrast] piglit gl-1.4-dlist-multidrawarrays regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [Mesa-dev] [PATCH 10/10] gallium/u_threaded: don't run out of memory with staging uploads

On Mon, Jan 22, 2018 at 2:07 PM, Nicolai Hähnle wrote: > On 10.01.2018 20:49, Marek Olšák wrote: >> >> From: Marek Olšák >> >> Cc: 17.2 17.3 >> --- >> src/gallium/auxiliary/util/u_threaded_context.c | 13 +

[Mesa-dev] [PATCH 1/2] svga: fix context alloc error handling

'cleanup' path is dereferencing 'svga' a lot, 'done' is a better choice. Found by Coccinelle. Signed-off-by: Grazvydas Ignotas --- src/gallium/drivers/svga/svga_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 2/2] winsys/svga: check correct member after create

.mob_fenced was already checked, probably a copy-paste bug. Found by Coccinelle. Signed-off-by: Grazvydas Ignotas --- src/gallium/winsys/svga/drm/vmw_screen_pools.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [Bug 103526] Mesa 13.0.6/13.0.4 llvmpipe software rasterizer on PowerPC. Unexpected format PIPE_FORMAT_A8B8G8R8_UNORM in st_new_renderbuffer_fb

https://bugs.freedesktop.org/show_bug.cgi?id=103526 --- Comment #4 from Ben Crocker --- Yes, please try Mesa 17.2.4 or later; Mesa 17.2.x is up to 17.2.8. OR you could try Mesa 17.3.1 or 17.3.2. In late 2016 to mid-2017, Roland Scheidegger, Ray Strode, and I solved a number

Re: [Mesa-dev] [PATCH] u_thread: Use pthread_setname_np on linux only

On 22/01/18 21:04, Samuel Thibault wrote: Hello, Jose Fonseca, on lun. 15 janv. 2018 12:29:39 +, wrote: On 13/01/18 11:33, Samuel Thibault wrote: pthread_setname_np was added in glibc 2.12 for the Linux port only, other ports do not necessarily have it. --- src/util/u_thread.h | 3 ++-

Re: [Mesa-dev] [PATCH] svga: Prevent use after free.

On 22/01/18 15:44, Emil Velikov wrote: On 22 January 2018 at 15:13, Jose Fonseca wrote: Courtesy of clang static analyzer. I was hunting for potential sources of memory corruption using Mesa with a GL trace, and happened to find this (unrelated) issue. ---

Re: [Mesa-dev] [AppVeyor] mesa master #6655 failed

I suspect it's an infrastructure problem. I appeared frequently a while back, then went away, now's comming again. I think the consensus is to move this jobs out of fdo into https://github.com/mesa3d but I got no reply from Daniel Stone, so I'm not sure how to move that forward. Jose On

Re: [Mesa-dev] [PATCH] swr: refactor swr_create_screen to allow for proper cleanup on error

On Jan 22, 2018, at 12:02 PM, Chuck Atkins > wrote: Hi Emil, Fixes: a4be2bcee2f ("swr: allow a single swr architecture to be builtin") It doesn't fix anything that was broken from that commit. The issues with error handling were

Re: [Mesa-dev] [PATCH v3 06/24] anv/image: Add a helper for determining when fast clears are supported

On Mon, Jan 22, 2018 at 12:19:33AM -0800, Jason Ekstrand wrote: > v2 (Jason Ekstrand): > - Return an enum instead of a boolean > > v3 (Jason Ekstrand): > - Return ANV_FAST_CLEAR_NONE instead of false (Topi) > - Rename ANV_FAST_CLEAR_ANY to ANV_FAST_CLEAR_DEFAULT_VALUE > - Add documentation

Re: [Mesa-dev] [PATCH v2 11/24] anv/blorp: Add src/dst_level helper variables in CmdCopyImage

On Fri, Jan 19, 2018 at 03:47:28PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_blorp.c | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) > This patch is Reviewed-by: Nanley Chery > diff --git a/src/intel/vulkan/anv_blorp.c

Re: [Mesa-dev] [PATCH v2 06/24] anv/image: Add a helper for determining when fast clears are supported

On Mon, Jan 22, 2018 at 11:03:07AM -0800, Jason Ekstrand wrote: > On Mon, Jan 22, 2018 at 10:48 AM, Nanley Chery > wrote: > > > On Fri, Jan 19, 2018 at 03:47:23PM -0800, Jason Ekstrand wrote: > > > v2 (Jason Ekstrand): > > > - Return an enum instead of a boolean > > > > >

Re: [Mesa-dev] [PATCH v2 09/24] anv/cmd_buffer: Generalize transition_color_buffer

On Fri, Jan 19, 2018 at 03:47:26PM -0800, Jason Ekstrand wrote: > This moves it to being based on layout_to_aux_usage instead of being > hard-coded based on bits of a priori knowledge of how transitions > interact with layouts. This conceptually simplifies things because > we're now using

Re: [Mesa-dev] [PATCH v2 06/24] anv/image: Add a helper for determining when fast clears are supported

On Mon, Jan 22, 2018 at 10:48 AM, Nanley Chery wrote: > On Fri, Jan 19, 2018 at 03:47:23PM -0800, Jason Ekstrand wrote: > > v2 (Jason Ekstrand): > > - Return an enum instead of a boolean > > > > Reviewed-by: Topi Pohjolainen > > --- > >

Re: [Mesa-dev] [PATCH v3 3/3] anv: implement VK_EXT_global_priority extension

On Mon, Jan 22, 2018 at 4:29 AM, Tapani Pälli wrote: > v2: add ANV_CONTEXT_REALTIME_PRIORITY (Chris) > use unreachable with unknown priority (Samuel) > > v3: add stubs in gem_stubs.c (Emil) > use priority defines from gen_defines.h > > Signed-off-by: Tapani Pälli

Re: [Mesa-dev] [PATCH v2 06/24] anv/image: Add a helper for determining when fast clears are supported

On Fri, Jan 19, 2018 at 03:47:23PM -0800, Jason Ekstrand wrote: > v2 (Jason Ekstrand): > - Return an enum instead of a boolean > > Reviewed-by: Topi Pohjolainen > --- > src/intel/vulkan/anv_image.c | 70 > ++ >

Re: [Mesa-dev] [PATCH] i965: Drop render_target_start from binding table struct.

On Thursday, January 18, 2018 11:47:33 PM PST Iago Toral wrote: > On Thu, 2018-01-18 at 15:49 -0800, Kenneth Graunke wrote: > > We have to start render targets at binding table index 0 in order to > > use > > headerless FB write messages, and in fact already assume this in a > > bunch > > of

Re: [Mesa-dev] [PATCH v2 04/24] anv/blorp: Rework HiZ ops to look like MCS and CCS

On Fri, Jan 19, 2018 at 03:47:21PM -0800, Jason Ekstrand wrote: > Reviewed-by: Topi Pohjolainen > --- > src/intel/vulkan/anv_blorp.c | 38 > ++ > src/intel/vulkan/anv_private.h | 9 + >

Re: [Mesa-dev] [PATCH 1/2] i965/bufmgr: Add a create_from_prime_tiled function

On Sun, Jan 21, 2018 at 8:05 PM, Jason Ekstrand wrote: > This new function is an import and a set tiling in one go. > --- > src/mesa/drivers/dri/i965/brw_bufmgr.c | 41 > ++ > src/mesa/drivers/dri/i965/brw_bufmgr.h | 4 > 2 files

Re: [Mesa-dev] [PATCH 2/2] i965: Set tiling on BOs imported with modifiers

On Mon, Jan 22, 2018 at 10:03 AM, Jason Ekstrand wrote: > On January 22, 2018 09:10:52 Kristian Høgsberg wrote: > >> On Sun, Jan 21, 2018 at 8:05 PM, Jason Ekstrand >> wrote: >>> >>> We need this to ensure that GTT maps work on

Re: [Mesa-dev] [PATCH 2/2] i965: Set tiling on BOs imported with modifiers

On January 22, 2018 09:10:52 Kristian Høgsberg wrote: On Sun, Jan 21, 2018 at 8:05 PM, Jason Ekstrand wrote: We need this to ensure that GTT maps work on buffers we get from Vulkan on the off chance that someone does a readpixels or something.

Re: [Mesa-dev] [PATCH] swr: refactor swr_create_screen to allow for proper cleanup on error

Hi Emil, Fixes: a4be2bcee2f ("swr: allow a single swr architecture to be builtin") > It doesn't fix anything that was broken from that commit. The issues with error handling were already present before then, it's just that the changes in a4be2bcee2f were substantial so this commit works off the

[Mesa-dev] [Bug 104732] [radv] Binding descriptor sets disturbs other pipeline bindings

https://bugs.freedesktop.org/show_bug.cgi?id=104732 Bug ID: 104732 Summary: [radv] Binding descriptor sets disturbs other pipeline bindings Product: Mesa Version: git Hardware: All OS: All

Re: [Mesa-dev] [PATCH] swr: refactor swr_create_screen to allow for proper cleanup on error

On 22 January 2018 at 17:03, Chuck Atkins wrote: > Hi Emil, > >> Please include your follow-up reply/context as commit message. > > > Will do. > > >> > +// cleanup for failed screen creation >> > +PUBLIC void swr_destroy_screen_internal(struct swr_screen **screen); >> >>

[Mesa-dev] [PATCH] swr: don't export swr_create_screen_internal

From: Emil Velikov With earlier rework the user and provider of the symbol are within the same binary. Thus there's no point in exporting the function. Spotted while reviewing patch from Chuck, that nearly added another unneeded PUBLIC function. Cc: Chuck Atkins

Re: [Mesa-dev] [PATCH 0/7] EGL_ANDROID_blob_cache

On 22.01.2018 15:16, Nicolai Hähnle wrote: On 19.01.2018 07:05, Tapani Pälli wrote: On 01/18/2018 05:49 PM, Nicolai Hähnle wrote: On 17.01.2018 17:10, Tapani Pälli wrote: On 17.01.2018 13:34, Nicolai Hähnle wrote: On 15.01.2018 13:31, Tapani Pälli wrote: Hello; Here's a refactored

Re: [Mesa-dev] [PATCH 2/2] i965: Set tiling on BOs imported with modifiers

On Sun, Jan 21, 2018 at 8:05 PM, Jason Ekstrand wrote: > We need this to ensure that GTT maps work on buffers we get from Vulkan > on the off chance that someone does a readpixels or something. Soon, we > will be removing GTT maps from i965 entirely and this can be

[Mesa-dev] [PATCH] swr: refactor swr_create_screen to allow for proper cleanup on error

This makes the following changes to address cleanup issues: - Error conditions now return NULL instead of calling exit() - swr_creen is now freed upon error, rather than leak. - Library handle from dlopen is now closed upon swr_screen destruction v2: Added additional context in commit msg and

[Mesa-dev] [PATCH] swr: refactor swr_create_screen to allow for proper cleanup on error

This makes the followingt changes to address cleanup issues: - Error conditions now return null instead of calling exit() - swr_creen is now freed upon error, rather than leak. - Library handle from dlopen is now closed upon swr_screen destruction v2: Added additional context in commit msg and

[Mesa-dev] [Bug 103543] meson targets which link libgallium.a have unresolved symbol llvm::RTDyldMemoryManager

https://bugs.freedesktop.org/show_bug.cgi?id=103543 --- Comment #8 from Vedran Miletić --- Created attachment 136898 --> https://bugs.freedesktop.org/attachment.cgi?id=136898=edit build errors -- You are receiving this mail because: You are the assignee for the bug. You

[Mesa-dev] [Bug 103543] meson targets which link libgallium.a have unresolved symbol llvm::RTDyldMemoryManager

https://bugs.freedesktop.org/show_bug.cgi?id=103543 Vedran Miletić changed: What|Removed |Added Status|NEEDINFO|NEW

Re: [Mesa-dev] [PATCH 1/3] intel: add new common header gen_defines.h

On 22.01.2018 17:10, Emil Velikov wrote: On 22 January 2018 at 12:29, Tapani Pälli wrote: Signed-off-by: Tapani Pälli --- src/intel/common/gen_defines.h | 52 ++ 1 file changed, 52 insertions(+)

Re: [Mesa-dev] [PATCH] swr: refactor swr_create_screen to allow for proper cleanup on error

Hi Emil, Please include your follow-up reply/context as commit message. > Will do. > +// cleanup for failed screen creation > > +PUBLIC void swr_destroy_screen_internal(struct swr_screen **screen); > > I'm fairly sure you don't need to make this function public. It's used > within the same

[Mesa-dev] [Bug 100951] vkcube fails with vkMapMemory failed

https://bugs.freedesktop.org/show_bug.cgi?id=100951 --- Comment #4 from Kristian Høgsberg --- Can you really claim it's "known broken" when nobody told the maintainer? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [PATCH] mesa: Only require independent blending for GLES 3.2.

Am 22.01.2018 um 08:16 schrieb Tapani Pälli: > > > On 01/22/2018 08:48 AM, Ilia Mirkin wrote: >> What es3 does require, though, is mrt. Maybe add something that >> ensures that mrt is supported? > > I guess that would be EXT_draw_buffers? That is currently enabled with > 'dummy_true'. But only

Re: [Mesa-dev] [PATCH] i965: make brw_context::num_samples unsigned int

On 21 January 2018 at 16:15, Jason Ekstrand wrote: > Fair enough. I wasn't sure what you meant. > > Reviewed-by: Jason Ekstrand > Thanks, tweaked a bit and pushed to master. -Emil ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] swr: refactor swr_create_screen to allow for proper cleanup on error

On 22 January 2018 at 15:12, Chuck Atkins wrote: > Signed-off-by: Chuck Atkins Please include your follow-up reply/context as commit message. > // arch-specific dll entry point > PUBLIC struct pipe_screen *swr_create_screen_internal(struct

Re: [Mesa-dev] [PATCH] svga: Prevent use after free.

On 22 January 2018 at 15:13, Jose Fonseca wrote: > Courtesy of clang static analyzer. > > I was hunting for potential sources of memory corruption using Mesa with > a GL trace, and happened to find this (unrelated) issue. > --- > src/gallium/drivers/svga/svga_context.c | 1 +

[Mesa-dev] [PATCH] spirv/nir: Fix the stream ID when emitting a primitive or vertex

According to the SPIR-V spec: “Stream must be an of a constant instruction with a scalar integer type. That constant is the output-primitive stream number.” The previous code was treating it as an integer literal. --- This is part of the GL SPIR-V branch to enable streams for transform

Re: [Mesa-dev] [PATCH] swr: refactor swr_create_screen to allow for proper cleanup on error

For context, without this, the library handle from dlopen never get's closed, even under successful operation, and the swr_screen created never get's freed on error. Also error conditions resulted in exit() rather than NULL return. - Chuck On Mon, Jan 22, 2018 at 10:12 AM, Chuck Atkins

[Mesa-dev] [PATCH] svga: Prevent use after free.

Courtesy of clang static analyzer. I was hunting for potential sources of memory corruption using Mesa with a GL trace, and happened to find this (unrelated) issue. --- src/gallium/drivers/svga/svga_context.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH] swr: refactor swr_create_screen to allow for proper cleanup on error

Signed-off-by: Chuck Atkins --- src/gallium/drivers/swr/swr_loader.cpp | 100 + src/gallium/drivers/swr/swr_public.h | 6 +- src/gallium/drivers/swr/swr_screen.cpp | 26 +++-- src/gallium/drivers/swr/swr_screen.h | 3 + 4

[Mesa-dev] [PATCH] swr: refactor swr_create_screen to allow for proper cleanup on error

Signed-off-by: Chuck Atkins --- src/gallium/drivers/swr/swr_loader.cpp | 100 + src/gallium/drivers/swr/swr_public.h | 6 +- src/gallium/drivers/swr/swr_screen.cpp | 26 +++-- src/gallium/drivers/swr/swr_screen.h | 3 + 4

Re: [Mesa-dev] [PATCH 1/3] intel: add new common header gen_defines.h

On 22 January 2018 at 12:29, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > --- > src/intel/common/gen_defines.h | 52 > ++ > 1 file changed, 52 insertions(+) > create mode 100644

[Mesa-dev] [Bug 104553] mat4: m[i][j] incorrect result with row_major UBO

https://bugs.freedesktop.org/show_bug.cgi?id=104553 --- Comment #8 from Ilia Mirkin --- FYI idr had a separate script to reduce the giant test cases to the smallest that would still fail. It should be in one of his piglit branches in his personal fd.o git repo. (I'm on the

Re: [Mesa-dev] [PATCH v2 23/24] intel/blorp: Use isl_aux_op instead of blorp_hiz_op

On Fri, Jan 19, 2018 at 03:47:40PM -0800, Jason Ekstrand wrote: > --- > src/intel/blorp/blorp.c | 2 +- > src/intel/blorp/blorp.h | 19 + > src/intel/blorp/blorp_clear.c | 2 +- > src/intel/blorp/blorp_genX_exec.h

Re: [Mesa-dev] [PATCH 1/3] ac: add stream handling to visit_end_primitive()

On 22/01/18 23:37, Nicolai Hähnle wrote: Why hasn't this been noticed before? I knew it was broken but the state tracker needed to be fixed first which I hadn't gotten to, fortunately Rob fixed it for me :) [1] [1]

Re: [Mesa-dev] [PATCH v2 22/24] intel/blorp: Use isl_aux_op instead of blorp_fast_clear_op

On Fri, Jan 19, 2018 at 03:47:39PM -0800, Jason Ekstrand wrote: > --- > src/intel/blorp/blorp.h | 9 +-- > src/intel/blorp/blorp_clear.c | 10 > src/intel/blorp/blorp_genX_exec.h | 16 ++-- > src/intel/blorp/blorp_priv.h

Re: [Mesa-dev] [PATCH] radeonsi/nir: fix fs output index

On 22/01/18 23:45, Nicolai Hähnle wrote: On 22.01.2018 04:57, Timothy Arceri wrote: Fixes the following piglit tests: arb_blend_func_extended-fbo-extended-blend arb_blend_func_extended-fbo-extended-blend-explicit arb_blend_func_extended-fbo-extended-blend-explicit_gles3

Re: [Mesa-dev] [PATCH v2 21/24] anv: Allow fast-clearing the first slice of a multi-slice image

On Fri, Jan 19, 2018 at 03:47:38PM -0800, Jason Ekstrand wrote: > Now that we're tracking aux properly per-slice, we can enable this for > applications which actually care. > --- > src/intel/vulkan/anv_blorp.c | 22 +++--- > src/intel/vulkan/genX_cmd_buffer.c | 13

Re: [Mesa-dev] [PATCH 2/7] egl: add support for EGL_ANDROID_blob_cache

On 19 January 2018 at 06:53, Tapani Pälli wrote: > > > On 01/18/2018 04:55 PM, Emil Velikov wrote: >> >> On 17 January 2018 at 16:11, Tapani Pälli wrote: >>> >>> >>> >>> On 17.01.2018 13:28, Nicolai Hähnle wrote: On 16.01.2018 18:45,

Re: [Mesa-dev] [PATCH v2 20/24] anv/cmd_buffer: Rework aux tracking

I read this thru a few times, and found just two typos: Reviewed-by: Topi Pohjolainen There are a lot of details that could go wrong and another set of eyes on it would be really good. On Fri, Jan 19, 2018 at 03:47:37PM -0800, Jason Ekstrand wrote: > This commit

Re: [Mesa-dev] [PATCH] ac: fix image load store for GLSL_SAMPLER_DIM_3D

Hey, Nicolai Hähnle wrote on 22.01.2018 14:18: > On 20.01.2018 04:11, Timothy Arceri wrote: >> Fixes the following piglit tests: >> >> arb_shader_image_load_store/layer/image3d/layered binding test >> arb_shader_image_load_store/max-size/image3d max size test/2048x8x8x1 >>

Re: [Mesa-dev] [PATCH v2] ac: remove arrays when when querying sampler info

On 19.01.2018 06:07, Timothy Arceri wrote: Fixes the following ARB_arrays_of_arrays piglit tests: basic-imagestore-const-uniform-index basic-imagestore-mixed-const-non-const-uniform-index basic-imagestore-mixed-const-non-const-uniform-index2 basic-imagestore-non-const-uniform-index

Re: [Mesa-dev] [PATCH] ac: fix ac_build_varying_gather_values() for packed layouts

On 19.01.2018 06:50, Timothy Arceri wrote: This fixes a segfault for varyings not starting at component 0. Reviewed-by: Nicolai Hähnle --- src/amd/common/ac_llvm_build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH v2] ac: fix emit vertex stream parameter

On 20.01.2018 02:38, Timothy Arceri wrote: Fixes the following piglit test on radeonsi: ./bin/arb_enhanced_layouts-gs-stream-location-aliasing Reviewed-by: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [Mesa-dev] [PATCH] ac: fix image load store for GLSL_SAMPLER_DIM_3D

On 20.01.2018 04:11, Timothy Arceri wrote: Fixes the following piglit tests: arb_shader_image_load_store/layer/image3d/layered binding test arb_shader_image_load_store/max-size/image3d max size test/2048x8x8x1 arb_shader_image_load_store/max-size/image3d max size test/8x2048x8x1

Re: [Mesa-dev] [PATCH 0/7] EGL_ANDROID_blob_cache

On 19.01.2018 07:05, Tapani Pälli wrote: On 01/18/2018 05:49 PM, Nicolai Hähnle wrote: On 17.01.2018 17:10, Tapani Pälli wrote: On 17.01.2018 13:34, Nicolai Hähnle wrote: On 15.01.2018 13:31, Tapani Pälli wrote: Hello; Here's a refactored series of EGL_ANDROID_blob_cache. Now cache

Re: [Mesa-dev] [PATCH] radeonsi/nir: add primitive id to inputs scan

On 19.01.2018 12:46, Timothy Arceri wrote: Fixes the following piglit tests: arb_tessellation_shader/fs-primitiveid-instanced glsl-1.50/primitive-id-no-gs glsl-1.50/primitive-id-no-gs-first-vertex glsl-1.50/primitive-id-no-gs-instanced glsl-1.50/primitive-id-no-gs-strip

  1   2   >