[Mesa-dev] [PATCH] mesa: add OES_EGL_image_external_essl3 support

2018-02-01 Thread Tapani Pälli
From: Ilia Mirkin Signed-off-by: Ilia Mirkin Reviewed-by: Tapani Pälli --- This one was originally sent as: https://patchwork.freedesktop.org/patch/45339/ I've done trivial rebase for the patch, went through the changes

[Mesa-dev] [PATCH] r600: fix resq for buffer images.

2018-02-01 Thread Dave Airlie
From: Dave Airlie If this is an image buffer, we need to calculate the correct resource id. Fixes: KHR-GL45.shader_image_size.* Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 5 - 1 file changed, 4 insertions(+), 1

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-01 Thread Timothy Arceri
On 02/02/18 17:21, Timothy Arceri wrote: On 02/02/18 16:38, Jan Vesely wrote: On Fri, 2018-02-02 at 15:03 +1100, Timothy Arceri wrote: When PIPE_SHADER_IR_LLVM existed this query made sense but now it always returns PIPE_SHADER_IR_NATIVE. Also it is now conlicting with PIPE_SHADER_IR_NIR for

[Mesa-dev] [PATCH] r600/eg: fix cube map array buffer images.

2018-02-01 Thread Dave Airlie
From: Dave Airlie This fixes a crash in: KHR-GL45.texture_cube_map_array.texture_size_compute_sh. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_state_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH (resend)] r600/sb: Don't require array declarations for TGSI_FILE_SYSTEM_VALUE

2018-02-01 Thread Gert Wollny
Am Freitag, den 02.02.2018, 02:13 +0100 schrieb Roland Scheidegger: > Am 30.01.2018 um 09:21 schrieb Gert Wollny: > > Although gl_SampleMaskIn is declared as an array in GLSL, it is > > effectively a 32 bit mask on all hardware supported by mesa, so the > > array indexing is ignored (Thanks Glenn

[Mesa-dev] [PATCH] r600: fix VERTEX_ATTRIB_STRIDE to be 2048

2018-02-01 Thread Dave Airlie
From: Dave Airlie This fixes: KHR-GL45.limits.max_vertex_attrib_stride looks like a typo from the first commit. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-01 Thread Timothy Arceri
On 02/02/18 16:38, Jan Vesely wrote: On Fri, 2018-02-02 at 15:03 +1100, Timothy Arceri wrote: When PIPE_SHADER_IR_LLVM existed this query made sense but now it always returns PIPE_SHADER_IR_NATIVE. Also it is now conlicting with PIPE_SHADER_IR_NIR for compute shaders, so just assume this is

[Mesa-dev] [PATCH v2 3/3] st/radeonsi: enable disk cache for nir

2018-02-01 Thread Timothy Arceri
Reviewed-by: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 4 src/mesa/state_tracker/st_program.c| 15 +++ 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c

[Mesa-dev] [PATCH v2 2/3] st: add nir shader disk cache support

2018-02-01 Thread Timothy Arceri
v2: include compute shader support --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +- src/mesa/state_tracker/st_program.c| 6 +- src/mesa/state_tracker/st_shader_cache.c | 163 ++--- src/mesa/state_tracker/st_shader_cache.h | 8 +- 4 files changed,

[Mesa-dev] [PATCH v2 1/3] st/glsl_to_tgsi: move nir detection earlier

2018-02-01 Thread Timothy Arceri
We move the nir check before the shader cache call so that we can call a nir based caching function in a following patch. Also with this change we simply check if vertex shaders support NIR rather than looping over the stages as mixing of shader types is not supported anyway. ---

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-01 Thread Jan Vesely
On Fri, 2018-02-02 at 15:03 +1100, Timothy Arceri wrote: > When PIPE_SHADER_IR_LLVM existed this query made sense but now it > always returns PIPE_SHADER_IR_NATIVE. Also it is now conlicting > with PIPE_SHADER_IR_NIR for compute shaders, so just assume this > is always PIPE_SHADER_IR_NATIVE for

[Mesa-dev] [PATCH] r600/eg: use texture target to pick array size not view target (v2)

2018-02-01 Thread Dave Airlie
From: Dave Airlie This fixes a few CTS cases in : KHR-GL45.texture_view.view_sampling some multisample cases are still broken, but not sure this is the same problem. v2: fix more cases Signed-off-by: Dave Airlie ---

Re: [Mesa-dev] [PATCH 2/9] glsl: add u64->fp64 and i64->fp64 builtins.

2018-02-01 Thread Dave Airlie
On 2 February 2018 at 03:40, Roland Scheidegger wrote: > I suppose this is a bit inefficient if the hw actually supports some > double ops? > I mean for uint->double you could just convert the low 8 bits and high > 24 bits (or different split) separately to float, convert both

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-01 Thread Timothy Arceri
On 02/02/18 15:12, Ilia Mirkin wrote: Seems like the proper solution to this problem is to use something like ST_DEBUG=nir (which would in turn check the SUPPORTED_IRS bitmap) rather than trying to hack drivers... That sounds like more of a hack to me. What happend when nir becomes the

[Mesa-dev] [PATCH] r600/fp64: fix integer->double conversion

2018-02-01 Thread Dave Airlie
From: Dave Airlie Doing a straight uint/int->fp32->fp64 conversion causes some precision issues, Roland suggested splitting the integer into two portions and doing two separate int->fp32->fp64 conversions then adding the results. This passes the tests in CTS and piglit.

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-01 Thread Ilia Mirkin
Seems like the proper solution to this problem is to use something like ST_DEBUG=nir (which would in turn check the SUPPORTED_IRS bitmap) rather than trying to hack drivers... On Thu, Feb 1, 2018 at 11:03 PM, Timothy Arceri wrote: > When PIPE_SHADER_IR_LLVM existed this

[Mesa-dev] [PATCH 07/11] ac/radeonsi: create ac_build_shader_clock() helper

2018-02-01 Thread Timothy Arceri
--- src/amd/common/ac_llvm_build.c | 8 src/amd/common/ac_llvm_build.h | 2 ++ src/gallium/drivers/radeonsi/si_shader.c | 6 +- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index

[Mesa-dev] [PATCH 03/11] ac/radeonsi: add local_invocation_ids to the abi

2018-02-01 Thread Timothy Arceri
--- src/amd/common/ac_nir_to_llvm.c | 5 ++--- src/amd/common/ac_shader_abi.h| 2 ++ src/gallium/drivers/radeonsi/si_shader.c | 4 ++-- src/gallium/drivers/radeonsi/si_shader_internal.h | 1 - 4 files changed, 6 insertions(+), 6 deletions(-) diff

[Mesa-dev] [PATCH 05/11] radeonsi: add get_block_size() helper

2018-02-01 Thread Timothy Arceri
This will be reused by the nir backend in a later patch. --- src/gallium/drivers/radeonsi/si_shader.c | 47 ++-- 1 file changed, 27 insertions(+), 20 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index

[Mesa-dev] [PATCH 10/11] radeonsi/nir: add nir support for compiling compute shaders

2018-02-01 Thread Timothy Arceri
--- src/gallium/drivers/radeonsi/si_compute.c | 44 ++- src/gallium/drivers/radeonsi/si_compute.h | 5 +++- src/gallium/drivers/radeonsi/si_get.c | 8 +++--- 3 files changed, 39 insertions(+), 18 deletions(-) diff --git

[Mesa-dev] [PATCH 09/11] ac/radeonsi: add num_work_groups to the abi

2018-02-01 Thread Timothy Arceri
--- src/amd/common/ac_nir_to_llvm.c | 5 ++--- src/amd/common/ac_shader_abi.h| 1 + src/gallium/drivers/radeonsi/si_shader.c | 4 ++-- src/gallium/drivers/radeonsi/si_shader_internal.h | 1 - 4 files changed, 5 insertions(+), 6 deletions(-) diff

[Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-01 Thread Timothy Arceri
When PIPE_SHADER_IR_LLVM existed this query made sense but now it always returns PIPE_SHADER_IR_NATIVE. Also it is now conlicting with PIPE_SHADER_IR_NIR for compute shaders, so just assume this is always PIPE_SHADER_IR_NATIVE for clover. This change indirectly enables NIR support for compute

[Mesa-dev] [PATCH 06/11] ac/radeonsi: add load_local_group_size() to the abi

2018-02-01 Thread Timothy Arceri
--- src/amd/common/ac_nir_to_llvm.c | 3 +++ src/amd/common/ac_shader_abi.h | 2 ++ src/gallium/drivers/radeonsi/si_shader.c | 1 + 3 files changed, 6 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index b2e72e109e..4c346119c3

[Mesa-dev] [PATCH 08/11] ac: implement nir_intrinsic_shader_clock

2018-02-01 Thread Timothy Arceri
--- src/amd/common/ac_nir_to_llvm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 4c346119c3..bf36c7ef84 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.c @@ -4448,6 +4448,9 @@ static

[Mesa-dev] radeonsi nir support for compute shaders

2018-02-01 Thread Timothy Arceri
Confiliting values returned by PIPE_SHADER_CAP_PREFERRED_IR meant that compute for NIR was always disable before this series (see patch 11). This series should contain everything except shared variable/atomic support, I intend to tackle those in a follow up series. Please review.

[Mesa-dev] [PATCH 02/11] ac/radeonsi: add workgroup_ids to the abi

2018-02-01 Thread Timothy Arceri
--- src/amd/common/ac_nir_to_llvm.c | 9 - src/amd/common/ac_shader_abi.h| 1 + src/gallium/drivers/radeonsi/si_shader.c | 9 - src/gallium/drivers/radeonsi/si_shader_internal.h | 1 - 4 files changed, 9 insertions(+), 11 deletions(-)

[Mesa-dev] [PATCH 04/11] ac: don't call emit_outputs() for compute

2018-02-01 Thread Timothy Arceri
--- src/amd/common/ac_nir_to_llvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 570c798d4e..b2e72e109e 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.c @@ -6758,8

[Mesa-dev] [PATCH 01/11] radeonsi/nir: gather some compute info in si_nir_scan_shader()

2018-02-01 Thread Timothy Arceri
--- src/gallium/drivers/radeonsi/si_shader_nir.c | 30 +++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 128be585cd..28b031d935 100644 ---

Re: [Mesa-dev] [PATCH] mesa: don't flag _NEW_COLOR for KHR adv.blend if prog constant doesn't change

2018-02-01 Thread Ian Romanick
Reviewed-by: Ian Romanick I also ran it through our CI. On 01/31/2018 11:54 AM, Marek Olšák wrote: > From: Marek Olšák > > This only affects drivers that set DriverFlags.NewBlend. > > v2: - fix typo advanded -> advanced > - return "enum

[Mesa-dev] [PATCH] anv: Do color resolve tracking one slice at a time for 3D images

2018-02-01 Thread Jason Ekstrand
--- src/intel/vulkan/anv_image.c | 14 +- src/intel/vulkan/anv_private.h | 9 - src/intel/vulkan/genX_cmd_buffer.c | 34 -- 3 files changed, 33 insertions(+), 24 deletions(-) diff --git a/src/intel/vulkan/anv_image.c

Re: [Mesa-dev] [PATCH] r600/eg: add crap indirect compute support.

2018-02-01 Thread Roland Scheidegger
That's not much "indirect" the way it's done, but looks alright to me ;-). Reviewed-by: Roland Scheidegger Am 30.01.2018 um 03:22 schrieb Dave Airlie: > From: Dave Airlie > > I think the cp packets can be made work, but I think it might > need a kernel

Re: [Mesa-dev] [PATCH (resend)] r600/sb: Don't require array declarations for TGSI_FILE_SYSTEM_VALUE

2018-02-01 Thread Roland Scheidegger
Am 30.01.2018 um 09:21 schrieb Gert Wollny: > Although gl_SampleMaskIn is declared as an array in GLSL, it is > effectively a 32 bit mask on all hardware supported by mesa, so the > array indexing is ignored (Thanks Glenn Kennard for the explanation). > > Add a comment that the assert is not made

Re: [Mesa-dev] [PATCH] r600: initial attempt at gl_HelperInvocation (v3)

2018-02-01 Thread Dave Airlie
>> >> It might be for this test, but I don't think it is in general. We want >> boolean >> which I think is 0 or 0x, not 0.0 or 1.0. > > The initial alu reg write was 0x, and the resinfo gives you back > a fixed 0, so... Doh I just noticed it now, my brain had a copy of the older

Re: [Mesa-dev] [PATCH] r600: initial attempt at gl_HelperInvocation (v3)

2018-02-01 Thread Roland Scheidegger
Am 02.02.2018 um 00:23 schrieb Dave Airlie: > On 2 February 2018 at 09:23, Dave Airlie wrote: >> On 2 February 2018 at 02:05, Roland Scheidegger wrote: >>> Am 01.02.2018 um 09:21 schrieb Dave Airlie: From: Dave Airlie

Re: [Mesa-dev] [PATCH] r600: initial attempt at gl_HelperInvocation (v3)

2018-02-01 Thread Dave Airlie
On 2 February 2018 at 09:23, Dave Airlie wrote: > On 2 February 2018 at 02:05, Roland Scheidegger wrote: >> Am 01.02.2018 um 09:21 schrieb Dave Airlie: >>> From: Dave Airlie >>> >>> This passes the CTS and piglit tests. >>> >>> This

Re: [Mesa-dev] [PATCH] r600: initial attempt at gl_HelperInvocation (v3)

2018-02-01 Thread Dave Airlie
On 2 February 2018 at 02:05, Roland Scheidegger wrote: > Am 01.02.2018 um 09:21 schrieb Dave Airlie: >> From: Dave Airlie >> >> This passes the CTS and piglit tests. >> >> This also disable sb for helper invocations until it doesn't >> mess up the VPM

Re: [Mesa-dev] [PATCH 2/3] gallium: Add a new A4B4G4R4 pipe format for Broadcom.

2018-02-01 Thread Marek Olšák
Patch 1 & 2: Reviewed-by: Marek Olšák Marek On Thu, Feb 1, 2018 at 8:20 PM, Eric Anholt wrote: > The VC5 HW puts A in the low bits and R in the high bits. We can't just > swizzle in the shaders because the blending HW can't pick what channel A > is in,

[Mesa-dev] [PATCH] gallium: remove llvm from ir struct

2018-02-01 Thread Timothy Arceri
This was added in 425dc4c4b366 but never used. Also since 100796c15c3a native has superseded llvm. --- src/gallium/include/pipe/p_state.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/include/pipe/p_state.h b/src/gallium/include/pipe/p_state.h index 2b56d60b5e..640e6ed26d 100644

Re: [Mesa-dev] [PATCH 2/9] glsl: add u64->fp64 and i64->fp64 builtins.

2018-02-01 Thread Dylan Baker
Quoting Elie Tournier (2018-02-01 12:13:53) > On Thu, Feb 01, 2018 at 10:00:12AM -0800, Dylan Baker wrote: > > There are changes from Makefile.sources that need be ported to corresponding > > meson.build files as well. > Oh yes, nice spot. I will do it on my local fp64 branch too. > > > > It

Re: [Mesa-dev] [PATCH] r600: don't do stack workarounds for hemlock

2018-02-01 Thread Alex Deucher
On Tue, Jan 30, 2018 at 12:07 AM, wrote: > From: Roland Scheidegger > > By the looks of it it seems hemlock is treated separately to cypress, but > certainly it won't need the stack workarounds cedar/redwood (and > seemingly every other eg chip except

[Mesa-dev] [PATCH 2/3] gallium: Add a new A4B4G4R4 pipe format for Broadcom.

2018-02-01 Thread Eric Anholt
The VC5 HW puts A in the low bits and R in the high bits. We can't just swizzle in the shaders because the blending HW can't pick what channel A is in, so make a new format to match it. --- src/gallium/auxiliary/util/u_format.csv | 1 + src/gallium/drivers/svga/svga_format.c | 1 +

[Mesa-dev] [PATCH 1/3] mesa: Drop incorrect A4B4G4R4 _mesa_format_matches_format_and_type() cases.

2018-02-01 Thread Eric Anholt
swapBytes operates on bytes, not 4-bit channels, so you can't just take non-swapBytes cases and flip the REV flag. Avoids piglit texture-packed-formats regressions when enabling the ABGR format. Fixes: c5a5c9a7db89 ("mesa/formats: add new mesa formats and their pack/unpack functions.") ---

[Mesa-dev] [PATCH 3/3] broadcom/vc5: Switch our RGBA4 support to the new gallium format.

2018-02-01 Thread Eric Anholt
Fixes fbo-generatemipmap-formats, fbo-alphatest-formats, etc. tests for GL_RGBA4, GL_RGB4, GL_RGBA2, etc. --- src/gallium/drivers/vc5/v3dx_format_table.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/vc5/v3dx_format_table.c

[Mesa-dev] [Bug 104374] Cemu 1.11.1 via Wine using Mesa Mild exposes LLVM AMDGPU bugs on RX Vega..

2018-02-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104374 --- Comment #2 from João Henrique --- This is the same issue as https://bugs.freedesktop.org/show_bug.cgi?id=104902 and it is reproducible on non mesa_mild branches (such as Padoka PPA) Included in that bug report is

Re: [Mesa-dev] [PATCH] gallivm/llvmpipe: add const qualifiers on sampler variables

2018-02-01 Thread Roland Scheidegger
Makes sense. Reviewed-by: Roland Scheidegger Am 01.02.2018 um 21:18 schrieb Brian Paul: > Once a lp_build_sampler_soa or lp_build_sampler_aos object is created, > it should never be modified. Found by inspection. > --- > src/gallium/auxiliary/draw/draw_llvm.c | 2

[Mesa-dev] [PATCH] gallivm/llvmpipe: add const qualifiers on sampler variables

2018-02-01 Thread Brian Paul
Once a lp_build_sampler_soa or lp_build_sampler_aos object is created, it should never be modified. Found by inspection. --- src/gallium/auxiliary/draw/draw_llvm.c | 2 +- src/gallium/auxiliary/gallivm/lp_bld_tgsi.h | 8 src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c | 2

Re: [Mesa-dev] [PATCH 2/9] glsl: add u64->fp64 and i64->fp64 builtins.

2018-02-01 Thread Elie Tournier
On Thu, Feb 01, 2018 at 10:00:12AM -0800, Dylan Baker wrote: > There are changes from Makefile.sources that need be ported to corresponding > meson.build files as well. Oh yes, nice spot. I will do it on my local fp64 branch too. > > It looks like builtin_float64.h is generated from float64.glsl,

Re: [Mesa-dev] [PATCH 2/9] glsl: add u64->fp64 and i64->fp64 builtins.

2018-02-01 Thread Dylan Baker
There are changes from Makefile.sources that need be ported to corresponding meson.build files as well. It looks like builtin_float64.h is generated from float64.glsl, is that right? I'm not very happy about checking in a generated file for all of the reasons that we don't check generated files

Re: [Mesa-dev] [PATCH 1/6] meson: find python2 on macOS

2018-02-01 Thread Dylan Baker
Quoting Emil Velikov (2018-02-01 03:49:12) > On 28 January 2018 at 14:24, Jon Turney wrote: > > From: Dylan Baker > > > > --- > > meson.build | 8 +++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/meson.build

Re: [Mesa-dev] [Test Patch] Meson: ensure vdpau has proper symbolsexposed

2018-02-01 Thread Dylan Baker
Emil had requested some changes, and it's on my list to get these respun today and back on the list. I'll CC you on them. Thanks for reminding me :) Dylan Quoting Marc Dietrich (2018-02-01 02:44:25) > Am Mittwoch, 17. Januar 2018, 18:41:00 CET schrieb Dylan Baker: > > I dug into what autotools

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] meson/swr: re-shuffle generated files

2018-02-01 Thread Dylan Baker
With the below nits fixed, for the series: Reviewed-by: Dylan Baker Quoting George Kyriazis (2018-02-01 08:54:14) > Move generated files from codegen/meson.build to other directories, in order > to satisfy generated include file dependencies > > Add correct file lists for

[Mesa-dev] [Bug 104908] Texture Compression Hint not converted to enum16

2018-02-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104908 Brian Paul changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH] renderonly: fix dumb BO allocation for non 32bpp formats

2018-02-01 Thread Lucas Stach
Am Mittwoch, den 31.01.2018, 11:37 + schrieb Daniel Stone: > On 30 January 2018 at 14:22, Lucas Stach > wrote: > > Take into account the resource format, instead of applying a > > hardcoded > > 32bpp. This not only over-allocates 16bpp formats, but also results > > in

Re: [Mesa-dev] [PATCH 0/8] Partly untangle pos/generic0 aliasing dependencies v2.

2018-02-01 Thread Mathias Fröhlich
Hi Brian, On Thursday, 1 February 2018 17:17:57 CET Brian Paul wrote: > Looks good. > > Reviewed-by: Brian Paul Thanks!! > I don't remember, do you need me to push these for you? I used to have an account for mesa. I have not used that for some time, but I assume that it

Re: [Mesa-dev] [PATCH 1/4] vbo: use vbo local var for draw call in vbo_save_playback_vertex_list()

2018-02-01 Thread Mathias Fröhlich
Hi Brian, with the updated comment that Ilia found, also Reviewed-by: Mathias Fröhlich best Mathias > --- > src/mesa/vbo/vbo_save_draw.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/src/mesa/vbo/vbo_save_draw.c

[Mesa-dev] [Bug 104908] Texture Compression Hint not converted to enum16

2018-02-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104908 --- Comment #1 from Brian Paul --- The patch looks good to me. I'll push it in a bit. I don't see any other issues related to Hint.TextureCompression. Unfortunately, there's no Piglit test that hits this. -- You are

Re: [Mesa-dev] [PATCH 1/6] meson: find python2 on macOS

2018-02-01 Thread Jon Turney
On 01/02/2018 11:49, Emil Velikov wrote: On 28 January 2018 at 14:24, Jon Turney wrote: From: Dylan Baker --- meson.build | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index

[Mesa-dev] [PATCH 2/4] travis: conditionalize building of prerequisites on if OS=linux

2018-02-01 Thread Jon Turney
Use a '|' YAML literal block to avoid the convoluted syntax needed to put the entire conditional on a single line. Signed-off-by: Jon Turney --- .travis.yml | 91 +++-- 1 file changed, 47 insertions(+), 44

[Mesa-dev] [PATCH 4/4] travis: add osx autotools build

2018-02-01 Thread Jon Turney
Signed-off-by: Jon Turney --- .travis.yml | 30 ++ 1 file changed, 30 insertions(+) diff --git a/.travis.yml b/.travis.yml index e18327bec9..fc137c9667 100644 --- a/.travis.yml +++ b/.travis.yml @@ -396,6 +396,36 @@ matrix: -

[Mesa-dev] [PATCH 0/4] Fix osx build and add to CI (reprise)

2018-02-01 Thread Jon Turney
Jon Turney (4): glx/test: fix building for osx travis: conditionalize building of prerequisites on if OS=linux travis: pip -> pip2 travis: add osx autotools build .travis.yml | 123 -- src/glx/tests/fake_glx_screen.cpp | 11

[Mesa-dev] [PATCH 3/4] travis: pip -> pip2

2018-02-01 Thread Jon Turney
On travis, for OSX, python2 from homebrew is pre-installed. per [1]: python points to the macOS system Python (with no manual PATH modification) python2 points to Homebrew’s Python 2.7.x (if installed) python3 points to Homebrew’s Python 3.x (if installed) pip doesn't exist pip2 points to

[Mesa-dev] [PATCH 1/4] glx/test: fix building for osx

2018-02-01 Thread Jon Turney
An additional stub for applegl_create_context() is needed Cannot test indirect API as it's not built on osx, currently Signed-off-by: Jon Turney --- src/glx/tests/fake_glx_screen.cpp | 11 +++ src/glx/tests/indirect_api.cpp| 4 2 files changed, 15

Re: [Mesa-dev] [PATCH v2] mesa: enable ASTC/ETC1 compressed 3D textures

2018-02-01 Thread Juan A. Suarez Romero
On Thu, 2018-02-01 at 12:45 +0100, Juan A. Suarez Romero wrote: > On Mon, 2018-01-29 at 16:25 -0800, Eric Anholt wrote: > > "Juan A. Suarez Romero" writes: > > > > > Enable these kind of 3D texture when proper extensions are available. > > > > > > Fixes

Re: [Mesa-dev] [PATCH mesa 1/2] meson: centralise the libdrm versions information

2018-02-01 Thread Emil Velikov
On 31 January 2018 at 17:11, Dylan Baker wrote: > Quoting Emil Velikov (2018-01-31 03:42:00) >> On 30 January 2018 at 21:31, Dylan Baker wrote: >> > Quoting Emil Velikov (2018-01-30 10:43:06) >> >> On 29 January 2018 at 18:57, Dylan Baker

Re: [Mesa-dev] [PATCH 2/9] glsl: add u64->fp64 and i64->fp64 builtins.

2018-02-01 Thread Roland Scheidegger
I suppose this is a bit inefficient if the hw actually supports some double ops? I mean for uint->double you could just convert the low 8 bits and high 24 bits (or different split) separately to float, convert both to double and add them. (I think should work for int->double exactly the same

Re: [Mesa-dev] [PATCH mesa 1/2] meson: centralise the libdrm versions information

2018-02-01 Thread Dylan Baker
Quoting Emil Velikov (2018-01-31 03:42:00) > On 30 January 2018 at 21:31, Dylan Baker wrote: > > Quoting Emil Velikov (2018-01-30 10:43:06) > >> On 29 January 2018 at 18:57, Dylan Baker wrote: > >> > Quoting Eric Engestrom (2018-01-29 10:15:50) > >> >>

Re: [Mesa-dev] [PATCH libdrm] meson: fix libdrm_nouveau pkgconfig include directories

2018-02-01 Thread Dylan Baker
Thanks! Quoting Eric Engestrom (2018-01-31 03:14:50) > On Thursday, 2018-01-25 16:14:45 -0800, Dylan Baker wrote: > > Signed-off-by: Dylan Baker > > Reviewed-by: Eric Engestrom > > > --- > > > > I have tested building every mesa driver

Re: [Mesa-dev] [PATCH mesa v2 1/2] meson: centralise the libdrm versions information

2018-02-01 Thread Dylan Baker
Quoting Eric Engestrom (2018-01-31 03:47:25) > The big comment is taken from the equivalent block in configure.ac > > Signed-off-by: Eric Engestrom > --- > meson.build | 30 > + >

Re: [Mesa-dev] [PATCH 4/4] vbo: change an argument in vbo_draw_indirect_prims()

2018-02-01 Thread Marek Olšák
With the comments on patch 3 addressed, the series is: Reviewed-by: Marek Olšák Marek On Thu, Feb 1, 2018 at 4:39 AM, Brian Paul wrote: > In vbo_draw_indirect_prims() pass the 'indirect_data' argument to > vbo->draw_prims(). All the callers are passing

[Mesa-dev] [PATCH 2/2] meson/swr: Updated copyright dates

2018-02-01 Thread George Kyriazis
cc: mesa-sta...@lists.freedesktop.org cc: dy...@pnwbakers.com --- src/gallium/drivers/swr/meson.build | 2 +- src/gallium/drivers/swr/rasterizer/codegen/meson.build | 2 +- src/gallium/drivers/swr/rasterizer/core/backends/meson.build | 2 +-

[Mesa-dev] [PATCH 1/2] meson/swr: re-shuffle generated files

2018-02-01 Thread George Kyriazis
Move generated files from codegen/meson.build to other directories, in order to satisfy generated include file dependencies Add correct file lists for architecture-specific libraries. cc: mesa-sta...@lists.freedesktop.org cc: dy...@pnwbakers.com --- src/gallium/drivers/swr/meson.build

[Mesa-dev] [Bug 104908] Texture Compression Hint not converted to enum16

2018-02-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104908 Bug ID: 104908 Summary: Texture Compression Hint not converted to enum16 Product: Mesa Version: git Hardware: All OS: All Status: NEW Severity: minor

Re: [Mesa-dev] [PATCH] glsl/lower_64bit: restrict int64 conversion to int64 instructions.

2018-02-01 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Feb 1, 2018 at 4:57 AM, Dave Airlie wrote: > From: Dave Airlie > > If the lowering flags for int64 were set we'd try and lower > the wrong things sometimes. > > Signed-off-by: Dave Airlie

Re: [Mesa-dev] [PATCH 0/8] Partly untangle pos/generic0 aliasing dependencies v2.

2018-02-01 Thread Brian Paul
On 02/01/2018 12:32 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Hi, Thanks for the review! This is the starting point to a patch series that I intent to feed. The aim is to get rid of some VERT_ATTRIB_MAX long loops that currently happen at about

Re: [Mesa-dev] [PATCH] ac/nir: replace SI.buffer.load.dword with amdgcn.buffer.load

2018-02-01 Thread Bas Nieuwenhuizen
I'm surprised it does not do a idxen and swizzling, but with the current code, this is Reviewed-by: Bas Nieuwenhuizen On Thu, Feb 1, 2018 at 4:37 PM, Samuel Pitoiset wrote: > The old one generates useless instructions in there, found while

Re: [Mesa-dev] [PATCH] r600: initial attempt at gl_HelperInvocation (v3)

2018-02-01 Thread Roland Scheidegger
Am 01.02.2018 um 09:21 schrieb Dave Airlie: > From: Dave Airlie > > This passes the CTS and piglit tests. > > This also disable sb for helper invocations until it doesn't > mess up the VPM flags. > > Thanks to Ilia and Glenn for advice, and Roland for working > out the

Re: [Mesa-dev] [PATCH v2] i965: check if upload is 0 explicitely, when downsizing a format

2018-02-01 Thread Kenneth Graunke
On Thursday, February 1, 2018 7:15:14 AM PST Andres Gomez wrote: > downsize_format_if_needed takes an integer as number of uploads > parameter. Hence, let's do an integer comparation instead of a boolean > check, since that is confusing. > > Since we are at it, fix a couple of wrongly tabbed

[Mesa-dev] X.Org Foundation Membership Renewal

2018-02-01 Thread Rob Clark
On Feb 1st all xorg members were expired as part of the regular process to remove inactive members. If you would still like to be a member of the X.Org Foundation, please renew your membership. To renew or to become a first time member, go to https://members.x.org/ . For renewals, log in and

Re: [Mesa-dev] [PATCH 3/4] vbo: add comments on the VBO draw function typedefs

2018-02-01 Thread Brian Paul
On 02/01/2018 03:49 AM, Ilia Mirkin wrote: On Wed, Jan 31, 2018 at 10:39 PM, Brian Paul wrote: And rename indirect_params -> indirect_draw_count_buffer and indirect_params_offset -> indirect_draw_count_offset to be more specific. --- src/mesa/vbo/vbo.h | 57

Re: [Mesa-dev] [PATCH] meson: don't install windows headers on non-windowsplatforms

2018-02-01 Thread Eric Engestrom
On Thursday, 2018-02-01 15:29:25 +0100, Marc Dietrich wrote: > Am Donnerstag, 1. Februar 2018, 15:07:55 CET schrieb Eric Engestrom: > > On Thursday, 2018-02-01 13:27:28 +0100, Marc Dietrich wrote: > > > Only dive into the windows subdir if windows platform is selected. > > > > > > Signed-off-by:

[Mesa-dev] [PATCH] ac/nir: replace SI.buffer.load.dword with amdgcn.buffer.load

2018-02-01 Thread Samuel Pitoiset
The old one generates useless instructions in there, found while comparing geometry shaders between RadeonSI and RADV. This improves all Vulkan demos that use geometry shaders, +4% for deferredshadows, +9% for viewportarray, +7% for geometryshader on Polaris10. This seems to also improve DOW3 a

[Mesa-dev] [PATCH v2] i965: check if upload is 0 explicitely, when downsizing a format

2018-02-01 Thread Andres Gomez
downsize_format_if_needed takes an integer as number of uploads parameter. Hence, let's do an integer comparation instead of a boolean check, since that is confusing. Since we are at it, fix a couple of wrongly tabbed indents. Cc: Alejandro Piñeiro Cc: Kenneth Graunke

[Mesa-dev] [PATCH] i965: check if compare is 0 explicitely, when downsizing a format

2018-02-01 Thread Andres Gomez
downsize_format_if_needed takes an integer as number of uploads parameter. Hence, let's do an integer comparation instead of a boolean check, since that is confusing. Since we are at it, fix a couple of wrongly tabbed indents. Cc: Alejandro Piñeiro Cc: Kenneth Graunke

[Mesa-dev] [Bug 104905] SpvOpFOrdEqual doesn't return correct results for NaNs

2018-02-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104905 Bug ID: 104905 Summary: SpvOpFOrdEqual doesn't return correct results for NaNs Product: Mesa Version: git Hardware: All OS: All Status: NEW Severity:

Re: [Mesa-dev] [PATCH] mesa: remove usage of alloca in externalobjects.c v3

2018-02-01 Thread Andres Rodriguez
On 2018-02-01 08:24 AM, Emil Velikov wrote: On 31 January 2018 at 19:03, Andres Rodriguez wrote: Don't want an overly large numBufferBarriers/numTextureBarriers to blow up the stack. v2: handle malloc errors v3: fix patch Suggested-by: Emil Velikov

Re: [Mesa-dev] [PATCH] meson: don't install windows headers on non-windowsplatforms

2018-02-01 Thread Marc Dietrich
Am Donnerstag, 1. Februar 2018, 15:07:55 CET schrieb Eric Engestrom: > On Thursday, 2018-02-01 13:27:28 +0100, Marc Dietrich wrote: > > Only dive into the windows subdir if windows platform is selected. > > > > Signed-off-by: Marc Dietrich > > Good point, although if I'm

Re: [Mesa-dev] [PATCH 4/4] svga: remove unneeded #includes in svga_pipe_draw.c

2018-02-01 Thread Neha Bhende
For the series, Reviewed-by: Neha Bhende From: Brian Paul Sent: Wednesday, January 31, 2018 7:37:23 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH 4/4] svga: remove unneeded #includes in

Re: [Mesa-dev] [PATCH] meson: don't install windows headers on non-windows platforms

2018-02-01 Thread Eric Engestrom
On Thursday, 2018-02-01 13:27:28 +0100, Marc Dietrich wrote: > Only dive into the windows subdir if windows platform is selected. > > Signed-off-by: Marc Dietrich Good point, although if I'm reading it right, it only installs a couple unnecessary headers right now; we got lucky

Re: [Mesa-dev] misc pahole repacking

2018-02-01 Thread Emil Velikov
On 1 February 2018 at 11:13, Adrian M Negreanu wrote: > There's a bug about quiting on unsupported tags: > https://bugzilla.redhat.com/show_bug.cgi?id=1348200 > > Should be fixed in v1.10 > http://pkgs.fedoraproject.org/cgit/rpms/dwarves.git/commit/?h=f25 > Seems like distros

[Mesa-dev] [Bug 104732] [radv] Binding descriptor sets disturbs other pipeline bindings

2018-02-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104732 Józef Kucia changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH] mesa: remove usage of alloca in externalobjects.c v3

2018-02-01 Thread Emil Velikov
On 31 January 2018 at 19:03, Andres Rodriguez wrote: > Don't want an overly large numBufferBarriers/numTextureBarriers to blow > up the stack. > > v2: handle malloc errors > v3: fix patch > > Suggested-by: Emil Velikov > Signed-off-by: Andres

Re: [Mesa-dev] [PATCH 6/6] travis: add macOS meson build

2018-02-01 Thread Emil Velikov
On 28 January 2018 at 14:24, Jon Turney wrote: > --- > .travis.yml | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/.travis.yml b/.travis.yml > index 9cecf2f615f..7e6bbfe306b 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -403,6 +403,11 @@ matrix: >

Re: [Mesa-dev] [PATCH 0/6] Fix osx build and add to CI

2018-02-01 Thread Emil Velikov
Hats off for sorting these out Jon! On 28 January 2018 at 14:18, Jon Turney wrote: > Jon Turney (6): > configure: Default to gbm=no on osx > osx: ld doesn't support --build-id > glx/apple: include util/debug.h for env_var_as_boolean prototype > glx/apple:

[Mesa-dev] [PATCH] meson: don't install windows headers on non-windows platforms

2018-02-01 Thread Marc Dietrich
Only dive into the windows subdir if windows platform is selected. Signed-off-by: Marc Dietrich --- src/glx/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/glx/meson.build b/src/glx/meson.build index 04cd647ee4..e645b22b5f 100644 ---

Re: [Mesa-dev] [PATCH 1/6] meson: find python2 on macOS

2018-02-01 Thread Emil Velikov
On 28 January 2018 at 14:24, Jon Turney wrote: > From: Dylan Baker > > --- > meson.build | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 824e3c46bc5..178743eddb1 100644 > ---

Re: [Mesa-dev] [PATCH v2] mesa: enable ASTC/ETC1 compressed 3D textures

2018-02-01 Thread Juan A. Suarez Romero
On Mon, 2018-01-29 at 16:25 -0800, Eric Anholt wrote: > "Juan A. Suarez Romero" writes: > > > Enable these kind of 3D texture when proper extensions are available. > > > > Fixes KHR-GLES2.texture_3d.* with these textures. > > > > v2: add better clarification (Eric) > > ---

Re: [Mesa-dev] [PATCH] i965: Call prepare_external after implicit window-system MSAA resolves

2018-02-01 Thread Tapani Pälli
This fixes the issue; Tested-by: Tapani Pälli On 02/01/2018 03:41 AM, Jason Ekstrand wrote: This fixes some rendering corruption in a couple of Android apps that use window-system MSAA. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104741 Cc:

Re: [Mesa-dev] [Mesa-stable] [PATCH] util/build-id: Fix address comparison for binaries with LOAD vaddr > 0

2018-02-01 Thread Emil Velikov
On 25 January 2018 at 15:11, Stephan Gerhold wrote: > On Thu, Jan 25, 2018 at 11:22:10AM +, Emil Velikov wrote: >> On 24 January 2018 at 14:13, Stephan Gerhold wrote: >> > build_id_find_nhdr_for_addr() fails to find the build-id if the first LOAD >>

Re: [Mesa-dev] [PATCH] i965: Bump official kernel requirement to Linux v3.9.

2018-02-01 Thread Emil Velikov
On 31 January 2018 at 19:33, Kenneth Graunke wrote: > In commit 3f353342a6b6744773c26ed66b12afed42bd57af (present in 17.3.0) > we started unconditionally using I915_EXEC_NO_RELOC, which was > introduced in Linux v3.9. ChromeOS kernel 3.8 has backported this, > so it should

Re: [Mesa-dev] misc pahole repacking

2018-02-01 Thread Adrian M Negreanu
There's a bug about quiting on unsupported tags: https://bugzilla.redhat.com/show_bug.cgi?id=1348200 Should be fixed in v1.10 http://pkgs.fedoraproject.org/cgit/rpms/dwarves.git/commit/?h=f25 On Wed, Jan 31, 2018 at 5:57 PM, Brian Paul wrote: > On 01/31/2018 01:48 AM, Tapani

  1   2   >