[Mesa-dev] [PATCH] mesa: Make gl_vertex_array contain pointers to first order VAO members.

2018-03-05 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi, The change basically strips down gl_vertex_array to two pointers into the VAO. Consequently the current vertex attributes in the vbo module need to be represented by structs present in the VAO instead of gl_vertex_array instances. The change prepares the backends somew

Re: [Mesa-dev] [PATCH 1/4] glxinfo/wglinfo: remove print_shader_limits() code

2018-03-05 Thread Mathias Fröhlich
Hi Brian, On Monday, 5 March 2018 17:53:01 CET Brian Paul wrote: > And add queries of GL 2.0 limits. All the VS, FS, GS limits which were > reported with print_shader_limits() are also covered by the GL 2.0 and > 3.2 queries. You can put my Reviewed-by: Mathias Fröhlich to the series. best

Re: [Mesa-dev] [PATCH] glsl: Fix memory leak with known glsl_type instances

2018-03-05 Thread Tapani Pälli
Hi; On 01.03.2018 03:12, Kenneth Graunke wrote: On Thursday, February 15, 2018 1:12:54 AM PST Tapani Pälli wrote: From: Simon Hausmann When looking up known glsl_type instances in the various hash tables, we end up leaking the key instances used for the lookup, as the glsl_type constructor al

Re: [Mesa-dev] [PATCH] intel: Add missing includes for building on Android

2018-03-05 Thread Tapani Pälli
LGTM Reviewed-by: Tapani Pälli On 06.03.2018 03:00, Clayton Craft wrote: This adds a missing library to the i965/Android.mk file, and updates intel/Android.mk to include the new library. Without this, mesa does not build on Android. Fixes: 272bef0601a "intel: Split gen_device_info out into lib

[Mesa-dev] [PATCH 1/3] glx/dri: Add a driconf option to disable GLX_SGI_video_sync

2018-03-05 Thread Thomas Hellstrom
Drivers on virtual hardware don't want to expose this extension to GLX compositors, similarly to GLX_OML_sync_control, since that significantly increases latency. Signed-off-by: Thomas Hellstrom Reviewed-by: Brian Paul Reviewed-by: Sinclair Yeh Reviewed-by: Deepak Rawat --- src/glx/dri2_glx.c

[Mesa-dev] [PATCH 3/3] drirc: Disable the GLX_SGI_video_sync extension for gnome-shell on vmware

2018-03-05 Thread Thomas Hellstrom
With this extension enabled and a server GLX implementation that actually honors it, Window movement lags considerably on gnome-shell/vmware, so disable it by default. Signed-off-by: Thomas Hellstrom Reviewed-by: Brian Paul Reviewed-by: Sinclair Yeh Reviewed-by: Deepak Rawat --- src/util/drir

[Mesa-dev] [PATCH 0/3] Fix vmware dri3 latency on gnome-shell

2018-03-05 Thread Thomas Hellstrom
Similarly to what we previously did for GLX_OML_sync_control, we want to disable the GLX_SGI_video_sync extension for gnome-shell on vmware. With either of these extensions enabled, window movement lag increases significantly. The reason this hits with dri3 and not with dri2 is that with dri2 on x

[Mesa-dev] [PATCH 2/3] gallium/st_dri: Honor the glx_disable_sgi_video_sync config option

2018-03-05 Thread Thomas Hellstrom
This option is disabled by default. Primarily intended for drivers on virtual hardware. Signed-off-by: Thomas Hellstrom Reviewed-by: Brian Paul Reviewed-by: Sinclair Yeh Reviewed-by: Deepak Rawat --- src/gallium/auxiliary/pipe-loader/driinfo_gallium.h | 1 + 1 file changed, 1 insertion(+) di

Re: [Mesa-dev] [PATCH] anv/entrypoints: VkGetDeviceProcAddr returns NULL for core instance commands

2018-03-05 Thread Iago Toral
On Mon, 2018-03-05 at 12:11 +, Emil Velikov wrote: > Hi Iago, > > Top level questions: > > I think this and the original commit should go to stable right? I am not sure if this qualifies for stable: these patches don't fix any user-visible bugs. If an application was calling vkGetDeviceProcA

Re: [Mesa-dev] Status of radeonsi NIR

2018-03-05 Thread Timothy Arceri
On 05/03/18 03:43, Benedikt Schemmer wrote: Hi all, I thought I'd do some testing on my machine to see if there are any problems with nir (enabled with R600_DEBUG=nir) Tested on Ubuntu 17.10 with mesa git of today (oibaf for 32 bit, mine with LLVM5.0 on 64 bit because I cant figure out how to

[Mesa-dev] [PATCH v2 2/2] spirv: fix OpUConvert when the source is signed

2018-03-05 Thread Samuel Iglesias Gonsálvez
From: Iago Toral Quiroga In this case we don't want to do sign-extension, since the value is interpreted as unsigned. If we want sign-extension, OpSConvert should be used. --- src/compiler/spirv/vtn_alu.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/sr

[Mesa-dev] [PATCH v2 1/2] spirv: fix OpSConvert when the source is unsigned

2018-03-05 Thread Samuel Iglesias Gonsálvez
OpSConvert interprets the MSB of the unsigned value as the sign bit and extends it to the new type. If we want to preserve the value, we need to use OpUConvert opcode. v2: - No need to check dst type. - Fix typo in comment. Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/spirv/vtn_alu

[Mesa-dev] [Bug 93965] Please backport OSMesaCreateContextAttribs to 11.1

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93965 Timothy Arceri changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

[Mesa-dev] [Bug 36488] please update Mesa Home Page : http://mesa3d.sourceforge.net with better gallium info

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36488 Timothy Arceri changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEW

Re: [Mesa-dev] [PATCH] Revert "nir: bump loop unroll limit to 96."

2018-03-05 Thread Dave Airlie
On 6 March 2018 at 13:59, Timothy Arceri wrote: > On 06/03/18 14:48, Timothy Arceri wrote: >> >> This reverts commit 2d36efdb7f18f061c519dbb93f6058bf161aad33. >> >> This raised limit turns out to harmful for more complex shaders, >> it causes excessive spilling in some Bioshock Infinite shaders. >

[Mesa-dev] [Bug 103945] FireFox Error Abort with flash objects

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103945 Timothy Arceri changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50317 Timothy Arceri changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[Mesa-dev] [Bug 103126] glthread doesn't offload anything in Witcher 2

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103126 Timothy Arceri changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

[Mesa-dev] [Bug 96550] 12.0.0-rc3: mesa_dri_drivers.so linking fails with: relocation R_X86_64_32S against `V4F_COUNT' can not be used when making a shared object

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96550 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 92293] A compilation error happen when update mesa from 10.6.7 to 11.0.2

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92293 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 35560] libOSMesa.so now (since 7.2 perhaps) contains the GL API preventing creating one executable with interchangeable libGL.so files

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35560 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 35200] Mesa 7.6 implementation error: bad datatype in interpolate_int_colors

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35200 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 28017] Compiz segfaults, backtrace log and patch included

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28017 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 105285] Mesa-utils -8.4 - glxinfo report has a blank value in GL_NUM_SHADING_LANGUAGE_VERSIONS subsection and also the aligniment below 4.3 seems not correct

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105285 --- Comment #7 from Arun Sivaraman --- Created attachment 137810 --> https://bugs.freedesktop.org/attachment.cgi?id=137810&action=edit GTX850m_glxinfo-l -- You are receiving this mail because: You are the assignee for the bug. You are the QA

[Mesa-dev] [Bug 105285] Mesa-utils -8.4 - glxinfo report has a blank value in GL_NUM_SHADING_LANGUAGE_VERSIONS subsection and also the aligniment below 4.3 seems not correct

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105285 --- Comment #6 from Arun Sivaraman --- Thanks for the reply, well I have developed a front-end application to view glxinfo, vulkaninfo and clinfo reports, and i was trying to include both Compat. profile and Core profile limits to the report. I

Re: [Mesa-dev] [PATCH] Revert "nir: bump loop unroll limit to 96."

2018-03-05 Thread Timothy Arceri
On 06/03/18 14:48, Timothy Arceri wrote: This reverts commit 2d36efdb7f18f061c519dbb93f6058bf161aad33. This raised limit turns out to harmful for more complex shaders, it causes excessive spilling in some Bioshock Infinite shaders. While not as bad as Bioshock (which went from 0 -> 268 in thre

[Mesa-dev] [PATCH] Revert "nir: bump loop unroll limit to 96."

2018-03-05 Thread Timothy Arceri
This reverts commit 2d36efdb7f18f061c519dbb93f6058bf161aad33. This raised limit turns out to harmful for more complex shaders, it causes excessive spilling in some Bioshock Infinite shaders. The fps for the ssao demo on radv remains unchanged when reverting this. Cc: Dave Airlie --- src/compil

Re: [Mesa-dev] [PATCH v2 2/5] i965/miptree: Use cpu tiling/detiling when mapping

2018-03-05 Thread Nanley Chery
On Mon, Mar 05, 2018 at 02:40:25PM -0800, Nanley Chery wrote: > On Thu, Jan 25, 2018 at 08:23:45AM -0800, Scott D Phillips wrote: > > Rename the (un)map_gtt functions to (un)map_map (map by > > returning a map) and add new functions (un)map_tiled_memcpy that > > return a shadow buffer populated wit

Re: [Mesa-dev] [PATCH 11/22 v2] nir: Recognize some more open-coded fmin / fmax

2018-03-05 Thread Jason Ekstrand
On Mon, Mar 5, 2018 at 2:25 PM, Ian Romanick wrote: > On 03/05/2018 02:07 PM, Jason Ekstrand wrote: > > On Mon, Mar 5, 2018 at 11:11 AM, Ian Romanick > > wrote: > > > > On 02/28/2018 12:48 PM, Jason Ekstrand wrote: > > > Rb > > > > For both or just this o

[Mesa-dev] Few issues with Meson

2018-03-05 Thread Mike Lothian
Hi I've been trying to get a Gentoo ebuild ready for meson I've had to fudge the llvm-config for cross compiling a 32bit mesa on a 64bit machine I notice that -Dvulkan-drivers= doesn't accept intel,radeon like autotools used to, it also seems as long as one value is correct the other is ignored

Re: [Mesa-dev] [PATCH 2/4] i965: perf: query topology

2018-03-05 Thread Rafael Antognolli
On Thu, Feb 22, 2018 at 05:24:38PM +, Lionel Landwerlin wrote: > With the introduction of asymmetric slices in CNL, we cannot rely on > the previous SUBSLICE_MASK getparam to tell userspace what subslices > are available. > > We introduce a new uAPI in the kernel driver to report exactly what

[Mesa-dev] [PATCH] intel: Add missing includes for building on Android

2018-03-05 Thread Clayton Craft
This adds a missing library to the i965/Android.mk file, and updates intel/Android.mk to include the new library. Without this, mesa does not build on Android. Fixes: 272bef0601a "intel: Split gen_device_info out into libintel_dev" --- src/intel/Android.mk | 1 + src/mesa/drivers/

[Mesa-dev] [Bug 105353] Textures flickering in Civilizations VI

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105353 Bug ID: 105353 Summary: Textures flickering in Civilizations VI Product: Mesa Version: 17.3 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity

Re: [Mesa-dev] [PATCH 21/22] i965/vec4: Allow CSE on subset VF constant loads

2018-03-05 Thread Kenneth Graunke
On Friday, February 23, 2018 3:56:06 PM PST Ian Romanick wrote: > From: Ian Romanick > > No changes on other platforms. > > Haswell, Ivy Bridge, and Sandy Bridge had similar results. (Haswell shown) > total instructions in shared programs: 13059891 -> 13059884 (<.01%) > instructions in affected

Re: [Mesa-dev] [PATCH 18/22] i965/fs: Add infrastructure for generating CSEL instructions.

2018-03-05 Thread Matt Turner
On Fri, Feb 23, 2018 at 3:56 PM, Ian Romanick wrote: > From: Kenneth Graunke > > v2 (idr): Don't allow CSEL with a non-float src2. > > v3 (idr): Add CSEL to fs_inst::flags_written. Suggested by Matt. brw_disassemble_inst fs_visitor::dump_instruction vec4_instruction:writes_flag vec4_visitor::du

[Mesa-dev] [Bug 95323] GL33-CTS.CommonBugs.CommonBug_ReservedNames fails

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95323 Timothy Arceri changed: What|Removed |Added Resolution|FIXED |WORKSFORME -- You are receiving this m

[Mesa-dev] [Bug 95323] GL33-CTS.CommonBugs.CommonBug_ReservedNames fails

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95323 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 17/22] nir: Narrow some dot product operations

2018-03-05 Thread Matt Turner
On Fri, Feb 23, 2018 at 3:56 PM, Ian Romanick wrote: > From: Ian Romanick > > On vector platforms, this helps elide some constant loads. > > No changes on Broadwell or Skylake. > > Haswell > total instructions in shared programs: 13093793 -> 13060163 (-0.26%) > instructions in affected programs:

[Mesa-dev] [Bug 103062] Error starting game FS17

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103062 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] PATH(s) to run Firefox with different Mesa versions

2018-03-05 Thread Germano Massullo
Good day I am testing Firefox with various Mesa versions to find which version started triggering the bug <> https://bugs.freedesktop.org/show_bug.cgi?id=104216 I packaged Mesa 18 for Fedora 27 https://copr-be.cloud.fedoraproject.org/results/germano/mesa_18/fedora-27-x86_64/00720216-mesa/ and then

Re: [Mesa-dev] [PATCH 18/22] i965/fs: Add infrastructure for generating CSEL instructions.

2018-03-05 Thread Matt Turner
On Fri, Feb 23, 2018 at 3:56 PM, Ian Romanick wrote: > From: Kenneth Graunke > > v2 (idr): Don't allow CSEL with a non-float src2. > > v3 (idr): Add CSEL to fs_inst::flags_written. Suggested by Matt. > > Signed-off-by: Kenneth Graunke > Signed-off-by: Ian Romanick > --- > src/intel/compiler/b

Re: [Mesa-dev] [PATCH 1/2] radeonsi: move si_nir_load_input_gs() to si_shader.c

2018-03-05 Thread Dave Airlie
For 1,1.5,2 Reviewed-by: Dave Airlie On 1 March 2018 at 14:24, Timothy Arceri wrote: > All the tess shader and tgsi equivalents are here and it allows > use to use llvm_type_is_64bit() in the following patch without > exposing it externally. > --- > src/gallium/drivers/radeonsi/si_shader.c

Re: [Mesa-dev] [PATCH 1/4] ac/shader: scan output usage mask for VS and TES

2018-03-05 Thread Dave Airlie
On 1 March 2018 at 20:54, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset For the series: Reviewed-by: Dave Airlie Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/3] ac: add ac_count_scratch_private_memory()

2018-03-05 Thread Dave Airlie
On 2 March 2018 at 07:12, Samuel Pitoiset wrote: > Imported from RadeonSI. For the series Reviewed-by: Dave Airlie ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 105183] Weird assertion in NIR linker

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105183 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH libdrm] intel/intel_chipset.h: Sync Cannonlake IDs.

2018-03-05 Thread Rodrigo Vivi
On Mon, Mar 05, 2018 at 02:51:46PM -0800, Rafael Antognolli wrote: > This is matching both the kernel and the spec. > > Reviewed-by: Rafael Antognolli . pushed, thanks > > On Wed, Feb 14, 2018 at 05:42:24PM -0800, Rodrigo Vivi wrote: > > Let's sync CNL ids with Spec and kernel. > > > > Sync wi

Re: [Mesa-dev] [PATCH libdrm] intel/intel_chipset.h: Sync Cannonlake IDs.

2018-03-05 Thread Rafael Antognolli
This is matching both the kernel and the spec. Reviewed-by: Rafael Antognolli . On Wed, Feb 14, 2018 at 05:42:24PM -0800, Rodrigo Vivi wrote: > Let's sync CNL ids with Spec and kernel. > > Sync with kernel commit '3f43031b1693 ("drm/i915/cnl: > Add Cannonlake PCI IDs for another SKU.")' and > co

Re: [Mesa-dev] [PATCH 20/22] i965/vec4: Relax writemask condition in CSE

2018-03-05 Thread Kenneth Graunke
On Friday, February 23, 2018 3:56:05 PM PST Ian Romanick wrote: > From: Ian Romanick > > If the previously seen instruction generates more fields than the new > instruction, still allow CSE to happen. This doesn't do much, but it > also enables a couple more shaders in the next patch. It helped

Re: [Mesa-dev] [PATCH v2 2/5] i965/miptree: Use cpu tiling/detiling when mapping

2018-03-05 Thread Nanley Chery
On Thu, Jan 25, 2018 at 08:23:45AM -0800, Scott D Phillips wrote: > Rename the (un)map_gtt functions to (un)map_map (map by > returning a map) and add new functions (un)map_tiled_memcpy that > return a shadow buffer populated with the intel_tiled_memcpy > functions. > > v2: Compute extents properl

Re: [Mesa-dev] [PATCH 19/22 v3] i965/fs: Merge CMP and SEL into CSEL on Gen8+

2018-03-05 Thread Kenneth Graunke
On Wednesday, February 28, 2018 12:20:28 PM PST Ian Romanick wrote: > From: Ian Romanick > > v2: Fix several problems handling inverted predicates. Add a much > bigger comment around the BRW_CONDITIONAL_NZ case. > > v3: Allow uniforms and shader inputs as sources for the original SEL and > CMP

[Mesa-dev] [PATCH 2/2] etnaviv: add get_driver_query_group_info(..)

2018-03-05 Thread Christian Gmeiner
This enables AMD_performance_monitor extension. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_query.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/gallium/drivers/etnaviv/etnaviv_query.c b/src/gallium/drivers/etnaviv/etnaviv_query.c index 9e8

[Mesa-dev] [PATCH 1/2] etnaviv: add query_group_info for sw counters

2018-03-05 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_query_sw.c | 30 -- src/gallium/drivers/etnaviv/etnaviv_query_sw.h | 5 + 2 files changed, 29 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_query_sw.c b/src/gal

[Mesa-dev] [PATCH 0/2] etnaviv: amd_performance_monitor support

2018-03-05 Thread Christian Gmeiner
Nothing fancy - passes all amd_performance_monitor piglits. Christian Gmeiner (2): etnaviv: add query_group_info for sw counters etnaviv: add get_driver_query_group_info(..) src/gallium/drivers/etnaviv/etnaviv_query.c| 13 +++ src/gallium/drivers/etnaviv/etnaviv_query_sw.c | 30 +

Re: [Mesa-dev] [PATCH 11/22 v2] nir: Recognize some more open-coded fmin / fmax

2018-03-05 Thread Ian Romanick
On 03/05/2018 02:07 PM, Jason Ekstrand wrote: > On Mon, Mar 5, 2018 at 11:11 AM, Ian Romanick > wrote: > > On 02/28/2018 12:48 PM, Jason Ekstrand wrote: > > Rb > > For both or just this one? > > > If you put the ~ on there, both. I'm not sure what you

Re: [Mesa-dev] [PATCH 18/22] i965/fs: Add infrastructure for generating CSEL instructions.

2018-03-05 Thread Kenneth Graunke
On Monday, March 5, 2018 11:17:29 AM PST Ian Romanick wrote: > On 02/28/2018 12:58 AM, Samuel Iglesias Gonsálvez wrote: > > On 24/02/18 00:56, Ian Romanick wrote: > >> From: Kenneth Graunke > >> > >> v2 (idr): Don't allow CSEL with a non-float src2. > >> > >> v3 (idr): Add CSEL to fs_inst::flags_w

[Mesa-dev] [PATCH 2/3] i965/extensions: Enable ASTC HDR on CannonLake

2018-03-05 Thread Nanley Chery
Cc: Rafael Antognolli --- src/mesa/drivers/dri/i965/intel_extensions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 73a6c73f537..c451f6cf749 100644 --- a/src/mesa/drivers/dri/

[Mesa-dev] [PATCH 3/3] i965/tex_image: Avoid the ASTC LDR workaround on gen9lp

2018-03-05 Thread Nanley Chery
Both the internal documentation and the results of testing this in the CI suggest that this is unnecessary. Add the fixes tag because this reduces an internal benchmark's startup time significantly. Eero reported that a less optimal version of this patch reduced the startup time of the benchmark by

[Mesa-dev] [PATCH 1/3] i965/mipmap_tree: Don't allocate CCS when emulating ETC support

2018-03-05 Thread Nanley Chery
--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index c6213b21629..8586968fd6f 100644 --- a/src/mesa/drivers/dri/i965/intel_m

Re: [Mesa-dev] [PATCH 11/22 v2] nir: Recognize some more open-coded fmin / fmax

2018-03-05 Thread Jason Ekstrand
On Mon, Mar 5, 2018 at 11:11 AM, Ian Romanick wrote: > On 02/28/2018 12:48 PM, Jason Ekstrand wrote: > > Rb > > For both or just this one? > If you put the ~ on there, both. > > On Wed, Feb 28, 2018 at 12:18 PM, Ian Romanick > > wrote: > > > > From: Ian Romani

Re: [Mesa-dev] [PATCH 2/5] i965/miptree: Use cpu tiling/detiling when mapping

2018-03-05 Thread Jason Ekstrand
On Mon, Mar 5, 2018 at 11:39 AM, Nanley Chery wrote: > On Tue, Jan 09, 2018 at 11:16:59PM -0800, Scott D Phillips wrote: > > Rename the (un)map_gtt functions to (un)map_map (map by > > returning a map) and add new functions (un)map_tiled_memcpy that > > return a shadow buffer populated with the i

[Mesa-dev] [PATCH] spirv: Add SpvCapabilityShaderViewportIndexLayerEXT

2018-03-05 Thread Caio Marcelo de Oliveira Filho
This capability allows gl_ViewportIndex and gl_Layer to also be used as outputs in Vertex and Tesselation shaders. v2: Make conditional to the capability, add gl_Layer, add tesselation shaders. (Iago) v3: Don't export to tesselation control shader. v4: Add Reviewd-by tag. Reviewed-by: Iago

Re: [Mesa-dev] [RFC] radeonsi: guard against indexbuf not being set

2018-03-05 Thread Roman Gilg
This is a RFC because I don't really know what I'm doing here. But we have this problem with AMD and KWin already for quite a long time and I hope it can be fixed now. I followed the debug output and tried this guard. On my system this fixed the issue with Alt+Tab crashing KWin. Still this might b

[Mesa-dev] [RFC] radeonsi: guard against indexbuf not being set

2018-03-05 Thread Roman Gilg
Fixes crashes of clients when index_size != 0, but there was no indexbuf set in si_draw_vbo. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103234 Signed-off-by: Roman Gilg --- src/gallium/drivers/radeonsi/si_state_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 1/2] meson: Allow building dri based EGL without GLX

2018-03-05 Thread Eric Anholt
Dylan Baker writes: > It should be possible to build EGL without GLX, but the meson build > currently doesn't allow that because it too tightly couples glx and dri. > This patch eases dri and glx apart, so that EGL without GLX can be > built. These are: Reviewed-by: Eric Anholt signature.asc

Re: [Mesa-dev] [PATCH mesa] freedreno: add missing include

2018-03-05 Thread Rob Clark
On Mon, Mar 5, 2018 at 12:52 PM, Eric Engestrom wrote: > Fixes: 26a9321d0ae819f2a49d7 "freedreno: add global_bindings state" > Cc: Rob Clark > Signed-off-by: Eric Engestrom > --- > src/gallium/drivers/freedreno/freedreno_state.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/gal

Re: [Mesa-dev] [RFC 0/6] Remove stubbed GLX_SGIX_swap_{barrier, group}

2018-03-05 Thread Brian Paul
On 03/05/2018 01:29 PM, Ian Romanick wrote: On 03/05/2018 11:08 AM, Ian Romanick wrote: On 03/05/2018 10:48 AM, Emil Velikov wrote: Hi all, It seems like these two extensions were never implemented or advertised. Be that in: - glx/dri - glx/apple - classic xlib-glx - gallium xlib-glx

Re: [Mesa-dev] [RFC 0/6] Remove stubbed GLX_SGIX_swap_{barrier, group}

2018-03-05 Thread Ian Romanick
On 03/05/2018 11:08 AM, Ian Romanick wrote: > On 03/05/2018 10:48 AM, Emil Velikov wrote: >> Hi all, >> >> It seems like these two extensions were never implemented or advertised. >> Be that in: >> - glx/dri >> - glx/apple >> - classic xlib-glx >> - gallium xlib-glx >> >> Yet, the entry points

Re: [Mesa-dev] [PATCH 2/5] i965/miptree: Use cpu tiling/detiling when mapping

2018-03-05 Thread Nanley Chery
On Tue, Jan 09, 2018 at 11:16:59PM -0800, Scott D Phillips wrote: > Rename the (un)map_gtt functions to (un)map_map (map by > returning a map) and add new functions (un)map_tiled_memcpy that > return a shadow buffer populated with the intel_tiled_memcpy > functions. Could you mention some of the r

Re: [Mesa-dev] [RFC 0/6] Remove stubbed GLX_SGIX_swap_{barrier, group}

2018-03-05 Thread Adam Jackson
On Mon, 2018-03-05 at 11:08 -0800, Ian Romanick wrote: > On 03/05/2018 10:48 AM, Emil Velikov wrote: > > > > Brian, Ian, > > > > Do you have any recollection about these experimental SGI extensions? > > Ajax and I had talked about implementing swap_group a few times, but > there were some techni

Re: [Mesa-dev] [PATCH 18/22] i965/fs: Add infrastructure for generating CSEL instructions.

2018-03-05 Thread Ian Romanick
On 02/28/2018 12:58 AM, Samuel Iglesias Gonsálvez wrote: > On 24/02/18 00:56, Ian Romanick wrote: >> From: Kenneth Graunke >> >> v2 (idr): Don't allow CSEL with a non-float src2. >> >> v3 (idr): Add CSEL to fs_inst::flags_written. Suggested by Matt. >> >> Signed-off-by: Kenneth Graunke >> Signed

Re: [Mesa-dev] [PATCH] gallium: work around libtool relink issue for libdrm

2018-03-05 Thread Emil Velikov
On 5 March 2018 at 16:41, Roman Gilg wrote: > This is similar to commit 90633079. libtool links first to system directories > instead of custom locations of libdrm on relinking. Since a more recent libdrm > version than the one provided by the system is often needed when compiling > mesa, make sur

Re: [Mesa-dev] [PATCH 11/22 v2] nir: Recognize some more open-coded fmin / fmax

2018-03-05 Thread Ian Romanick
On 02/28/2018 12:48 PM, Jason Ekstrand wrote: > Rb For both or just this one? > On Wed, Feb 28, 2018 at 12:18 PM, Ian Romanick > wrote: > > From: Ian Romanick > > > This transformation is inexact because section 4.7.1 (

Re: [Mesa-dev] [PATCH] st/mesa: ensure that images don't try to reference non-existent levels

2018-03-05 Thread Ilia Mirkin
The problem is that st_finalize_texture isn't doing its job in some circumstances. Specifically, if I have a 2-level 2d array with level0 = (2,2,7) and level1 = (1,1,7) with a non-mipmap filter (e.g. GL_NEAREST), then at no point are two resources combined into one. Clamping the level will avoid t

Re: [Mesa-dev] [RFC 0/6] Remove stubbed GLX_SGIX_swap_{barrier, group}

2018-03-05 Thread Ian Romanick
On 03/05/2018 10:48 AM, Emil Velikov wrote: > Hi all, > > It seems like these two extensions were never implemented or advertised. > Be that in: > - glx/dri > - glx/apple > - classic xlib-glx > - gallium xlib-glx > > Yet, the entry points were available, hence apps might have linked > against

Re: [Mesa-dev] [PATCH RFC] radeonsi: Disable IEEE_MODE.

2018-03-05 Thread Jan Vesely
On Mon, 2018-03-05 at 10:04 +, Eric Engestrom wrote: > On Saturday, 2018-03-03 18:35:02 -0500, Jan Vesely wrote: > > Neither GL nor CL nor SPIRV needs the IEEE handling of sNaNs. > > > > Signed-off-by: Jan Vesely > > --- > > This is the 3rd way to handle broken fmin/fmax in clover CL. > > It

Re: [Mesa-dev] [PATCH] st/mesa: ensure that images don't try to reference non-existent levels

2018-03-05 Thread Marek Olšák
Maybe st/mesa should clamp the level instead of assert. Marek On Thu, Mar 1, 2018 at 7:23 AM, Ilia Mirkin wrote: > Yes, as I mentioned this makes some tests assert. > > They were passing before, but it was through luck since the actual images > were never accessed. > > On Mar 1, 2018 04:04, "Tim

Re: [Mesa-dev] [PATCH 11/29] intel/blorp: Include nir_format_convert.h in blorp_blit.c

2018-03-05 Thread Pohjolainen, Topi
On Fri, Jan 26, 2018 at 05:59:40PM -0800, Jason Ekstrand wrote: > nir_mask_shift_or is now defined in nir_format_convert.h so we can > delete the copy in blorp_blit.c. > --- > src/intel/blorp/blorp_blit.c | 20 +--- > 1 file changed, 1 insertion(+), 19 deletions(-) Reviewed-by: To

[Mesa-dev] [PATCH 5/6] gallium/x11: remove empty GLX_SGIX_swap_group stubs

2018-03-05 Thread Emil Velikov
From: Emil Velikov The extension was never implemented. Quick search suggests: - no actual users (on my Arch setup) - the Nvidia driver does not implement the extension Signed-off-by: Emil Velikov --- src/gallium/state_trackers/glx/xlib/glx_api.c | 12 src/gallium/state_trac

[Mesa-dev] [PATCH 6/6] glx: remove empty GLX_SGIX_swap_group stubs

2018-03-05 Thread Emil Velikov
From: Emil Velikov The extension was never implemented. Quick search suggests: - no actual users (on my Arch setup) - the Nvidia driver does not implement the extension Signed-off-by: Emil Velikov --- src/glx/apple/glx_empty.c | 12 src/glx/glxcmds.c | 16 ---

[Mesa-dev] [PATCH 1/6] x11: remove empty GLX_SGIX_swap_barrier stubs

2018-03-05 Thread Emil Velikov
From: Emil Velikov The extension was never implemented. Quick search suggests: - no actual users (on my Arch setup) - the Nvidia driver does not implement the extension Signed-off-by: Emil Velikov --- src/mesa/drivers/x11/fakeglx.c | 25 - src/mesa/drivers/x11/glxapi.

[Mesa-dev] [PATCH 2/6] gallium/x11: remove empty GLX_SGIX_swap_barrier stubs

2018-03-05 Thread Emil Velikov
From: Emil Velikov The extension was never implemented. Quick search suggests: - no actual users (on my Arch setup) - the Nvidia driver does not implement the extension Signed-off-by: Emil Velikov --- src/gallium/state_trackers/glx/xlib/glx_api.c | 21 - src/gallium/s

[Mesa-dev] [PATCH 3/6] glx: remove empty GLX_SGIX_swap_barrier stubs

2018-03-05 Thread Emil Velikov
From: Emil Velikov The extension was never implemented. Quick search suggests: - no actual users (on my Arch setup) - the Nvidia driver does not implement the extension Signed-off-by: Emil Velikov --- src/glx/apple/glx_empty.c | 21 - src/glx/glxcmds.c | 25 --

[Mesa-dev] [PATCH 4/6] x11: remove empty GLX_SGIX_swap_group stubs

2018-03-05 Thread Emil Velikov
From: Emil Velikov The extension was never implemented. Quick search suggests: - no actual users (on my Arch setup) - the Nvidia driver does not implement the extension Signed-off-by: Emil Velikov --- src/mesa/drivers/x11/fakeglx.c | 15 --- src/mesa/drivers/x11/glxapi.c | 16 --

[Mesa-dev] [RFC 0/6] Remove stubbed GLX_SGIX_swap_{barrier,group}

2018-03-05 Thread Emil Velikov
Hi all, It seems like these two extensions were never implemented or advertised. Be that in: - glx/dri - glx/apple - classic xlib-glx - gallium xlib-glx Yet, the entry points were available, hence apps might have linked against it. Furthermore I cannot see any users of those on my system and

Re: [Mesa-dev] [PATCH 10/29] nir/format_convert: Add a function to pack RGB9_E5 formats

2018-03-05 Thread Pohjolainen, Topi
On Fri, Jan 26, 2018 at 05:59:39PM -0800, Jason Ekstrand wrote: > --- > src/compiler/nir/nir_format_convert.h | 64 > +++ > 1 file changed, 64 insertions(+) I didn't check against any specs but this looks to match format_rgb9e5.h::float3_to_rgb9e5(). Reviewed-by:

[Mesa-dev] [Bug 100259] [EGL] [GBM] undefined reference to `gbm_bo_create_with_modifiers'

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100259 --- Comment #25 from Roman Gilg --- I "necro-bumped" this bug because I wanted to share my findings in regards to the manual manipulation of the relink_command, what I haven't seen here before. Maybe that's trivial to you, but implying that I'm

Re: [Mesa-dev] [PATCH v3] clover: Allow overriding platform/device version numbers

2018-03-05 Thread Pierre Moreau
With Francisco’s comments addressed, Reviewed-by: Pierre Moreau On 2018-03-04 — 09:13, Aaron Watry wrote: > Useful for testing API, builtin library, and device completeness of > not-yet-supported versions. > > Signed-off-by: Aaron Watry > (v1) Reviewed-by: Pierre Moreau > (v2) Reviewed-by: Fr

[Mesa-dev] [PATCH] configure: remove unused AM_CONDITIONAL

2018-03-05 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index d8093597dd0..0cfb0f7d851 100644 --- a/configure.ac +++ b/configure.ac @@ -451,7 +451,6 @@ if test "x$GCC_ATOMIC_BUILTINS_SUPPORTED" = x1; then

Re: [Mesa-dev] [PATCH] travis: keep meson version below 0.45.0

2018-03-05 Thread Dylan Baker
Quoting Andres Gomez (2018-03-05 07:25:36) > Recently Meson upgraded to 0.45.0 and it needs python 3.5+, which is > not available in Trusty. > > Cc: Eric Engestrom > Cc: Dylan Baker > Cc: Emil Velikov > Cc: Jon Turney > Signed-off-by: Andres Gomez > --- > .travis.yml | 7 --- > 1 file ch

Re: [Mesa-dev] [PATCH v3] clover: Allow overriding platform/device version numbers

2018-03-05 Thread Francisco Jerez
Aaron Watry writes: > Useful for testing API, builtin library, and device completeness of > not-yet-supported versions. > > Signed-off-by: Aaron Watry > (v1) Reviewed-by: Pierre Moreau > (v2) Reviewed-by: Francisco Jerez > Cc: Jan Vesely > Cc: Emil Velikov > > v3: mark CL version overrides a

[Mesa-dev] [PATCH mesa] freedreno: add missing include

2018-03-05 Thread Eric Engestrom
Fixes: 26a9321d0ae819f2a49d7 "freedreno: add global_bindings state" Cc: Rob Clark Signed-off-by: Eric Engestrom --- src/gallium/drivers/freedreno/freedreno_state.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/freedreno/freedreno_state.c b/src/gallium/drivers/freedre

Re: [Mesa-dev] [PATCH 09/29] nir/format_convert: Add pack/unpack for R11F_G11F_B10F

2018-03-05 Thread Pohjolainen, Topi
On Sun, Mar 04, 2018 at 07:44:09AM -0600, Jason Ekstrand wrote: > On March 4, 2018 03:11:03 "Pohjolainen, Topi" > wrote: > > >On Fri, Jan 26, 2018 at 05:59:38PM -0800, Jason Ekstrand wrote: > >>--- > >> src/compiler/nir/nir_format_convert.h | 38 > >> +++ > >> 1 fi

Re: [Mesa-dev] [PATCH 05/29] intel/isl: Add a helper for inverting swizzles

2018-03-05 Thread Pohjolainen, Topi
On Sun, Mar 04, 2018 at 07:10:01AM -0600, Jason Ekstrand wrote: > On March 3, 2018 10:50:43 "Pohjolainen, Topi" > wrote: > > >On Thu, Mar 01, 2018 at 03:04:14PM -0800, Jason Ekstrand wrote: > >>On Thu, Mar 1, 2018 at 6:49 AM, Pohjolainen, Topi < > >>topi.pohjolai...@gmail.com> wrote: > >> > >>> O

[Mesa-dev] [Bug 100259] [EGL] [GBM] undefined reference to `gbm_bo_create_with_modifiers'

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100259 --- Comment #24 from Emil Velikov --- Precisely the issue is fundamentally the same and there's three solutions. Here's another $export LD_LIBRARY_PATH=/path/to/custom/build/DSOs && ./configure... Let's not necro-bump bugs every time someone

[Mesa-dev] [Bug 100259] [EGL] [GBM] undefined reference to `gbm_bo_create_with_modifiers'

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100259 --- Comment #23 from Roman Gilg --- Sorry, that's what I forgot to mention: I compile libdrm from current master with prefix /opt/drm. In this case if -L/opt/drm/lib in the relink_command in mesa/src/gallium/targets/dri/gallium_dri.la is bef

Re: [Mesa-dev] [ANNOUNCE] mesa 18.0.0-rc4

2018-03-05 Thread Ernst Sjöstrand
Is there a lot of new patches queued up before the 18.0 release? In that case you could push them to a branch (before tagging) and it could be given a quick pre-test... Not sure how that ties in the with current release process. Regards //Ernst 2018-02-09 3:27 GMT+01:00 Emil Velikov : > The fourt

[Mesa-dev] [Bug 105344] Installation bug by video card modules conflict (nvidia GTX 950 M)

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105344 Emil Velikov changed: What|Removed |Added QA Contact|mesa-dev@lists.freedesktop. |nouveau@lists.freedesktop.o

[Mesa-dev] [Bug 100259] [EGL] [GBM] undefined reference to `gbm_bo_create_with_modifiers'

2018-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100259 --- Comment #22 from Daniel Stone --- Roman, that would only work if you have a newer version of GBM installed into /opt/drm/lib. If you're doing completely clean builds, there is no full solution: the only known workarounds are the ones Emil ha

Re: [Mesa-dev] [PATCH] vulkan: do not expose surface/swapchain extensions on Android

2018-03-05 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand At some point, we could add some code to the XML parser to parse extension dependencies and maybe do this automatically. However, that's a pile of work to avoid a two-line change so let's not bother for now. On Mon, Mar 5, 2018 at 8:46 AM, Tapani Pälli wrote: > On

Re: [Mesa-dev] [PATCH] disk cache: Link with -latomic if necessary

2018-03-05 Thread Emil Velikov
[Trimming down the CC list] Hi Mike, On 4 March 2018 at 00:20, Mike Lothian wrote: > Hi > > Sorry to be a pain again > > I've just tested this with clang and the 32bit build still fails without > -latomic > > libtool: link: /bin/true glsl/.libs/libstandalone.a Eric has a point here - the patch b

  1   2   >