[Mesa-dev] [Bug 11130] Mesa with NPTL support makes Python extensions linked to libGL crash with std::cerr usage.

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=11130 Timothy Arceri changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

Re: [Mesa-dev] [PATCH] nir: Implement optional b2f->iand lowering

2018-05-01 Thread Alyssa Rosenzweig
> Tell me a little more about what your hardware supports. Both integers and floats are first-class; they are each natively 32-bit, with 16-bit versions to be supported down the line. There's support for int8 and float64, but I haven't seen these used with GLSL, so I don't know how they work. Fr

Re: [Mesa-dev] radv: Support for control flow attributes (SPIR-V: Unroll, DontUnroll and maybe Flatten, DontFlatten)

2018-05-01 Thread Panagiotis Christopoulos Charitos
Hi, I have multiple shaders that are part of my opensource engine and I see VGPR usage improvements (on AMDVLK). I can gather a few and attach them here. They can be in glsl or SPIRV forms. Will that work or did I misunderstood the question? Panagiotis Christopoulos Charitos www.ancient-ritual.c

[Mesa-dev] [Bug 68445] New option to GALLIUM_HUD

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=68445 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] swr/rast: Fix WriteBitcodeToFile usage with llvm-7.0.

2018-05-01 Thread Vinson Lee
Fix build error after llvm-7.0svn r325155 ("Pass a reference to a module to the bitcode writer."). CXX rasterizer/jitter/libmesaswr_la-JitManager.lo rasterizer/jitter/JitManager.cpp:548:30: error: reference to type 'const llvm::Module' could not bind to an lvalue of type 'const llvm::Modul

[Mesa-dev] [Bug 98471] [TRACKER] Mesa 13.0 release tracker

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98471 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v1 1/2] egl/android: #ifdef out flink name support

2018-05-01 Thread Robert Foss
Hey, On 2018-05-01 08:29, Tomasz Figa wrote: On Tue, May 1, 2018 at 11:20 AM Rob Herring wrote: On Fri, Apr 27, 2018 at 6:57 AM, Robert Foss wrote: From: Rob Herring [snip] @@ -1228,20 +1254,31 @@ dri2_initialize_android(_EGLDriver *drv, _EGLDisplay *disp) dri2_dpy->is_render_no

Re: [Mesa-dev] [PATCH v1 1/2] egl/android: #ifdef out flink name support

2018-05-01 Thread Robert Foss
Hey Rob, On 2018-05-01 04:20, Rob Herring wrote: On Fri, Apr 27, 2018 at 6:57 AM, Robert Foss wrote: From: Rob Herring Maintaining both flink names and prime fd support which are provided by 2 different gralloc implementations is problematic because we have a dependency on a specific gralloc

Re: [Mesa-dev] [PATCH 1/1] main: fail texture_storage() call if the size is not okay

2018-05-01 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 27.04.2018 17:34, James Xiong wrote: From: "Xiong, James" Signed-off-by: Xiong, James --- src/mesa/main/texstorage.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/texstorage.c b/src/mesa/main/texstorage.c index 44edba3..9cb8b90 100644 ---

[Mesa-dev] [Bug 106246] radv: VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT and bringing down initial pipeline compile times

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106246 --- Comment #8 from Nicolai Hähnle --- The fast register allocator stresses the spill logic a lot. I believe it basically spills at the end of every basic block and reloads at the start of every basic block. Plus it's not very well tested with A

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Nicolai Hähnle
On 01.05.2018 01:43, Marek Olšák wrote: From: Marek Olšák This is a hypothetical interface for EQAA (a superset of CSAA). CSAA could be exposed via GL_NV_framebuffer_multisample_coverage. EQAA additionally removes the restriction that the number of samples in all FBO attachments must match, whi

Re: [Mesa-dev] [PATCH v3 01/13] mesa/st/glsl_to_tgsi: Add method to collect some statistics

2018-05-01 Thread Nicolai Hähnle
Please make this thread-safe. Thanks, Nicolai On 28.04.2018 21:30, Gert Wollny wrote: When mesa is compiled in debug mode then this adds the possibility to print out some statistics about the translated shaders to a file. The functionality is enabled by setting the environment variable G

Re: [Mesa-dev] [PATCH v3 02/13] mesa/st: glsl_to_tgsi: Split arrays who's elements are only accessed directly

2018-05-01 Thread Nicolai Hähnle
So the GLSL transforms don't already do this? Interesting... anyway, seems a nice improvement, I just have some stylistic nitpicks below. On 28.04.2018 21:30, Gert Wollny wrote: Array who's elements are only accessed directly are replaced by the according number of temporary registers. By doin

Re: [Mesa-dev] [PATCH v3 03/13] mesa/st/glsl_to_tgsi: Properly resolve life times simple if/else + use constructs

2018-05-01 Thread Nicolai Hähnle
On 28.04.2018 21:30, Gert Wollny wrote: in constructs like below, currently the live range estimation extends the live range of t unecessarily to the whole loop because it was not detected that t is unconditional written and later read only in the "if (a)" scope. while (foo) { ...

Re: [Mesa-dev] [PATCH v3 04/13] mesa/st/glsl_to_tgsi:rename lifetime to register_live_range

2018-05-01 Thread Nicolai Hähnle
On 28.04.2018 21:30, Gert Wollny wrote: On one hand "live range" is the term used in the literature, and on the other hand a distinction is needed from the array live ranges. Signed-off-by: Gert Wollny --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 16 ++--- .../state_tracker/st_gl

Re: [Mesa-dev] [PATCH v3 06/13] mesa/st/glsl_to_tgsi: Add class to track array live range

2018-05-01 Thread Nicolai Hähnle
On 28.04.2018 21:30, Gert Wollny wrote: todo explain Indeed... how is that different from the tracking of ordinary registers? Cheers, Nicolai Signed-off-by: Gert Wollny --- .../state_tracker/st_glsl_to_tgsi_array_merge.cpp | 69 ++ .../state_tracker/st_glsl_to_tgsi

Re: [Mesa-dev] [PATCH v3 05/13] mesa/st: Add helper classes for array merging and interleaving

2018-05-01 Thread Nicolai Hähnle
First some high-level remarks: Why is `finalized` necessary? The `finalize` operation should be idempotent, i.e. if you call if twice in a row, the second time should be a no-op. So you can just call finalize on the target array unconditionally. That would make the code cleaner. Similarly, t

Re: [Mesa-dev] [PATCH v3 09/13] mesa/st/glsl_to_tgsi: rename access_record to register_merge_record and some more renames

2018-05-01 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 28.04.2018 21:30, Gert Wollny wrote: Signed-off-by: Gert Wollny --- .../state_tracker/st_glsl_to_tgsi_temprename.cpp | 61 +++--- .../state_tracker/st_glsl_to_tgsi_temprename.h | 2 +- 2 files changed, 32 insertions(+), 31 deletions(-)

Re: [Mesa-dev] [PATCH v3 10/13] mesa/st/glsl_to_tgsi: move evaluation of read mask up in the call hierarchy

2018-05-01 Thread Nicolai Hähnle
Again, I don't think having separate classes for tracking temporaries and tracking arrays is a good idea. They do require some semantic differences, but the only one I can really think of can be summarized as "there are no unconditional writes into arrays". If you think about it that way, it s

[Mesa-dev] [Bug 106180] [bisected] radv vulkan smoke test black screen (Add support for DRI3 v1.2)

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106180 --- Comment #6 from mercuriete --- This bug has something to do with DRI MODIFIERS My ugly patch fix my problem. My guess is... with PRIME there are something wrong with the swapchain -- You are receiving this mail because: You are the assig

Re: [Mesa-dev] [PATCH v3 13/13] mesa/st/glsl_to_tgsi: Expose array live range tracking and merging

2018-05-01 Thread Nicolai Hähnle
On 28.04.2018 21:30, Gert Wollny wrote: This patch ties in the array split, merge, and interleave code. shader-wb changes in the TGSI code are: You mean shader-db? Cheers, Nicolai original code | array-merge | change in % mean max | meanmax | mean

[Mesa-dev] [Bug 106180] [bisected] radv vulkan smoke test black screen (Add support for DRI3 v1.2)

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106180 --- Comment #7 from mercuriete --- Created attachment 139243 --> https://bugs.freedesktop.org/attachment.cgi?id=139243&action=edit ugly patch -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee fo

[Mesa-dev] [Bug 106180] [bisected] radv vulkan smoke test black screen (Add support for DRI3 v1.2)

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106180 --- Comment #8 from mercuriete --- I dont know anything about mesa but my guess without any knowledge is that maybe... the swap chain with PRIME is always SUBOPTIMAL forcing to recreate the swap chain. because is linear. not sure anyway... but

[Mesa-dev] [Bug 106331] radv doesnt support VK_FORMAT_R32G32B32_SFLOAT

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106331 Bug ID: 106331 Summary: radv doesnt support VK_FORMAT_R32G32B32_SFLOAT Product: Mesa Version: 18.0 Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 106180] [bisected] radv vulkan smoke test black screen (Add support for DRI3 v1.2)

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106180 --- Comment #9 from mercuriete --- vulkan gpuinfo intel haswell https://vulkan.gpuinfo.org/displayreport.php?id=3061 amd cape verde: https://vulkan.gpuinfo.org/displayreport.php?id=3060 Maybe you can check if is problem with OPTIMAL formats.

Re: [Mesa-dev] [PATCH] radv/winsys: fix leaking resources from bo's imported by fd

2018-05-01 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 05/01/2018 12:13 AM, Andres Rodriguez wrote: A bo's ref_count was not being initialized when imported from an fd. Therefore, we would fail to free the resource during VkFreeMemory(). This patch fixes applications like hifi VR in threaded mode, which perform freq

Re: [Mesa-dev] [PATCH] radv: set fmask_surf_index on fmask surfaces.

2018-05-01 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 05/01/2018 04:33 AM, Dave Airlie wrote: From: Dave Airlie This is needed for gfx9 and later for all fmask surface index. (Mentioned by Marek on irc) --- src/amd/vulkan/radv_image.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/a

[Mesa-dev] [Bug 106209] [opencl] [llvm-svn] build failure undefined reference to `clang::FrontendTimesIsEnabled'

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106209 --- Comment #5 from Kai --- Created attachment 139244 --> https://bugs.freedesktop.org/attachment.cgi?id=139244&action=edit Proposed patch The attached patch fixes the issue for me. I've sent it to mesa-dev as well, though it'll take some tim

[Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-01 Thread Kai Wasserbäch
Otherwise the build fails with an undefined reference to clang::FrontendTimesIsEnabled. Bugzilla: https://bugs.freedesktop.org/106209 Cc: mesa-sta...@lists.freedesktop.org Cc: Jan Vesely Signed-off-by: Kai Wasserbäch --- Hey, this patch fixes a FTBFS for me with recent LLVM/Clang 7 revisions fr

Re: [Mesa-dev] [PATCH 0/3] common bits from HDR POC

2018-05-01 Thread Tapani Pälli
On 01.05.2018 01:22, Jason Ekstrand wrote: Here's a really dumb question:  What good does it do someone to have the extension if no actual window-system HDR is supported?  I'm just wondering if we want to only expose the extension if hardware can actually do it. I think it's a good question

[Mesa-dev] [Bug 106209] [opencl] [llvm-svn] build failure undefined reference to `clang::FrontendTimesIsEnabled'

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106209 --- Comment #6 from Kai --- Patch on the list at https://patchwork.freedesktop.org/patch/219763/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug._

Re: [Mesa-dev] [PATCH] swr/rast: Fix WriteBitcodeToFile usage with llvm-7.0.

2018-05-01 Thread Kyriazis, George
Reviewed-By: George Kyriazis mailto:george.kyria...@intel.com>> On May 1, 2018, at 2:05 AM, Vinson Lee mailto:v...@freedesktop.org>> wrote: Fix build error after llvm-7.0svn r325155 ("Pass a reference to a module to the bitcode writer."). CXX rasterizer/jitter/libmesaswr_la-JitManager.l

Re: [Mesa-dev] [PATCH] radv: set fmask_surf_index on fmask surfaces.

2018-05-01 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen No CTS regressions here. On Tue, May 1, 2018 at 1:23 PM, Samuel Pitoiset wrote: > Reviewed-by: Samuel Pitoiset > > On 05/01/2018 04:33 AM, Dave Airlie wrote: >> >> From: Dave Airlie >> >> This is needed for gfx9 and later for all fmask surface index. >> >> (Ment

Re: [Mesa-dev] [PATCH v3 10/13] mesa/st/glsl_to_tgsi: move evaluation of read mask up in the call hierarchy

2018-05-01 Thread Gert Wollny
Hello Nicolai, many thanks for the review. Am Dienstag, den 01.05.2018, 12:41 +0200 schrieb Nicolai Hähnle: > Again, I don't think having separate classes for tracking > temporaries and tracking arrays is a good idea. > > They do require some semantic differences, but the only one I can > rea

[Mesa-dev] [Bug 106151] [amdgpu][vulkan] GPU hang (Vega 56) while running game (Rise of the Tomb Raider)

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106151 --- Comment #13 from pritzl3...@gmail.com --- Thank you for the patch! Unfortunately it still hangs for me. I applied the patch to Mesa 18.1.0-rc2. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact

[Mesa-dev] [PATCH v2 01/14] etnaviv: add own format entry for pe formats

2018-05-01 Thread Christian Gmeiner
When using multi layer formats pe and rs formats will differ. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_format.c | 357 ++- src/gallium/drivers/etnaviv/etnaviv_format.h | 3 + src/gallium/drivers/etnaviv/etnaviv_screen.c | 3 +- src/gallium/driv

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Roland Scheidegger
Am 01.05.2018 um 01:43 schrieb Marek Olšák: > From: Marek Olšák > > This is a hypothetical interface for EQAA (a superset of CSAA). CSAA could be > exposed via GL_NV_framebuffer_multisample_coverage. EQAA additionally removes > the restriction that the number of samples in all FBO attachments mus

[Mesa-dev] [PATCH v2 00/14] etnaviv: add OES_texture_half_float support

2018-05-01 Thread Christian Gmeiner
This patch series adds support for half-float textures. This version of the patch series got a little bit bigger as it adds support for 'multi layer' formats for the RS and seperates RS and PE format tables. Patches 1-7 are adding support for a seperate entry for PE format and 'multi layer' format

[Mesa-dev] [PATCH v2 02/14] etnaviv: fix some rs format mappings

2018-05-01 Thread Christian Gmeiner
Use the same rs formats as etna_compatible_rs_format(..) does. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_format.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_format.c b/src/gallium/drivers/etnaviv/e

[Mesa-dev] [PATCH v2 05/14] etnaviv: take care of the number of layers

2018-05-01 Thread Christian Gmeiner
With the help of the number of layers we can choose the correct RS clear format - like the binary blob does. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_rs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_rs.

[Mesa-dev] [PATCH v2 03/14] etnaviv: rs: add support for multi layer formats

2018-05-01 Thread Christian Gmeiner
The binary blob driver supports 'multi layer' formats. For instance: gcvSURF_A16B16G16R16F_2_A8R8G8B8 < format >_n_< base format > This defines what base format we can use for RS. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_format.c | 56 +++

[Mesa-dev] [PATCH v2 04/14] etnaviv: put logic for rs clear format selection into caller

2018-05-01 Thread Christian Gmeiner
We do no need to call translate_rs_format(..) as we can simplify things by using formats blocksize to choose the correct RS format for clearing. No piglit regressions. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_rs.c | 14 +- 1 file changed, 13 insertion

[Mesa-dev] [PATCH v2 06/14] etnaviv: use correct format for translate_msaa_format(..)

2018-05-01 Thread Christian Gmeiner
In a later patch we will remove the calls to etna_compatible_rs_format(..) which will cause some troubles if nr_samples > 1. fbo-depthstencil: etnaviv_rs.c:664: etna_try_rs_blit: Assertion `msaa_format != ETNA_NO_MATCH' failed. In this case we call translate_msaa_format(..) with the full set of

[Mesa-dev] [PATCH v2 08/14] mesa: handle OES_texture_half_float formats in _mesa_base_tex_format()

2018-05-01 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan --- src/mesa/main/glformats.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index cba5e670db..1d3d524875 100644 --- a/src/mesa/main/glformats.c

[Mesa-dev] [PATCH v2 09/14] etnaviv: HALTI0 indicates extended pe formats

2018-05-01 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c b/src/gallium/drivers/etnaviv/etnaviv_screen

[Mesa-dev] [PATCH v2 11/14] etnaviv: add support for extended pe formats

2018-05-01 Thread Christian Gmeiner
Use the extended format if an such a format was passed. v1 -> v2: - set FORMAT_MASK bit when using ext PE format as suggested by Wladimir J. van der Laan Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_state.c | 11 +-- 1 file changed, 9 insertions(+), 2 del

[Mesa-dev] [PATCH v2 14/14] etnaviv: add float formats

2018-05-01 Thread Christian Gmeiner
v1 -> v2: - rebased to master - added I16_FLOAT and I32_FLOAT as suggested by Wladimir J. van der Laan Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_format.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/

[Mesa-dev] [PATCH v2 13/14] etnaviv: expose float formats only if GPU supports it

2018-05-01 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c b/src/gallium/drivers/etnaviv/etnaviv_screen.c index 35e6e8944c..132b0ba5c

[Mesa-dev] [PATCH v2 07/14] etnaviv: drop calls to etna_compatible_rs_format(..)

2018-05-01 Thread Christian Gmeiner
etna_compatible_rs_format(..) was called before translate_rs_format(..) which reduced the used formats somewhat. The following table shows the affected pipe formats with compatible format and the value from the format table: PIPE_FORMAT_B8G8R8X8_UNORM: com: 0x6 - tbl: 0x5 PIPE_FORMAT_B5G5R5A1_UNO

[Mesa-dev] [PATCH v2 12/14] etnaviv: handle 8 byte block in tiling

2018-05-01 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_tiling.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_tiling.c b/src/gallium/drivers/etnaviv/etnaviv_tiling.c index f

[Mesa-dev] [PATCH v2 10/14] etnaviv: update RS_FORMAT_MASK to include extended formats

2018-05-01 Thread Christian Gmeiner
Also update RS_FORMAT_RB_SWAP. Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_format.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_format.c b/src/gallium/drivers/etna

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Axel Davy
Hi, On 01/05/2018 01:43, Marek Olšák wrote: From: Marek Olšák This is a hypothetical interface for EQAA (a superset of CSAA). CSAA could be exposed via GL_NV_framebuffer_multisample_coverage. EQAA additionally removes the restriction that the number of samples in all FBO attachments must match

[Mesa-dev] [Bug 106209] [opencl] [llvm-svn] build failure undefined reference to `clang::FrontendTimesIsEnabled'

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106209 --- Comment #7 from Jan Vesely --- Right. Thanks! I didn't realize we list clang libraries explicitly. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Nicolai Hähnle
On 01.05.2018 16:48, Roland Scheidegger wrote: -**nr_samples** the nr of msaa samples. 0 (or 1) specifies a resource -which isn't multisampled. +**nr_samples**: For Z/S, this is the number of samples. For color, if EQAA +is unsupported, this is the number of both coverage samples and color sample

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-01 Thread Jan Vesely
On Tue, 2018-05-01 at 14:14 +0200, Kai Wasserbäch wrote: > Otherwise the build fails with an undefined reference to > clang::FrontendTimesIsEnabled. > > Bugzilla: https://bugs.freedesktop.org/106209 > Cc: mesa-sta...@lists.freedesktop.org > Cc: Jan Vesely > Signed-off-by: Kai Wasserbäch > --- >

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Roland Scheidegger
Am 01.05.2018 um 16:51 schrieb Axel Davy: > Hi, > > On 01/05/2018 01:43, Marek Olšák wrote: >> From: Marek Olšák >> >> This is a hypothetical interface for EQAA (a superset of CSAA). CSAA >> could be >> exposed via GL_NV_framebuffer_multisample_coverage. EQAA additionally >> removes >> the restri

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Roland Scheidegger
Am 01.05.2018 um 17:18 schrieb Nicolai Hähnle: > On 01.05.2018 16:48, Roland Scheidegger wrote: >>> -**nr_samples** the nr of msaa samples. 0 (or 1) specifies a resource >>> -which isn't multisampled. >>> +**nr_samples**: For Z/S, this is the number of samples. For color, >>> if EQAA >>> +is unsupp

Re: [Mesa-dev] [PATCH v3 05/13] mesa/st: Add helper classes for array merging and interleaving

2018-05-01 Thread Gert Wollny
Am Dienstag, den 01.05.2018, 12:38 +0200 schrieb Nicolai Hähnle: > First some high-level remarks: > > Why is `finalized` necessary? The `finalize` operation should be > idempotent, i.e. if you call if twice in a row, the second time > should be a no-op. It actually works exactly like this. >

[Mesa-dev] [PATCH] radv: Allow vkEnumerateInstanceVersion ProcAddr without instance.

2018-05-01 Thread Bas Nieuwenhuizen
Apparently the somewhere between 1.1.70 and 1.1.73 the loader started depending on this. The loader then creates a 1.0 instance, which gets into funny situation because we have a 1.1 device. No idea how to do line wrapping in Mako though, my random guesses did not work. CC: 18.1 --- src/amd/vul

Re: [Mesa-dev] [PATCH] nir: Implement optional b2f->iand lowering

2018-05-01 Thread Matt Turner
On Mon, Apr 30, 2018 at 7:50 PM, Alyssa Rosenzweig wrote: >> Tell me a little more about what your hardware supports. > > Both integers and floats are first-class; they are each natively 32-bit, > with 16-bit versions to be supported down the line. There's support for > int8 and float64, but I hav

Re: [Mesa-dev] [PATCH v3 02/13] mesa/st: glsl_to_tgsi: Split arrays who's elements are only accessed directly

2018-05-01 Thread Gert Wollny
Am Dienstag, den 01.05.2018, 11:57 +0200 schrieb Nicolai Hähnle: > So the GLSL transforms don't already do this? Interesting... anyway, > seems a nice improvement, When I first sent this patch stand-alone there were some comments about this: https://patchwork.freedesktop.org/patch/189842/[¹

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-01 Thread Kai Wasserbäch
Hey Jan, Jan Vesely wrote on 01.05.2018 17:19: > On Tue, 2018-05-01 at 14:14 +0200, Kai Wasserbäch wrote: >> Otherwise the build fails with an undefined reference to >> clang::FrontendTimesIsEnabled. >> >> Bugzilla: https://bugs.freedesktop.org/106209 >> Cc: mesa-sta...@lists.freedesktop.org >> Cc:

Re: [Mesa-dev] [PATCH v1 1/2] egl/android: #ifdef out flink name support

2018-05-01 Thread Rob Herring
On Tue, May 1, 2018 at 3:13 AM, Robert Foss wrote: > Hey Rob, > > > On 2018-05-01 04:20, Rob Herring wrote: >> >> On Fri, Apr 27, 2018 at 6:57 AM, Robert Foss >> wrote: >>> >>> From: Rob Herring >>> >>> Maintaining both flink names and prime fd support which are provided by >>> 2 different grall

[Mesa-dev] [PATCH] anv: Allow lookup of vkEnumerateInstanceVersion without an instance

2018-05-01 Thread Jason Ekstrand
Fixes: cbab2d1da5edfe9df27a010adf8b1aa9dbee473b --- src/intel/vulkan/anv_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index e82f294..6aff4e9 100644 --- a/src/intel/vulkan/anv_device.c +++ b/src/intel/vulkan/anv_device.c

Re: [Mesa-dev] [PATCH] radv: Allow vkEnumerateInstanceVersion ProcAddr without instance.

2018-05-01 Thread Jason Ekstrand
We solve the issue differently but I just verified that it is a problem and also broken in anv and this looks correct to me. Reviewed-by: Jason Ekstrand Now you can review my patch. :-P On Tue, May 1, 2018 at 9:06 AM, Bas Nieuwenhuizen wrote: > Apparently the somewhere between 1.1.70 and 1.1.

Re: [Mesa-dev] [PATCH] anv: Allow lookup of vkEnumerateInstanceVersion without an instance

2018-05-01 Thread Bas Nieuwenhuizen
well that works too. Reviewed-by: Bas Nieuwenhuizen On Tue, May 1, 2018 at 7:01 PM, Jason Ekstrand wrote: > Fixes: cbab2d1da5edfe9df27a010adf8b1aa9dbee473b > --- > src/intel/vulkan/anv_device.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/v

[Mesa-dev] [Bug 104302] Wolfenstein 2 (2017) under wine graphical artifacting on RADV

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104302 --- Comment #17 from Samuel Pitoiset --- Thanks for confirming. I'm aware of the faces issue but I haven't been able to fix it yet. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.__

[Mesa-dev] [Bug 106337] eglWaitClient() doesn't work as documented using DRI2 backend

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106337 Bug ID: 106337 Summary: eglWaitClient() doesn't work as documented using DRI2 backend Product: Mesa Version: 18.0 Hardware: Other OS: All Statu

Re: [Mesa-dev] [PATCH] anv: Don't advertise Float64 or Int64 on HW withou 64-bit types

2018-05-01 Thread Anuj Phogat
On Mon, Apr 30, 2018 at 3:15 PM, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_device.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > index adcd506..e82f294 100644 > --- a/src/intel/vulkan/anv_d

Re: [Mesa-dev] [Mesa-stable] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-01 Thread Aaron Watry
Given the discussion that's ongoing, this patch might not land as-is, but if it does: Tested-By: Aaron Watry Note: The meson build currently works as-is and doesn't require an equivalent patch. --Aaron On Tue, May 1, 2018 at 7:14 AM, Kai Wasserbäch wrote: > Otherwise the build fails with an un

[Mesa-dev] [Bug 104457] Resetting rcs0 after gpu hang

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104457 Timothy Arceri changed: What|Removed |Added Component|Mesa core |Drivers/DRI/i965 QA Contact|me

[Mesa-dev] [Bug 93561] ninja: error: '$(PRIVATE_SCRIPT)', needed by 'out/target/product/rpi2/gen/STATIC_LIBRARIES/libmesa_dri_common_intermediates/xmlpool/options.h', missing and no known rule to make

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93561 Timothy Arceri changed: What|Removed |Added Resolution|--- |NOTOURBUG Status|NEW

[Mesa-dev] [Bug 34874] --enable-shared-glapi breaks apps

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=34874 Timothy Arceri changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

[Mesa-dev] [Bug 55021] Regression: eglInitialize crashes with 9.0

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=55021 Timothy Arceri changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

[Mesa-dev] [Bug 65427] Gallium EGL on Wayland blocks in eglInitialize (no display thread bound)

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65427 Timothy Arceri changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

[Mesa-dev] [Bug 32678] egl_gallium driver doesn't support EGL_KHR_image_pixmap extension

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=32678 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 97516] GLX_OML_swap_method not fully supported

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97516 Timothy Arceri changed: What|Removed |Added Component|Other |GLX -- You are receiving this mail bec

[Mesa-dev] [Bug 106180] [bisected] radv vulkan smoke test black screen (Add support for DRI3 v1.2)

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106180 --- Comment #10 from mercuriete --- Created attachment 139255 --> https://bugs.freedesktop.org/attachment.cgi?id=139255&action=edit good patch -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee f

[Mesa-dev] [Bug 106180] [bisected] radv vulkan smoke test black screen (Add support for DRI3 v1.2)

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106180 --- Comment #11 from mercuriete --- The previous patch fix this issue I've never contributed before to mesa, I want to send this patch to the mail list but i dont know how: if you want to commit that patch i would like to be: Abel Garcia Dort

[Mesa-dev] [Bug 106180] [bisected] radv vulkan smoke test black screen (Add support for DRI3 v1.2)

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106180 mercuriete changed: What|Removed |Added CC||b...@basnieuwenhuizen.nl -- You are recei

[Mesa-dev] [Bug 106180] [bisected] radv vulkan smoke test black screen (Add support for DRI3 v1.2)

2018-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106180 --- Comment #12 from mercuriete --- I've tested my patch and now I can play again dota2 and i can do vulkan smoketest. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___

[Mesa-dev] [PATCH] freedreno: Fix ir3_cmdline.c build.

2018-05-01 Thread Eric Anholt
Fixes: 6487e7a30c9e ("nir: move GL specific passes to src/compiler/glsl") --- src/gallium/drivers/freedreno/ir3/ir3_cmdline.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/freedreno/ir3/ir3_cmdline.c b/src/gallium/drivers/freedreno/ir3/ir3_cmdline.c index 5631216ebd9e..5

[Mesa-dev] [PATCH 1/2] radv: Don't check the incoming apiVersion on CreateInstance.

2018-05-01 Thread Bas Nieuwenhuizen
This fixes dEQP-VK.api.device_init.create_instance_invalid_api_version CC: 18.1 --- src/amd/vulkan/radv_device.c | 9 - 1 file changed, 9 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 629957afec2..26f2e3b1aea 100644 --- a/src/amd/vulkan/rad

[Mesa-dev] [PATCH 2/2] radv: UseEnumerateInstanceVersion for the default version.

2018-05-01 Thread Bas Nieuwenhuizen
--- src/amd/vulkan/radv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 26f2e3b1aea..7e7d784ca43 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c @@ -460,7 +460,7 @@ VkResult

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Marek Olšák
On Tue, May 1, 2018 at 5:35 AM, Nicolai Hähnle wrote: > On 01.05.2018 01:43, Marek Olšák wrote: > >> From: Marek Olšák >> >> This is a hypothetical interface for EQAA (a superset of CSAA). CSAA >> could be >> exposed via GL_NV_framebuffer_multisample_coverage. EQAA additionally >> removes >> the

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Marek Olšák
On Tue, May 1, 2018 at 10:48 AM, Roland Scheidegger wrote: > Am 01.05.2018 um 01:43 schrieb Marek Olšák: > > From: Marek Olšák > > > > This is a hypothetical interface for EQAA (a superset of CSAA). CSAA > could be > > exposed via GL_NV_framebuffer_multisample_coverage. EQAA additionally > remov

[Mesa-dev] [PATCH 4/5] v3d: Rename driver functions from vc5 to v3d.

2018-05-01 Thread Eric Anholt
This is the final step of the driver rename. --- The 300k of contents of this patch are just s/vc5/v3d/ over the files. See my vc5-publish branch for full series. src/gallium/drivers/v3d/v3d_blit.c | 96 +++--- src/gallium/drivers/v3d/v3d_bufmgr.c| 158 +- src/gallium/d

[Mesa-dev] [PATCH 0/5] vc5 rename to v3d and enable by default.

2018-05-01 Thread Eric Anholt
Unless there's some last-minute catch, I'll be landing the kernel driver this week, so I'd like to enable the Mesa side of the vc5 driver once that hits drm-next. I've renamed the kernel side to "v3d" since we've got both V3D 3.x ("vc5") and V3D 4.x ("vc6") supported already, and I'd like to avoid

[Mesa-dev] [PATCH 3/5] v3d: Rename the driver files from "vc5" to "v3d".

2018-05-01 Thread Eric Anholt
--- configure.ac | 4 +- src/broadcom/Makefile.am | 2 +- .../{Makefile.vc5.am => Makefile.v3d.am} | 0 src/gallium/Makefile.am | 2 +- .../auxiliary/target-helpers/drm_helper.h | 2 +- .../drivers/{vc5 => v3

[Mesa-dev] [PATCH 1/5] v3d: Switch the vc5 driver to using the finalized V3D UABI.

2018-05-01 Thread Eric Anholt
In the process of merging to the kernel, I renamed the driver to the general product line's name (since we have both vc5 and vc6 supported already). Since the ABI is finalized, move the header to include/drm-uapi. --- Makefile.am | 1 + .../vc5_drm.h => include/

[Mesa-dev] [PATCH 2/5] v3d: Rename the vc5_dri.so driver to v3d_dri.so.

2018-05-01 Thread Eric Anholt
This allows the driver to load against the merged kernel DRM driver. In the process, rename most of the build system variables and gallium plumbing functions. --- configure.ac | 18 ++-- meson.build | 6 ++-- meson_option

[Mesa-dev] [PATCH 5/5] v3d: Enable the driver by default.

2018-05-01 Thread Eric Anholt
Now that we have a stabilized ABI and a fairly conformant driver, turn it on. --- configure.ac| 2 +- src/gallium/drivers/v3d/meson.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index d5228032bb7b..626b238511e0 1006

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Marek Olšák
On Tue, May 1, 2018 at 10:51 AM, Axel Davy wrote: > Hi, > > > On 01/05/2018 01:43, Marek Olšák wrote: > >> From: Marek Olšák >> >> This is a hypothetical interface for EQAA (a superset of CSAA). CSAA >> could be >> exposed via GL_NV_framebuffer_multisample_coverage. EQAA additionally >> removes

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Marek Olšák
The maximum config is: - 16 coverage samples - 8 Z/S samples - 8 color samples The minimum config is: - 1-16 coverage samples - 1 Z/S sample - 1 color sample The coverage buffer (each color buffer has one) remembers undefined samples if color samples < coverage samples, and the resolve shader can

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Marek Olšák
We need a way to distinguish between AA and no AA even if color samples == 1. nr_samples is currently used for that purpose, so it makes sense to use nr_samples for coverage samples. color samples == 1 means that you can store 1 color sample per pixel and other samples are flagged as undefined and

Re: [Mesa-dev] [PATCH 20/29] intel/isl/format: Add field locations informations to channel_layout

2018-05-01 Thread Jason Ekstrand
ping On Tue, Mar 6, 2018 at 9:53 AM, Jason Ekstrand wrote: > On Tue, Mar 6, 2018 at 9:46 AM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > >> On Tue, Mar 06, 2018 at 09:11:18AM -0800, Jason Ekstrand wrote: >> > On Tue, Mar 6, 2018 at 1:54 AM, Pohjolainen, Topi < >> > topi.pohjolai..

Re: [Mesa-dev] [PATCH 26/29] intel/blorp: Add support for more format bitcasting

2018-05-01 Thread Jason Ekstrand
On Wed, Mar 7, 2018 at 5:08 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Jan 26, 2018 at 05:59:55PM -0800, Jason Ekstrand wrote: > > By making use of the NIR helper for uint vector casts, we should now be > > able to bitcast between any two uint formats so long as their cha

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Roland Scheidegger
Am 01.05.2018 um 22:49 schrieb Marek Olšák: > On Tue, May 1, 2018 at 10:48 AM, Roland Scheidegger > wrote: > > Am 01.05.2018 um 01:43 schrieb Marek Olšák: > > From: Marek Olšák mailto:marek.ol...@amd.com>> > > > > This is a hypothetical interface for EQ

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-01 Thread Jan Vesely
On Tue, 2018-05-01 at 18:23 +0200, Kai Wasserbäch wrote: > Hey Jan, > Jan Vesely wrote on 01.05.2018 17:19: > > On Tue, 2018-05-01 at 14:14 +0200, Kai Wasserbäch wrote: > > > Otherwise the build fails with an undefined reference to > > > clang::FrontendTimesIsEnabled. > > > > > > Bugzilla: https:/

Re: [Mesa-dev] [PATCH 17/29] i965/blorp: Remove a pile of blorp_blit restrictions

2018-05-01 Thread Jason Ekstrand
On Tue, Mar 6, 2018 at 12:15 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Jan 26, 2018 at 05:59:46PM -0800, Jason Ekstrand wrote: > > Previously, blorp could only blit into something that was renderable. > > Thanks to recent additions to blorp, it can now blit into basicall

  1   2   >