Re: [Mesa-dev] [RFC PATCH] gallium: add interface for advanced MSAA

2018-05-21 Thread Marek Olšák
It was marketed that way because D3D didn't have API to do anything else. In practice, EQAA can do arbitrary color coverage, color storage, and Z/S sample counts, and each color render target can have different values too. So everything is allowed, but the combinations that don't make sense only

Re: [Mesa-dev] [ANNOUNCE] mesa 18.1.0

2018-05-21 Thread Stuart Young
Appears that while the release notes for 18.1.0 are actually up on the website[1], the News[2] column on the main website didn't get updated, as 18.1.0 isn't listed there. 1. https://www.mesa3d.org/relnotes/18.1.0.html 2. https://www.mesa3d.org/index.html On 19 May 2018 at 09:43,

Re: [Mesa-dev] [PATCH] llvmpipe: improve rasterization discard logic

2018-05-21 Thread Brian Paul
On 05/21/2018 07:34 PM, srol...@vmware.com wrote: From: Roland Scheidegger This unifies the explicit rasterization dicard as well as the implicit "discard" Looks OK to me. Minor nits below. Reviewed-by: Brian Paul rasterization disabled logic

[Mesa-dev] [PATCH] llvmpipe: improve rasterization discard logic

2018-05-21 Thread sroland
From: Roland Scheidegger This unifies the explicit rasterization dicard as well as the implicit rasterization disabled logic (which we need for another state tracker), which really should do the exact same thing. We'll now toss out the prims early on in setup with (implicit

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for advanced MSAA

2018-05-21 Thread Roland Scheidegger
I was under the (apparently wrong) impression EQAA always worked like that too. Even AMD's marketing said EQAA has the same number of stencil/depth/color samples as regular MSAA (when the feature was new, HD 6900,

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for advanced MSAA

2018-05-21 Thread Marek Olšák
Your understanding is correct. I misunderstood CSAA. So it looks like that CSAA is more useless than I thought. You get the coverage-samples level of quality for back-to-front rendering, but you may get the depth-samples level of quality for front-to-back rendering, because "edges" generated by

[Mesa-dev] [PATCHv2 3/4] i965: Handle non-zero texture buffer offsets in buffer object range calculation.

2018-05-21 Thread Francisco Jerez
Otherwise the specified surface state will allow the GPU to access memory up to BufferOffset bytes past the end of the buffer. Found by inspection. v2: Protect against out-of-range BufferOffset (Nanley). Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c

[Mesa-dev] [PATCH] v3d: Fix automake linking error.

2018-05-21 Thread Vinson Lee
CXXLDgallium_dri.la ../../../../src/broadcom/.libs/libbroadcom.a(clif_dump.o): In function `clif_dump_packet': src/broadcom/clif/clif_dump.c:87: undefined reference to `v3d33_clif_dump_packet' src/broadcom/clif/clif_dump.c:85: undefined reference to `v3d41_clif_dump_packet'

Re: [Mesa-dev] [PATCH] radeonsi: Track pipe_vertex_buffers for relocs.

2018-05-21 Thread Marek Olšák
On Sun, May 20, 2018 at 2:21 PM, Mathias Fröhlich wrote: > Hi Marek, > > On Sunday, 20 May 2018 20:08:08 CEST Marek Olšák wrote: > > The old code saves which vertex element is the first to use a VBO slot. > > When VBOs are added to the buffer list, each VBO is added

Re: [Mesa-dev] [PATCH] i965/glk: Add l3 banks count for 2x6 configuration

2018-05-21 Thread Clayton Craft
Quoting Anuj Phogat (2018-05-21 15:21:56) > 2x6 configuration with pci-id 0x3185 has same number of > banks (2) as 3x6 configuration (pci-id 0x3184). This passes testing, you can add me to the tested-by. > > Reported-by: Clayton Craft > Signed-off-by: Anuj Phogat

Re: [Mesa-dev] [RFC PATCH] Replace an flock with a random filename to evade some very ugly system dependent code

2018-05-21 Thread Timothy Arceri
On 22/05/18 04:40, Benedikt Schemmer wrote: Ok, small update. Please ignore this rfc. I finally got appveyor to build my repo. There are at least these dependencies that would need to addressed (for anybody wanting tor try): #include // can be eliminated sometimes by replacing with

Re: [Mesa-dev] [PATCH v2 2/3] glsl: allow built-in variables to be explicitly declared

2018-05-21 Thread Timothy Arceri
Ian can I get your thoughts on this series? On 12/05/18 14:49, Timothy Arceri wrote: Mesa seems to be the only implementation that doesn't allow builtins to be explicitly declared. The GLSL 1.30 spec seems to imply that buitins may be explicitly declared. This this allows the game "Full Bore"

Re: [Mesa-dev] [PATCH 1/2] glsl: always enable OES_standard_derivatives features if supported

2018-05-21 Thread Timothy Arceri
On 22/05/18 03:13, Ian Romanick wrote: On 05/16/2018 12:04 AM, Timothy Arceri wrote: The GLSL ES 1.0 spec made these features optional. With OES_standard_derivatives they are guaranteed to be available but currently the extension must be enabled to use them. Instead this changes the code to

Re: [Mesa-dev] [PATCH] Revert "st/nir: use NIR for asm programs"

2018-05-21 Thread Timothy Arceri
On 22/05/18 04:15, Eric Anholt wrote: Timothy Arceri writes: On 18/05/18 00:53, Eric Anholt wrote: This reverts commit 5c33e8c7729edd5e16020ebb8703be96523e04f2. It broke fixed function vertex programs on vc4 and v3d, and apparently caused trouble for radeonsi's NIR

Re: [Mesa-dev] [PATCH] i965/glk: Add l3 banks count for 2x6 configuration

2018-05-21 Thread Lionel Landwerlin
On 21/05/18 23:25, Lionel Landwerlin wrote: On 21/05/18 23:21, Anuj Phogat wrote: 2x6 configuration with pci-id 0x3185 has same number of banks (2) as 3x6 configuration (pci-id 0x3184). Reported-by: Clayton Craft Signed-off-by: Anuj Phogat

Re: [Mesa-dev] [PATCH] i965/glk: Add l3 banks count for 2x6 configuration

2018-05-21 Thread Lionel Landwerlin
On 21/05/18 23:21, Anuj Phogat wrote: 2x6 configuration with pci-id 0x3185 has same number of banks (2) as 3x6 configuration (pci-id 0x3184). Reported-by: Clayton Craft Signed-off-by: Anuj Phogat Cc: Cc:

[Mesa-dev] [PATCH] i965/glk: Add l3 banks count for 2x6 configuration

2018-05-21 Thread Anuj Phogat
2x6 configuration with pci-id 0x3185 has same number of banks (2) as 3x6 configuration (pci-id 0x3184). Reported-by: Clayton Craft Signed-off-by: Anuj Phogat Cc: Cc: Lionel Landwerlin

[Mesa-dev] [Bug 106283] Shader replacements works only for limited use cases

2018-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106283 --- Comment #10 from i...@yahoo.com --- (In reply to iive from comment #9) > (In reply to Tapani Pälli from comment #8) > > I'm working on something different ATM and would not like to context switch > > but will look at this later. If changes

[Mesa-dev] [PATCH 4.16 039/110] drm/i915/gen9: Add WaClearHIZ_WM_CHICKEN3 for bxt and glk

2018-05-21 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Michel Thierry commit b579f924a90f42fa561afd8201514fc216b71949 upstream. Factor in clear values wherever required while updating destination min/max. References:

[Mesa-dev] [HOWTO] CI on appveyor with a linux image

2018-05-21 Thread Benedikt Schemmer
I thought this might be interesting because currently appveyor is only used with MSVC and LLVM 3.3.1 They can however provide Ubuntu 16.04 LTS. Its free for OSS. You only need some kind of repository. Basic setup is easy https://www.appveyor.com/docs/ The hard part is the appveyor.yml file,

Re: [Mesa-dev] [PATCH 3/3] mesa/main/shaderapi: purely non-functional cleanups, like whitespace errors and cleanups

2018-05-21 Thread Benedikt Schemmer
Am 21.05.2018 um 19:21 schrieb Ian Romanick: > On 05/10/2018 02:05 AM, Benedikt Schemmer wrote: >> remove a memset too and yes, this is all functionally identical >> >> --- >> src/mesa/main/shaderapi.c | 40 >> 1 file changed, 20 insertions(+), 20

[Mesa-dev] [PATCH 4.14 27/95] drm/i915/gen9: Add WaClearHIZ_WM_CHICKEN3 for bxt and glk

2018-05-21 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Michel Thierry commit b579f924a90f42fa561afd8201514fc216b71949 upstream. Factor in clear values wherever required while updating destination min/max. References:

[Mesa-dev] [Bug 106595] [RADV] Rendering distortions only when MSAA is enabled

2018-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106595 --- Comment #3 from zefkerri...@gmail.com --- https://cgit.freedesktop.org/mesa/mesa/commit/?id=73df16dcee79e2281c8d8a830dbbe6655359c82d This video I shot before applying this patch, but I believe that the issue of wings rendering is not related

[Mesa-dev] [Bug 106595] [RADV] Rendering distortions only when MSAA is enabled

2018-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106595 --- Comment #2 from zefkerri...@gmail.com --- (In reply to Samuel Pitoiset from comment #1) > Do you have > https://cgit.freedesktop.org/mesa/mesa/commit/ > ?id=73df16dcee79e2281c8d8a830dbbe6655359c82d in your tree? Yes, I have. But this patch,

Re: [Mesa-dev] [PATCH v2] mesa: handle a bunch of formats in IMPLEMENTATION_COLOR_READ_*

2018-05-21 Thread Eric Anholt
Tomeu Vizoso writes: > Virgl could save a lot of work converting buffers in the host side > between formats if Mesa supported a bunch of other formats when reading > pixels. > > This commit adds cases to handle specific formats so that the values > reported by the two

[Mesa-dev] [Bug 106595] [RADV] Rendering distortions only when MSAA is enabled

2018-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106595 --- Comment #1 from Samuel Pitoiset --- Do you have https://cgit.freedesktop.org/mesa/mesa/commit/?id=73df16dcee79e2281c8d8a830dbbe6655359c82d in your tree? -- You are receiving this mail because: You are the QA

[Mesa-dev] [Bug 106595] [RADV] Rendering distortions only when MSAA is enabled

2018-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106595 zefkerri...@gmail.com changed: What|Removed |Added CC||zefkerri...@gmail.com -- You

[Mesa-dev] [Bug 106595] [RADV] Rendering distortions only when MSAA is enabled

2018-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106595 Bug ID: 106595 Summary: [RADV] Rendering distortions only when MSAA is enabled Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] [PATCH mesa] i965: Check result of make_surface() for miptree_create

2018-05-21 Thread Ian Romanick
On 05/17/2018 05:05 AM, Eric Engestrom wrote: > From: Andrea Azzarone > > Since make_surface() can fail we need to check the result before > dereferencing it. > > Bug: https://github.com/mesa3d/mesa/pull/5 > Bug:

Re: [Mesa-dev] [RFC PATCH] Replace an flock with a random filename to evade some very ugly system dependent code

2018-05-21 Thread Benedikt Schemmer
Ok, small update. Please ignore this rfc. I finally got appveyor to build my repo. There are at least these dependencies that would need to addressed (for anybody wanting tor try): #include // can be eliminated sometimes by replacing with __TIMESTAMP__ or maybe better __DATE__ __TIME__

Re: [Mesa-dev] [PATCH] vbo: remove MaxVertexAttribStride assert check.

2018-05-21 Thread Ian Romanick
On 05/17/2018 11:56 PM, Mathias Fröhlich wrote: > Hi Dave, > > On Friday, 18 May 2018 06:57:19 CEST Dave Airlie wrote: >>> May be I should take care of all of these type of asserts, also the ones >>> with MaxVertexAttribRelativeOffset and care for not checking them >>> when the extension version

Re: [Mesa-dev] [PATCH] v3d: Include v3d_drm.h path.

2018-05-21 Thread Eric Anholt
Vinson Lee writes: > Fix build error. > > CC v3d_blit.lo > In file included from v3d_blit.c:27:0: > v3d_context.h:39:10: fatal error: v3d_drm.h: No such file or directory > #include "v3d_drm.h" > ^~~ > > Fixes: 8a793d42f1cc ("v3d: Switch the vc5

Re: [Mesa-dev] [PATCH] Revert "st/nir: use NIR for asm programs"

2018-05-21 Thread Eric Anholt
Timothy Arceri writes: > On 18/05/18 00:53, Eric Anholt wrote: >> This reverts commit 5c33e8c7729edd5e16020ebb8703be96523e04f2. It broke >> fixed function vertex programs on vc4 and v3d, and apparently caused >> trouble for radeonsi's NIR paths as well. > > Has someone

Re: [Mesa-dev] [PATCH 1/3] docs/releasing: Add complete command line to scripts

2018-05-21 Thread Ian Romanick
With the nits in patch 3 fixed, this series is Reviewed-by: Ian Romanick On 05/21/2018 10:34 AM, Dylan Baker wrote: > particularly that bugzilla_mesa and shortlog_mesa take an argument to > pass directly to git. > --- > docs/releasing.html | 4 ++-- > 1 file changed,

Re: [Mesa-dev] [PATCH 3/3] docs/releasing: Add note about using a staging branch

2018-05-21 Thread Ian Romanick
On 05/21/2018 10:34 AM, Dylan Baker wrote: > --- > docs/releasing.html | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/docs/releasing.html b/docs/releasing.html > index 07f100caae1..20fc4579a32 100644 > --- a/docs/releasing.html > +++ b/docs/releasing.html > @@

Re: [Mesa-dev] [PATCH] nir/print: fix printing of 8/16 bit constant variables

2018-05-21 Thread Karol Herbst
On Mon, May 21, 2018 at 7:31 PM, Chema Casanova wrote: > As GLSL_TYPE_FLOAT16 type support is not implemented in this patch, we > would need to change commit summary to ".. 8/16 bit integer constant.." > or just implement half float support with something like. > > + case

[Mesa-dev] [PATCH 3/3] docs/releasing: Add note about using a staging branch

2018-05-21 Thread Dylan Baker
--- docs/releasing.html | 19 +++ 1 file changed, 19 insertions(+) diff --git a/docs/releasing.html b/docs/releasing.html index 07f100caae1..20fc4579a32 100644 --- a/docs/releasing.html +++ b/docs/releasing.html @@ -249,6 +249,25 @@ Now go to

[Mesa-dev] [PATCH 1/3] docs/releasing: Add complete command line to scripts

2018-05-21 Thread Dylan Baker
particularly that bugzilla_mesa and shortlog_mesa take an argument to pass directly to git. --- docs/releasing.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/releasing.html b/docs/releasing.html index a022d0c484b..d69eba1136f 100644 --- a/docs/releasing.html +++

[Mesa-dev] [PATCH 2/3] docs/releasing: add meson to build systems to test

2018-05-21 Thread Dylan Baker
--- docs/releasing.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/releasing.html b/docs/releasing.html index d69eba1136f..07f100caae1 100644 --- a/docs/releasing.html +++ b/docs/releasing.html @@ -122,7 +122,7 @@ Currently Ilia Mirkin and AMD devs have requested

[Mesa-dev] [PATCH 1/2] bin/bugzilla_mesa.sh: explicitly set the --pretty argument

2018-05-21 Thread Dylan Baker
Signed-off-by: Dylan Baker --- bin/bugzilla_mesa.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/bugzilla_mesa.sh b/bin/bugzilla_mesa.sh index a8f5305844b..9095bc9deea 100755 --- a/bin/bugzilla_mesa.sh +++ b/bin/bugzilla_mesa.sh @@ -23,7 +23,7

[Mesa-dev] [PATCH 2/2] bin/get-pick-listh.sh: force git --pretty=medium

2018-05-21 Thread Dylan Baker
Signed-off-by: Dylan Baker --- bin/get-pick-list.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/get-pick-list.sh b/bin/get-pick-list.sh index 1bd0b367d8b..9e9a39e494b 100755 --- a/bin/get-pick-list.sh +++ b/bin/get-pick-list.sh @@ -12,7 +12,7

Re: [Mesa-dev] [PATCH] nir/print: fix printing of 8/16 bit constant variables

2018-05-21 Thread Chema Casanova
As GLSL_TYPE_FLOAT16 type support is not implemented in this patch, we would need to change commit summary to ".. 8/16 bit integer constant.." or just implement half float support with something like. + case GLSL_TYPE_FLOAT16: + for (i = 0; i < cols; i++) { + for (j = 0; j < rows;

Re: [Mesa-dev] [PATCH 2/2] r600/compute: Mark several functions as static

2018-05-21 Thread Bruno Jimenez
On Mon, 2018-05-21 at 09:34 -0500, Aaron Watry wrote: > On Mon, May 21, 2018 at 9:34 AM, Aaron Watry > wrote: > > On Mon, May 21, 2018 at 6:25 AM, Bruno Jimenez > m> wrote: > > > On Fri, 2018-05-18 at 22:52 -0400, Jan Vesely wrote: > > > > On Fri,

Re: [Mesa-dev] [PATCH 3/3] mesa/main/shaderapi: purely non-functional cleanups, like whitespace errors and cleanups

2018-05-21 Thread Ian Romanick
On 05/10/2018 02:05 AM, Benedikt Schemmer wrote: > remove a memset too and yes, this is all functionally identical > > --- > src/mesa/main/shaderapi.c | 40 > 1 file changed, 20 insertions(+), 20 deletions(-) > > diff --git a/src/mesa/main/shaderapi.c

Re: [Mesa-dev] [PATCH 1/2] glsl: always enable OES_standard_derivatives features if supported

2018-05-21 Thread Ian Romanick
On 05/16/2018 12:04 AM, Timothy Arceri wrote: > The GLSL ES 1.0 spec made these features optional. With > OES_standard_derivatives they are guaranteed to be available > but currently the extension must be enabled to use them. > > Instead this changes the code to check if the driver supports > the

Re: [Mesa-dev] [PATCH 2/2] radv: fix computation of user sgprs for 32-bit pointers

2018-05-21 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Mon, May 21, 2018 at 4:57 PM, Samuel Pitoiset wrote: > With 32-bit pointers we only need one user SGPR per desc set. > > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [RFC PATCH 1/3] mesa/main/extensions: make constants slightly more expressive and adjust layout

2018-05-21 Thread Ian Romanick
I'm not in favor of this patch. The lines in this file are already annoyingly long. I don't think making them longer helps. On 05/19/2018 06:18 AM, Benedikt Schemmer wrote: > This just makes the constants more descriptive > > CC: "Marek Olšák" > CC: Eric Anholt

Re: [Mesa-dev] [RFC] glsl: bump default glsl version to 130 if EXT_gpu_shader4 used

2018-05-21 Thread Ian Romanick
On 05/15/2018 04:41 PM, Marek Olšák wrote: > On Tue, May 15, 2018 at 4:59 PM, Jason Ekstrand > wrote: > > On Tue, May 15, 2018 at 1:38 PM, Marek Olšák > wrote: > > On Tue, May 15,

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for advanced MSAA

2018-05-21 Thread Axel Davy
Hi, I get the impression when looking at online documentation about EQAA and CSAA, like http://www.nvidia.fr/object/coverage-sampled-aa.html that the number of stored samples is the same for the color and depth buffers. Only the samples used for coverage is greater. With your proposal,

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2018-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Kai changed: What|Removed |Added Depends on||106594 Referenced

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for advanced MSAA

2018-05-21 Thread Roland Scheidegger
This looks reasonable to me. Roland Am 18.05.2018 um 06:05 schrieb Marek Olšák: > From: Marek Olšák > > The interface only uses general MSAA terms, so it's "advanced MSAA" and not > something vendor-specific. > > It's a proper subset of EQAA, and a proper superset of

Re: [Mesa-dev] [PATCH 02/19] intel/fs: Use groups for SIMD16 LINTERP on gen11+

2018-05-21 Thread Kenneth Graunke
On Monday, May 21, 2018 7:04:39 AM PDT Jason Ekstrand wrote: > On May 20, 2018 23:45:27 Kenneth Graunke wrote: > > > On Friday, May 18, 2018 4:35:15 PM PDT Jason Ekstrand wrote: > >> This is better than compression control because it naturally extends to > >> SIMD32. > >>

[Mesa-dev] [PATCH 1/2] radv: drop user_sgpr_info::sgpr_count

2018-05-21 Thread Samuel Pitoiset
It's only used inside allocate_user_sgprs(). Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c

[Mesa-dev] [PATCH 2/2] radv: fix computation of user sgprs for 32-bit pointers

2018-05-21 Thread Samuel Pitoiset
With 32-bit pointers we only need one user SGPR per desc set. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c

[Mesa-dev] [Bug 106479] NDEBUG not defined for libamdgpu_addrlib

2018-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106479 Bas Nieuwenhuizen changed: What|Removed |Added Status|NEW |NEEDINFO

[Mesa-dev] [Bug 106479] NDEBUG not defined for libamdgpu_addrlib

2018-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106479 Bas Nieuwenhuizen changed: What|Removed |Added Component|Mesa core

[Mesa-dev] [Bug 106511] radv: MSAA broken on SI (assertion failure in vkCreateImage)

2018-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106511 --- Comment #2 from Bas Nieuwenhuizen --- This should be fixed with https://patchwork.freedesktop.org/patch/224584/ -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact

Re: [Mesa-dev] [PATCH 4/5] egl/wayland: Allow client->server format conversion for PRIME offload.

2018-05-21 Thread Eric Engestrom
On Saturday, 2018-05-19 05:32:41 +0200, Mario Kleiner wrote: > Support PRIME render offload between a Wayland server gpu and a Wayland > client gpu with different channel ordering for their color formats, > e.g., between Intel drivers which currently only support ARGB2101010 > and XRGB2101010

Re: [Mesa-dev] [PATCH 2/2] r600/compute: Mark several functions as static

2018-05-21 Thread Aaron Watry
On Mon, May 21, 2018 at 9:34 AM, Aaron Watry wrote: > On Mon, May 21, 2018 at 6:25 AM, Bruno Jimenez wrote: >> On Fri, 2018-05-18 at 22:52 -0400, Jan Vesely wrote: >>> On Fri, 2018-05-18 at 21:31 -0500, Aaron Watry wrote: >>> > On Fri, May 18, 2018 at 1:15

Re: [Mesa-dev] [PATCH 2/2] r600/compute: Mark several functions as static

2018-05-21 Thread Aaron Watry
On Mon, May 21, 2018 at 6:25 AM, Bruno Jimenez wrote: > On Fri, 2018-05-18 at 22:52 -0400, Jan Vesely wrote: >> On Fri, 2018-05-18 at 21:31 -0500, Aaron Watry wrote: >> > On Fri, May 18, 2018 at 1:15 PM, Jan Vesely > > > wrote: >> > > On Thu,

Re: [Mesa-dev] [PATCH 3/5] egl/x11: Handle both depth 30 formats for eglCreateImage(). (v3)

2018-05-21 Thread Eric Engestrom
On Saturday, 2018-05-19 05:32:40 +0200, Mario Kleiner wrote: > We need to distinguish if the backing storage of a pixmap > is XRGB2101010 or XBGR2101010, as different gpu hw supports > different formats. NVidia hw prefers XBGR, whereas AMD and > Intel are happy with XRGB. > > Use the red channel

Re: [Mesa-dev] [PATCH] radv: fix centroid interpolation

2018-05-21 Thread Bas Nieuwenhuizen
On Mon, May 21, 2018 at 2:37 PM, Ilia Mirkin wrote: > What do centroid / sample interpolation modes mean in a non-msaa > environment? Or does key.fs.multisample mean something else? Yeah that was what I was wondering too. It is valid for shaders to use so we should handel

Re: [Mesa-dev] [PATCH 02/19] intel/fs: Use groups for SIMD16 LINTERP on gen11+

2018-05-21 Thread Jason Ekstrand
On May 20, 2018 23:45:27 Kenneth Graunke wrote: On Friday, May 18, 2018 4:35:15 PM PDT Jason Ekstrand wrote: This is better than compression control because it naturally extends to SIMD32. --- src/intel/compiler/brw_fs_generator.cpp | 6 ++ 1 file changed, 2

[Mesa-dev] [PATCH] ac/surface/gfx6: Don't force a tile index for fmask.

2018-05-21 Thread Bas Nieuwenhuizen
The bpe of the fmask often differs from the bpe of the main surface. On SI that means it has to get a different tile index. addrlib is capable of figuring this out itself, so just pass -1 instead to let it know that it is not preset. Fixes: 9bf3570fed0 "ac/surface/gfx6: compute FMASK together

[Mesa-dev] [PATCH] nir/print: fix printing of 8/16 bit constant variables

2018-05-21 Thread Karol Herbst
Signed-off-by: Karol Herbst --- src/compiler/nir/nir_print.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/compiler/nir/nir_print.c b/src/compiler/nir/nir_print.c index 97b2d6164cd..e331a26d932 100644 --- a/src/compiler/nir/nir_print.c +++

Re: [Mesa-dev] Splitting a texture between multiple samplers in Gallium

2018-05-21 Thread Ilia Mirkin
So ... what do you do when someone attaches max_samplers' worth of RGBA32F textures to a single stage? My guess is that you just fail to render and tell the application author, "don't do that". The alternative is to expose 1/4th of the true maximum, which is probably undesirable. Normally these

Re: [Mesa-dev] [PATCH] radv: fix centroid interpolation

2018-05-21 Thread Ilia Mirkin
What do centroid / sample interpolation modes mean in a non-msaa environment? Or does key.fs.multisample mean something else? On Mon, May 21, 2018 at 5:15 AM, Samuel Pitoiset wrote: > It's legal to set the centroid and sample interpolation modes > when MSAA disabled.

[Mesa-dev] Splitting a texture between multiple samplers in Gallium

2018-05-21 Thread Konstantin P.
We are writing a driver for some proprietary hardware using Gallium. And this hardware supports GL_ARB_texture_float, but requires to change texture format from PIPE_FORMAT_R32G32B32A32_FLOAT to PIPE_FORMAT_R8G8B8A8_UNORM and use four samplers (one R8G8B8A8_UNORM texture for each original color).

[Mesa-dev] [Bug 102390] centroid interpolation causes broken attribute values

2018-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102390 Samuel Pitoiset changed: What|Removed |Added Status|NEEDINFO|RESOLVED

[Mesa-dev] [Bug 106315] The witness + dxvk suffers flickering garbage

2018-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106315 Samuel Pitoiset changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 2/2] r600/compute: Mark several functions as static

2018-05-21 Thread Bruno Jimenez
On Fri, 2018-05-18 at 22:52 -0400, Jan Vesely wrote: > On Fri, 2018-05-18 at 21:31 -0500, Aaron Watry wrote: > > On Fri, May 18, 2018 at 1:15 PM, Jan Vesely > > wrote: > > > On Thu, 2018-05-17 at 19:20 -0500, Aaron Watry wrote: > > > > They're not used anywhere else, so

Re: [Mesa-dev] [PATCH] intel/eu: Set EXECUTE_1 when setting the rounding mode in cr0

2018-05-21 Thread Chema Casanova
Thanks for fixing the full overwrite of the Control Register. Reviewed-by: Jose Maria Casanova Crespo El 19/05/18 a las 05:09, Jason Ekstrand escribió: > Fixes: d6cd14f2131a5b "i965/fs: Define new shader opcode to..." > --- > src/intel/compiler/brw_eu_emit.c | 2 ++ > 1

Re: [Mesa-dev] [PATCH 09/22] intel/compiler: implement 16-bit multiply-add

2018-05-21 Thread Eero Tamminen
Hi, On 21.05.2018 10:42, Iago Toral wrote: On Fri, 2018-05-18 at 12:08 +0300, Eero Tamminen wrote: On 17.05.2018 14:25, Eero Tamminen wrote: On 17.05.2018 11:46, Iago Toral Quiroga wrote: The PRM for MAD states that F, DF and HF are supported, however, then it requires that the instruction

Re: [Mesa-dev] [RFC PATCH] Replace an flock with a random filename to evade some very ugly system dependent code

2018-05-21 Thread Benedikt Schemmer
Am 21.05.2018 um 01:19 schrieb Timothy Arceri: > > > On 20/05/18 22:16, Benedikt Schemmer wrote: >> There is exactly one flock in mesa and it caused mesa not to build >> on windows when shader cache was enabled. >> >> It should be possible to revert 9f8dc3bf03ec825bae7041858dda6ca2e9a34363 >>

Re: [Mesa-dev] [PATCH] radv: fix centroid interpolation

2018-05-21 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Mon, May 21, 2018 at 11:15 AM, Samuel Pitoiset wrote: > It's legal to set the centroid and sample interpolation modes > when MSAA disabled. So, we have to initialize the centroid > inputs because the hardware

[Mesa-dev] [PATCH] radv: fix centroid interpolation

2018-05-21 Thread Samuel Pitoiset
It's legal to set the centroid and sample interpolation modes when MSAA disabled. So, we have to initialize the centroid inputs because the hardware doesn't. This fixes rendering issues with DXVK and The Witness, World of Warcraft, Trackmania and probably more games. Bugzilla:

[Mesa-dev] [Bug 106587] Dota2 is very dark when using vulkan render on a Intel << AMD prime setup

2018-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106587 Bas Nieuwenhuizen changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 18/47] (0018b) Fix for Patch 0018; I have no idea if this is a real fix or not

2018-05-21 Thread Rantala, Valtteri
This should not have been here at the first place. This patch set is a POC that simd32 gives performance boosts for certain benchmarks. As you said it really needs clean up and more testing, before it can be merged. -- Valtteri From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On

Re: [Mesa-dev] [RFC PATCH] virgl: Always assume that ORIGIN_UPPER_LEFT and PIXEL_CENTER* are supported

2018-05-21 Thread Gert Wollny
Am Donnerstag, den 17.05.2018, 12:33 +0200 schrieb Gert Wollny: > The driver must support at least one of > > PIPE_CAP_TGSI_FS_COORD_ORIGIN_UPPER_LEFT > PIPE_CAP_TGSI_FS_COORD_ORIGIN_LOWER_LEFT > > and one of > > PIPE_CAP_TGSI_FS_COORD_PIXEL_CENTER_HALF_INTEGER >

Re: [Mesa-dev] [PATCH 03/19] intel/eu: Remove brw_codegen::compressed_stack.

2018-05-21 Thread Kenneth Graunke
On Friday, May 18, 2018 4:35:16 PM PDT Jason Ekstrand wrote: > From: Francisco Jerez > > Reviewed-by: Jason Ekstrand > --- > src/intel/compiler/brw_eu.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/intel/compiler/brw_eu.h

Re: [Mesa-dev] [PATCH 02/19] intel/fs: Use groups for SIMD16 LINTERP on gen11+

2018-05-21 Thread Kenneth Graunke
On Friday, May 18, 2018 4:35:15 PM PDT Jason Ekstrand wrote: > This is better than compression control because it naturally extends to > SIMD32. > --- > src/intel/compiler/brw_fs_generator.cpp | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH mesa] egl/x11: deduplicate depth-to-format logic

2018-05-21 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 05/18/2018 06:14 PM, Eric Engestrom wrote: Suggested-by: Emil Velikov Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/platform_x11.c | 35 ++--

Re: [Mesa-dev] [PATCH 03/22] compiler/spirv: fix SpvOpIsInf for 16-bit float

2018-05-21 Thread Iago Toral
On Thu, 2018-05-17 at 06:59 -0700, Jason Ekstrand wrote: > > On May 17, 2018 01:47:11 Iago Toral Quiroga > wrote: > > > --- > > src/compiler/spirv/vtn_alu.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/src/compiler/spirv/vtn_alu.c > >

Re: [Mesa-dev] [PATCH] tgsi/scan: add hw atomic to the list of memory accessing files

2018-05-21 Thread Dave Airlie
ping? On 10 May 2018 at 10:05, Dave Airlie wrote: > From: Dave Airlie > > This fixes 4 out of 5 cases in: > arb_framebuffer_no_attachments-atomic on cayman. > --- > src/gallium/auxiliary/tgsi/tgsi_scan.c | 3 ++- > 1 file changed, 2 insertions(+), 1

[Mesa-dev] [Bug 106590] Wrong line numbers expanded while compiling shaders

2018-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106590 --- Comment #1 from Timothy Arceri --- Thanks for the patch! However you should sign up to the mesa mailing list [1] and send it there for review. [1] https://lists.freedesktop.org/mailman/listinfo/mesa-dev See also:

[Mesa-dev] [Bug 106590] Wrong line numbers expanded while compiling shaders

2018-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106590 Bug ID: 106590 Summary: Wrong line numbers expanded while compiling shaders Product: Mesa Version: 17.1 Hardware: ARM OS: Linux (All) Status: NEW