maine
From: Michel Dänzer
Sent: Tuesday, February 11, 2020 2:03 AM
To: Neha Bhende; Brian Paul; Charmaine Lee
Cc: mesa-dev@lists.freedesktop.org
Subject: Re: [Mesa-dev] [Review Request (master branch)] svga: Use
pipe_shader_state_from_tgsi to set shader state
Hi Charmaine,
it looks like you p
The patch looks good to me.
It replaces my earlier patch request on the same issue.
Reviewed-by: Charmaine Lee
On 8/2/19, 9:54 AM, "Brian Paul" wrote:
On 08/02/2019 10:36 AM, srol...@vmware.com wrote:
> From: Roland Scheidegger
>
> These versions sti
This patch fixes a missing argument to CreateAtomicCmpXchg for older
version of LLVM.
---
src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
index 79d1029..
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Monday, May 20, 2019 6:36:33 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Charmaine Lee
Subject: [PATCH] svga: clamp max_const_buffers to SVGA_MAX_CONST_BUFS
In case the device reports 15 (or
>From: Brian Paul
>Sent: Monday, May 20, 2019 6:39 AM
>To: Charmaine Lee; mesa-dev@lists.freedesktop.org; Neha Bhende;
>marek.ol...@amd.com
>Subject: Re: [PATCH 2/2] mesa: unreference current winsys buffers when
>unbinding winsys buffers
>Both look OK to me. Do they n
With commit c89e8470e58, framebuffers are purged after unbinding context,
but this change also introduces a heap corruption when running Rhino application
on VMware svga device. Instead of purging the framebuffers after the context
is unbound, this patch first ubinds the winsys buffers, then purges
This fixes surface leak when no winsys buffers are bound.
---
src/mesa/main/context.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c
index 34da16b..04ef4d5 100644
--- a/src/mesa/main/context.c
+++ b/src/mesa/main/context.c
@@ -1765,6 +1765
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Tuesday, October 9, 2018 8:06:26 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: change svga_destroy_shader_variant() to return void
For the series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Friday, July 27, 2018 7:21:53 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] mesa: move var decls in texstore_rgba()
Move them closer to where
Java2d opengl pipeline passes NULL piAttribList to
wglCreatePbufferARB(). So skip parsing the attribute list
if it is NULL.
---
src/gallium/state_trackers/wgl/stw_ext_pbuffer.c | 80
1 file changed, 41 insertions(+), 39 deletions(-)
diff --git a/src/gallium/state_trackers
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, June 14, 2018 8:13:01 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] st/mesa: add missing switch cases in
glsl_to_tgsi_visitor::visit()
To silence
Looks good.
Also verified that the workaround fixes the crashes that are seen with VMware
svga driver due to this bug.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Tuesday, May 8, 2018 7:43:49 AM
To: mesa-dev@lists.freedesktop.org
Cc: Matt Turner
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Monday, April 30, 2018 7:42 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] tgsi: use enums instead of unsigned in ureg code
---
src/gallium/auxiliary/tgsi
With this patch, _ElementSize is initialized along with the rest
of the vertex array attributes in new_draw_rasterpos_stage().
This fixes a crash in st_pipe_vertex_format() when running
topogun-1.06-orc-84k-resize trace file with VMware svga driver.
---
src/mesa/state_tracker/st_cb_rasterpos.c | 5
For the series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Friday, April 13, 2018 2:35:37 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 5/5] gallium/osmesa: link with winsock2 library on Windows
To fix the
For the series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Friday, April 13, 2018 9:03:41 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 3/3] glsl: #undef THIS macro to fix MSVC build
THIS is a macro in one
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Friday, March 30, 2018 7:42 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] glapi: define GL_API to be GLAPI in glapi_dispatch.c
This fixes a Windows build warning
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, February 28, 2018 7:29 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: fix blending regression
The earlier Mesa commit 3d06c8afb5 ("st/mesa:
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Friday, February 16, 2018 12:59:28 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: replaced 'unsigned' with proper enum types in shader code
---
s
Looks good.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, February 15, 2018 8:31:12 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: replace gotos with else clauses
Simple clean-up.
---
src
Looks good.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, February 14, 2018 6:57:21 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: call tgsi_scan_shader() for dummy shaders
If we fail to
For patch 2 and 3, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, February 14, 2018 1:15:14 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 3/3] svga: move duplicated code for setting fillmode/flatshade
>From: Brian Paul
>Sent: Wednesday, February 14, 2018 1:15 PM
>To: mesa-dev@lists.freedesktop.org
>Cc: Charmaine Lee; Neha Bhende
>Subject: [PATCH 1/3] svga: call tgsi_scan_shader() for dummy shaders
>If we fail to compile the normal VS or FS we fall back to a simple/
>dumm
For the series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Tuesday, January 30, 2018 7:36:43 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] st/mesa: whitespace, formatting fixes in
st_glsl_to_tgsi.cpp
For this series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Tuesday, January 30, 2018 7:36:27 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] svga: use opcode local var to simplify some code
---
src
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, January 25, 2018 10:38:51 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: s/Bool/SVGA3dBool/ in SVGA3dDevCapResult
And fix whitespace. To sync up
For the series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, January 25, 2018 8:48:00 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Charmaine Lee; Roland Scheidegger
Subject: [PATCH 3/3] mesa: whitespace fixes in varray.h
Looks good.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, December 28, 2017 11:09:34 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Charmaine Lee
Subject: [PATCH] svga: update SVGA_NEW_ flags for updating sampler state
The
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, December 28, 2017 8:19:24 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: check for null fs pointer in update_samplers()
This can happen when
For this series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Sunday, December 24, 2017 2:40:28 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] svga: use tgsi_util_get_shadow_ref_src_index() in a couple
For the series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Saturday, December 23, 2017 9:13:47 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] svga: fix TGSI_TEXTURE_SHADOW1D coordinate selection
Fixes
Series looks good.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, December 7, 2017 2:25:05 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende; Roland Scheidegger
Subject: [PATCH 2/2] gallium/util: don't p
Series looks good.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Tuesday, November 21, 2017 6:33:22 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] svga: move svga_is_format_supported() to svga_format.c
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Friday, November 17, 2017 2:40:01 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende; Roland Scheidegger
Subject: [PATCH] tgsi: bump tgsi_opcode_info::output_mode size to 4 bits
To
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, November 16, 2017 3:36:15 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: add missing PIPE_SHADER_CAP_MAX_HW_ATOMIC_COUNTER* cases
---
src/gallium
>From: Brian Paul
>Sent: Tuesday, November 14, 2017 3:42 PM
>To: mesa-dev@lists.freedesktop.org
>Cc: Charmaine Lee; Neha Bhende
>Subject: [PATCH 1/2] tgsi: s/unsigned/enum tgsi_texture_type/
...
>diff --git a/src/gallium/auxiliary/tgsi/tgsi_util.h
>b/src/gallium/auxil
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Friday, November 10, 2017 6:40:26 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee
Subject: [PATCH] svga: issue debug warning for unsupported two-sided stencil
state
We only have a single
Reviewed-by; Charmaine Lee
From: Brian Paul
Sent: Thursday, November 9, 2017 11:31:16 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee
Subject: [PATCH] st/mesa: remove 'struct' keyword on function parameter
st_src_reg is a class, no
For this series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, November 9, 2017 11:31:42 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee
Subject: [PATCH 3/3] mesa: s/GLint/gl_buffer_index/ for _ColorDrawBufferIndexes
Also fix
For this series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Monday, November 6, 2017 1:00:30 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee
Subject: [PATCH 1/2] st/mesa: use enum types instead of int/unsigned
Use the proper enum types
Nice catch.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, November 1, 2017 7:45:29 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee
Subject: [PATCH] gallium: increase pipe_sampler_view::target bitfield size for
MSVC
MSVC treats
For the series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Tuesday, October 3, 2017 1:04:16 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 4/4] util: include string.h in u_string.h
To fix MinGW compiler
Reviewed-by: Charmaine Lee
> On Sep 3, 2017, at 10:13 PM, Tapani Pälli wrote:
>
> incompatible pointer to integer conversion assigning to 'GLintptr' (aka 'int')
> from 'const char *' [-Werror,-Wint-conversion]
>
> offset = indices;
&g
Instead of saving primitive offset in the minmax cache key,
save the actual buffer offset which is used in the cache lookup.
Fixes rendering artifact seen with GoogleEarth when run with
VMware driver.
v2: Per Brian's comment, initialize offset to avoid compiler warning.
Cc: mesa-sta...@lists.fre
Instead of saving primitive offset in the minmax cache key,
save the actual buffer offset which is used in the cache lookup.
Fixes rendering artifact seen with GoogleEarth when run with
VMware driver.
---
src/mesa/vbo/vbo_minmax_index.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, August 30, 2017 10:16:05 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: include sample count in surface_size() computation
Use MAX2() because
Looks good. Thanks.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Tuesday, August 22, 2017 1:21:56 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] vbo: fix glVertexAttrib(index=0)
Depending on which extension
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Monday, August 21, 2017 11:55 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: replace gotos with conditionals in array drawing code
No Piglit regressions
Change looks good.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, August 2, 2017 8:30 PM
To: Bruce Cherniak; mesa-dev@lists.freedesktop.org
Cc: 17 . 2; Charmaine Lee
Subject: Re: [Mesa-stable] [PATCH] st/mesa: add osmesa framebuffer iface
Fixes: bbc29393d3beaf6344c7188547b4ff61b63946ae
Tested-by: Christoph Haag
---
src/mesa/state_tracker/st_manager.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/state_tracker/st_manager.c
b/src/mesa/state_tracker/st_manager.c
index 834bcc9..6447403 100644
--- a/src/
>From: James Legg
>Sent: Tuesday, July 25, 2017 6:24 AM
>To: mesa-dev@lists.freedesktop.org; Charmaine Lee
>Subject: Re: [Mesa-dev] [PATCH] st/mesa: create framebuffer iface hash table
>per st manager
>On Sun, 2017-07-23 at 16:37 -0700, Charmaine Lee wrote:
>> With
Hi Marek,
I have pushed the fix for Steam. Commit bbc29393d3beaf6344c7188547b4ff61b63946ae
should fix the problem. Can you please try?
-Charmaine
From: Marek Olšák
Sent: Monday, July 24, 2017 3:16:07 PM
To: Charmaine Lee
Cc: Christoph Haag; mesa-dev
>From: Brian Paul
>Sent: Saturday, July 22, 2017 12:24 PM
>To: mesa-dev@lists.freedesktop.org
>Cc: Charmaine Lee; Neha Bhende
>Subject: [PATCH 2/2] svga: implement MSAA alpha_to_one feature
>The device doesn't directly support this feature so we implement it with
>ad
With this patch, framebuffer interface hash table is created
per state tracker manager.
Fixes crash with steam.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101876
Fixes: 5124bf98239 ("st/mesa: add destroy_drawable interface")
Tested-by: Christoph Haag
---
src/gallium/include/state_tr
799a1d3 in __libc_start_main () from /usr/lib32/libc.so.6
No symbol table info available.
#23 0x5662d159 in _start ()
No symbol table info available.
On 20.07.2017 20:26, Charmaine Lee wrote:
> With this patch, the st manager will maintain a hash table for
> the active framebuffer inte
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, July 20, 2017 1:54 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: only support 4x, 8x, 16x msaa
Skip 2x MSAA, for example, since it's seldom
With this patch, the st manager will maintain a hash table for
the active framebuffer interface objects. A destroy_drawable interface
is added to allow the state tracker to notify the st manager to remove
the associated framebuffer interface object from the hash table,
so the associated framebuffer
Fixes piglit test crash when context creation fails.
v2: As suggested by Brian, move the init to st_create_context_priv()
---
src/mesa/state_tracker/st_context.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/state_tracker/st_context.c
b/src/mesa/state_tracker
Fixes piglit test crash when context creation fails.
---
src/mesa/state_tracker/st_context.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/state_tracker/st_context.c
b/src/mesa/state_tracker/st_context.c
index 560d94e..8eccad6 100644
--- a/src/mesa/state_track
Reviewed-by: Charmaine Lee
From: Lucas Stach
Sent: Thursday, July 13, 2017 10:01 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Brian Paul
Subject: [PATCH] st/mesa: handle stfbi being NULL on entry of
st_framebuffer_reuse_or_create
Apparently
Reviewed-by: Charmaine Lee
From: Michel Dänzer
Sent: Thursday, July 13, 2017 12:21 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Brian Paul
Subject: [PATCH] st/mesa: Handle st_framebuffer_create returning NULL
From: Michel Dänzer
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, July 12, 2017 9:28 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] draw: s/unsigned/enum tgsi_semantic/
---
src/gallium/auxiliary/draw
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, July 12, 2017 9:28 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: move comment, declaration in
svga_init_shader_key_common()
put the comment
Looks good. Thanks for the quick fix.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Tuesday, July 11, 2017 2:02 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: fix texture swizzle writemasking
Commit
Commit a5e733c6b52e93de3000647d075f5ca2f55fcb71 fixes the dangling
framebuffer object by unreferencing the window system draw/read buffers
when context is released. However this can prematurely destroy the
resources associated with these window system buffers. The problem is
reproducible with Turbi
Series looks good.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Monday, July 10, 2017 2:50:25 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 5/5] svga: s/unsigned/enum tgsi_texture_type/
---
src/gallium
Reviewed-by :Charmaine Lee
From: Brian Paul
Sent: Monday, July 10, 2017 7:40 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; mesa-sta...@lists.freedesktop.org
Subject: [PATCH] svga: fix PIPE_CAP_MAX_TEXTURE_BUFFER_SIZE value
This query is
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Sunday, July 9, 2017 1:00 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee
Subject: [PATCH] svga: fix breakage in create_backed_surface_view()
This fixes a regression in some piglit tests since
>From: Brian Paul
>Sent: Friday, July 7, 2017 7:10 AM
>To: mesa-dev@lists.freedesktop.org
>Cc: Charmaine Lee; Neha Bhende; Olivier Lauffenburger
>Subject: [PATCH 2/2] mesa: finish implementing glPrimitiveRestartNV() for
>display lists
>If we try to build a dis
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, July 5, 2017 7:56 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: adjust line subpixel position for HWv8
This fixes two regressions on HWv8
Series looks good.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Friday, July 7, 2017 7:11 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 3/3] vbo: rename target->index in loopback code
Because it's
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Friday, July 7, 2017 7:11 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] st/mesa: remove unused st_framebuffer::Private field
---
src/mesa/state_tracker
st_texture_object(texObj)->pt);
>+ level = texImage->Level + texObj->MinLevel;
>+ box.z += texObj->MinLayer;
> }
>+ else {
>+ /* Texture level sizes may be inconsistent. We my have "loose",
>+ * per-image gallium resources. The texImage->Level may not match
>+ * the gallium resource texture level.
>+ */
>+ level = find_mipmap_level(texImage, pt);
>+ }
>+
>+ assert(level <= pt->last_level);
> pipe->clear_texture(pipe, pt, level, &box, clearValue ? clearValue
>: zeros);
> }
>--
>1.9.1
Series looks good to me.
Reviewed-by: Charmaine Lee
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>From: Brian Paul
>Sent: Sunday, July 2, 2017 8:12 AM
>To: mesa-dev@lists.freedesktop.org
>Cc: Charmaine Lee
>Subject: [PATCH 1/4] svga: fix buffer binding flags initialization
>If a buffer is created/initialized with glNamedBufferData we will
>have no target (GL_ARRAY_BUFF
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Sunday, July 2, 2017 8:07 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee
Subject: [PATCH] wglcontext: assorted updates
Print context flags, vendor, renderer strings.
Default to not setting the
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, June 28, 2017 3:13 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: add texture size/levels sanity check code in
svga_texture_create()
The state
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Friday, June 16, 2017 12:21 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: add some missing SVGA_STATS_* enum values, prefix strings
To fix the build when
For the series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, June 15, 2017 10:42:00 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] draw: check for line_width != 1.0f in validate_pipeline()
We
Looks great.
For the series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, May 3, 2017 12:49:40 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] wglgears: fix up wglChoosePixelFormatARB() attribute
Series looks good. One typo below:
>From: Brian Paul
>Sent: Thursday, April 27, 2017 10:19 AM
>To: mesa-dev@lists.freedesktop.org
>Cc: Charmaine Lee; Neha Bhende
>Subject: [PATCH 1/2] wglgears.c: add -srgb option
>To test sRGB pixel format selection and sRGB renderi
Looks good to me.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, April 6, 2017 11:49 AM
To: mesa-dev@lists.freedesktop.org
Cc: Jose Fonseca; Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: remove pre-SVGA3D_HWVERSION_WS8_B1 code
3D
Change series looks good.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, March 1, 2017 6:45:54 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] svga: fix crash regression since e027935a795
During
When st_context_flush() is called with ST_FLUSH_WAIT,
the function will return after the fence is completed.
---
src/gallium/include/state_tracker/st_api.h | 1 +
src/mesa/state_tracker/st_manager.c| 7 +++
2 files changed, 8 insertions(+)
diff --git a/src/gallium/include/state_tracke
Before releasing a shared context, flush the context
with ST_FLUSH_WAIT to make sure all commands are executed.
This ensures that rendering to any shared resources is completed
before they will be referenced by another context.
Fixes an intermittent flickering with Photoshop. (VMware bug# 1779340)
Series tested with vmware svga driver. Changes looks good.
Tested-by: Charmaine Lee
From: mesa-dev on behalf of Marek
Olšák
Sent: Wednesday, February 8, 2017 4:11:01 PM
To: mesa-dev@lists.freedesktop.org
Subject: [Mesa-dev] [PATCH 00/11] Gallium
>From: Rob Clark
>On Wed, Dec 21, 2016 at 12:32 PM, Charmaine Lee wrote:
>>
>> Hi Rob,
>>
>> Your mesa commit a5e733c mesa: drop current draw/read buffer when ctx is
>> released
>> is causing rendering issue when running with vmware svga driver.
>
Change looks fine to me. Thanks.
Reviewed-by: Charmaine Lee
From: Roland Scheidegger
Sent: Tuesday, December 13, 2016 10:38 AM
To: Edward O'Callaghan; mesa-dev@lists.freedesktop.org
Cc: Brian Paul; Charmaine Lee
Subject: Re: [Mesa-dev] [PATCH v
This patch deletes those fragment shaders in util_blitter_destroy().
---
src/gallium/auxiliary/util/u_blitter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/util/u_blitter.c
b/src/gallium/auxiliary/util/u_blitter.c
index 98b5421..45dc033 100644
--- a/s
Fixes tgsi error introduced in commit 3817a7a. The error complains missing
swizzle component in the conversion string "UMIN TEMP[0], TEMP[0], IMM[0].x".
---
src/gallium/auxiliary/util/u_simple_shaders.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/auxiliary/u
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, November 2, 2016 3:08 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee
Subject: [PATCH] gallium/hud: call fflush() after printing error messages
For Windows. Otherwise, we don'
Series looks fine to me.
Some minor nit below.
Reviewed-by: Charmaine Lee
>From: Brian Paul
>Sent: Wednesday, October 19, 2016 3:07 PM
>To: mesa-dev@lists.freedesktop.org
>Cc: Charmaine Lee
>Subject: [PATCH 6/6] vbo: clean up with 'indent', whitespace fixes,
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Tuesday, October 18, 2016 9:36 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee
Subject: [PATCH] svga: minor code improvements in
svga_validate_pipe_sampler_view()
Use the 'texture' lo
Series looks good to me.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Friday, September 23, 2016 8:48 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee
Subject: [PATCH 8/8] st/mesa: small optimization in swizzle_swizzle()
Usually, there&#
>From: Brian Paul
>Sent: Friday, September 23, 2016 8:48 AM
>To: mesa-dev@lists.freedesktop.org
>Cc: Charmaine Lee
>Subject: [PATCH 1/8] svga: eliminate unneeded gotos in
>svga_validate_surface_view()
>---
> src/gallium/drivers/svga/svga_surface.c | 9 +++--
> 1
>From: Brian Paul
>Sent: Friday, September 23, 2016 8:48 AM
>To: mesa-dev@lists.freedesktop.org
>Cc: Charmaine Lee
>Subject: [PATCH 1/8] svga: eliminate unneeded gotos in
>svga_validate_surface_view()
>---
> src/gallium/drivers/svga/svga_surface.c | 9 +++--
> 1
For the series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, September 21, 2016 8:25 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee
Subject: [PATCH 2/2] svga: minor simplification in svga_validate_surface_view()
Get rid of
Looks good.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, September 15, 2016 8:34 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee
Subject: [PATCH] mesa: check for no matrix change in _mesa_LoadMatrixf()
Some apps issue redundant
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Monday, August 29, 2016 9:16:09 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Charmaine Lee
Subject: [PATCH] svga: s/unsigned/enum pipe_shader_type/
---
src/gallium/drivers/svga/svga_draw.c
Series looks good to me.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, August 17, 2016 7:40:13 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] svga: fix src/dst typo in
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Monday, August 15, 2016 3:43:22 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee
Subject: [PATCH] svga: remove incorrect buffer invalidation code
Fixes regression with team_fortress_2 trace.
This
1 - 100 of 148 matches
Mail list logo
