Re: [Mesa-dev] [PATCH 1/5] wayland-egl: allow shipping the library or not

2018-06-05 Thread Eric Engestrom
goal is to remove the Mesa copies, but with this patch we > allow builders to explicitly select if they want it. > > Note: since the header (wayland-egl-backend.h) is now used by C++ > people, s/private/driver_private/ was applied. > > Cc: Eric Engestrom > CC

Re: [Mesa-dev] [PATCH 5/5] travis: bump the wayland version to 1.15.0

2018-06-05 Thread Eric Engestrom
On Tuesday, 2018-06-05 15:14:34 +0100, Emil Velikov wrote: > From: Emil Velikov > > As covered earlier - this is the version which ships > wayland-egl{,-backend} and associated files. > > Signed-off-by: Emil Velikov > --- > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

[Mesa-dev] [PATCH mesa] travis: use correct form for array options

2018-06-05 Thread Eric Engestrom
I'd like to eventually drop support for the confusing "an array of a single empty string is meant to be interpreted as an empty array", so let's start by not using it anymore. Signed-off-by: Eric Engestrom --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[Mesa-dev] [PATCH mesa] autotools: add missing android file to package

2018-06-04 Thread Eric Engestrom
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=106779 Fixes: ff904978a1d299a36b587 "gallium/util: Android backtrace support" Signed-off-by: Eric Engestrom --- src/gallium/auxiliary/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/Makefile.am b/s

Re: [Mesa-dev] [PATCH mesa 1/3] egl: rewire the build systems to use libwayland-egl

2018-06-04 Thread Eric Engestrom
On Monday, 2018-06-04 09:15:06 -0700, Matt Turner wrote: > On Thu, May 31, 2018 at 10:22 AM, Emil Velikov > wrote: > > On 29 May 2018 at 15:41, Eric Engestrom wrote: > >> Cc: Emil Velikov > >> Cc: Daniel Stone > >> Signed-off-by: Eric Engestrom > &g

[Mesa-dev] [PATCH mesa] configure: radv depends on mako

2018-06-04 Thread Eric Engestrom
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=106784 Fixes: 17201a2eb0b1b85387136 "radv: port to using updated anv entrypoint/extension generator." Signed-off-by: Eric Engestrom --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/co

[Mesa-dev] [PATCH mesa] meson: fix platforms check for `-D egl=true`

2018-06-04 Thread Eric Engestrom
Fixes: 0ed6a87a106b6e2266e0 "meson: fix platforms=[]" Reported-by: Christoph Haag Signed-off-by: Eric Engestrom --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 7b7c118d77b11cc38f7b..1d1b2a979b1de80ddd06 100644 --- a/m

Re: [Mesa-dev] [PATCH mesa 3/5] bin: rewrite get_reviewers as opt-in only

2018-06-01 Thread Eric Engestrom
On Thursday, 2018-05-31 10:04:25 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-05-31 07:04:33) > > Some people have mentioned they don't like the current get_reviewers.pl > > script (the one from the kernel) because it is way too greedy in its > > search for r

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

2018-06-01 Thread Eric Engestrom
On Friday, 2018-06-01 11:16:29 +0100, Daniel Stone wrote: > On 1 June 2018 at 11:10, Eric Engestrom wrote: > > On Thursday, 2018-05-31 14:59:58 -0700, Jason Ekstrand wrote: > >> If you could deal with Daniel's feedback and v3 just this patch sooner > >> rather than

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

2018-06-01 Thread Eric Engestrom
On Thursday, 2018-05-31 14:59:58 -0700, Jason Ekstrand wrote: > If you could deal with Daniel's feedback and v3 just this patch sooner > rather than later, that would be good. I'd like to merge it before we > switch to gitlab so we can start using gitlab CI artifacts for the website > right away.

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

2018-06-01 Thread Eric Engestrom
On Friday, 2018-06-01 09:43:48 +0200, Juan A. Suarez Romero wrote: > On Thu, 2018-05-31 at 08:52 +0100, Daniel Stone wrote: > > Hi Laura, > > > > On 30 May 2018 at 23:53, Laura Ekstrand wrote: > > > @@ -0,0 +1,9 @@ > > > +pages: > > > + stage: deploy > > > + script: > > > + - mkdir .public

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-01 Thread Eric Engestrom
On Thursday, 2018-05-31 21:33:16 -0400, mesa-dev-boun...@lists.freedesktop.org wrote: > On Thu, May 31, 2018 at 8:31 PM, Jordan Justen > wrote: > > On 2018-05-31 16:06:13, Laura Ekstrand wrote: > >> A little bit of messing around this afternoon, led to this: > >> https://drive.google.com/file/d/1

Re: [Mesa-dev] [PATCH 06/16] docs: Add Sphinx configuration file.

2018-06-01 Thread Eric Engestrom
On Thursday, 2018-05-31 14:00:24 -0700, Dylan Baker wrote: > Quoting Laura Ekstrand (2018-05-24 17:27:09) > > From: Jean Hertel > > > > This tells Sphinx how to build our website from reStructured Text. > > > > Signed-off-by: Jean Hertel > > --- > > docs/conf.py | 162 > >

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-05-31 Thread Eric Engestrom
On Thursday, 2018-05-31 16:57:17 +0100, Daniel Stone wrote: > Hi Juan, > Thanks for picking this up! > > On 31 May 2018 at 16:44, Juan A. Suarez Romero wrote: > > @@ -255,6 +257,12 @@ dri2_wl_create_window_surface(_EGLDriver *drv, > > _EGLDisplay *disp, > >goto cleanup_surf; > > } >

Re: [Mesa-dev] [PATCH mesa] anv: return true only if all the writes succeed, not just the last one

2018-05-31 Thread Eric Engestrom
op it as it's not really important as it turns out there isn't any actual bug :] > > On Tue, May 29, 2018 at 9:12 AM, Eric Engestrom > wrote: > > > Signed-off-by: Eric Engestrom > > --- > > src/intel/vulkan/anv_pipeline_cache.c | 38 +--

[Mesa-dev] [PATCH mesa 5/5] scripts: remove old get_reviewers.pl

2018-05-31 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Note: I don't expect to land this patch any time soon, but it's part of this patch series :) --- scripts/get_reviewer.pl | 2301 --- 1 file changed, 2301 deletions(-) delete mode 100755 scripts/get_reviewer.pl di

[Mesa-dev] [PATCH mesa 4/5] REVIEWERS: add added/deleted files to the build systems review groups

2018-05-31 Thread Eric Engestrom
This will notify build systems maintainers when files are added or deleted, so that they can make sure their build systems are updated accordingly. Cc: Dylan Baker Cc: Emil Velikov Cc: Rob Herring Signed-off-by: Eric Engestrom --- REVIEWERS | 4 1 file changed, 4 insertions(+) diff

[Mesa-dev] [PATCH mesa 3/5] bin: rewrite get_reviewers as opt-in only

2018-05-31 Thread Eric Engestrom
wer.py To reiterate, this script is now opt-in only, as it only returns reviewers added in REVIEWERS. Signed-off-by: Eric Engestrom --- As a quirk that I decided to leave in, "F: /dev/null" can now be used to subscribe to files being added or deleted, which I'm thinking of adding to the

[Mesa-dev] [PATCH mesa 2/5] REVIEWERS: drop unused N: entry comment

2018-05-31 Thread Eric Engestrom
It is currently unused in Mesa, and the new script (see next patch) will not support it. Signed-off-by: Eric Engestrom --- REVIEWERS | 8 1 file changed, 8 deletions(-) diff --git a/REVIEWERS b/REVIEWERS index beece0a7ae8c315b6ddb..44176d7cb0a95d101756 100644 --- a/REVIEWERS +++ b

[Mesa-dev] [PATCH mesa 1/5] REVIEWERS: add root meson.build to the Meson reviewers group

2018-05-31 Thread Eric Engestrom
Cc: Dylan Baker Signed-off-by: Eric Engestrom --- REVIEWERS | 1 + 1 file changed, 1 insertion(+) diff --git a/REVIEWERS b/REVIEWERS index 638b8b71b5af3ebd4efa..beece0a7ae8c315b6ddb 100644 --- a/REVIEWERS +++ b/REVIEWERS @@ -116,6 +116,7 @@ MESON BUILD R: Dylan Baker R: Eric Engestrom F

Re: [Mesa-dev] [PATCH v2 10/15] docs: Add toctree to relnotes

2018-05-31 Thread Eric Engestrom
On Wednesday, 2018-05-30 15:53:22 -0700, Laura Ekstrand wrote: > From: Jean Hertel > > Toctree directives create automatically generated navigation sidebars. > This is the new relnotes sidebar. > --- > docs/relnotes.rst | 210 > ++ > 1 file ch

[Mesa-dev] [PATCH mesa] anv: return true only if all the writes succeed, not just the last one

2018-05-29 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_pipeline_cache.c | 38 +-- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/intel/vulkan/anv_pipeline_cache.c b/src/intel/vulkan/anv_pipeline_cache.c index 82551e9f81f293ecadbe

Re: [Mesa-dev] [PATCH] egl/x11: Move dri2_format_for_depth prototype.

2018-05-29 Thread Eric Engestrom
On Tuesday, 2018-05-29 16:34:48 +0100, Marathe, Yogesh wrote: > > -Original Message- > > From: Engestrom, Eric > > Sent: Tuesday, May 29, 2018 7:48 PM > > To: Marathe, Yogesh > > Cc: Vinson Lee ; Daniel Stone > > ; Emil Velikov ; E

[Mesa-dev] [PATCH mesa 3/3] docs: add note about moving to libwayland-egl in 18.2.0

2018-05-29 Thread Eric Engestrom
Cc: Emil Velikov Cc: Daniel Stone Cc: Andres Gomez Cc: Dylan Baker Signed-off-by: Eric Engestrom --- docs/relnotes/18.2.0.html | 8 1 file changed, 8 insertions(+) diff --git a/docs/relnotes/18.2.0.html b/docs/relnotes/18.2.0.html index 00b253c076fd0f5bef00..94bc17e0082ce6f22fa2

[Mesa-dev] [PATCH mesa 1/3] egl: rewire the build systems to use libwayland-egl

2018-05-29 Thread Eric Engestrom
Cc: Emil Velikov Cc: Daniel Stone Signed-off-by: Eric Engestrom --- A couple things worth mentioning: - I chose to add libwayland-egl as a separate dependency for EGL rather than bumping the libwayland required version, so that old libwayland can still be used if EGL is not needed. I&#

[Mesa-dev] [PATCH mesa 2/3] egl: remove wayland-egl now that we're using libwayland-egl

2018-05-29 Thread Eric Engestrom
Cc: Emil Velikov Cc: Daniel Stone Signed-off-by: Eric Engestrom --- src/egl/wayland/wayland-egl/Makefile.am | 24 -- src/egl/wayland/wayland-egl/meson.build | 50 .../wayland-egl/wayland-egl-abi-check.c | 235 -- .../wayland/wayland-egl/wayland-egl

Re: [Mesa-dev] [PATCH] egl/x11: Move dri2_format_for_depth prototype.

2018-05-29 Thread Eric Engestrom
ngestrom, Eric > > Cc: Daniel Stone ; Emil Velikov > > ; Eric Engestrom ; Marathe, > > Yogesh ; ML mesa-dev > d...@lists.freedesktop.org> > > Subject: Re: [Mesa-dev] [PATCH] egl/x11: Move dri2_format_for_depth > > prototype. > > > > On Fri, May 25, 20

Re: [Mesa-dev] [PATCH] pkgconfig: Fix gl.pc when glvnd is enabled

2018-05-29 Thread Eric Engestrom
t/tree/trunk/0001-glvnd-fix-gl.pc.patch?h=packages/mesa > > Signed-off-by: Adam Jackson Acked-by: Eric Engestrom Tested-by: Eric Engestrom > --- > src/mesa/gl.pc.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/gl.pc.in b/src/mesa/

Re: [Mesa-dev] [PATCH] egl/x11: Move dri2_format_for_depth prototype.

2018-05-25 Thread Eric Engestrom
On Friday, 2018-05-25 16:06:26 +0100, Eric Engestrom wrote: > On Friday, 2018-05-25 06:52:25 +, Vinson Lee wrote: > > Fix build error without DRI3. > > D'uh! > I forgot building dri3 was optional, sorry :/ > > Reviewed-by: Eric Engestrom Actually, wait no,

Re: [Mesa-dev] [PATCH v2 1/2] util/u_math: Implement a logbase2 function for unsigned long

2018-05-25 Thread Eric Engestrom
On Thursday, 2018-05-24 11:47:52 +0200, Karol Herbst wrote: > From: Pierre Moreau > > v2 (Karol Herbst ): > * removed unneeded ll > * ll -> ull Reviewed-by: Eric Engestrom > > Signed-off-by: Karol Herbst > --- > src/gallium/auxiliary/util/u_math.h | 55 ++

Re: [Mesa-dev] [PATCH] egl/x11: Move dri2_format_for_depth prototype.

2018-05-25 Thread Eric Engestrom
On Friday, 2018-05-25 06:52:25 +, Vinson Lee wrote: > Fix build error without DRI3. D'uh! I forgot building dri3 was optional, sorry :/ Reviewed-by: Eric Engestrom > > CC drivers/dri2/platform_x11.lo > drivers/dri2/platform_x11.c:1010:1: error: no previous proto

Re: [Mesa-dev] [PATCH 16/16] docs: Remove unneeded mesa css file.

2018-05-25 Thread Eric Engestrom
tart using gitlab :) For patch 1 (the yaml file), with or without my comment (can be done later), patch 2 (the python conversion script, which btw I guess we should probably delete once the conversion is done), patch 7 (the sphinx-build yml line), and 12-16 are: Reviewed-by: Eric Engestrom Th

Re: [Mesa-dev] [PATCH 15/16] docs: Human edits to the website code for clarity.

2018-05-25 Thread Eric Engestrom
On Thursday, 2018-05-24 17:27:18 -0700, Laura Ekstrand wrote: > There's a lot here. If you're interested, it's mostly whitespace fixes, > switching variable names and function names to the Sphinx orange variable > highlight style, and naming code blocks to take advantage of Pygments > syntax highl

Re: [Mesa-dev] [PATCH 12/16] docs: Fix Sphinx compile errors.

2018-05-25 Thread Eric Engestrom
On Thursday, 2018-05-24 17:27:15 -0700, Laura Ekstrand wrote: > This just involves some quick fixes to formatting of the affected pages. > --- > docs/autoconf.rst| 1 + > docs/conf.py | 2 +- > docs/dispatch.rst| 72 > ++--

Re: [Mesa-dev] [PATCH 02/16] docs: Add python script that converts html to rst.

2018-05-25 Thread Eric Engestrom
On Thursday, 2018-05-24 17:27:05 -0700, Laura Ekstrand wrote: > Use Beautiful Soup to fix bad html, then use pandoc for converting to > rst. > --- > docs/rstConverter.py | 23 +++ > 1 file changed, 23 insertions(+) > create mode 100755 docs/rstConverter.py > > diff --git a/do

Re: [Mesa-dev] [PATCH 01/16] Added ci yaml file for Gitlab.

2018-05-25 Thread Eric Engestrom
On Thursday, 2018-05-24 17:27:04 -0700, Laura Ekstrand wrote: > For now, all this does is copy our current webpage into a public folder. > Daniel Stone has the server configured to check this public folder and > host the index.html as mesa-test.freedesktop.org. When this patch series > is approved,

[Mesa-dev] [PATCH mesa 2/2] egl: remove unused include

2018-05-23 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/main/egldefines.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/egl/main/egldefines.h b/src/egl/main/egldefines.h index d0502f33091a9ecb06bd..c925e0ca55338f73dbec 100644 --- a/src/egl/main/egldefines.h +++ b/src/egl/main/egldefines.h @@ -34,8

[Mesa-dev] [PATCH mesa 1/2] egl: add missing includes

2018-05-23 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/egl_dri2.c | 1 + src/egl/main/eglapi.c | 2 ++ src/egl/main/eglapi.h | 1 + src/egl/main/eglglobals.c | 2 ++ src/egl/main/eglsurface.c | 2 ++ 5 files changed, 8 insertions(+) diff --git a/src/egl/drivers

[Mesa-dev] [PATCH mesa] docs/release-calendar: fix copy/paste typo

2018-05-23 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- docs/release-calendar.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/release-calendar.html b/docs/release-calendar.html index ba297532dc3172e36e60..28de47935b29bfcc2ceb 100644 --- a/docs/release-calendar.html +++ b/docs/release

[Mesa-dev] [PATCH mesa 3/3] docs: drop unnecessary out-of-frame target

2018-05-23 Thread Eric Engestrom
I'm guessing an earlier version of the website used to have the page contents in , but this isn't the case anymore so just drop the unnecessary `target="_main"` :) Signed-off-by: Eric Engestrom --- docs/viewperf.html | 21 + 1 file changed, 9 inserti

[Mesa-dev] [PATCH mesa 2/3] docs: fix various html tags mistakes

2018-05-23 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- docs/egl.html | 1 + docs/precompiled.html | 2 ++ docs/utilities.html | 2 +- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/egl.html b/docs/egl.html index 3d8a85b4e7eecb1c07a1..2bc8f2372728822c69d6 100644 --- a/docs/egl.html +++ b

[Mesa-dev] [PATCH mesa 1/3] docs: fix `<` & `>` used in html code

2018-05-23 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- docs/codingstyle.html | 4 ++-- docs/submittingpatches.html | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/codingstyle.html b/docs/codingstyle.html index 7e9f470a1005d39320e0..34acae27fe6846f06682 100644 --- a/docs

Re: [Mesa-dev] [PATCH 4/5] egl/wayland: Allow client->server format conversion for PRIME offload.

2018-05-23 Thread Eric Engestrom
On Wednesday, 2018-05-23 06:51:12 +0200, Mario Kleiner wrote: > On Mon, May 21, 2018 at 4:42 PM, Eric Engestrom > wrote: > > On Saturday, 2018-05-19 05:32:41 +0200, Mario Kleiner wrote: > >> Support PRIME render offload between a Wayland server gpu and a Wayland > >

Re: [Mesa-dev] [PATCH 1/2] util/u_math: Implement a logbase2 function for unsigned long

2018-05-23 Thread Eric Engestrom
;= 2ll; pos += 2ll; } > + if (n >= 1ll<< 1ll) { pos += 1ll; } ^^ `ll` is being added a bit too much (although it's harmless); for instance, in this function I believe this one is the only one that does anything, and technically only on the first li

Re: [Mesa-dev] [PATCH 3/3] docs/releasing: Add note about using a staging branch

2018-05-23 Thread Eric Engestrom
nch: > + > + > +git checkout X.Y > +git checkout -b X.Y-proposed > + > + > +This branch should be reported to any teams using a CI to track upcoming > stable Might be worth adding a section with a list of the CI teams and their contact person? Series (with typo fixes already

Re: [Mesa-dev] [PATCH v2 1/9] util: Add a virtual memory allocator

2018-05-23 Thread Eric Engestrom
On Wednesday, 2018-05-23 00:25:11 -0700, Jordan Justen wrote: > On 2018-05-22 14:52:28, Scott D Phillips wrote: > > From: Jason Ekstrand > > > > This is simple linear-walk first-fit allocator roughly based on the > > allocator in the radeon winsys code. This allocator has two primary > > functio

[Mesa-dev] [PATCH mesa] vulkan: don't free uninitialised memory

2018-05-22 Thread Eric Engestrom
The modifiers array hasn't been initialised by then, much less with data that would need freeing. Move the label after the loop to fix this. Signed-off-by: Eric Engestrom --- src/vulkan/wsi/wsi_common_x11.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/vulka

Re: [Mesa-dev] [PATCH mesa] i965: Check result of make_surface() for miptree_create

2018-05-22 Thread Eric Engestrom
On Monday, 2018-05-21 11:42:37 -0700, Ian Romanick wrote: > On 05/17/2018 05:05 AM, Eric Engestrom wrote: > > From: Andrea Azzarone > > > > Since make_surface() can fail we need to check the result before > > dereferencing it. > > > > Bug: https://githu

Re: [Mesa-dev] [PATCH 4/5] egl/wayland: Allow client->server format conversion for PRIME offload.

2018-05-21 Thread Eric Engestrom
On Saturday, 2018-05-19 05:32:41 +0200, Mario Kleiner wrote: > Support PRIME render offload between a Wayland server gpu and a Wayland > client gpu with different channel ordering for their color formats, > e.g., between Intel drivers which currently only support ARGB2101010 > and XRGB2101010 impor

Re: [Mesa-dev] [PATCH 3/5] egl/x11: Handle both depth 30 formats for eglCreateImage(). (v3)

2018-05-21 Thread Eric Engestrom
> + if (visual_iter.rem) > + return visual_iter.data; > + } > + > + return NULL; > +} > + > +/* Get red channel mask for given depth. */ > +unsigned int > +dri2_x11_get_red_mask_for_depth(struct dri2_egl_display *dri2_dpy, int depth) > +

[Mesa-dev] [PATCH mesa 1/2] dri: fix error value returned by driGLFormatToImageFormat()

2018-05-18 Thread Eric Engestrom
0 is not a valid value for the __DRI_IMAGE_FORMAT_* enum. It is, however, the value of MESA_FORMAT_NONE, which two of the callers (i915 & i965) checked for. The other callers (that check for errors, ie. st/dri) already check for __DRI_IMAGE_FORMAT_NONE. Signed-off-by: Eric Engestrom ---

[Mesa-dev] [PATCH mesa 2/2] dri: replace two-way switch case with a table lookup

2018-05-18 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/mesa/drivers/dri/common/dri_util.c | 142 + 1 file changed, 76 insertions(+), 66 deletions(-) diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c index 66c034819dc7956a1b7a

[Mesa-dev] [PATCH mesa] egl/x11: deduplicate depth-to-format logic

2018-05-18 Thread Eric Engestrom
Suggested-by: Emil Velikov Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/platform_x11.c | 35 ++-- src/egl/drivers/dri2/platform_x11_dri3.c | 21 ++ src/egl/drivers/dri2/platform_x11_dri3.h | 3 ++ 3 files changed, 26 insertions(+), 33 deletions

[Mesa-dev] [PATCH mesa] i965: Check result of make_surface() for miptree_create

2018-05-17 Thread Eric Engestrom
From: Andrea Azzarone Since make_surface() can fail we need to check the result before dereferencing it. Bug: https://github.com/mesa3d/mesa/pull/5 Bug: https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1760415 Reviewed-by: Eric Engestrom --- Andrea: We don't use github, I

Re: [Mesa-dev] [PATCH] autotools, meson: add tileset.h

2018-05-17 Thread Eric Engestrom
On Monday, 2018-05-14 11:05:34 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-05-14 06:09:59) > > > > Dylan, what do you think? Do we want to remove all the unnecessary > > files() from meson, or keep them to mirror what was needed by autotools? > > I'd

[Mesa-dev] [PATCH mesa v2 7/7] meson: remove "empty array"/"array of an empty string" confusion

2018-05-15 Thread Eric Engestrom
on by removing the empty-string option. Cc: Dylan Baker Cc: Eric Anholt Cc: Matt Turner Cc: Daniel Stone Cc: Jason Ekstrand Cc: Kenneth Graunke Signed-off-by: Eric Engestrom --- The rest of the series can land independently of this patch v2: drop unnecessary code at the same time as we remove the

[Mesa-dev] [PATCH mesa v2 6/7] docs/meson: mention how to use array options

2018-05-15 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- docs/meson.html | 8 1 file changed, 8 insertions(+) diff --git a/docs/meson.html b/docs/meson.html index f394a22fc2a7d058828e..29907a60a9cb02975065 100644 --- a/docs/meson.html +++ b/docs/meson.html @@ -67,6 +67,14 @@ 1. Basic Usage meson

[Mesa-dev] [PATCH mesa v2 3/7] meson: fix vulkan-drivers=[]

2018-05-15 Thread Eric Engestrom
Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") Signed-off-by: Eric Engestrom --- v2: handle both `-D vulkan-drivers=[]` and `-D vulkan-drivers=` --- meson.build | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/meson.build b/meson.b

[Mesa-dev] [PATCH mesa v2 2/7] meson: fix gallium-drivers=[]

2018-05-15 Thread Eric Engestrom
Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") Signed-off-by: Eric Engestrom --- v2: handle both `-D gallium-drivers=[]` and `-D gallium-drivers=` --- meson.build | 66 - 1 file changed, 25 insertions(+), 41 deletion

[Mesa-dev] [PATCH mesa v2 1/7] meson: fix dri-drivers=[]

2018-05-15 Thread Eric Engestrom
Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") Signed-off-by: Eric Engestrom --- v2: handle both `-D dri-drivers=[]` and `-D dri-drivers=` --- meson.build | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/meson.build b/meson.b

[Mesa-dev] [PATCH mesa v2 5/7] meson: drop unused empty string array element

2018-05-15 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 7d3db81c887d82c6fe57..a8fd0980010babae8c9f 100644 --- a/meson.build +++ b/meson.build @@ -100,13 +100,13 @@ if _drivers.contains('auto'

[Mesa-dev] [PATCH mesa v2 4/7] meson: fix platforms=[]

2018-05-15 Thread Eric Engestrom
Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") Signed-off-by: Eric Engestrom --- v2: handle both `-D platforms=[]` and `-D platforms=` --- meson.build | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/meson.build b/meson.b

[Mesa-dev] [PATCH mesa 2/2] docs/meson: mention how to use array options

2018-05-14 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- docs/meson.html | 8 1 file changed, 8 insertions(+) diff --git a/docs/meson.html b/docs/meson.html index d05b5fe347b67bad9f8d..c260b703902083045e27 100644 --- a/docs/meson.html +++ b/docs/meson.html @@ -67,6 +67,14 @@ 1. Basic Usage meson

[Mesa-dev] [PATCH mesa 1/2] meson: remove "empty array"/"array of an empty string" confusion

2018-05-14 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- meson_options.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/meson_options.txt b/meson_options.txt index ce7d87f1ebd74a4ecc2c..b851f086a2b756142d8d 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -23,7 +23,7 @@ option

[Mesa-dev] [PATCH mesa 4/4] docs/meson: mark code/commands as

2018-05-14 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- docs/meson.html | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/docs/meson.html b/docs/meson.html index 009aebd817057f3e73da..29907a60a9cb02975065 100644 --- a/docs/meson.html +++ b/docs/meson.html @@ -33,7 +33,7 @@ 1

[Mesa-dev] [PATCH mesa 3/4] docs/meson: replace plaintext url with a link

2018-05-14 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- docs/meson.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/meson.html b/docs/meson.html index 3c0e3a168b1a706a99be..009aebd817057f3e73da 100644 --- a/docs/meson.html +++ b/docs/meson.html @@ -90,9 +90,9 @@ 1. Basic Usage

[Mesa-dev] [PATCH mesa 2/4] docs/meson: fix various html issues

2018-05-14 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- docs/meson.html | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/docs/meson.html b/docs/meson.html index 841a0d5b9d8d65b71da5..3c0e3a168b1a706a99be 100644 --- a/docs/meson.html +++ b/docs/meson.html @@ -95,6 +95,7 @@ 1. Basic Usage

[Mesa-dev] [PATCH mesa 1/4] docs/meson: fix various typos

2018-05-14 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- docs/meson.html | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/meson.html b/docs/meson.html index c260b703902083045e27..841a0d5b9d8d65b71da5 100644 --- a/docs/meson.html +++ b/docs/meson.html @@ -49,7 +49,7 @@ 1. Basic

Re: [Mesa-dev] [PATCH mesa 4/5] meson: fix platforms=[]

2018-05-14 Thread Eric Engestrom
On Friday, 2018-05-11 08:54:13 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-05-11 07:12:29) > > Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") > > Signed-off-by: Eric Engestrom > > --- > > meson.build | 26 +++-

Re: [Mesa-dev] [PATCH] autotools, meson: add tileset.h

2018-05-14 Thread Eric Engestrom
On Monday, 2018-05-14 16:02:02 +0200, Juan A. Suarez Romero wrote: > On Mon, 2018-05-14 at 14:09 +0100, Eric Engestrom wrote: > > On Monday, 2018-05-14 13:53:37 +0200, Juan A. Suarez Romero wrote: > > > Fixes: 4e52cb51b5 ("swr/rast: Thread locked tiles improvement")

Re: [Mesa-dev] [PATCH mesa 2/5] meson: fix gallium-drivers=[]

2018-05-14 Thread Eric Engestrom
On Friday, 2018-05-11 08:48:34 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-05-11 07:12:27) > > Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") > > Signed-off-by: Eric Engestrom > > --- > > meson.build | 73 +++

Re: [Mesa-dev] [PATCH] docs: add 18.0.5 in the release calendar

2018-05-14 Thread Eric Engestrom
On Monday, 2018-05-14 11:34:43 +0200, Juan A. Suarez Romero wrote: > Mesa 18.1 series has not been released yet, so let's extend 18.0 lifetime. > > CC: Andres Gomez > CC: Emil Velikov > --- > docs/release-calendar.html | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --gi

Re: [Mesa-dev] [PATCH] autotools, meson: add tileset.h

2018-05-14 Thread Eric Engestrom
@@ files_swr_arch = files( >'rasterizer/core/threads.h', >'rasterizer/core/tilemgr.cpp', >'rasterizer/core/tilemgr.h', > + 'rasterizer/core/tileset.h', Meson tracks #includes, so adding this is actually a noop, but for consistency let

[Mesa-dev] [PATCH mesa 4/5] meson: fix platforms=[]

2018-05-11 Thread Eric Engestrom
Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") Signed-off-by: Eric Engestrom --- meson.build | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/meson.build b/meson.build index a8999f37bd06a84cf7c0..5dd5168eb95dc823bbbe 10

[Mesa-dev] [PATCH mesa 3/5] meson: fix vulkan-drivers=[]

2018-05-11 Thread Eric Engestrom
Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") Signed-off-by: Eric Engestrom --- meson.build | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/meson.build b/meson.build index 6b069ae5dfc52adba1b7..a8999f37bd06a84cf7c0 100644 --- a/meson.b

[Mesa-dev] [PATCH mesa 5/5] meson: drop unused empty string array element

2018-05-11 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 5dd5168eb95dc823bbbe..bd48e343d30c1024c104 100644 --- a/meson.build +++ b/meson.build @@ -100,13 +100,13 @@ if _drivers.contains('auto'

[Mesa-dev] [PATCH mesa 2/5] meson: fix gallium-drivers=[]

2018-05-11 Thread Eric Engestrom
Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") Signed-off-by: Eric Engestrom --- meson.build | 73 +++-- 1 file changed, 32 insertions(+), 41 deletions(-) diff --git a/meson.build b/meson.build index afebfd2c65

[Mesa-dev] [PATCH mesa 0/5] meson: fix empty array options

2018-05-11 Thread Eric Engestrom
I'm guessing these were tested using `-D platforms=`, which actually sets the array to contain 1 element, an empty string. Rework the code to handle both that, and emptying the array (`-D platforms=[]`). Eric Engestrom (5): meson: fix dri-drivers=[] meson: fix gallium-drivers=[]

[Mesa-dev] [PATCH mesa 1/5] meson: fix dri-drivers=[]

2018-05-11 Thread Eric Engestrom
Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") Signed-off-by: Eric Engestrom --- meson.build | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/meson.build b/meson.build index e52b4a51093247bef95a..afebfd2c65fdb22dae29 10

Re: [Mesa-dev] meson: Fix build for egl platform_x11 with dri3

2018-05-11 Thread Eric Engestrom
rc/egl/drivers/dri2/egl_dri2.h:41:32: fatal error: loader_dri3_helper.h: > No such file or directory > > Cc: Dylan Baker > Signed-off-by: Ville Syrjälä Reviewed-by: Eric Engestrom > --- > src/egl/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a

[Mesa-dev] [PATCH mesa] meson: remove dependency antipattern

2018-05-11 Thread Eric Engestrom
recommended way to deal with non-existant dependency, but these don't work with `.found()`, so now the recommended way is to declare a impossible dependency, which null_dep does for us in Mesa. In short, we don't need and shouldn't check for `!= []` anywhere anymore. Signed-off-by:

Re: [Mesa-dev] [PATCH] meson: Set .so version for xa like autotools does

2018-04-05 Thread Eric Engestrom
On Wednesday, 2018-04-04 10:58:29 -0700, Dylan Baker wrote: > Fixes: 0ba909f0f111824223bc38563d1a6bc73e69c2cc >("meson: build gallium xa state tracker") > Signed-off-by: Dylan Baker Reviewed-by: Eric Engestrom > --- > src/gallium/targets/xa/meson.build | 4

Re: [Mesa-dev] [PATCH] meson: fix megadriver symlinking

2018-04-05 Thread Eric Engestrom
sktop.org/show_bug.cgi?id=105567 > Signed-off-by: Dylan Baker Been using that locally for a couple months: Reviewed-and-Tested-by: Eric Engestrom > --- > bin/install_megadrivers.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bin/install_megadriv

Re: [Mesa-dev] [PATCH 1/2] gallium/util: Don't stub u_debug_stack on Android

2018-03-29 Thread Eric Engestrom
D) /* Not implemented here; see u_debug_stack_android.cpp */ #else /* ! HAVE_LIBUNWIND */ But other than this, the series looks good to me :) This patch (preferably with the amendment I suggested) is: Reviewed-by: Eric Engestrom The other one is: Acked-by: Eric Engestrom (I don't kn

[Mesa-dev] [PATCH mesa 5/5] egl: add symbol checking script for the glvnd case

2018-03-28 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Am I reading it right [1], that no other symbol should be exposed? If so, we're not doing that and should fix it (before landing this patch). [1] https://github.com/NVIDIA/libglvnd/blob/f6d236e8dc8efbdf117fb3016d7815c96917a3e4/include/glvnd/libeglabi.h

[Mesa-dev] [PATCH mesa 4/5] gbm: use new symbols checking script

2018-03-28 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/gbm/Makefile.am | 1 + src/gbm/gbm-symbols-check | 20 ++-- 2 files changed, 7 insertions(+), 14 deletions(-) diff --git a/src/gbm/Makefile.am b/src/gbm/Makefile.am index 5097212cda0aa54fb57c..e22e72dec922367d73e2 100644 --- a/src/gbm

[Mesa-dev] [PATCH mesa 3/5] egl: use new symbols checking script

2018-03-28 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- This currently fails on my system (meson), haven't had time to investigate yet: New ABI detected - If intentional, update the test. wl_drm_interface zwp_linux_buffer_params_v1_interface zwp_linux_dmabuf_v1_interface A priori, these should only

[Mesa-dev] [PATCH mesa 2/5] gles: use new symbols checking script

2018-03-28 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- This will fail unless [1] lands first. [1] https://patchwork.freedesktop.org/patch/213409/ --- meson.build | 1 + src/mapi/Makefile.am | 1 + src/mapi/es1api/ABI-check | 22 -- src/mapi/es2api/ABI-check | 22

[Mesa-dev] [PATCH mesa 1/5] symbols-check: add new meta-script

2018-03-28 Thread Eric Engestrom
The next few commits will convert existing tests to use this. Signed-off-by: Eric Engestrom --- scripts/symbols-check | 68 +++ 1 file changed, 68 insertions(+) create mode 100755 scripts/symbols-check diff --git a/scripts/symbols-check b

[Mesa-dev] [PATCH mesa] u_endian: use non-underscore-prefixed BYTE_ORDER names

2018-03-28 Thread Eric Engestrom
Cc: Jonathan Gray Signed-off-by: Eric Engestrom --- Note: scons was already defining _DEFAULT_SOURCE --- Android.common.mk | 2 +- configure.ac| 2 +- meson.build | 1 + src/util/u_endian.h | 8 ++-- 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a

Re: [Mesa-dev] [PATCH 1/2] autotools: include meson_get_version

2018-03-28 Thread Eric Engestrom
42d10842 >("meson: Add script to use VERSION file for getting version") Both are Reviewed-by: Eric Engestrom > --- > Makefile.am | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Makefile.am b/Makefile.am > index 804b1d85353..a8

[Mesa-dev] [PATCH mesa] gles: remove entrypoint check that shouldn't be there

2018-03-28 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- If I understand the comment correctly, these should *not* be exposed, right? They aren't in any build I checked, and will cause the updated tests to fail if the check is left here. --- src/mapi/es1api/ABI-check | 3 --- src/mapi/es2api/ABI-check | 3 --- 2

[Mesa-dev] [PATCH mesa] docs: fix 18.0 release note version

2018-03-28 Thread Eric Engestrom
Fixes: 839fb3a696679bfe975c2 "docs: Update 18.0.0 release notes" Cc: "18.0" Cc: Emil Velikov Signed-off-by: Eric Engestrom --- docs/relnotes/18.0.0.html | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/relnotes/18.0.0.html b/docs/relnot

Re: [Mesa-dev] [PATCH mesa] meson/configure: detect endian.h instead of trying to guess when it's available

2018-03-28 Thread Eric Engestrom
On Wednesday, 2018-03-28 14:05:00 +1100, Jonathan Gray wrote: > On Tue, Mar 27, 2018 at 07:36:17PM +0100, Emil Velikov wrote: > > On 25 March 2018 at 09:06, Jonathan Gray wrote: > > > On Wed, Mar 21, 2018 at 05:09:17PM +0000, Eric Engestrom wrote: > > >> Cc: Maxi

[Mesa-dev] [PATCH mesa] gbm: remove never-implemented function

2018-03-26 Thread Eric Engestrom
I assume this was implemented in a previous version of that commit, but was removed in the version that actually landed. Fixes: 8430af5ebe1ee8119e14 "Add support for swrast to the DRM EGL platform" Cc: Giovanni Campagna Cc: Emil Velikov Signed-off-by: Eric Engestrom --- src/gbm/g

Re: [Mesa-dev] [PATCH] configure: use AC_CHECK_HEADERS to check for endian.h

2018-03-23 Thread Eric Engestrom
NC,HEADER} instances > with the plural version (or even the _ONCE suffixed version) and drop > the DEFINES hacks. > > Fixes: cbee1bfb342 ("meson/configure: detect endian.h instead of trying > to guess when it's available") > Cc: Eric Engestrom Acked-by: Eric Enge

[Mesa-dev] [PATCH mesa] meson: fix header check message

2018-03-23 Thread Eric Engestrom
before: Checking if "endian.h works" compiles: YES after: Checking if "endian.h" compiles: YES Signed-off-by: Eric Engestrom --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 28c403d2e1f939e56ccc..acc6688

Re: [Mesa-dev] [PATCH] fix gcc 8 parenthesis warning

2018-03-23 Thread Eric Engestrom
On Friday, 2018-03-23 08:09:46 -0700, Ian Romanick wrote: > On 03/23/2018 03:52 AM, Eric Engestrom wrote: > > On Friday, 2018-03-23 11:01:23 +0100, Marc Dietrich wrote: > >> fixes warnings like this: > >> [184/1137] Compiling C++ object > >> 'src/compiler/

Re: [Mesa-dev] [PATCH mesa] meson/configure: detect endian.h instead of trying to guess when it's available

2018-03-23 Thread Eric Engestrom
On Friday, 2018-03-23 09:33:39 +, Eric Engestrom wrote: > > > On March 23, 2018 9:21:25 AM UTC, "Tapani Pälli" > wrote: > > > > > > On 03/21/2018 08:55 PM, Eric Engestrom wrote: > > > > > > > > > On March 21, 2018

Re: [Mesa-dev] [PATCH] fix several maybe uninitialized variable errors

2018-03-23 Thread Eric Engestrom
On Friday, 2018-03-23 12:15:42 +0100, Marc Dietrich wrote: > Mostly false warnings, however AVX detection could have been problematic. Thanks, but could you split this into one patch per logical change? (In this case, that's one patch per file you changed) > > Signed-off-by: Marc Dietrich > ---

<    4   5   6   7   8   9   10   11   12   13   >