Re: [Mesa-dev] [PATCH 3/3] u_dynarray: turn util_dynarray_{grow, resize} into element-oriented macros

{ > + util_dynarray_fini(buf); > + return 0; > + } > + > + unsigned newsize = nelts * eltsize; > void *p = util_dynarray_ensure_cap(buf, newsize); > buf->size = newsize; > > return p; > } > > static inline void > util_dynarr

Re: [Mesa-dev] [PATCH v2 1/3] llvmpipe: add lp_fence_timedwait() helper

czw., 25 kwi 2019 o 20:11 Gustaw Smolarczyk napisał(a): > > czw., 25 kwi 2019 o 19:42 Emil Velikov napisał(a): > > > > The function is analogous to lp_fence_wait() while taking at timeout > > (ns) parameter, as needed for EGL fence/sync. > > > > v2: >

Re: [Mesa-dev] [PATCH v2 1/3] llvmpipe: add lp_fence_timedwait() helper

k(>mutex); > + assert(f->issued); > + while (f->count < f->rank) { > + ret = cnd_timedwait(>signalled, >mutex, ); > + if (ret != thrd_success) > + break; > + } > + mtx_unlock(>mutex); > + return (f->count >= f->rank &&am

Re: [Mesa-dev] [PATCH 1/3] llvmpipe: add lp_fence_timedwait() helper

wt., 16 kwi 2019 o 12:11 Emil Velikov napisał(a): > > On Thu, 11 Apr 2019 at 17:55, Gustaw Smolarczyk wrote: > > > > czw., 11 kwi 2019 o 18:06 Emil Velikov > > napisał(a): > > > > > > The function is analogous to lp_fence_wait() while taking at timeo

Re: [Mesa-dev] [PATCH 1/3] llvmpipe: add lp_fence_timedwait() helper

>mutex); > + assert(f->issued); > + while (f->count < f->rank) { > + ret = cnd_timedwait(>signalled, >mutex, ); Shouldn't ret be checked for thrd_busy here as well? Otherwise, the function will busy-wait after the timeout is reached instead of returning.

Re: [Mesa-dev] [PATCH] radv: fix compiler issues with GCC 9

FWIW, Reviewed-by: Gustaw Smolarczyk pon., 11 lut 2019 o 10:15 Samuel Pitoiset napisał(a): > > "The C standard says that compound literals which occur inside of > the body of a function have automatic storage duration associated > with the enclosing block. Older GCC rele

Re: [Mesa-dev] [PATCH 1.5/2] ac/surface/gfx9: let addrlib choose the preferred swizzle kind

sin.height = in->height; > sin.numSlices = in->numSlices; > sin.numMipLevels = in->numMipLevels; > sin.numSamples = in->numSamples; > sin.numFrags = in->numFrags; > > - if (flags & RADEON_SURF_SCANOUT) { Isn't the `fl

Re: [Mesa-dev] [PATCH 2/2] util/ralloc: Make sizeof(linear_header) a multiple of 8

alloc_child(void *parent, unsigned size) > > > ptr = (linear_size_chunk *)((char*)[1] + latest->offset); > > > ptr->size = size; > > > latest->offset += full_size; > > > + > > > + assert((uintptr_t)[1] % SUBALLOC_ALIGNMENT == 0); &g

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

śr., 31 paź 2018 o 00:23 Marek Olšák napisał(a): > > On Tue, Oct 30, 2018 at 7:11 PM Gustaw Smolarczyk > wrote: >> >> wt., 30 paź 2018 o 23:55 Marek Olšák napisał(a): >> > >> > On Tue, Oct 30, 2018 at 6:32 PM Gustaw Smolarczyk >> > wrote:

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

wt., 30 paź 2018 o 23:55 Marek Olšák napisał(a): > > On Tue, Oct 30, 2018 at 6:32 PM Gustaw Smolarczyk > wrote: >> >> wt., 30 paź 2018, 23:01 Marek Olšák : >>> >>> On Mon, Oct 29, 2018 at 12:43 PM Michel Dänzer wrote: >>>> >>>> On

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

wt., 30 paź 2018, 23:01 Marek Olšák : > On Mon, Oct 29, 2018 at 12:43 PM Michel Dänzer wrote: > >> On 2018-10-28 11:27 a.m., Gustaw Smolarczyk wrote: >> > pon., 17 wrz 2018 o 18:24 Michel Dänzer >> napisał(a): >> >> >> >> On 2018-09-15 3:04 a

Re: [Mesa-dev] [PATCH 02/14] vbo: Remove the VBO_SAFE_FALLBACK flag.

wt., 30 paź 2018, 06:08 : > From: Mathias Fröhlich > > On finishing a display list playback the VBO_SAFE_FALLBACK bit > s/SAFE/SAVE/g (here and in the title) Regards, Gustaw Smolarczyk is still kept in vbo_save_context::replay_flags. But examining > replay_flags and the dis

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

_ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev Hi, What was the conclusion of this discussion? I don't see any whitelist/blacklist for this feature. I have just tested b

Re: [Mesa-dev] [PATCH 3/3] radeonsi: add support for Raven2

radeonsi/si_pipe.c > @@ -1026,23 +1026,24 @@ struct pipe_screen *radeonsi_screen_create(struct > radeon_winsys *ws, > sscreen->has_msaa_sample_loc_bug = (sscreen->info.family >= > CHIP_POLARIS10 && > sscreen->

Re: [Mesa-dev] [PATCH] radv: check return from mkdir

ret == -1) > > if (ret == -1 && errno != EEXIST) ? Won't EEXIST be returned even in case the path already exists but is not a directory? [1] Regards, Gustaw Smolarczyk [1] http://man7.org/linux/man-pages/man2/mkdir.2.html > > > + return false; >

Re: [Mesa-dev] [PATCH] radv: fix descriptor pool allocation size

rPoolCreateInfo::pPoolSizes with a member equal to that type. What it implies (I think), is that VkDescriptorPoolCreateInfo::maxSets and descriptorCount of each VkDescriptorPoolCreateInfo::pPoolSizes are treated separately. I don't think you should multi

Re: [Mesa-dev] [PATCH v2] mesa: rotation of 0-vector

*/ > +optimized = GL_TRUE; > +/* rotate only around x-axis */ > +M(1,1) = c; > +M(2,2) = c; > +if (x < 0.0F) { Isn't x guaranteed to be 0.0F here? And I think you wanted to treat it as 1.0F in that case, so that (0, 0, 0)

Re: [Mesa-dev] [PATCH] mesa: add ff fragment shader support for geom and tess shaders

2018-06-18 11:19 GMT+02:00 Iago Toral : > On Mon, 2018-06-18 at 10:45 +0200, Gustaw Smolarczyk wrote: > > 2018-06-18 10:39 GMT+02:00 Iago Toral : > > > On Mon, 2018-06-18 at 09:43 +0200, Gustaw Smolarczyk wrote: > > > > 2018-06-18 4:39 GMT+02:00 Timothy Arcer

Re: [Mesa-dev] [PATCH] mesa: add ff fragment shader support for geom and tess shaders

2018-06-18 10:39 GMT+02:00 Iago Toral : > On Mon, 2018-06-18 at 09:43 +0200, Gustaw Smolarczyk wrote: > > 2018-06-18 4:39 GMT+02:00 Timothy Arceri : > > This is required for compatibility profile support. > --- > src/mesa/main/ff_fragment_shader.cpp | 6 +- > 1 fi

Re: [Mesa-dev] [PATCH] mesa: add ff fragment shader support for geom and tess shaders

when the vertex shader is missing (unless that was intended - I am not really familiar with how fixed function shaders work alongside new features). You could also move or update the comment that is just above your change. Regards, Gustaw Smolarczyk >vprog = ctx->_Shader->CurrentPr

Re: [Mesa-dev] [PATCH 07/16] radv: Implement VK_KHR_maintenance3.

ts. These have nothing to do with the pipeline. They > are > * just muttiple descriptor set layouts pasted together > diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c > index 00bb70612e..593cfc9a36 100644 > --- a/src/amd/vulkan/radv_device.c > +++ b/src/amd/vulkan/rad

Re: [Mesa-dev] [PATCH] r600/egd_tables.py: make the script python 2+3 compatible

lass StringTable: > > > > > """ > > > > > fragments = [ > > > > > '"%s\\0" /* %s */' % ( > > > > > -te[0].encode('string_escape'), > > > > > +

Re: [Mesa-dev] [PATCH] nir: remove the abs call in is_neg_power_of_two

tation of the resulting bits). And this also holds for INT_MIN, for example for 32-bit int, INT_MIN == -2^31 and -(unsigned)INT_MIN == (unsigned)INT_MIN == 2^31. In other words - by first converting to unsigned, we make any overflow happening during computation defined as wrapping, and we want the res

Re: [Mesa-dev] [PATCH 3/9] glsl/lower_64bit: extract non-64bit sources from vectors.

:ivec2_type; > + } else > + result_type = ir->type->get_scalar_type(); > > ir_factory body(, mem_ctx); > > for (unsigned i = 0; i < num_operands; i++) { > - expand_source(body, ir->operands[i], src[i]); > + if (ir->operands[i]->type->is_64bit())

Re: [Mesa-dev] [PATCH] st/mesa: expand glDrawPixels cache to handle multiple images

oldest_drawpixels_cache_entry(struct st_context *st) > > +{ > > + unsigned oldest_age = ~0u, oldest_index = ~0u; > > + unsigned i; > > + > > + /* Find entry with oldest (lowest) age */ > > + for (i = 0; i < ARRAY_SIZE(

Re: [Mesa-dev] DRI Configurator replacement announcement

2018-01-16 8:33 GMT+01:00 Gert Wollny : > Hello Jean, > > Am Montag, den 15.01.2018, 20:15 + schrieb Jean Hertel: > > I have written a simply application like DRI Conf tool. > > It is written using GTKmm and C++. > Great! > > Unfortunately, it didn't link properly, so I

Re: [Mesa-dev] [PATCH] ac: change legacy_surf_level::slice_size to dword units

2017-11-27 14:43 GMT+01:00 Marek Olšák : > On Mon, Nov 27, 2017 at 12:54 PM, Nicolai Hähnle > wrote: > > On 23.11.2017 20:35, Marek Olšák wrote: > >> > >> From: Marek Olšák > >> > >> The next commit will reduce the size even more. > >>

Re: [Mesa-dev] [PATCH] mesa: replace GLenum with GLenum16 in common structures

2017-11-14 15:04 GMT+01:00 Marek Olšák : > On Mon, Nov 13, 2017 at 10:19 PM, Ian Romanick wrote: >> On 11/08/2017 07:16 PM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> For lower CPU cache usage. All enums fit within 2 bytes. >> >>

Re: [Mesa-dev] [Mesa-stable] [PATCH] util/queue: fix a race condition in the fence code

2017-09-28 20:21 GMT+02:00 Nicolai Hähnle <nhaeh...@gmail.com>: > On 28.09.2017 19:18, Gustaw Smolarczyk wrote: >> >> 2017-09-28 18:52 GMT+02:00 Marek Olšák <mar...@gmail.com>: >>> >>> A clearer comment would be: "Don't destroy the fence when

Re: [Mesa-dev] [Mesa-stable] [PATCH] util/queue: fix a race condition in the fence code

2017-09-28 18:52 GMT+02:00 Marek Olšák : > A clearer comment would be: "Don't destroy the fence when it's in the > middle of util_queue_fence_signal (signalled but not unlocked yet > because util_queue_fence_is_signalled doesn't lock). Instead, wait > until

Re: [Mesa-dev] [PATCH 3/3] radeonsi: fix border color translation for integer textures

*_BLACK work). I don't know GL rules enough to judge that (whether 0.0 and -0.0 should be indistinguishable), but is that ok? Regards, Gustaw Smolarczyk ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] radv: do not use a bitfield when dirtying the vertex buffers

2017-09-06 15:53 GMT+02:00 Samuel Pitoiset : > Useless to track which one has been updated because we > re-upload all the vertex buffers in one shot. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 5 +++-- >

Re: [Mesa-dev] [PATCH v2] glsl: update the extensions that are enabled for 460

2017-08-02 20:57 GMT+02:00 Samuel Pitoiset : > Other ones are either unsupported or don't have any helper > function checks. > > v2: - fix ARB_shader_draw_parameters system value names > > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] AMD Tahiti: A question about PFP firmware

$ ./piglit run gpu -t arb_draw_indirect results/indirect --dmesg [12/12] pass: 11, fail: 1 Thank you for running Piglit! Results have been written to /home/bigos/src/piglit/results/indirect The only one failing is spec/arb_draw_indirect/arb_draw_indirect-draw-arrays-prim-restart. However, it is

[Mesa-dev] AMD Tahiti: A question about PFP firmware

Hello, While looking at the extension list on my Tahiti GPU (SI) I have found that ARB_draw_parameters is missing. Looking at the code, it requires ME firmware version >= 87 and PFP firmware version >= 121. While the first is satisfied, the second is not [1]. I believe I use the newest TAHITI

Re: [Mesa-dev] [PATCH v6 1/3] util: Add util_strlcpy

ert.f...@collabora.com> >> > --- >> > Changes since v5: >> >Actually include changes from v5 in patch >> > >> > Changes since v4: >> >Gustaw Smolarczyk <wielkie...@gmail.com> >> > - Make util_strlcpy have the

Re: [Mesa-dev] [PATCH v6 1/3] util: Add util_strlcpy

2017-07-05 8:57 GMT+02:00 Robert Foss <robert.f...@collabora.com>: > Add local strlcpy implementation. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- > Changes since v5: > Actually include changes from v5 in patch > > Changes sinc

Re: [Mesa-dev] [PATCH v4 1/3] util: Add util_strlcpy

4 lip 2017 14:25 "Robert Foss" napisał(a): Add local strlcpy implementation. Signed-off-by: Robert Foss --- Changes since v3: Matt Turner - Change name of util_strncpy to util_strlcpy Changes since v2: Brian

Re: [Mesa-dev] [PATCH v3 1/3] util: Add util_strncpy

2017-07-03 6:10 GMT+02:00 Robert Foss : > On Sun, 2017-07-02 at 21:06 -0700, Matt Turner wrote: >> Otherwise known as strlcpy()? > > I didn't realize this, a wrapper would be needed for all platformsou > that don't support it natively. > > Do you know which platforms

Re: [Mesa-dev] [PATCH v1 3/3] gallium/hud: Prevent buffer overflow in hud_thread_busy_install

2017-06-29 4:41 GMT+02:00 Robert Foss : > Switch to using strncopy to avoid potential overflow of > name array in struct hud_graph. > > Coverity-id: 1413760 > > Signed-off-by: Robert Foss > --- > src/gallium/auxiliary/hud/hud_cpu.c | 2 +- >

Re: [Mesa-dev] [PATCH] gallium/util: Allow pipe_resource_reference to be inlined again

2017-06-13 12:07 GMT+02:00 Michel Dänzer : > On 13/06/17 06:51 PM, Timothy Arceri wrote: >> On 13/06/17 19:22, Michel Dänzer wrote: >>> From: Michel Dänzer >>> >>> It calling itself recursively prevented it from being inlined, resulting >>> in a copy

Re: [Mesa-dev] [PATCH 10/21] mesa: add validate_depth_buffer() helper

Same problem as in the previous patch. Regards, Gustaw 1 cze 2017 15:07 "Samuel Pitoiset" napisał(a): Signed-off-by: Samuel Pitoiset --- src/mesa/main/blit.c | 105 +++--- - 1 file changed, 56

Re: [Mesa-dev] [PATCH 09/21] mesa: add validate_stencil_buffer() helper

This time, send it to the list too. Gustaw 1 cze 2017 15:45 "Gustaw Smolarczyk" <wielkie...@gmail.com> napisał(a): 1 cze 2017 15:07 "Samuel Pitoiset" <samuel.pitoi...@gmail.com> napisał(a): Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.c

Re: [Mesa-dev] [PATCH 14/16] anv: Advertise both 32-bit and 48-bit heaps when we have enough memory

2017-05-18 23:01 GMT+02:00 Jason Ekstrand : > --- > src/intel/vulkan/anv_device.c | 42 -- > 1 file changed, 36 insertions(+), 6 deletions(-) > > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > index

Re: [Mesa-dev] [PATCH 05/14] mesa/main/ff_frag: Don't bother with VARYING_BIT_FOGC.

2017-05-16 18:48 GMT+02:00 Ian Romanick <i...@freedesktop.org>: > On 05/15/2017 11:38 AM, Gustaw Smolarczyk wrote: >> 2017-05-15 20:28 GMT+02:00 Ian Romanick <i...@freedesktop.org>: >>> With this patch I applied, I still see this bit used in several >>> plac

Re: [Mesa-dev] [PATCH 05/14] mesa/main/ff_frag: Don't bother with VARYING_BIT_FOGC.

2017-05-15 20:28 GMT+02:00 Ian Romanick : > With this patch I applied, I still see this bit used in several > places, including the i915 driver. Did you test that? > > rc/compiler/shader_enums.h:#define VARYING_BIT_FOGC > BITFIELD64_BIT(VARYING_SLOT_FOGC) >

Re: [Mesa-dev] [PATCH 06/17] st/mesa: unify TCS, TES, GS st_*_program structures

2017-05-01 14:52 GMT+02:00 Marek Olšák : > From: Marek Olšák SNIP > > /** > * Derived from Mesa gl_program: > */ > -struct st_geometry_program > +struct st_common_program > { > struct gl_program Base; /**< The Mesa geometry program */ I think

Re: [Mesa-dev] [RFC PATCH 3/4] ff_fragment_shader: mark impossible switch values with unreachable

case I missed something. > > Cheers, > Nicolai > > >>} >> } >> >> @@ -579,9 +576,8 @@ emit_combine(texenv_fragment_program *p, >> case TEXENV_MODE_ADD_PRODUCTS_SIGNED_NV: >>return add(add(mul(src[0], src[1]), mul(src[2], src

Re: [Mesa-dev] [PATCH 00/14] Better Travis-CI integration, take 2

2017-04-21 14:08 GMT+02:00 Emil Velikov : > Note: GCC 5/6 crashes with internal compiler error at seemingly random > stages of the build. Unless any of the SWR devs sort it out, we might > want to disable it for now. > > A sample report can be seen at >

Re: [Mesa-dev] [PATCH 10/14] mesa/main: Maintain compressed fog mode.

2017-04-08 18:37 GMT+02:00 Marek Olšák <mar...@gmail.com>: > On Sat, Apr 8, 2017 at 12:53 AM, Gustaw Smolarczyk <wielkie...@gmail.com> > wrote: >> 2017-04-07 23:56 GMT+02:00 Marek Olšák <mar...@gmail.com>: >>> On Fri, Apr 7, 2017 at 6:54 PM, Gustaw Smola

Re: [Mesa-dev] [PATCH 10/14] mesa/main: Maintain compressed fog mode.

2017-04-07 23:56 GMT+02:00 Marek Olšák <mar...@gmail.com>: > On Fri, Apr 7, 2017 at 6:54 PM, Gustaw Smolarczyk <wielkie...@gmail.com> > wrote: >> 2017-04-07 16:31 GMT+02:00 Marek Olšák <mar...@gmail.com>: >>> On Thu, Mar 30, 2017 at 8:09 PM, Gustaw Smola

Re: [Mesa-dev] [PATCH 11/14] mesa/main: Maintain compressed TexEnv Combine state.

2017-04-07 16:40 GMT+02:00 Marek Olšák <mar...@gmail.com>: > On Fri, Apr 7, 2017 at 4:35 PM, Marek Olšák <mar...@gmail.com> wrote: >> On Thu, Mar 30, 2017 at 8:09 PM, Gustaw Smolarczyk <wielkie...@gmail.com> >> wrote: >>> Signed-off-by: Gustaw Smolarcz

Re: [Mesa-dev] [PATCH 10/14] mesa/main: Maintain compressed fog mode.

2017-04-07 16:31 GMT+02:00 Marek Olšák <mar...@gmail.com>: > On Thu, Mar 30, 2017 at 8:09 PM, Gustaw Smolarczyk <wielkie...@gmail.com> > wrote: >> Signed-off-by: Gustaw Smolarczyk <wielkie...@gmail.com> >> --- >> src/mesa/main/enable.c | 1 + >>

[Mesa-dev] [PATCH 14/14] st/mesa: Use compressed fog mode for atifs.

Signed-off-by: Gustaw Smolarczyk <wielkie...@gmail.com> --- src/mesa/state_tracker/st_atifs_to_tgsi.c | 6 +++--- src/mesa/state_tracker/st_atom_shader.c | 17 + 2 files changed, 4 insertions(+), 19 deletions(-) diff --git a/src/mesa/state_tracker/st_atifs_to_tgsi.c

[Mesa-dev] [PATCH 11/14] mesa/main: Maintain compressed TexEnv Combine state.

Signed-off-by: Gustaw Smolarczyk <wielkie...@gmail.com> --- src/mesa/main/mtypes.h | 83 ++ src/mesa/main/texstate.c | 103 +++ 2 files changed, 186 insertions(+) diff --git a/src/mesa/main/mtypes.h b/sr

[Mesa-dev] [PATCH 13/14] mesa/main/ff_frag: Use compressed TexEnv Combine state.

Along the way, add missing GL_ONE source support and drop non-existing GL_ZERO and GL_ONE operand support. Signed-off-by: Gustaw Smolarczyk <wielkie...@gmail.com> --- src/mesa/main/ff_fragment_shader.cpp | 335 +++ 1 file changed, 104 insertions(+), 231 del

[Mesa-dev] [PATCH 09/14] mesa/main/ff_frag: Don't retrieve format if not necessary.

Signed-off-by: Gustaw Smolarczyk <wielkie...@gmail.com> --- src/mesa/main/ff_fragment_shader.cpp | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index 2b4d99c879..e1fe9b58c0

[Mesa-dev] [PATCH 05/14] mesa/main/ff_frag: Don't bother with VARYING_BIT_FOGC.

It's not used. Signed-off-by: Gustaw Smolarczyk <wielkie...@gmail.com> --- src/mesa/main/ff_fragment_shader.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index 95c74e2b92..05641997de

[Mesa-dev] [PATCH 12/14] mesa/main/ff_frag: Use compressed fog mode.

Signed-off-by: Gustaw Smolarczyk <wielkie...@gmail.com> --- src/mesa/main/ff_fragment_shader.cpp | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index e1fe9b58c0..bdbefc7880

[Mesa-dev] [PATCH 07/14] mesa/main/ff_frag: Store nr_enabled_units only once.

Signed-off-by: Gustaw Smolarczyk <wielkie...@gmail.com> --- src/mesa/main/ff_fragment_shader.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index 1b76f40e9a..717f39e9d3 100644 ---

[Mesa-dev] [PATCH 10/14] mesa/main: Maintain compressed fog mode.

Signed-off-by: Gustaw Smolarczyk <wielkie...@gmail.com> --- src/mesa/main/enable.c | 1 + src/mesa/main/fog.c| 9 + src/mesa/main/mtypes.h | 14 ++ 3 files changed, 24 insertions(+) diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c index d9d6

[Mesa-dev] [PATCH 08/14] mesa/main/ff_frag: Use gl_texture_object::TargetIndex.

Instead of computing it once again using _mesa_tex_target_to_index. Signed-off-by: Gustaw Smolarczyk <wielkie...@gmail.com> --- src/mesa/main/ff_fragment_shader.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mes

[Mesa-dev] [PATCH 06/14] mesa/main/ff_frag: Simplify get_fp_input_mask.

Change it into filter_fp_input_mask transform function that instead of returning a mask, transforms input. Also, simplify the case of vertex program handling by assuming that fp_inputs is always a combination of VARYING_BIT_COL* and VARYING_BIT_TEX*. Signed-off-by: Gustaw Smolarczyk <wiel

[Mesa-dev] [PATCH 01/14] mesa/main/ff_frag: Use correct constant.

Since fixed-function shaders are restricted to MAX_TEXTURE_COORD_UNITS texture units, use this constant instead of MAX_TEXTURE_UNITS. This reduces the array size from 32 to 8. Signed-off-by: Gustaw Smolarczyk <wielkie...@gmail.com> Reviewed-by: Eric Anholt <e...@anholt.net> --- s

[Mesa-dev] [PATCH 04/14] mesa/main/ff_frag: Remove unused struct.

Signed-off-by: Gustaw Smolarczyk <wielkie...@gmail.com> --- src/mesa/main/ff_fragment_shader.cpp | 8 1 file changed, 8 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index 9b00c36534..95c74e2b92 100644 --- a/src/mes

[Mesa-dev] [PATCH 03/14] mesa/main/ff_frag: Reduce the size of nr_enabled_units.

Since it holds values from 0 to 8, 4 bits will suffice. Signed-off-by: Gustaw Smolarczyk <wielkie...@gmail.com> Reviewed-by: Eric Anholt <e...@anholt.net> --- src/mesa/main/ff_fragment_shader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/s

[Mesa-dev] [PATCH 02/14] mesa/main/ff_frag: Remove enabled_units.

Its only usage is easily replaced by nr_enabled_units. As for cache key part, unit[i].enabled should be enough. Signed-off-by: Gustaw Smolarczyk <wielkie...@gmail.com> Reviewed-by: Eric Anholt <e...@anholt.net> --- src/mesa/main/ff_fragment_shader.cpp | 4 +--- 1 file changed, 1 ins

[Mesa-dev] [PATCH 00/14] More substantial ff_fragment_shader cache key optimizations.

% to ~0.37%. Standard deviation here is ~0.025% so the performance gain is statistically significant. Regards, Gustaw Gustaw Smolarczyk (14): mesa/main/ff_frag: Use correct constant. mesa/main/ff_frag: Remove enabled_units. mesa/main/ff_frag: Reduce the size of nr_enabled_units. mesa/ma

Re: [Mesa-dev] [RFC 2/3] mesa: always return GL_OUT_OF_MEMORY or GL_NO_ERROR when KHR_no_error enabled

28 mar 2017 06:35 "Timothy Arceri" napisał(a): --- src/mesa/main/getstring.c | 12 1 file changed, 12 insertions(+) diff --git a/src/mesa/main/getstring.c b/src/mesa/main/getstring.c index 6e90511..50140cf 100644 --- a/src/mesa/main/getstring.c +++

Re: [Mesa-dev] [PATCH 0/3] Minor fixed-function fragment shader cache key optimizations.

2017-03-27 21:27 GMT+02:00 Gustaw Smolarczyk <wielkie...@gmail.com>: > 2017-03-27 21:10 GMT+02:00 Jason Ekstrand <ja...@jlekstrand.net>: >> On March 27, 2017 10:24:47 AM Gustaw Smolarczyk <wielkie...@gmail.com> >> wrote: >> >>> Hello, >>&g

Re: [Mesa-dev] [PATCH v2 2/2] mesa: load a user defined drirc file specified via an environment variable

2017-03-27 21:59 GMT+02:00 Edmondo Tommasina : > Introduce a new MESA_USER_DRIRC environment variable to load a customized > drirc file. > > This can be used mostly for two things: > 1. Force the load of a different user drirc configuration for an application >

Re: [Mesa-dev] [PATCH 0/3] Minor fixed-function fragment shader cache key optimizations.

2017-03-27 21:10 GMT+02:00 Jason Ekstrand <ja...@jlekstrand.net>: > On March 27, 2017 10:24:47 AM Gustaw Smolarczyk <wielkie...@gmail.com> > wrote: > >> Hello, >> >> I was playing with profiling Minecraft on radeonsi in perf and found that >> _mesa_get

[Mesa-dev] [PATCH 3/3] mesa/main: Reduce the size of nr_enabled_units in ff cache key.

Since it holds values from 0 to 8, 4 bits will suffice. Signed-off-by: Gustaw Smolarczyk <wielkie...@gmail.com> --- src/mesa/main/ff_fragment_shader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mes

[Mesa-dev] [PATCH 2/3] mesa/main: Remove enabled_units from ff cache key.

Its only usage is easily replaced by nr_enabled_units. As for cache key part, unit[i].enabled should be enough. Signed-off-by: Gustaw Smolarczyk <wielkie...@gmail.com> --- src/mesa/main/ff_fragment_shader.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mes

[Mesa-dev] [PATCH 1/3] mesa/main: Use correct constant in ff cache key.

Since fixed-function shaders are restricted to MAX_TEXTURE_COORD_UNITS texture units, use this constant instead of MAX_TEXTURE_UNITS. This reduces the array size from 32 to 8. Signed-off-by: Gustaw Smolarczyk <wielkie...@gmail.com> --- src/mesa/main/ff_fragment_shader.cpp | 2 +- 1 file c

[Mesa-dev] [PATCH 0/3] Minor fixed-function fragment shader cache key optimizations.

the gl context be more similar to ff cache key. This way make_state_key would be more about copying stuff around than translating it from one representation to another. As I don't have commit access, please push the changes after you deem them ready for that. Regards, Gustaw Gustaw Smolarczyk (3

Re: [Mesa-dev] [PATCH 2/2] mesa: load a user defined drirc file specified via an environment variable

26 mar 2017 22:32 "Edmondo Tommasina" napisał(a): Define a new MESA_USER_DRIRC environment variable to load a customized drirc file. When the variable is not defined, nothing changes and the ${HOME}/.drirc file will be loaded. If the variable is set to a file, this

Re: [Mesa-dev] [PATCH v2] mesa/main: Fix memset in formatquery.c

27 mar 2017 08:47 "Alejandro Piñeiro" napisał(a): On 27/03/17 01:51, Edward O'Callaghan wrote: > V.1: > We memset number of elements without multiplication by the > element size. It is not usual to summarize v1. The idea is explain just the changes. > > V.2: > We

Re: [Mesa-dev] [PATCH 2/2] anv: Advertise larger heap sizes

18 mar 2017 05:24 "Jason Ekstrand" napisał(a): Instead of just advertising the aperture size, we do something more intelligent. On systems with a full 48-bit PPGTT, we can address 100% of the available system RAM from the GPU. In order to keep clients from burning 100% of

Re: [Mesa-dev] [PATCH] mesa/main: Fix memset in formatquery.c

17 mar 2017 10:01 "Alejandro Piñeiro" napisał(a): On 17/03/17 06:26, Edward O'Callaghan wrote: > We memset number of elements without multiplication by the > element size. > > Signed-off-by: Edward O'Callaghan > --- >

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi: move image count to shared structure.

21 lut 2017 03:47 "Jason Ekstrand" napisał(a): Fine by me Reviewed-by: Jason Ekstrand On Mon, Feb 20, 2017 at 6:26 PM, Dave Airlie wrote: > From: Dave Airlie > > For prime support I need to access this, so

Re: [Mesa-dev] [PATCH v2] radeonsi, r600g: Alias 'R600_DEBUG' with 'RADEON_DEBUG'

2017-02-20 11:19 GMT+01:00 Edward O'Callaghan : > > On 02/20/2017 09:15 PM, Edward O'Callaghan wrote: >> The name has become a little misleading now that it applies >> to both r600g and radeonsi. >> >> V.2: Michel Dänzer - R600_DEBUG must continue to work. >> >>

Re: [Mesa-dev] [PATCH 2/3] radv/ac: use shader umsb helper.

I think you meant "shared" and not "shader" in the first line of the commit message. Gustaw 16 lut 2017 04:55 "Dave Airlie" napisał(a): From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 18

Re: [Mesa-dev] [RFC PATCH 1/1] st/dri: add a new driconf option override_glsl_version for ARK games

2017-02-07 14:11 GMT+01:00 Eero Tamminen : > Hi, > > On 06.02.2017 22:26, Samuel Pitoiset wrote: >> >> On 02/06/2017 04:45 PM, Eero Tamminen wrote: >>> >>> Results from quick try on Ubuntu 16.04 with today's version of the game >>> (ARK: Survival Evolved)... >>> >>> With

Re: [Mesa-dev] [PATCH 15/17] gallium/radeon: remove r600_common_context::max_db

2017-01-26 17:04 GMT+01:00 Marek Olšák : > From: Marek Olšák > > this cleanup is based on the vulkan driver, which seems to do the same thing Is this also ok for r600g? If I'm right, the amdgpu-pro Vulkan driver doesn't have any support for pre-GCN

Re: [Mesa-dev] [PATCH 08/12] glcpp: Use strpbrk in the line continuations pass

7 sty 2017 20:04 "Vladislav Egorov" napisał(a): To find newlines the line continuations removal pass uses strchr() twice -- first time to find '\n', second time to find '\r'. Now, if the shader uses Unix line separators '\n', the file could contain no '\r' at all, so each

Re: [Mesa-dev] [PATCH] nir/algebraic: Add optimizations for "a == a && a CMP b"

2016-12-20 6:32 GMT+01:00 Jason Ekstrand : > This sequence shows up The Talos Principal, at least under Vulkan, > and prevents loop analysis from properly computing trip counts in a > few loops. > --- > src/compiler/nir/nir_opt_algebraic.py | 8 > 1 file changed, 8

Re: [Mesa-dev] radv vs vulkan loader

2016-12-16 18:12 GMT+01:00 Gustaw Smolarczyk <wielkie...@gmail.com>: > 2016-12-16 17:57 GMT+01:00 Emil Velikov <emil.l.veli...@gmail.com>: >> On 16 December 2016 at 15:27, Gustaw Smolarczyk <wielkie...@gmail.com> wrote: >>> 2016-12-16 14:50 GMT+01:00 Em

Re: [Mesa-dev] radv vs vulkan loader

2016-12-16 17:57 GMT+01:00 Emil Velikov <emil.l.veli...@gmail.com>: > On 16 December 2016 at 15:27, Gustaw Smolarczyk <wielkie...@gmail.com> wrote: >> 2016-12-16 14:50 GMT+01:00 Emil Velikov <emil.l.veli...@gmail.com>: >>> >>> On 5 October 2016 at 2

Re: [Mesa-dev] radv vs vulkan loader

2016-12-16 14:50 GMT+01:00 Emil Velikov <emil.l.veli...@gmail.com>: > On 5 October 2016 at 23:12, Gustaw Smolarczyk <wielkie...@gmail.com> > wrote: > > 2016-10-06 0:05 GMT+02:00 Emil Velikov <emil.l.veli...@gmail.com>: > >> On 5 October 2016 at 21:45,

Re: [Mesa-dev] [PATCH v2 4/4] nir: Rewrite lower_regs_to_ssa to use the phi builder

15 gru 2016 18:19 "Jason Ekstrand" napisał(a): This keeps some of Connor's original code. However, while I was at it, I updated this very old pass to a bit more modern NIR. --- src/compiler/nir/nir_lower_regs_to_ssa.c | 582 --- 1 file changed,

Re: [Mesa-dev] [PATCH v2 2/4] nir: Add foreach_register helper macros

15 gru 2016 18:19 "Jason Ekstrand" napisał(a): --- src/compiler/nir/nir.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index f1c99ce..4a9fe65 100644 --- a/src/compiler/nir/nir.h +++ b/src/compiler/nir/nir.h @@

[Mesa-dev] [PATCH] configure: Strip LLVMX86Asm* dependencies.

They are picked automatically by the provided llvm-config flags, but are not needed. Fixes loading radv through a vulkan loader. Cc: 13.0 --- It's work-around for: https://lists.freedesktop.org/archives/mesa-dev/2016-October/130765.html Since there are other

Re: [Mesa-dev] [PATCH 05/10] radeonsi: check for sampler state CSO corruption

2016-12-02 21:39 GMT+01:00 Marek Olšák : > From: Marek Olšák > > It really happens. > --- > src/gallium/drivers/radeonsi/si_descriptors.c | 1 + > src/gallium/drivers/radeonsi/si_pipe.h| 3 +++ > src/gallium/drivers/radeonsi/si_state.c | 5

Re: [Mesa-dev] Mesa 13.0.2 release candidate

2016-11-24 18:25 GMT+01:00 Emil Velikov : > Hello list, > > The candidate for the Mesa 13.0.2 is now available. Currently we have: > - 49 queued > - 4 nominated (outstanding) > - and 1 rejected patch(es) > > > With this series we have - fixes for vc4, i965 and radeon

Re: [Mesa-dev] [PATCH] [rfc] radv: add initial prime support.

2016-11-23 6:28 GMT+01:00 Dave Airlie : > From: Dave Airlie > > This is kind of a gross hacks, but vulkan doesn't specify anything > but it would be nice to let people with prime systems at least > see some stuff rendering for now. > > This creates a linear

Re: [Mesa-dev] [PATCH] mesa: if MESA_DEBUG=context, create a debug context

2016-11-16 0:05 GMT+01:00 Brian Paul : > A number of drivers report useful debug/perf information accessible > through GL_ARB_debug_output and with debug contexts (i.e. setting the > GLX_CONTEXT_DEBUG_BIT_ARB flag). But few applications actually use > the GL_ARB_debug_output

Re: [Mesa-dev] [PATCH] radv: fix GetFenceStatus for signaled fences

Looks like a follow-up to 24815bd7b3b50d2e634b56ca607856ecf08ec4ee Note sure if my rb is helpful, but: Reviewed-by: Gustaw Smolarczyk <wielkie...@gmail.com> 2016-11-09 8:43 GMT+01:00 Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl>: > Reviewed-by: Bas Nieuwenhuizen <b...@b

Re: [Mesa-dev] [PATCH 2/3] nir: add conditional discard optimisation

I am not really that much familiar with nir, so I apologize if what I write below is wrong. What if we had something like: a = 0; if (x) { discard_if(y); a = 1; } Then if (x && !y), we must not discard and both at the same time set a to 1. Your transformation would probably change it to: a

[Mesa-dev] [PATCH] radv/winsys: Fail early on overgrown cs.

When !use_ib_bos, we can't easily chain ibs one to another. If the required cs size grows over 1Mi - 8 dwords just fail the cs so that we won't assert-fail in radv_amdgpu_winsys_cs_submit later on. --- Please, push the patch after it has been reviewed.

  1   2   >