Re: state of EGL support on MacOS?

2023-01-06 Thread Jeremy Huddleston Sequoia
The glx/apple code is quite dated. I think mesa has had a few architectural changes in the years since it was brought up (~15+ years ago). If someone is really serious about hardware rendering for X11 apps running on macOS, I'd be happy to chat with them and point them in the right directions

[Mesa-dev] Supporting macOS / XQuartz on master

2021-01-15 Thread Jeremy Huddleston Sequoia
Hey folks, I finally had a little bit of time to take a look at mesa and XQuartz for the first time in ~4 years. I am incredibly impressed that there wasn't more bitrot. I was expecting a painful few days since I've never looked at meson, but I was able to get it functional relatively

Re: [Mesa-dev] [PATCH mesa] meson: add GL/glext.h warning fix for MacOS

2018-06-15 Thread Jeremy Huddleston Sequoia
I think we can instead revert c7f3657450683827446072ad6b1e8fce04078162. I believe the underlying issue should instead be addressed by a087a09fa86f9617af98f6294dd2228555a4891c. If any issues remain, we should address them properly rather than masking them with this. A quick audit makes me

[Mesa-dev] [PATCH mesa 2/2] sched.h needs to be imported on Darwin/OSX targets.

2018-03-14 Thread Jeremy Huddleston Sequoia
From: Apple SWE <jerem...@apple.com> sched_yield is used but the include reference on Darwin is missing. This patch conditionally guards on Darwin/OSX to import sched.h first. Reviewed-by: Jeremy Huddleston Sequoia <jerem...@apple.com> Signed-off-by: Jeremy Huddleston Sequoia <jer

[Mesa-dev] [PATCH mesa 1/2] Add processor topology calculation implementation for Darwin/OSX targets.

2018-03-14 Thread Jeremy Huddleston Sequoia
cessor affinities. With this patch, it is possible to use SWR as an alternate renderer on OSX to softpipe and llvmpipe. Reviewed-by: Jeremy Huddleston Sequoia <jerem...@apple.com> Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- .../drivers/swr/rasterizer/core/threa

[Mesa-dev] [PATCH] mesa: Deal with size differences between GLuint and GLhandleARB in GetAttachedObjectsARB

2017-08-17 Thread Jeremy Huddleston Sequoia
Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> CC: Nicolai Hähnle <nhaeh...@gmail.com> CC: Matt Turner <matts...@gmail.com> CC: Ian Romanick <i...@freedesktop.org> CC: Brian Paul <bri...@vmware.com> --- src/mesa/main/shaderapi.c | 22

Re: [Mesa-dev] [PATCH 7/7] docs/releasing: added relevant people for build/check with MacOSX

2017-04-18 Thread Jeremy Huddleston Sequoia
SX in the > releasing doc? > > On Mon, 2017-03-27 at 21:48 +0300, Andres Gomez wrote: >> Signed-off-by: Andres Gomez <ago...@igalia.com> >> Cc: Emil Velikov <emil.veli...@collabora.com> >> Cc: Jeremy Huddleston Sequoia <jerem...@apple.com> >&

Re: [Mesa-dev] [PATCH 11/19] glx/apple: automake: include builddir prior to srcdir

2017-01-16 Thread Jeremy Huddleston Sequoia
LGTM Reviewed-by: Jeremy Sequoia <jerem...@apple.com> > On Jan 16, 2017, at 07:45, Emil Velikov <emil.l.veli...@gmail.com> wrote: > > From: Emil Velikov <emil.veli...@collabora.com> > > Analogous to previous commit. > > Cc: "12.0 13.0" <mes

Re: [Mesa-dev] [PATCH 7/7] glx: unify GLX_SGIX_pbuffer aliased declarations

2016-12-06 Thread Jeremy Huddleston Sequoia
> On Dec 6, 2016, at 06:04, Emil Velikov <emil.l.veli...@gmail.com> wrote: > > On 5 December 2016 at 22:50, Jeremy Huddleston Sequoia > <jerem...@apple.com> wrote: >> >>> On Dec 5, 2016, at 11:52 AM, Emil Velikov <emil.l.veli...@gmail.com>

Re: [Mesa-dev] [PATCH 7/7] glx: unify GLX_SGIX_pbuffer aliased declarations

2016-12-05 Thread Jeremy Huddleston Sequoia
f > type. This change is both API and ABI safe since the header uses the > correct GLXPbufferSGIX and both types are a typedef of the same > primitive XID. > > Cc: Jeremy Huddleston Sequoia <jerem...@apple.com> > Signed-off-by: Emil Velikov <emil.veli...@collabora.com>

Re: [Mesa-dev] [PATCH v4 2/2] glx: apple specific occurences of dummyContext check

2016-08-13 Thread Jeremy Huddleston Sequoia
> On Aug 12, 2016, at 05:11, Tapani Pälli <tapani.pa...@intel.com> wrote: > > > > On 08/12/2016 01:31 PM, Jeremy Huddleston Sequoia wrote: >> >>> On Aug 12, 2016, at 00:41, Tapani Pälli <tapani.pa...@intel.com> wrote: >>> >>>

Re: [Mesa-dev] [PATCH v4 2/2] glx: apple specific occurences of dummyContext check

2016-08-12 Thread Jeremy Huddleston Sequoia
> On Aug 12, 2016, at 00:41, Tapani Pälli <tapani.pa...@intel.com> wrote: > > > On 07/18/2016 07:07 PM, Jeremy Huddleston Sequoia wrote: >> Will do. Thanks for pinging me. Early June was very busy and I didn't see >> this come through. I'll get ba

Re: [Mesa-dev] [PATCH v4 2/2] glx: apple specific occurences of dummyContext check

2016-07-18 Thread Jeremy Huddleston Sequoia
hanges? Patch 1 was already > reviewed by Emil. > > // Tapani > > > On 06/07/2016 01:33 PM, Tapani Pälli wrote: >> Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> >> Cc: Jeremy Huddleston Sequoia <jerem...@apple.com> >> --- >> src/glx/apple/apple_

Re: [Mesa-dev] [PATCH v2] glx: fix crash with bad fbconfig

2016-06-08 Thread Jeremy Huddleston Sequoia
> On Jun 7, 2016, at 03:25, Emil Velikov wrote: > > On 31 May 2016 at 10:53, Tapani Pälli wrote: >> From: Daniel Czarnowski >> >> GLX documentation states: >>glXCreateNewContext can generate the following

[Mesa-dev] [PATCH] mesa: Deal with size differences between GLuint and GLhandleARB in GetAttachedObjectsARB

2016-05-08 Thread Jeremy Huddleston Sequoia
Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> CC: Nicolai Hähnle <nhaeh...@gmail.com> CC: Matt Turner <matts...@gmail.com> CC: Ian Romanick <i...@freedesktop.org> --- src/mesa/main/shaderapi.c | 26 +- 1 file changed, 25 insertions

Re: [Mesa-dev] [PATCH 3/3] mesa: Deal with size differences between GLuint and GLhandleARB in GetAttachedObjectsARB

2016-01-21 Thread Jeremy Huddleston Sequoia
> On Jan 21, 2016, at 07:51, Nicolai Hähnle <nhaeh...@gmail.com> wrote: > > Wow... did you actually run into that crash? No. I was just paying attention to compiler warnings ;) > > On 20.01.2016 20:14, Jeremy Huddleston Sequoia wrote: >> Signed-off-by: Jerem

[Mesa-dev] [PATCH v2] mesa: Deal with size differences between GLuint and GLhandleARB in GetAttachedObjectsARB

2016-01-21 Thread Jeremy Huddleston Sequoia
Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> CC: Nicolai Hähnle <nhaeh...@gmail.com> CC: Matt Turner <matts...@gmail.com> --- src/mesa/main/shaderapi.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/shaderapi

[Mesa-dev] [PATCH 0/3] Misc GLhandleARB GLuint cleanup

2016-01-20 Thread Jeremy Huddleston Sequoia
This series includes 3 changes related to help reconcile the differences in declaration between Apple's vs Mesa's GLhandleARB type. The first, I expect to be mostly uncontroversial as they are mainly cleaning up and correcting some prototypes. The second is just a casting which should be

[Mesa-dev] [PATCH 2/3] mesa: Fix format warnings

2016-01-20 Thread Jeremy Huddleston Sequoia
quot;, obj); ~~ ^~~ %lu Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- src/mesa/main/shaderapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 9512e3b..a988f41 100644 --- a/src/mesa/main/shaderapi.

[Mesa-dev] [PATCH 3/3] mesa: Deal with size differences between GLuint and GLhandleARB in GetAttachedObjectsARB

2016-01-20 Thread Jeremy Huddleston Sequoia
Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- src/mesa/main/shaderapi.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index a988f41..75fc17c 100644 --- a/src/mesa/main/shaderapi.c

[Mesa-dev] [PATCH 1/3] mesa: Fix some function prototype mismatching

2016-01-20 Thread Jeremy Huddleston Sequoia
fn)(GLuint)) { ^ 1 warning generated. Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- src/mesa/main/dlist.c | 5 ++--- src/mesa/main/shader_query.cpp | 12 ++-- src/mes

Re: [Mesa-dev] mesa: Reduce libGL.so binary size by about 15%

2016-01-20 Thread Jeremy Huddleston Sequoia
Sorry, I thought I responded to this a while ago. Reviewed-by: Jeremy Huddleston Sequoia <jerem...@apple.com> Tested-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --Jeremy > On Jan 19, 2016, at 05:21, Andreas Boll <andreas.boll@gmail.com> wrote: > > Je

Re: [Mesa-dev] [RFC] glapi: Build gl_gentable.c only on Darwin

2015-12-09 Thread Jeremy Huddleston Sequoia
The general concept of this change seems fine to me. Given the desire to keep glapi as similar as possible across platforms, would it be better to just move this into glx/apple rather than leaving it in glapi? > On Dec 9, 2015, at 09:07, Emil Velikov wrote: > > On 9

Re: [Mesa-dev] mesa: Reduce libGL.so binary size by about 15%

2015-09-28 Thread Jeremy Huddleston Sequoia
longer, then the best thing might be > to remove it entirely. > > On Sat, Sep 26, 2015 at 5:56 PM, Jeremy Huddleston Sequoia > <jerem...@apple.com> wrote: > Reviewing diffs of code that generates code is always ick. =( > > This *looks* right to me, but has it been given a bea

Re: [Mesa-dev] mesa: Reduce libGL.so binary size by about 15%

2015-09-26 Thread Jeremy Huddleston Sequoia
Reviewing diffs of code that generates code is always ick. =( This *looks* right to me, but has it been given a beating for correctness? If not, let me know, and I'll give it a whirl when I have some cycles. Reviewed-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- You're

Re: [Mesa-dev] [PATCH 06/11] loader: use HAVE_LIBDRM instead of ! __NOT_HAVE_DRM_H

2015-09-26 Thread Jeremy Huddleston Sequoia
Sorry, been slammed and trying to catch up. I forget if I replied to this or not, but if you're still waiting on me: Reviewed-by: Jeremy Huddleston Sequoia <jerem...@apple.com> > On Jul 9, 2015, at 10:55, Ian Romanick <i...@freedesktop.org> wrote: > > I can't really sp

Re: [Mesa-dev] [PATCH] configure.ac: Add support to enable read-only text segment on x86.

2015-09-04 Thread Jeremy Huddleston Sequoia
Wow, that's a blast from the past ;) > On Sep 3, 2015, at 21:36, Matt Turner <matts...@gmail.com> wrote: > > From: Jeremy Huddleston <jerem...@freedesktop.org> > > Cc: "10.6 11.0" <mesa-sta...@lists.freedesktop.org> > Bugzilla: https://bugs.gentoo.o

Re: [Mesa-dev] [PATCH] glext.h: Add missing include of stddef.h for ptrdiff_t

2015-05-20 Thread Jeremy Huddleston Sequoia
On May 20, 2015, at 13:59, Emil Velikov emil.l.veli...@gmail.com wrote: Hi Jeremy, On 11 February 2015 at 20:36, Jeremy Huddleston Sequoia jerem...@freedesktop.org wrote: Signed-off-by: Jeremy Huddleston Sequoia jerem...@apple.com --- include/GL/glext.h | 1 + 1 file changed, 1

Re: [Mesa-dev] [PATCH:mesa] swrast: Build fix for Solaris

2015-05-15 Thread Jeremy Huddleston Sequoia
Looks right to me. I think this was also mentioned in the bugzilla ticket where this change was committed from. Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com On May 15, 2015, at 19:05, Alan Coopersmith alan.coopersm...@oracle.com wrote: Fixes regression from commit

Re: [Mesa-dev] [PATCH] darwin: Fix install name of libOSMesa

2015-02-11 Thread Jeremy Huddleston Sequoia
On Feb 11, 2015, at 05:02, Emil Velikov emil.l.veli...@gmail.com wrote: On 11 February 2015 at 10:32, Jeremy Huddleston Sequoia jerem...@apple.com wrote: libOSMesa is a library, not a module Fwiw I'm not 100% sure that's the case. But considering it's been like that* for a long time we

[Mesa-dev] [PATCH] glext.h: Add missing include of stddef.h for ptrdiff_t

2015-02-11 Thread Jeremy Huddleston Sequoia
Signed-off-by: Jeremy Huddleston Sequoia jerem...@apple.com --- include/GL/glext.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/GL/glext.h b/include/GL/glext.h index 256ad35..0328cf6 100644 --- a/include/GL/glext.h +++ b/include/GL/glext.h @@ -4470,6 +4470,7 @@ GLAPI void APIENTRY

[Mesa-dev] Removing the --allow-multiple-definition hack

2015-02-11 Thread Jeremy Huddleston Sequoia
Is there any indication on when is this temporary hack going to be removed? This kind of linking is not legal in many toolchains (eg on darwin), and I imagine behavior is not well defined in places where this hack actually works. --Jeremy commit 7414552b1826ece48a622c14b48cad3a37b68025

[Mesa-dev] [PATCH] darwin: Fix install name of libOSMesa

2015-02-11 Thread Jeremy Huddleston Sequoia
libOSMesa is a library, not a module Signed-off-by: Jeremy Huddleston Sequoia jerem...@apple.com --- src/mesa/drivers/osmesa/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/osmesa/Makefile.am b/src/mesa/drivers/osmesa/Makefile.am index 589b5ee..8d69915 100644

Re: [Mesa-dev] [PATCH] swrast: Build fix for darwin

2015-01-01 Thread Jeremy Huddleston Sequoia
even want to return the full size of system memory for __DRI2_RENDERER_VIDEO_MEMORY. On Jan 1, 2015, at 20:10, Jeremy Huddleston Sequoia jerem...@apple.com wrote: Fixes regression from commit 64b1dc44495890cbc2c7c5509cb830264020998c Signed-off-by: Jeremy Huddleston Sequoia jerem

[Mesa-dev] [PATCH] swrast: Build fix for darwin

2015-01-01 Thread Jeremy Huddleston Sequoia
Fixes regression from commit 64b1dc44495890cbc2c7c5509cb830264020998c Signed-off-by: Jeremy Huddleston Sequoia jerem...@apple.com CC: Emil Velikov emil.l.veli...@gmail.com CC: jon.tur...@dronecode.org.uk CC: io...@macports.org --- src/mesa/drivers/dri/swrast/swrast.c | 16 1

[Mesa-dev] how client glx extensions and GLX extensions are determined (and how best to limit them)

2014-06-01 Thread Jeremy Huddleston Sequoia
I'm trying to take a stab at adding core profile support to XQuartz. As a first step, I'm trying to add GLX_ARB_create_context and GLX_ARB_create_context_profile. For now, I want to make sure that GLX_ARB_create_context and GLX_ARB_create_context_profile are only advertised as being available

[Mesa-dev] build failure: _mesa_BindAttribLocation vs _mesa_lookup_shader_program_err , GLuint vs GLhandleARB

2014-05-24 Thread Jeremy Huddleston Sequoia
I'm getting this build failure: main/shader_query.cpp:49:7: error: no matching function for call to '_mesa_lookup_shader_program_err' _mesa_lookup_shader_program_err(ctx, program, glBindAttribLocation); ^~~ ../../src/mesa/main/shaderobj.h:81:1: note:

Re: [Mesa-dev] build failure: _mesa_BindAttribLocation vs _mesa_lookup_shader_program_err , GLuint vs GLhandleARB

2014-05-24 Thread Jeremy Huddleston Sequoia
On May 24, 2014, at 19:55, Emil Velikov emil.l.veli...@gmail.com wrote: On 25/05/14 02:12, Jeremy Huddleston Sequoia wrote: I'm getting this build failure: main/shader_query.cpp:49:7: error: no matching function for call to '_mesa_lookup_shader_program_err

Re: [Mesa-dev] [PATCH 3/3] Fix build of appleglx

2014-05-20 Thread Jeremy Huddleston Sequoia
Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com with one minor change (see below): On May 13, 2014, at 05:15, Jon TURNEY jon.tur...@dronecode.org.uk wrote: ... diff --git a/src/glx/Makefile.am b/src/glx/Makefile.am index eee7c2c..c18d1c5 100644 --- a/src/glx/Makefile.am +++ b/src

Re: [Mesa-dev] [PATCH 2/3] Make DRI dependencies and build depend on the target

2014-05-20 Thread Jeremy Huddleston Sequoia
Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com On May 13, 2014, at 05:15, Jon TURNEY jon.tur...@dronecode.org.uk wrote: - Don't require xcb-dri[23] etc. if we aren't building for a target with DRM, as we won't be using dri[23] - Enable a more fine-grained control of what DRI

Re: [Mesa-dev] [PATCH 3/3] Fix build of appleglx

2014-05-20 Thread Jeremy Huddleston Sequoia
On May 20, 2014, at 05:57, Jon TURNEY jon.tur...@dronecode.org.uk wrote: On 20/05/2014 09:57, Jeremy Huddleston Sequoia wrote: Reviewed-by: Jeremy Huddleston Sequoia with one minor change (see below): Thanks very much for taking the time to review these. No, thank you for taking the time

Re: [Mesa-dev] [PATCH] glx/dri2: Respect --enable/disable-driglx-direct

2014-02-17 Thread Jeremy Huddleston Sequoia
On Feb 17, 2014, at 13:29, Emil Velikov emil.l.veli...@gmail.com wrote: On 17/02/14 06:49, Jeremy Huddleston Sequoia wrote: On Feb 16, 2014, at 17:15, Emil Velikov emil.l.veli...@gmail.com wrote: On 16/02/14 02:00, Jeremy Huddleston Sequoia wrote: Mesa master hasn't built for OSX

Re: [Mesa-dev] [PATCH] glx/dri2: Respect --enable/disable-driglx-direct

2014-02-16 Thread Jeremy Huddleston Sequoia
Mesa master hasn't built for OSX for over a year now, unfortunately, but I agree excluding in Makefile.am is preferable to cpp-guards. Hopefully someone will have the time and patience to get it working again in the near future. --Jeremy Sent from my iPad On Feb 13, 2014, at 8:29, Ian

Re: [Mesa-dev] [PATCH] glx/dri2: Respect --enable/disable-driglx-direct

2014-02-16 Thread Jeremy Huddleston Sequoia
On Feb 16, 2014, at 17:15, Emil Velikov emil.l.veli...@gmail.com wrote: On 16/02/14 02:00, Jeremy Huddleston Sequoia wrote: Mesa master hasn't built for OSX for over a year now, unfortunately, but I agree excluding in Makefile.am is preferable to cpp-guards. Hopefully someone will have

Re: [Mesa-dev] [PATCH 3/3] glx/apple: Fixed glx context memory leak in case of failure.

2014-02-10 Thread Jeremy Huddleston Sequoia
Yep, looks right to me. Reviewed-by: Jeremy Huddleston Sequoia: jerem...@apple.com On Feb 10, 2014, at 07:57, Ian Romanick i...@freedesktop.org wrote: Perhaps Jeremy can review this patch... On 02/10/2014 01:58 AM, Siavash Eliasi wrote: --- src/glx/apple/apple_glx_context.c | 1 + 1 file

Re: [Mesa-dev] Recent master build failure (upgrade gl2ext.h / glDrawBuffersNV fallout)

2012-07-11 Thread Jeremy Huddleston Sequoia
Tested-by: Jeremy Huddleston Sequoia jerem...@apple.com I tried applying that change to current master (a0698b000b693fc1345fadd6d418dfd8d7548e44), and it didn't work at first, but after a make clean it did. It looks like the Makefile dependencies were insufficient to propagate this change

[Mesa-dev] Recent master build failure (upgrade gl2ext.h / glDrawBuffersNV fallout)

2012-07-10 Thread Jeremy Huddleston Sequoia
Mesa master stopped building successfully on my tinderbox on 7/6. The relevant changes from the previous successful build were 95ce454..c445b0f, and I bisected it to the upgrade of gl2ext.h to version 18099 (see below). ../../../src/mapi/glapi/glapitemp.h:4635:1: error: no previous prototype

Re: [Mesa-dev] Doing 8.0.1 release?

2012-05-24 Thread Jeremy Huddleston
This is still a problem with the 8.0.3 release. Can this please get addressed in 8.0.4 =): python -t -O -O ../../src/mapi/glapi/gen/gl_table.py -f ../../src/mapi/glapi/gen/gl_and_es_API.xml -m remap_table -c es1 main/api_exec_es1_dispatch.h python -t -O -O

Re: [Mesa-dev] Doing 8.0.1 release?

2012-05-24 Thread Jeremy Huddleston
On May 24, 2012, at 11:36, Matt Turner matts...@gmail.com wrote: On Thu, May 24, 2012 at 2:20 PM, Jeremy Huddleston jerem...@apple.com wrote: This is still a problem with the 8.0.3 release. Can this please get addressed in 8.0.4 =): python -t -O -O ../../src/mapi/glapi/gen/gl_table.py -f

Re: [Mesa-dev] [PATCH] mesa: Use the proper feature test macros for strtod_l and strtof[_l].

2012-05-11 Thread Jeremy Huddleston
On May 11, 2012, at 08:58, Bryan Henderson bry...@giraffe-data.com wrote: Android does not have strtod_l. Yet, the old co de successfully compiled because Android does not define _GNU_SOURCE. Just to make sure we're all on the same page: NOBODY defines _GNU_SOURCE. At least they shouldn't.

Re: [Mesa-dev] [PATCH] mesa: Use the proper feature test macros for strtod_l and strtof[_l].

2012-05-09 Thread Jeremy Huddleston
...@giraffe-data.com [v2/Kayden: rebased version of Bryan's original patch from: https://bugs.freedesktop.org/show_bug.cgi?id=33447] Cc: Jeremy Huddleston jerem...@apple.com Cc: Chad Versace chad.vers...@linux.intel.com Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=33447 Signed-off

Re: [Mesa-dev] Doing 8.0.1 release?

2012-03-16 Thread Jeremy Huddleston
Please make sure to include python-generated C files in the 8.0.2 tarball. They were not there in 8.0.1's: python -t -O -O main/es_generator.py -S main/APIspec.xml -V GLES1.1 main/api_exec_es1.c Traceback (most recent call last): File main/es_generator.py, line 26, in module import

Re: [Mesa-dev] Recent mesa changes are causing tinderbox to fail

2012-01-08 Thread Jeremy Huddleston
On Jan 2, 2012, at 7:03 PM, Ian Romanick wrote: On 01/02/2012 06:18 PM, Jeremy Huddleston wrote: xdriinfo is failing to build in tinderbox (through no change of its own). The relevant changes in mesa were bce506f..7705833. My guess is that this was caused by one of: glx: Add

[Mesa-dev] Recent mesa changes are causing tinderbox to fail

2012-01-02 Thread Jeremy Huddleston
xdriinfo is failing to build in tinderbox (through no change of its own). The relevant changes in mesa were bce506f..7705833. My guess is that this was caused by one of: glx: Add __glX_send_client_info super function glx: Initial implementation of glXCreateContextAttribsARB Here's the

Re: [Mesa-dev] [PATCH 06/13] glx: Make __glXSendError available in non-Apple builds

2011-12-19 Thread Jeremy Huddleston
6, 7, and 13 look good to me, but I haven't tested them yet. Reviewed-by: Jeremy Huddleston jerem...@apple.com On Dec 16, 2011, at 11:55 AM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Jeremy Huddleston jerem

Re: [Mesa-dev] XCB-only GLX protocol?

2011-11-28 Thread Jeremy Huddleston
On Nov 28, 2011, at 6:56 PM, Jakob Bornecrantz wrote: On Mon, Nov 28, 2011 at 3:13 AM, Ian Romanick i...@freedesktop.org wrote: All, I'm starting to work on GLX_ARB_create_context. This extension and the layered GLX_ARB_create_context_profile extension add some GLX protocol. Is there

Re: [Mesa-dev] [RFC PATCH] automake: add support to src/glsl/

2011-09-30 Thread Jeremy Huddleston
So the original complaint, that he is forced to accept the GPLv3 to use autoconf seems a little confused. From the 2.62 release notes at http://lists.gnu.org/archive/html/autotools-announce/2008-04/msg2.html: Meanwhile, several source files within the Autoconf project are under

Re: [Mesa-dev] [RFC PATCH] automake: add support to src/glsl/

2011-09-29 Thread Jeremy Huddleston
On Sep 28, 2011, at 23:28, Miles Bader wrote: 2011/9/29 Alan Coopersmith alan.coopersm...@oracle.com: _Why_ is the GPLv3 not acceptable, when the GPLv2 was? Note his employer, which is well known as not accepting the GPLv3, possibly due to it being a mobile phone manufacturer, and the

Re: [Mesa-dev] [PATCH] mesa: Ensure that r300 compiler files only appear once in the tarballs

2011-07-26 Thread Jeremy Huddleston
That looks like it: Reviewed-by: Jeremy Huddleston jerem...@apple.com Tested-by: Jeremy Huddleston jerem...@apple.com You can probably revert the --dereference one as well. On Jul 26, 2011, at 12:09 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Cc: Jeremy Huddleston

[Mesa-dev] r300 problems in the 7.10.3 and 7.11 tarballs

2011-07-25 Thread Jeremy Huddleston
Can we please get a 7.10.4 release with this fixed? It's not a bug in libarchive; you just get lucky that gnutar doesn't complain (which I think *is* a bug in gnutar). Some users are running into problems using gnutar with this archive, so that's not really a great fallback either:

Re: [Mesa-dev] r300 problems in the 7.10.3 and 7.11 tarballs

2011-07-25 Thread Jeremy Huddleston
On Jul 25, 2011, at 8:02 PM, Ian Romanick wrote: Can we please get a 7.10.4 release with this fixed? It's not a bug in libarchive; you just get lucky that gnutar doesn't complain (which I think *is* a bug in gnutar). Does this still occur in the 7.11-rc3 tarballs? It's the same as the

[Mesa-dev] [PATCH 2/4 resend] glx: Allow a context-specific fallback for glXGetProcAddress

2011-06-18 Thread Jeremy Huddleston
In applegl, GLX advertises the same extensions provided by OpenGL.framework even if such extensions are not provided by glapi. This allows a client to get access to such API. Signed-off-by: Jeremy Huddleston jerem...@apple.com --- src/glx/applegl_glx.c |9 + src/glx/dri2_glx.c

[Mesa-dev] [PATCH 3/4 resend] glx: Destroy the old context only after the new one has been bound

2011-06-17 Thread Jeremy Huddleston
This fixes a regression introduced by 49d7e48b33264d94e30af6129c281b6acafa9427 Signed-off-by: Jeremy Huddleston jerem...@apple.com --- src/glx/glxcurrent.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git origin/master/src/glx/glxcurrent.c origin/master/src

[Mesa-dev] PATCH 1/4 resend] glapi: Update specs to correctly list FramebufferTextureLayerARB as an alias of FramebufferTextureLayerEXT

2011-06-17 Thread Jeremy Huddleston
FramebufferTextureLayer is an alias of FramebufferTextureLayerEXT, so FramebufferTextureLayerARB needs to be listed as an alias of FramebufferTextureLayerEXT rather than FramebufferTextureLayer. Signed-off-by: Jeremy Huddleston jerem...@apple.com --- src/mapi/glapi/gen/ARB_geometry_shader4.xml

[Mesa-dev] [PATCH 4/4 resend] glx: Bind to our context before __glXSetCurrentContext

2011-06-17 Thread Jeremy Huddleston
We want to bind to our context before calling __glXSetCurrentContext or messing with the gc rect in order to properly handle error conditions. Signed-off-by: Jeremy Huddleston jerem...@apple.com --- src/glx/glxcurrent.c | 25 - 1 files changed, 16 insertions(+), 9

Re: [Mesa-dev] Mesa (master): glapi: Add API that can create a _glapi_table from a dlfcn handle

2011-06-14 Thread Jeremy Huddleston
01:33 PM, Jeremy Huddleston wrote: Hi Brian, Please give this change a try. It should clear up the gcc -pedantic warnings and also replaces the NULL entries with noops since that seems to be done in other tables as well (eg: indirect_init.c). Thanks, Jeremy diff --git a/src/mapi

Re: [Mesa-dev] Mesa (master): glapi: Add API that can create a _glapi_table from a dlfcn handle

2011-06-13 Thread Jeremy Huddleston
); - SET_%(name)s(disp, dlsym(handle, symboln)); + disp-%(name)s = dlsym(handle, symboln); } On Jun 13, 2011, at 7:22 AM, Brian Paul wrote: On 06/11/2011 11:18 PM, Jeremy Huddleston wrote: Module: Mesa Branch: master Commit: 85937f4c0d4a78d3a11e3c1fa6148640f2a9ad7b

Re: [Mesa-dev] Mesa (master): glapi: Add API that can create a _glapi_table from a dlfcn handle

2011-06-13 Thread Jeremy Huddleston
Alright... looks like it needs the cast. Thanks. On Jun 13, 2011, at 2:27 PM, Brian Paul wrote: On 06/13/2011 02:05 PM, Jeremy Huddleston wrote: Hi Brian, Does this get rid of your warnings? (you'll need to regenerate the glapi_gentable.c) Getting a different warning now

Re: [Mesa-dev] Mesa (master): glapi: Add API that can create a _glapi_table from a dlfcn handle

2011-06-13 Thread Jeremy Huddleston
b44d13e67bfe81b2d7af4aeda2c3caf7f252bd0f should work for you. Thanks for letting me know. --Jeremy On Jun 13, 2011, at 2:27 PM, Brian Paul wrote: On 06/13/2011 02:05 PM, Jeremy Huddleston wrote: Hi Brian, Does this get rid of your warnings? (you'll need to regenerate

[Mesa-dev] [PATCH] glapi: Add API that can create a _glapi_table from a dlfcn handle

2011-06-09 Thread Jeremy Huddleston
know if I should keep the generated code out of git. Thanks, Jeremy The patch was rejected by the list due to size, so see it here: http://cgit.freedesktop.org/~jeremyhu/mesa/commit/?id=45aed4cea5b938cce9bfd8e93d16255b2b7a466a On Jun 8, 2011, at 12:35 PM, Jeremy Huddleston wrote: In moving

[Mesa-dev] generating _glapi_table from a dlfcn handle

2011-06-08 Thread Jeremy Huddleston
In moving src/glx/apple over to glapi this past week, I used our dispatch table code from xserver/hw/xquartz/GL/indirect.c as the model for creating our _glapi_table. Our table should contain pointers into OSX's OpenGL implementation, so the call is just passed along to that implementation.

Re: [Mesa-dev] Understanding GLX_INDIRECT_RENDERING (libOSMesa fails to link due to gl_dispatch_stub*)

2011-06-07 Thread Jeremy Huddleston
On Jun 7, 2011, at 1:01 PM, Jeremy Huddleston wrote: On Jun 7, 2011, at 12:01 PM, Jeremy Huddleston wrote: So what is the proper fix here? How should libOSMesa be getting built? Should libmesa.a be providing those stubs (rather than my change which put them in mesa/osmesa)? Should

Re: [Mesa-dev] Understanding GLX_INDIRECT_RENDERING (libOSMesa fails to link due to gl_dispatch_stub*)

2011-06-07 Thread Jeremy Huddleston
On Jun 7, 2011, at 2:13 PM, Brian Paul wrote: Ok, I see what is happening. configs/darwin bitrotted and included the -lGL, but other configs have since removed that. It looks like I should just remove -lGL from OSMESA_LIB_DEPS in addition to the other changes that I've already sent for

[Mesa-dev] packaging src/glx/apple

2011-06-06 Thread Jeremy Huddleston
src/glx/apple should land in MesaLib. What magic needs to be done to make sure it lands up there? This was a problem with 7.8.x, and I just solved it by putting out my own MesaLibApple-7.8.2. 7.9.x and 7.10.x didn't build on darwin, so it wasn't really a concern. I've gone through and fixed

[Mesa-dev] mesa regressions on darwin

2011-06-05 Thread Jeremy Huddleston
So I've finally sat down and tried to fix regressions on master due to glx restructuring last year ... mostly these are changes where people forgot to make corresponding changes in the apple subdirectory. There is one standout that I'm not sure how to fix (glxext.c). This is a build failure

Re: [Mesa-dev] mesa regressions on darwin

2011-06-05 Thread Jeremy Huddleston
I think I've figured out those issues... I just need to now figure out how to properly implement applegl_glx.c ... On Jun 5, 2011, at 6:34 PM, Jeremy Huddleston wrote: So I've finally sat down and tried to fix regressions on master due to glx restructuring last year ... mostly

Re: [Mesa-dev] [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-06 Thread Jeremy Huddleston
On May 5, 2011, at 1:09 PM, Jesse Barnes wrote: On Thu, 05 May 2011 12:59:50 -0700 Jeremy Huddleston jerem...@apple.com wrote: For *proto/mesa: Reviewed-by: Jeremy Huddleston jerem...@apple.com Thanks. For xserver: This looks incomplete. You also need to update swap_count

Re: [Mesa-dev] [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-06 Thread Jeremy Huddleston
Yes, I realize that there are some areas that use 64bit for sbc. Do we really need 64bits for this? If so, how do we properly to communicate the 64bit value between server/client? Currently, your changes result in an implicit cast from 64bit to 32bits in DRI2SwapComplete which will cause

Re: [Mesa-dev] [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-06 Thread Jeremy Huddleston
For *proto/mesa: Reviewed-by: Jeremy Huddleston jerem...@apple.com For xserver: This looks incomplete. You also need to update swap_count in DRI2DrawableRec to be CARD32. On May 5, 2011, at 12:45 PM, Jesse Barnes wrote: Use the new event types so we can pass a valid SBC value to clients

Re: [Mesa-dev] [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

2011-05-06 Thread Jeremy Huddleston
Yeah, that looks about right. This in combination with the latest version of xserver/glx/dri2: use new GLX/DRI2 swap event types Reviewed-by: Jeremy Huddleston jerem...@apple.com On May 6, 2011, at 10:39, Jesse Barnes wrote: On Fri, 06 May 2011 09:25:35 +0200 Michel Dänzer mic

Re: [Mesa-dev] mesa-from-git: build with clang(++) and --enable-glx-tls

2011-05-06 Thread Jeremy Huddleston
See: http://cgit.freedesktop.org/xorg/xserver/commit/?id=bb4d145bd25e2aee988b100ecf1105ea3b6a40b8 I suggest you do something similar for mesa. On Apr 9, 2011, at 04:28, Sedat Dilek wrote: Just as an addendum to configure-option --enable-glx-tls (see [1] and [2]). - Sedat - [1]

Re: [Mesa-dev] glproto changes

2011-05-05 Thread Jeremy Huddleston
: On Wed, 4 May 2011 21:29:23 -0700 Jeremy Huddleston jerem...@freedesktop.org wrote: Yeah... so considering the comments in mesa-dev earlier today, I was really surprised to see that glproto and dri2proto were tagged today. I think we need to brownbag retract and rethink this. Damnit

[Mesa-dev] [PATCH] configure: Don't use $CLANG since it will collide with the static analyzer.

2011-05-05 Thread Jeremy Huddleston
We just prefix the $CLANG environment variable in configure.ac with acv_mesa_ Found by: tinderbox Signed-off-by: Jeremy Huddleston jerem...@apple.com --- configure.ac |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 54d9c29

Re: [Mesa-dev] Error building glxext.c

2011-05-04 Thread Jeremy Huddleston
Well, it's not building correctly on my tinderbox which uses master glproto and master libGL, so either libGL has bad C, or libGL is using the system's glproto instead of the one it queries out of PKG_CONFIG_PATH. Either way, it's a mesa bug happening on both of my linux tinderboxes (gentoo

Re: [Mesa-dev] Error building glxext.c

2011-05-04 Thread Jeremy Huddleston
On May 4, 2011, at 11:04, Jesse Barnes wrote: libGL is missing the change and version requirement bump, so you'll have to use the last glproto release until I land the Mesa fix along with a new glproto release. Sorry for the trouble; I pushed glproto yesterday assuming I'd be able to push

Re: [Mesa-dev] glproto changes

2011-05-04 Thread Jeremy Huddleston
Yeah... so considering the comments in mesa-dev earlier today, I was really surprised to see that glproto and dri2proto were tagged today. I think we need to brownbag retract and rethink this. These changes break API. I'm all for fixing the structs, but anything that breaks API (or worse,

Re: [Mesa-dev] Mesa 7.8.2 release

2010-07-11 Thread Jeremy Huddleston
The 7.8.2 release is missing src/glx/apple ... I have made these bits available here: http://static.macosforge.org/xquartz/downloads/src/MesaApple-7.8.2.tar.bz2 sha1476f177ec6cbe8d5718a2109516a5121ab1574d2 rmd160 c2dd3363883c5826a9797ef631f668958660e740 What needs to be done to make sure

Re: [Mesa-dev] Mesa 7.8.2 release?

2010-06-16 Thread Jeremy Huddleston
On Jun 16, 2010, at 16:25, Dan Nicholson wrote: On Wed, Jun 16, 2010 at 4:20 PM, Jeremy Huddleston jerem...@freedesktop.org wrote: Hey Tom, What version of OSX do you have? I hadn't pulled changes into my tree (http://cgit.freedesktop.org/~jeremyhu/mesa/log/?h=7.8) since the beginning

Re: [Mesa-dev] GLX_USE_APPLEGL

2010-05-20 Thread Jeremy Huddleston
Hi Kristian, Thanks for your comments. I sent out a few requests to the mailing list a while back. I just took the silence as whatever. it doesn't really affect us. ... that being said, I actually share your concern about this #ifdef-crud. My main reason for integrating it as-is was to

Re: [Mesa-dev] [Fwd: Mesa (7.8): f]

2010-04-27 Thread Jeremy Huddleston
/mesa/commit/?id=39bd4602c0c31d4984293fd6e419405aca32d940 Author: Jeremy Huddleston jerem...@apple.com Date: Tue Apr 27 12:22:50 2010 -0700 f Signed-off-by: Jeremy Huddleston jerem...@apple.com --- src/glx/apple/apple_glx_pbuffer.c | 11 ++- 1 files changed, 10 insertions