Re: [Mesa-dev] [PATCH 1/4] st/nine: Fix bad tracking of bound vs textures

2018-03-14 Thread Patrick Rudolph
e was at least one texture read in the vs shader. > > Signed-off-by: Axel Davy The series is Reviewed-by: Patrick Rudolph Please also include it into 17.3 stable. > --- > src/gallium/state_trackers/nine/nine_state.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion

Re: [Mesa-dev] [PATCH] nv50, nvc0: disable depth offsets when there is no depth buffer

2017-01-15 Thread Patrick Rudolph
On Sun, 15 Jan 2017 22:06:01 +0100 Axel Davy wrote: As far as I remember this doesn't affact wine, as it resets the offset in case no depth buffer is attached. The same could be done in nine, but would add some overhead and it isn't required on other gallium drivers. Regards, Patrick > Shouldn't

Re: [Mesa-dev] [PATCH] r600g: fix and optimize tgsi_cmp when using ABS and NEG modifier

2016-04-24 Thread Patrick Rudolph
On 2016-04-07 08:10 AM, Dave Airlie wrote: > On 7 April 2016 at 15:43, Ian Romanick wrote: >> On 04/02/2016 02:45 AM, Patrick Rudolph wrote: >>> Are there optimizations done on TGSI ? >>> I can't find any file in src/gallium/auxiliary/tgsi that does so. >>

Re: [Mesa-dev] [PATCH] r600g: fix and optimize tgsi_cmp when using ABS and NEG modifier

2016-04-02 Thread Patrick Rudolph
) for quite some time, and we've found that > having x==0 instead of -abs(x)>=0 in higher-level IR helps other > optimizations make progress. Maybe do this when translating out of TGSI? > > On 03/30/2016 03:30 AM, Patrick Rudolph wrote: >> It affects the game "RIFT&quo

Re: [Mesa-dev] [PATCH] r600g: fix and optimize tgsi_cmp when using ABS and NEG modifier

2016-03-30 Thread Patrick Rudolph
It affects the game "RIFT" and fixes slightly wrong colors on the player model, when using the nine state-tracker. Kind Regards, Patrick On 2016-03-29 11:09 PM, Dave Airlie wrote: > On 28 March 2016 at 19:52, wrote: >> From: Patrick Rudolph >> >> Some apps set

Re: [Mesa-dev] [PATCH 00/12] Some more Nine fixes

2016-02-11 Thread Patrick Rudolph
For commit 1-9 and 11 Series is Reviewed-by: Patrick Rudolph On 2016-02-08 12:13 AM, Axel Davy wrote: > A few more patches I'd like to get in 11.2. > > There a few cleanup patches and some fixes. > > The last patch fixes build with llvm 32 bits > when it isn'

Re: [Mesa-dev] [PATCH v2] st/nine: Implement Managed vertex/index buffers

2016-02-11 Thread Patrick Rudolph
On 2016-02-06 03:12 PM, Axel Davy wrote: > We were implementing those the same way than > the default pool, which is sub-optimal. > > The buffer is supposed to return pointer to > a ram copy when user locks, and automatically > update the vram copy when needed. > > v2: Rename NineBuffer9_Validate

[Mesa-dev] [PATCH] util/u_helpers: return correct number of bound buffers

2015-12-10 Thread Patrick Rudolph
ing at the top-most slot results in correct behaviour. Calculating the correct number of bound buffers fixes a NULL pointer dereference in nvc0_validate_vertex_buffers_shared(). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93004 Signed-off-by: Patrick Rudolph --- src/gallium/auxiliary/u

Re: [Mesa-dev] [PATCH 2/2] util/u_helpers: return correct number of bound buffers

2015-12-09 Thread Patrick Rudolph
d Regards, Patrick On 2015-12-09 07:10 PM, Ilia Mirkin wrote: > I'm probably just being dense... can you provide an exact sequence of > calls that would cause this logic to fail? Seems like it should work > as-is... > > On Sun, Dec 6, 2015 at 4:12 AM, Patrick Rudolph wrote:

[Mesa-dev] [PATCH 1/2] nvc0: fix use after free of pipe_resource

2015-12-06 Thread Patrick Rudolph
Always reset the vertex bufctx to make sure there's no pointer to an already freed pipe_resource left after unbinding buffers. Fixes use after free crash in nvc0_bufctx_fence(). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93004 Signed-off-by: Patrick Rudolph --- src/gallium/dr

[Mesa-dev] [PATCH 2/2] util/u_helpers: return correct number of bound buffers

2015-12-06 Thread Patrick Rudolph
ber of bound buffers fixes a NULL pointer dereference in nvc0_validate_vertex_buffers_shared(). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93004 Signed-off-by: Patrick Rudolph --- src/gallium/auxiliary/util/u_helpers.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) d