[Mesa-dev] [PATCH] spirv: convert the shift operand for bitwise shift ops to uint32

/2018-April/193026.html Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- src/compiler/spirv/vtn_alu.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/compiler/spirv/vtn_alu.c b/src/compiler/spirv/vtn_alu.c index 71e743cdd1e..1d33ae28273 100644 ---

Re: [Mesa-dev] [PATCH 0/2] i965: Add support for fp16 <-> fp64 conversions

These two patches are still unreviewed. Sam On 13/04/18 07:30, Samuel Iglesias Gonsálvez wrote: > Hello, > > This series implements support for doing fp16 <-> fp64 conversions on > i965. The PRM says we need to do an intermediate conversion to a 32 bit > type. > >

Re: [Mesa-dev] NIR issue with SPIRV ops that have operands with different bit-size

rk wrote: > > On Tue, Apr 24, 2018 at 4:24 AM, Samuel Iglesias Gonsálvez > > <sigles...@igalia.com <mailto:sigles...@igalia.com>> wrote: > >> Hello, > >> > >> Recently, we have found problems between some SPIRV opcodes and &g

[Mesa-dev] NIR issue with SPIRV ops that have operands with different bit-size

Hello, Recently, we have found problems between some SPIRV opcodes and NIR. SPIR-V allows opcodes to mix different bit-sizes for their operands, such as for some bitfield operations and other ops like bitwise shifts. In NIR, when the ALU opcode doesn't have specified bitsizes for their

[Mesa-dev] [PATCH 1/2] i965/fs: implement conversions from float16 to 64 bits data types

Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- src/intel/compiler/brw_fs_nir.cpp | 32 1 file changed, 32 insertions(+) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index 822a1ac4227..2c007a2a5a7

[Mesa-dev] [PATCH 2/2] i965/fs: Implement float64 to float16 conversion

It is not supported directly in the HW, we need to convert to float32 first as intermediate step. Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- src/intel/compiler/brw_fs_nir.cpp | 17 + 1 file changed, 17 insertions(+) diff --git a/src/intel/co

[Mesa-dev] [PATCH 0/2] i965: Add support for fp16 <-> fp64 conversions

ub.com/Igalia/mesa.git \ -b siglesias/vulkan-fp16-fp64-conversions There are tests for Vulkan CTS under review (CL#2246) for testing these patches. Best regards, Sam [0] https://lists.freedesktop.org/archives/mesa-dev/2018-April/191888.html Samuel Iglesias Gonsálvez (2): i965/fs: imp

Re: [Mesa-dev] [PATCH 1/7] i965: Move unmap_gtt before map_gtt

Patches 1-6 are, Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> On 12/04/18 02:10, Chris Wilson wrote: > Reorder code to avoid a forward declaration in the next patch. > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > --- >

Re: [Mesa-dev] [PATCH] nir: rename variables in nir_lower_io_to_temporaries for clarity

Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> Sam On 05/04/18 01:16, Caio Marcelo de Oliveira Filho wrote: > In the emit_copies() function, the use of "newv" and "temp" names made > sense when only copies from temporaries to the new vari

[Mesa-dev] XDC 2018: Call for Papers

Hello, I have the pleasure to announce that the X.org Developer Conference 2018 will be held in A Coruña, Spain from September 26th to September 28th. The venue is located at the Computer Science faculty of the University of Coruña. This year, we have created a new website for the event:

[Mesa-dev] [PATCH 1/2] spirv: fix the translation of SPIR-V conversion opcodes to NIR

There are some SPIRV opcodes (like UConvert and SConvert) have some expectations of the output that doesn't depend on the operands data type. Generalize the solution of all of them. Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- src/compiler/spirv/vtn_alu.

[Mesa-dev] [PATCH 2/2] spirv: update arguments for vtn_nir_alu_op_for_spirv_opcode()

We don't need anymore the source and destination's data type, just their bitsize. Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- src/compiler/spirv/spirv_to_nir.c | 4 ++-- src/compiler/spirv/vtn_alu.c | 30 ++ src/compiler

Re: [Mesa-dev] [PATCH v3 1/2] spirv: fix OpSConvert when the source is unsigned

On 13/03/18 19:23, Jason Ekstrand wrote: > On Tue, Mar 13, 2018 at 5:40 AM, Samuel Iglesias Gonsálvez > <sigles...@igalia.com <mailto:sigles...@igalia.com>> wrote: > > OpSConvert interprets the MSB of the unsigned value as the sign > bit and > extends

[Mesa-dev] [PATCH v3 2/2] spirv: fix OpUConvert when the source is signed

From: Iago Toral Quiroga In this case we don't want to do sign-extension, since the value is interpreted as unsigned. If we want sign-extension, OpSConvert should be used. v2: - Use src/dst bitsize to get the proper conversion opcode. (Jason) --- src/compiler/spirv/vtn_alu.c

[Mesa-dev] [PATCH v3 1/2] spirv: fix OpSConvert when the source is unsigned

) Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- src/compiler/spirv/vtn_alu.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/compiler/spirv/vtn_alu.c b/src/compiler/spirv/vtn_alu.c index d0c9e316935..9dcd183a48d 100644 --- a/src/compiler

Re: [Mesa-dev] [PATCH v2 1/2] spirv: fix OpSConvert when the source is unsigned

On 12/03/18 20:42, Jason Ekstrand wrote: > On Mon, Mar 5, 2018 at 10:21 PM, Samuel Iglesias Gonsálvez > <sigles...@igalia.com <mailto:sigles...@igalia.com>> wrote: > > OpSConvert interprets the MSB of the unsigned value as the sign > bit and > extends

Re: [Mesa-dev] [PATCH 00/56] anv: Add support for Vulkan 1.1

Thanks a lot Jason! As Iago said, we are pleased to had the opportunity to work with you on this :-D Sam On 08/03/18 00:08, Jason Ekstrand wrote: > Hi all, > > I just wanted to give a shout out and a huge "Thank You!" to all of > the people who made this release possible.  There were a large

Re: [Mesa-dev] [PATCH] spirv: Add SpvCapabilityShaderViewportIndexLayerEXT

On 05/03/18 22:58, Caio Marcelo de Oliveira Filho wrote: > This capability allows gl_ViewportIndex and gl_Layer to also be used > as outputs in Vertex and Tesselation shaders. > > v2: Make conditional to the capability, add gl_Layer, add tesselation > shaders. (Iago) > > v3: Don't export to

[Mesa-dev] [PATCH v2 2/2] spirv: fix OpUConvert when the source is signed

From: Iago Toral Quiroga In this case we don't want to do sign-extension, since the value is interpreted as unsigned. If we want sign-extension, OpSConvert should be used. --- src/compiler/spirv/vtn_alu.c | 20 +++- 1 file changed, 19 insertions(+), 1

[Mesa-dev] [PATCH v2 1/2] spirv: fix OpSConvert when the source is unsigned

OpSConvert interprets the MSB of the unsigned value as the sign bit and extends it to the new type. If we want to preserve the value, we need to use OpUConvert opcode. v2: - No need to check dst type. - Fix typo in comment. Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --

Re: [Mesa-dev] [PATCH] spirv: fix OpSConvert when the source is unsigned

Please ignore this patch. I am going to send a v2 of it, together with a fix for OpUConvert. Thanks, Sam On 05/03/18 11:18, Samuel Iglesias Gonsálvez wrote: > OpSConvert interprets the MSB of the unsigned value as the sign bit and > extends it to the new type. If we want to preserve the

[Mesa-dev] [PATCH] spirv: fix OpSConvert when the source is unsigned

OpSConvert interprets the MSB of the unsigned value as the sign bit and extends it to the new type. If we want to preserve the value, we need to use OpUConvert opcode. Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- src/compiler/spirv/vtn_alu.c | 19

Re: [Mesa-dev] [PATCH v2] anv: Don't expose VK_KHX_multiview on android.

Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> On 05/03/18 09:57, Tapani Pälli wrote: > Just like commit 2ffe395 does for radv. > > Fixes following dEQP test on i965: >dEQP-VK.api.info.android.no_unknown_extensions > > v2: make it !ANDROID since thi

Re: [Mesa-dev] [PATCH 1/4] intel: Split gen_device_info out into libintel_dev

On 28/02/18 11:15, Jordan Justen wrote: > On 2018-02-28 01:58:24, Samuel Iglesias Gonsálvez wrote: >> What is the idea for src/intel/dev/ ? >> >> I'm not against this patch, just asking. > Ken noticed a lot of duplicate lines in the xml for surface formats. > (Pat

Re: [Mesa-dev] [PATCH 1/4] intel: Split gen_device_info out into libintel_dev

On 28/02/18 10:58, Samuel Iglesias Gonsálvez wrote: > > What is the idea for src/intel/dev/ ? > > I'm not against this patch, just asking. > Anyway, this patch has my R-b too. Sam > Patches 2-4 are, > > Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> &

Re: [Mesa-dev] [PATCH 1/4] intel: Split gen_device_info out into libintel_dev

What is the idea for src/intel/dev/ ? I'm not against this patch, just asking. Patches 2-4 are, Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> Sam On 27/02/18 21:32, Jordan Justen wrote: > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> >

Re: [Mesa-dev] [PATCH 15/22] nir: Use De Morgan's Law on logic compounded comparisons

Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> On 24/02/18 00:56, Ian Romanick wrote: > From: Ian Romanick <ian.d.roman...@intel.com> > > The replacement of the comparison operators must happen during this > step. If it does not, the next pass of nir_op

Re: [Mesa-dev] [PATCH 19/22] i965/fs: Merge CMP and SEL into CSEL on Gen8+

Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> On 24/02/18 00:56, Ian Romanick wrote: > From: Ian Romanick <ian.d.roman...@intel.com> > > Skylake > total instructions in shared programs: 14514547 -> 14503025 (-0.08%) > instructions in affected progr

Re: [Mesa-dev] [PATCH 18/22] i965/fs: Add infrastructure for generating CSEL instructions.

s_generator::generate_code(const cfg_t *cfg, int > dispatch_width) >case BRW_OPCODE_SEL: >brw_SEL(p, dst, src[0], src[1]); >break; > + case BRW_OPCODE_CSEL: > + brw_set_default_access_mode(p, BRW_ALIGN_16); > + brw_CSEL(p, dst, s

Re: [Mesa-dev] [PATCH v4] anv: enable VK_EXT_shader_stencil_export

Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> On 28/02/18 07:34, Gustavo Lima Chaves wrote: > v2: > An attempt to support SpvExecutionModeStencilRefReplacingEXT's behavior > also follows, with the interpretation to said mode being we prevent > w

Re: [Mesa-dev] [PATCH] glsl/linker: fix bug when checking precision qualifier

On 27/02/18 13:37, Tapani Pälli wrote: > > > On 01/30/2018 09:50 AM, Samuel Iglesias Gonsálvez wrote: >> According to GLSL ES 3.2 spec, see table in 9.2.1 "Linked Shaders" >> section, the precision qualifier should match for uniform variables. >> This also

Re: [Mesa-dev] [PATCH 22/22] nir: Don't i2b a value that is already Boolean

Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> On 24/02/18 00:56, Ian Romanick wrote: > From: Ian Romanick <ian.d.roman...@intel.com> > > A bunch of shaders have sequences like: > > i2b(u2i(floatBitsToUint(intBitsToFloat(x == y ? -1 : 0 > &g

Re: [Mesa-dev] [PATCH 17/22] nir: Narrow some dot product operations

Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> On 24/02/18 00:56, Ian Romanick wrote: > From: Ian Romanick <ian.d.roman...@intel.com> > > On vector platforms, this helps elide some constant loads. > > No changes on Broadwell or Skylake. > > Haswe

Re: [Mesa-dev] [PATCH 16/22] nir: Simplify some comparisons like a+b < a

Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> Patches 12-14 were also reviewed but I clicked on Reply List, instead of Reply all. Sam On 24/02/18 00:56, Ian Romanick wrote: > From: Ian Romanick <ian.d.roman...@intel.com> > > All Gen7+ platforms had simi

Re: [Mesa-dev] [PATCH 14/22] nir: Replace fmin(b2f(a), b) with a bcsel

Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> On 24/02/18 00:55, Ian Romanick wrote: > From: Ian Romanick <ian.d.roman...@intel.com> > > All of the affected shaders are HDR mappers from Serious Sam 3. > > All Gen7+ platforms had similar resul

Re: [Mesa-dev] [PATCH 13/22] nir: Pull b2f out of bcsel

Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> On 24/02/18 00:55, Ian Romanick wrote: > From: Ian Romanick <ian.d.roman...@intel.com> > > All platforms had similar results. (Skylake shown) > total instructions in shared programs: 14516592 -> 1451

Re: [Mesa-dev] [PATCH 12/22] nir: Replace an odd comparison involving fmin of -b2f

Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> On 24/02/18 00:55, Ian Romanick wrote: > From: Ian Romanick <ian.d.roman...@intel.com> > > I noticed the fge version while looking at a shader for an unrelated > reason. The feq version prevents a regr

Re: [Mesa-dev] [PATCH 01/22] i965: Silence unused parameter warnings

Patches 1-10 are, Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> Sam On 24/02/18 00:55, Ian Romanick wrote: > From: Ian Romanick <ian.d.roman...@intel.com> > > Reduces my build from 7119 warnings to 7005 warnings by silencing 114 > instances of &

Re: [Mesa-dev] [PATCH] glsl/linker: fix bug when checking precision qualifier

Still unreviewed. Sam On 12/02/18 09:10, Samuel Iglesias Gonsálvez wrote: > This patch is still unreviewed. > > Sam > > > On 30/01/18 08:50, Samuel Iglesias Gonsálvez wrote: >> According to GLSL ES 3.2 spec, see table in 9.2.1 "Linked Shaders" >> secti

Re: [Mesa-dev] [PATCH v2 2/9] intel/blorp: Add indirect clear color support to mcs_partial_resolve

Acked-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> Sam On 24/02/18 07:22, Jason Ekstrand wrote: > This is a bit complicated because we have to get the indirect clear > color in there somehow. In order to not do any more work in the shader > than needed, we set it up as

[Mesa-dev] [PATCH v2] anv: set maxResourceSize to the respective value for each generation

v2: - Add the proper values to gen9+ (Jason) Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- src/intel/vulkan/anv_formats.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c

Re: [Mesa-dev] [PATCH] anv: fix maxResourceSize for pre-gen9

On 26/02/18 17:02, Jason Ekstrand wrote: > On Mon, Feb 26, 2018 at 12:58 AM, Samuel Iglesias Gonsálvez > <sigles...@igalia.com <mailto:sigles...@igalia.com>> wrote: > > Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com > <mailto:sigles...@

[Mesa-dev] [PATCH] anv: fix maxResourceSize for pre-gen9

Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- src/intel/vulkan/anv_formats.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c index 9c52ad5acbd..324797b7f10 100644 --- a/src/intel/

Re: [Mesa-dev] [PATCH v2 0/9] anv: Enable fast-clears for multisampled images

Patches 1, 3-9 are: Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> Sam On 24/02/18 07:22, Jason Ekstrand wrote: > We've had multisample compression support for some time and we've had > single-sampled fast-clears but multisampled fast clears haven't been all

Re: [Mesa-dev] [PATCH 0/5] anv: Support CCS_E for images which may be used for

Series is, Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> Sam On 06/02/18 00:13, Jason Ekstrand wrote: > This little series adds support for enabling CCS_E for images which may > have VK_IMAGE_USAGE_STORAGE_BIT set. Previously, we just bailed on these > images a

Re: [Mesa-dev] [PATCH] glsl/linker: fix bug when checking precision qualifier

This patch is still unreviewed. Sam On 30/01/18 08:50, Samuel Iglesias Gonsálvez wrote: > According to GLSL ES 3.2 spec, see table in 9.2.1 "Linked Shaders" > section, the precision qualifier should match for uniform variables. > This also applies to previou

Re: [Mesa-dev] [PATCH 1/6] intel/vulkan: Support INTEL_NO_HW environment variable

Series is, Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> Sam On 10/02/18 09:06, Jordan Justen wrote: > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > --- > src/intel/vulkan/anv_device.c | 3 +++ > src/intel/vulkan/anv_private.h |

Re: [Mesa-dev] [PATCH 1/2] intel/compiler: fix first_component for 64-bit types on vertex inputs

Series is, Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> Sam On 19/01/18 09:17, Iago Toral Quiroga wrote: > Divide it by two as we do for other stages. This is because the > component layout qualifier is always in 32-bit units. > > Fixes issues in a new C

[Mesa-dev] [PATCH] glsl/linker: fix bug when checking precision qualifier

blocks.cpp. Fixes: b50b82b8a553 ("glsl/es31: precision qualifier doesn't need to match in shader interface block members") Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- src/compiler/glsl/linker.cpp | 12 1 file changed, 4 insertions(+), 8 dele

Re: [Mesa-dev] [PATCH 1/4] Revert "anv/meson: Make anv_entrypoints_gen.py depend on anv_extensions.py"

I am not a meson expert but changes look fine. The series is: Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> Sam On 23/01/18 18:44, Dylan Baker wrote: > This reverts commit 10d1b0be8e9c463dbc35cd66968299f33c76672c. > > This is unnecessary, the depend_files argumen

Re: [Mesa-dev] [PATCH 00/21] anv: Follow the rules for vkGet*ProcAddr

On 23/01/18 09:01, Jason Ekstrand wrote: > On Mon, Jan 22, 2018 at 11:46 PM, Samuel Iglesias Gonsálvez > <sigles...@igalia.com <mailto:sigles...@igalia.com>> wrote: > > I have comments on patch 2 and 18 (below). For the rest, > > Reviewed-by: Sam

Re: [Mesa-dev] [PATCH 00/21] anv: Follow the rules for vkGet*ProcAddr

I have comments on patch 2 and 18 (below). For the rest, Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> On 20/01/18 20:11, Jason Ekstrand wrote: > Our previous scheme for Get*ProcAddr was to just return what we could and > not care about the details.

Re: [Mesa-dev] [PATCH 02/21] anv: Split anv_extensions.py into two files

On 20/01/18 20:11, Jason Ekstrand wrote: > The new anv_extensions_gen.py is the code generator while the old > anv_extensions.py file is purely declarative. > --- > src/intel/Makefile.vulkan.am | 3 +- > src/intel/vulkan/anv_extensions.py | 154 --- >

Re: [Mesa-dev] [PATCH 00/21] anv: Follow the rules for vkGet*ProcAddr

rt of exposing a few symbols, > is now a completely stand-alone Vulkan implementation and doesn't require a > loader. > > Cc: Samuel Iglesias Gonsálvez <sigles...@igalia.com> > > Jason Ekstrand (21): > anv/meson: Make anv_entrypoints_gen.py depend on anv_extensions.p

Re: [Mesa-dev] [PATCH v2] anv: implement VK_EXT_global_priority extension

Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> Sam On 19/01/18 12:36, Tapani Pälli wrote: > v2: add ANV_CONTEXT_REALTIME_PRIORITY (Chris) > use unreachable with unknown priority (Samuel) > > Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> >

Re: [Mesa-dev] [PATCH] anv: implement VK_EXT_global_priority extension

On 19/01/18 12:11, Tapani Pälli wrote: > > > On 01/19/2018 01:08 PM, Samuel Iglesias Gonsálvez wrote: >> >> >> On 19/01/18 11:44, Tapani Pälli wrote: >>> Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> >>> --- >>> >>>

Re: [Mesa-dev] [PATCH] anv: implement VK_EXT_global_priority extension

Oh, Chris was faster :) Sam On 19/01/18 12:08, Samuel Iglesias Gonsálvez wrote: > > On 19/01/18 11:44, Tapani Pälli wrote: >> Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> >> --- >> >> Small crucible test available here: >> https://cgit.

Re: [Mesa-dev] [PATCH] anv: implement VK_EXT_global_priority extension

On 19/01/18 11:44, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > --- > > Small crucible test available here: > https://cgit.freedesktop.org/~tpalli/crucible/commit/?h=VK_EXT_global_priority > > src/intel/vulkan/anv_device.c | 25 +++ >

[Mesa-dev] [PATCH] anv: avoid segmentation fault due to vk_error()

vk_error() is a macro that calls __vk_errorf() with instance == NULL. Then, __vk_errorf() passes a pointer to instance->debug_report_callbacks to vk_debug_error(), which segfaults as this pointer is invalid but not NULL. Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com>

Re: [Mesa-dev] [PATCH 0/8] Algebraic optimizations

Series is, Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> On 17/01/18 01:44, Ian Romanick wrote: > This is the first series to resurrect some work that I started as long > as 2.5 years ago. A lot of that work produced mixed bag results, but > that was before nir_o

[Mesa-dev] [PATCH v4] anv: return VK_ERROR_OUT_OF_DEVICE_MEMORY when surface size is out of HW limits

Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- src/intel/vulkan/anv_image.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 4d13e05e11f..72e408764d8 100644 --- a/src/intel/

Re: [Mesa-dev] [PATCH v3 1/2] isl: don't crash when creating a huge image

er just making anv fail gracefully, I am going to send a patch now with it. Sam > On Mon, Jan 15, 2018 at 4:03 AM, Samuel Iglesias Gonsálvez > <sigles...@igalia.com <mailto:sigles...@igalia.com>> wrote: > > The HW has some limits but, according to the spec, we can cr

Re: [Mesa-dev] [PATCH 02/10] i965: Use the translated color logic op from the context

For patches 2, 5-9, Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> Sam On 12/01/18 23:56, Ian Romanick wrote: > From: Ian Romanick <ian.d.roman...@intel.com> > > And delete the resulting dead code. > > Signed-off-by: Ian Romanick <ian.d.roman..

[Mesa-dev] [PATCH v3 2/2] anv: return VK_ERROR_OUT_OF_DEVICE_MEMORY when surface size is out of HW limits

Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- src/intel/vulkan/anv_image.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 4d13e05e11f..401de16ddc5 100644 --- a/src/intel/vulkan/anv_image.c +++

[Mesa-dev] [PATCH v3 1/2] isl: don't crash when creating a huge image

-VK.pipeline.render_to_image.core.2d_array.huge.* dEQP-VK.pipeline.render_to_image.core.cube_array.huge.* Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- src/intel/isl/isl.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/intel/isl/isl.c b/src

Re: [Mesa-dev] [PATCH v2] isl: don't crash when creating a huge image

ane); Hence, we fail in vkCreateImage() with VK_ERROR_OUT_OF_DEVICE_MEMORY as the suggested change to the spec, with zero changes to other users of isl_surf_init() . If you agree, I will send both patches again for review. Sam > On Thu, Jan 11, 2018 at 5:04 AM, Samuel Iglesias Gonsálvez > <sigle

Re: [Mesa-dev] [PATCH v2] isl: don't crash when creating a huge image

This patch is still unreviewed. Sam On 14/11/17 09:45, Samuel Iglesias Gonsálvez wrote: > The HW has some limits but, according to the spec, we can create > the image as it has not yet any memory backing it. This patch > logs a debug error and set the size to the UINT64_MAX in order t

[Mesa-dev] [PATCH] anv: VkDescriptorSetLayoutBinding can have descriptorCount == 0

ayout." Fixes: dEQP-VK.binding_model.descriptor_update.empty_descriptor.uniform_buffer Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- src/intel/vulkan/anv_descriptor_set.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_des

[Mesa-dev] [PATCH] anv: fix maxDescriptorSet* limits

ot; Fixes: dEQP-VK.api.info.device.properties Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- Fixes CL#2078. Jason, I don't now if is there any HW limitation for these. src/intel/vulkan/anv_device.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

[Mesa-dev] [PATCH] anv: disallow VK_REMAINING_ARRAY_LAYERS in vkCmdClearAttachments()

Vulkan spec doesn't specify that VK_REMAINING_ARRAY_LAYERS is allowed in the passed VkClearRect struct. Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- src/intel/vulkan/anv_blorp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/vulkan/anv_blorp.c b/src

Re: [Mesa-dev] [PATCH] anv: fix bug when VK_REMAINING_ARRAY_LAYERS is used in vkCmdClearAttachments()

n > > > On December 15, 2017 03:36:07 Samuel Iglesias Gonsálvez > <sigles...@igalia.com> wrote: > >> Blorp was not supporting the use of the constant >> VK_REMAINING_ARRAY_LAYERS >> (whose value is ~0) in the VkClearRect structure. If we receive it, we >>

[Mesa-dev] [PATCH] anv: fix bug when VK_REMAINING_ARRAY_LAYERS is used in vkCmdClearAttachments()

Blorp was not supporting the use of the constant VK_REMAINING_ARRAY_LAYERS (whose value is ~0) in the VkClearRect structure. If we receive it, we need to calculate the layer count as the image layers count minus the base array layer. Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.

Re: [Mesa-dev] [PATCH v2] isl: don't crash when creating a huge image

On 28/11/17 11:07, Samuel Iglesias Gonsálvez wrote: > This patch is still unreviewed. > Gently reminder. Sam > Sam > > On Tue, 2017-11-14 at 09:45 +0100, Samuel Iglesias Gonsálvez wrote: >> The HW has some limits but, according to the spec, we can create >> the

Re: [Mesa-dev] [PATCH 1/8] spirv: Add a vtn_type field to all vtn_values

Patches 1, 3, 4, 5, 6, 7 are, Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> Sam On 07/12/17 17:12, Jason Ekstrand wrote: > At the moment, this just lets us drop the const_type for constants and > unify things a bit. Eventually, we will use this to store the types o

Re: [Mesa-dev] [PATCH 1/4] spirv: Make sampled images a real type

Series is, Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> Sam On 08/12/17 08:42, Jason Ekstrand wrote: > Previously, we just gave them exactly the same type as the respective > image (which already had a sampler2D or similar type). Now they have > thei

[Mesa-dev] [PATCH v3] anv: fix bug when using component qualifier in FS outputs

.linkage.varying.component.frag_out.* v3: - Remove FRAG_RESULT_MAX. - Add const and use sizeof (Ian). - Do three-pass to set properly the locations of fragment outputs when having arrays (Jason). Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- I wrote CL#2003 addin

Re: [Mesa-dev] [PATCH 2/2] glsl: don't run intrastage array validation when the interface type is not an array

es it sound good to you? Sam > On 09.11.2017 12:48, Samuel Iglesias Gonsálvez wrote: > > Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> > > --- > > src/compiler/glsl/link_interface_blocks.cpp | 2 +- > > 1 file changed, 1 insertion(+), 1 de

Re: [Mesa-dev] [PATCH 1/2] glsl/es: precision qualifier doesn't need to match in UBOs

On Thu, 2017-11-30 at 15:46 +0100, Nicolai Hähnle wrote: > On 09.11.2017 12:48, Samuel Iglesias Gonsálvez wrote: > > Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> > > Can you also update the comment? I can't quite match what the > comment > says to

Re: [Mesa-dev] [PATCH v2] anv: fix bug when using component qualifier in FS outputs

On Tue, 2017-11-28 at 12:59 -0800, Jason Ekstrand wrote: > On Tue, Nov 14, 2017 at 10:39 PM, Samuel Iglesias Gonsálvez < > sigles...@igalia.com> wrote: > > > We can write to the same output but in different components, like > > in this example: > > > >

Re: [Mesa-dev] [PATCH v2] anv: fix bug when using component qualifier in FS outputs

; Reviewed-by: Ian Romanick <ian.d.roman...@intel.com> > > On 11/28/2017 02:06 AM, Samuel Iglesias Gonsálvez wrote: > > This patch is still unreviewed. > > > > Sam > > > > On Wed, 2017-11-15 at 07:39 +0100, Samuel Iglesias Gonsálvez wrote: > > &

Re: [Mesa-dev] [PATCH 2/2] spirv: fix bug when OpSpecConstantOp calls a conversion

On Tue, 2017-11-28 at 13:13 -0800, Ian Romanick wrote: > On 11/20/2017 10:25 PM, Samuel Iglesias Gonsálvez wrote: > > In that case, nir_eval_const_opcode() will evaluate the conversion > > but as it was using destination's bit_size, the resulting > > value was just a cast o

Re: [Mesa-dev] [PATCH v3 4/4] spirv: add support for images and samplers as function arguments

This patch is still unreviewed. Sam On Wed, 2017-10-18 at 09:54 +0200, Samuel Iglesias Gonsálvez wrote: > Fixes: > > dEQP-VK.spirv_assembly.instruction.*.image_sampler.* > > Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> > --- > src/co

Re: [Mesa-dev] [PATCH 1/2] glsl/es: precision qualifier doesn't need to match in UBOs

This patch series is still unreviewed. Sam On Thu, 2017-11-09 at 12:48 +0100, Samuel Iglesias Gonsálvez wrote: > Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> > --- > src/compiler/glsl/link_interface_blocks.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 del

Re: [Mesa-dev] [PATCH v2] isl: don't crash when creating a huge image

This patch is still unreviewed. Sam On Tue, 2017-11-14 at 09:45 +0100, Samuel Iglesias Gonsálvez wrote: > The HW has some limits but, according to the spec, we can create > the image as it has not yet any memory backing it. This patch > logs a debug error and set the size to the U

Re: [Mesa-dev] [PATCH v2] anv: fix bug when using component qualifier in FS outputs

This patch is still unreviewed. Sam On Wed, 2017-11-15 at 07:39 +0100, Samuel Iglesias Gonsálvez wrote: > We can write to the same output but in different components, like > in this example: > > layout(location = 0, component = 0) out ivec2 dEQP_FragColor_0; > layout(location = 0

Re: [Mesa-dev] [PATCH 1/2] spirv: allow specialization constants with bitsize different than 32 bits

This patch series is still unreviewed. Sam On Tue, 2017-11-21 at 07:25 +0100, Samuel Iglesias Gonsálvez wrote: > Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> > --- > src/compiler/spirv/spirv_to_nir.c | 1 - > 1 file changed, 1 deletion(-) > > diff --

[Mesa-dev] [PATCH 2/2] spirv: fix bug when OpSpecConstantOp calls a conversion

.*.opspecconstantop.*convert* Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- src/compiler/spirv/spirv_to_nir.c | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c

[Mesa-dev] [PATCH 1/2] spirv: allow specialization constants with bitsize different than 32 bits

Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- src/compiler/spirv/spirv_to_nir.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 027efab88d7..2cc3c275ea9 100644 --- a/src/compiler

Re: [Mesa-dev] [PATCH 3/4] i965: Rewrite disassembly annotation code

You can add my Acked-by to this patch, I skimmed over it and I have not found any error. Acked-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> I would be better for review if it was split in different patches, even though they would be squashed together before pushing to master

Re: [Mesa-dev] [PATCH 4/4] i965: Rename intel_asm_annotation -> brw_disasm_info

Patches 1, 2 and 4 are: Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> Sam On Thu, 2017-11-16 at 20:47 -0800, Matt Turner wrote: > It was the only file named intel_* in the compiler. > --- > src/intel/Makefile.sources | 6

[Mesa-dev] [PATCH v2] anv: fix bug when using component qualifier in FS outputs

.linkage.varying.component.frag_out.* Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- src/compiler/shader_enums.h | 1 + src/intel/vulkan/anv_pipeline.c | 46 +++-- 2 files changed, 32 insertions(+), 15 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] anv: fix bug when using component qualifier in FS outputs

On Wed, 2017-11-08 at 08:19 -0800, Jason Ekstrand wrote: > On Thu, Nov 2, 2017 at 12:28 AM, Samuel Iglesias Gonsálvez < > sigles...@igalia.com> wrote: > > > We can write to the same output but in different components, like > > in this example: > > > >

[Mesa-dev] [PATCH v2] isl: don't crash when creating a huge image

-VK.pipeline.render_to_image.core.2d_array.huge.* dEQP-VK.pipeline.render_to_image.core.cube_array.huge.* Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- src/intel/isl/isl.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/intel/isl/isl.c b/src

Re: [Mesa-dev] [PATCH] anv: don't crash when creating a huge image

On Thu, 2017-11-09 at 16:34 -0800, Jason Ekstrand wrote: > On Thu, Nov 9, 2017 at 4:23 PM, Chad Versace <chadvers...@chromium.or > g> > wrote: > > > On Wed 08 Nov 2017, Jason Ekstrand wrote: > > > On Wed, Nov 8, 2017 at 1:34 AM, Samuel Iglesias Gonsálvez <[

Re: [Mesa-dev] [PATCH 1/2] glsl/es: precision qualifier doesn't need to match in UBOs

I forgot to add here that GLSL ES 320 requires precisions to match for default uniforms, but not for uniforms in UBOs. This spec change also affects OpenGL ES 3.1 and OpenGL ES 3.0. I fixed it locally. Sam On Thu, 2017-11-09 at 12:48 +0100, Samuel Iglesias Gonsálvez wrote: > Signed-

[Mesa-dev] [PATCH 2/2] glsl: don't run intrastage array validation when the interface type is not an array

Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- src/compiler/glsl/link_interface_blocks.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/link_interface_blocks.cpp b/src/compiler/glsl/link_interface_blocks.cpp index c2c3b

[Mesa-dev] [PATCH 1/2] glsl/es: precision qualifier doesn't need to match in UBOs

Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- src/compiler/glsl/link_interface_blocks.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/link_interface_blocks.cpp b/src/compiler/glsl/link_interface_blocks.cpp index 510d4

[Mesa-dev] [PATCH] anv: don't crash when creating a huge image

s the crashes on BDW for the following tests: dEQP-VK.pipeline.render_to_image.core.2d_array.huge.* dEQP-VK.pipeline.render_to_image.core.cube_array.huge.* Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- Jason, I was tempted to move this piece of code to anv_Allocat

Re: [Mesa-dev] [PATCH] anv: fix bug when using component qualifier in FS outputs

Gently reminder that this patch is still unreviewed :-) Sam On Thu, 2017-11-02 at 08:28 +0100, Samuel Iglesias Gonsálvez wrote: > We can write to the same output but in different components, like > in this example: > > layout(location = 0, component = 0) out ivec2 dEQP_FragColor

Re: [Mesa-dev] [PATCH v3 1/4] nir: set default lod to texture opcodes that needed it but don't provide it

On Thu, 2017-10-19 at 06:55 -0700, Jason Ekstrand wrote: > On October 18, 2017 11:44:12 PM Samuel Iglesias Gonsálvez > <sigles...@igalia.com> wrote: > > > On Wednesday, October 18, 2017 8:11:01 AM CEST Jason Ekstrand > > wrote: > > > On October 18, 2017 1

<    1   2   3   4   5   6   7   8   9   10   >