On 06.04.2012 17:38, nobled wrote:
> On Mon, Apr 2, 2012 at 7:40 AM, Tolga Dalman
> wrote:
> Hi,
>
>
> On 02.04.2012 00:24, nobled wrote:
>>>> #define LIST_FOR_EACH_ENTRY(pos, head, member)
>>>>\
>>>>
Hi Vadim,
On 03.04.2012 15:29, Vadim Girlin wrote:
> On Mon, 2012-04-02 at 13:19 +0200, Tolga Dalman wrote:
>>> +static unsigned
>>> +hash_table_var_hash(const void *key)
>>> +{
>>> + ir_variable *var = (ir_variable*) key;
>>
>> Why not us
hould be possible quite easily.
Best regards
Tolga Dalman
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJPeZAkAAoJEI0vwg8AaIlUzlQH/3dCLXcdoFvE9M7KtC/BEmhT
Qw+sYrG77VvQaMhB5uM6DpNkEZU
p
> @@ -54,11 +54,18 @@ public:
> virtual ir_visitor_status visit_leave(class ir_function_signature *);
> };
>
> +static unsigned
> +hash_table_var_hash(const void *key)
> +{
> + ir_variable *var = (ir_variable*) key;
Why not use const ir_variable instead ? In that case
hich would break MSVC. I think it's
> better to commit Vinson's patch as is.
Ok. Still, the builtin in the second #ifdef is useless as the variable
will never be used. However, this is another issue I guess.
Best regards
Tolga Dalman
-BEGIN PGP SIGNATURE-
Version: GnuPG
fined(PIPE_CC_MSVC) && defined(PIPE_ARCH_X86)
__asm {
mov frame_pointer, ebp
}
frame_pointer = (const void **)frame_pointer[0];
#else
frame_pointer = NULL;
#endif
Thus, the second and last block can be removed entirely.
Best regards
Tolga Dalman
-BEGIN PGP SIGNATURE-
Vers
rors.append(re.compile("AdapterInfo..*"))
Test.ignoreErrors.append(re.compile("No memory leaks detected."))
+Test.ignoreErrors.append(re.complie("libGL: Can't open configuration file*"))
s/complie/compile/
Best regards
Tolga Dalman
___
On Tue, 20 Sep 2011 08:20:27 -0700
Paul Berry wrote:
> On 20 September 2011 01:05, Tolga Dalman wrote:
> Tolga, your uneasiness is certainly justified in terms of conventional
> wisdom. As someone who used to write numerical analysis software, I cringe
> whenever I see floats co
On Tue, 20 Sep 2011 00:17:37 -0700 (PDT)
Michal Krol wrote:
> - Original Message -
> > On Sun, 11 Sep 2011 13:05:38 +0200, Tolga Dalman
> > wrote:
> > > Hi Kenneth,
> > >
> > > On Fri, 9 Sep 2011 14:41:45 -0700
> > > Kenne
F) {
> - return reg->imm.f == 1.0;
> + if (type == BRW_REGISTER_TYPE_F) {
> + return imm.f == 1.0;
Shouldn't this rather be something like
fabs(imm.f - 1.0) < std::numeric_limits::eps() ?
Nevertheless, I like your patch.
Best regards
Tolga Dalman
rontxrb->drawable && b->type == WINDOW) {
> + if (b->display && b->display == dpy && b->frontxrb->drawable &&
> b->type == WINDOW) {
Why not just check for dpy == NULL once at the beginning and leave out the
b->display check then ?
11 matches
Mail list logo
