Re: [Mesa-dev] [Mesa-stable] [PATCH 04/15] glsl: Add preprocessor error condition for #else directive

2014-06-11 Thread Carl Worth
Carl Worth writes: > I'll poke around at the existing code to see why the garbage after #else > is caught with #if 0, but not with #if 1. The difference is fairly straightforward, but it's going to be tricky to fix. Currently, the parser has a production for HASH_ELSE and NEWLINE tokens that loo

Re: [Mesa-dev] [Mesa-stable] [PATCH 04/15] glsl: Add preprocessor error condition for #else directive

2014-06-11 Thread Anuj Phogat
On Wed, Jun 11, 2014 at 6:51 PM, Carl Worth wrote: > Anuj Phogat writes: > >> #if 0 > >> #else garbage > >> #endif > >> > >> The Khronos test contains two tokens after #else. I'm not sure if that > >> is the difference or not. > > Khronos is testing many different cases. Failing case tests: > >

Re: [Mesa-dev] [Mesa-stable] [PATCH 04/15] glsl: Add preprocessor error condition for #else directive

2014-06-11 Thread Carl Worth
Anuj Phogat writes: >> #if 0 >> #else garbage >> #endif >> >> The Khronos test contains two tokens after #else. I'm not sure if that >> is the difference or not. > Khronos is testing many different cases. Failing case tests: > > #if 1 > #else garbage > #endif It is the "#if 1" that causes the exi