Re: [Mesa-dev] [PATCH] glxglvnddispatch: Add missing dispatch for GetDriverConfig

2017-05-17 Thread Hans de Goede
Hi, On 17-05-17 14:57, Emil Velikov wrote: On 16 May 2017 at 22:42, Hans de Goede wrote: Hi, On 05/16/2017 07:51 PM, Emil Velikov wrote: Hi Hans Please poke if patches fall through the cracks. On 20 March 2017 at 11:05, Hans de Goede wrote: Together with some fixes to xdriinfo this fi

Re: [Mesa-dev] [PATCH] glxglvnddispatch: Add missing dispatch for GetDriverConfig

2017-05-17 Thread Kyle Brenneman
On 05/17/2017 12:50 PM, Emil Velikov wrote: On 17 May 2017 at 17:05, Kyle Brenneman wrote: The patch assumes that glXGetDriverConfig will only ever be implemented by Mesa. As long as that's a safe assumption, the change looks right to me. Can you elaborate a bit more here? Both the AMDGPU-PRO

Re: [Mesa-dev] [PATCH] glxglvnddispatch: Add missing dispatch for GetDriverConfig

2017-05-17 Thread Emil Velikov
On 17 May 2017 at 17:05, Kyle Brenneman wrote: > The patch assumes that glXGetDriverConfig will only ever be implemented by > Mesa. As long as that's a safe assumption, the change looks right to me. Can you elaborate a bit more here? Both the AMDGPU-PRO stack and the ImgTec driver used in CrOS u

Re: [Mesa-dev] [PATCH] glxglvnddispatch: Add missing dispatch for GetDriverConfig

2017-05-17 Thread Kyle Brenneman
On 05/17/2017 06:57 AM, Emil Velikov wrote: On 16 May 2017 at 22:42, Hans de Goede wrote: Hi, On 05/16/2017 07:51 PM, Emil Velikov wrote: Hi Hans Please poke if patches fall through the cracks. On 20 March 2017 at 11:05, Hans de Goede wrote: Together with some fixes to xdriinfo this fixe

Re: [Mesa-dev] [PATCH] glxglvnddispatch: Add missing dispatch for GetDriverConfig

2017-05-17 Thread Emil Velikov
On 16 May 2017 at 22:42, Hans de Goede wrote: > Hi, > > > On 05/16/2017 07:51 PM, Emil Velikov wrote: >> >> Hi Hans >> >> Please poke if patches fall through the cracks. >> >> On 20 March 2017 at 11:05, Hans de Goede wrote: >>> >>> Together with some fixes to xdriinfo this fixes xdriinfo not work

Re: [Mesa-dev] [PATCH] glxglvnddispatch: Add missing dispatch for GetDriverConfig

2017-05-16 Thread Hans de Goede
Hi, On 05/16/2017 07:51 PM, Emil Velikov wrote: Hi Hans Please poke if patches fall through the cracks. On 20 March 2017 at 11:05, Hans de Goede wrote: Together with some fixes to xdriinfo this fixes xdriinfo not working with glvnd. Since apps (xdriinfo) expect GetDriverConfig to work witho

Re: [Mesa-dev] [PATCH] glxglvnddispatch: Add missing dispatch for GetDriverConfig

2017-05-16 Thread Emil Velikov
Hi Hans Please poke if patches fall through the cracks. On 20 March 2017 at 11:05, Hans de Goede wrote: > Together with some fixes to xdriinfo this fixes xdriinfo not working > with glvnd. > > Since apps (xdriinfo) expect GetDriverConfig to work without going to > need through the dance to setup

[Mesa-dev] [PATCH] glxglvnddispatch: Add missing dispatch for GetDriverConfig

2017-03-20 Thread Hans de Goede
Together with some fixes to xdriinfo this fixes xdriinfo not working with glvnd. Since apps (xdriinfo) expect GetDriverConfig to work without going to need through the dance to setup a glxcontext (which is a reasonable expectation IMHO), the dispatch for this ends up significantly different then a