[Mesa-dev] [PATCH] i965/fs: Use fs_reg for CS/VS atomics pixel mask immediate data

2015-02-20 Thread Jordan Justen
The brw_imm_ud will yield a HW_REG which then will introduce a barrier for certain optimization opportunities. No piglit regressions seen with gen8 (simd8vs). Suggested-by: Matt Turner Signed-off-by: Jordan Justen Cc: Matt Turner --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 4 ++-- 1 fi

Re: [Mesa-dev] [PATCH] i965/fs: Use fs_reg for CS/VS atomics pixel mask immediate data

2015-02-20 Thread Matt Turner
Reviewed-by: Matt Turner It might be a good idea to make the fs_reg(struct brw_reg) explicit to prevent this kind of mistake from happening. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/fs: Use fs_reg for CS/VS atomics pixel mask immediate data

2015-02-20 Thread Matt Turner
On Fri, Feb 20, 2015 at 1:14 PM, Jordan Justen wrote: > The brw_imm_ud will yield a HW_REG which then will introduce a barrier > for certain optimization opportunities. > > No piglit regressions seen with gen8 (simd8vs). > > Suggested-by: Matt Turner > Signed-off-by: Jordan Justen > Cc: Matt Tur