[Mesa-dev] [PATCH] intel: compiler: remove dead local variables at optimization pass

2018-09-03 Thread Lionel Landwerlin
We're hitting an assert in gfxbench because one of the local variable is a sampler (according to Jason this isn't valid) : testfw_app: ../src/compiler/nir_types.cpp:551: void glsl_get_natural_size_align_bytes(const glsl_type*, unsigned int*, unsigned int*): Assertion `!"type does not have a natu

[Mesa-dev] [PATCH] intel: compiler: remove dead local variables at optimization pass

2018-08-23 Thread Lionel Landwerlin
We're hitting an assert in gfxbench because one of the local variable is a sampler (according to Jason this isn't valid) : testfw_app: ../src/compiler/nir_types.cpp:551: void glsl_get_natural_size_align_bytes(const glsl_type*, unsigned int*, unsigned int*): Assertion `!"type does not have a natu

Re: [Mesa-dev] [PATCH] intel: compiler: remove dead local variables at optimization pass

2018-09-03 Thread Jason Ekstrand
On Thu, Aug 23, 2018 at 8:38 AM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > We're hitting an assert in gfxbench because one of the local variable > is a sampler (according to Jason this isn't valid) : > > testfw_app: ../src/compiler/nir_types.cpp:551: void > glsl_get_natural_size_a

Re: [Mesa-dev] [PATCH] intel: compiler: remove dead local variables at optimization pass

2018-09-03 Thread Lionel Landwerlin
On 03/09/2018 16:47, Lionel Landwerlin wrote: We're hitting an assert in gfxbench because one of the local variable is a sampler (according to Jason this isn't valid) : testfw_app: ../src/compiler/nir_types.cpp:551: void glsl_get_natural_size_align_bytes(const glsl_type*, unsigned int*, unsigne

Re: [Mesa-dev] [PATCH] intel: compiler: remove dead local variables at optimization pass

2018-09-03 Thread Jason Ekstrand
On September 3, 2018 10:47:11 Lionel Landwerlin wrote: We're hitting an assert in gfxbench because one of the local variable is a sampler (according to Jason this isn't valid) : testfw_app: ../src/compiler/nir_types.cpp:551: void glsl_get_natural_size_align_bytes(const glsl_type*, unsigned i

Re: [Mesa-dev] [PATCH] intel: compiler: remove dead local variables at optimization pass

2018-09-03 Thread Lionel Landwerlin
On 03/09/2018 17:15, Jason Ekstrand wrote: On September 3, 2018 10:47:11 Lionel Landwerlin wrote: We're hitting an assert in gfxbench because one of the local variable is a sampler (according to Jason this isn't valid) : testfw_app: ../src/compiler/nir_types.cpp:551: void glsl_get_natural_s

Re: [Mesa-dev] [PATCH] intel: compiler: remove dead local variables at optimization pass

2018-09-04 Thread Andres Gomez
Lionel, should we also include this in the stable queues ? On Mon, 2018-09-03 at 16:47 +0100, Lionel Landwerlin wrote: > We're hitting an assert in gfxbench because one of the local variable > is a sampler (according to Jason this isn't valid) : > > testfw_app: ../src/compiler/nir_types.cpp:551:

Re: [Mesa-dev] [PATCH] intel: compiler: remove dead local variables at optimization pass

2018-09-04 Thread Jason Ekstrand
Doesn't matter too much On Tue, Sep 4, 2018 at 3:45 PM Andres Gomez wrote: > Lionel, should we also include this in the stable queues ? > > > On Mon, 2018-09-03 at 16:47 +0100, Lionel Landwerlin wrote: > > We're hitting an assert in gfxbench because one of the local variable > > is a sampler (ac

Re: [Mesa-dev] [PATCH] intel: compiler: remove dead local variables at optimization pass

2018-09-04 Thread Andres Gomez
Thanks for the prompt reply, Jason. I will skip this patch, then. On Tue, 2018-09-04 at 15:51 -0500, Jason Ekstrand wrote: > Doesn't matter too much > > On Tue, Sep 4, 2018 at 3:45 PM Andres Gomez wrote: > > Lionel, should we also include this in the stable queues ? > > > > > > On Mon, 2018-0