Re: [Mesa-dev] [PATCH] mesa: Only validate SSO shader IO in OpenGL ES or debug context

2016-05-26 Thread Ilia Mirkin
On Thu, May 26, 2016 at 7:09 PM, Ian Romanick wrote: > On 05/26/2016 03:39 PM, Ilia Mirkin wrote: >> On Thu, May 26, 2016 at 6:26 PM, Ian Romanick wrote: >>> On 05/26/2016 03:03 PM, Ilia Mirkin wrote: This will cause st/mesa to break, no? Right now validate_io iterates over the shader i

Re: [Mesa-dev] [PATCH] mesa: Only validate SSO shader IO in OpenGL ES or debug context

2016-05-26 Thread Timothy Arceri
On Thu, 2016-05-26 at 14:59 -0700, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > Suggested-by: Timothy Arceri > Cc: Timothy Arceri Looks good to me. Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists

Re: [Mesa-dev] [PATCH] mesa: Only validate SSO shader IO in OpenGL ES or debug context

2016-05-26 Thread Ian Romanick
On 05/26/2016 03:39 PM, Ilia Mirkin wrote: > On Thu, May 26, 2016 at 6:26 PM, Ian Romanick wrote: >> On 05/26/2016 03:03 PM, Ilia Mirkin wrote: >>> This will cause st/mesa to break, no? Right now validate_io iterates >>> over the shader ir, which st/mesa frees after linking. >> >> Only as much as

Re: [Mesa-dev] [PATCH] mesa: Only validate SSO shader IO in OpenGL ES or debug context

2016-05-26 Thread Ilia Mirkin
On Thu, May 26, 2016 at 6:26 PM, Ian Romanick wrote: > On 05/26/2016 03:03 PM, Ilia Mirkin wrote: >> This will cause st/mesa to break, no? Right now validate_io iterates >> over the shader ir, which st/mesa frees after linking. > > Only as much as it is already broken. :) Any desktop OpenGL applic

Re: [Mesa-dev] [PATCH] mesa: Only validate SSO shader IO in OpenGL ES or debug context

2016-05-26 Thread Ian Romanick
On 05/26/2016 03:03 PM, Ilia Mirkin wrote: > This will cause st/mesa to break, no? Right now validate_io iterates > over the shader ir, which st/mesa frees after linking. Only as much as it is already broken. :) Any desktop OpenGL application using GLSL ES shaders would already have that problem.

Re: [Mesa-dev] [PATCH] mesa: Only validate SSO shader IO in OpenGL ES or debug context

2016-05-26 Thread Ilia Mirkin
This will cause st/mesa to break, no? Right now validate_io iterates over the shader ir, which st/mesa frees after linking. -ilia On Thu, May 26, 2016 at 5:59 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > Suggested-by: Timothy Arceri > Cc: Timothy Arceri >

[Mesa-dev] [PATCH] mesa: Only validate SSO shader IO in OpenGL ES or debug context

2016-05-26 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Suggested-by: Timothy Arceri Cc: Timothy Arceri --- src/mesa/main/pipelineobj.c| 18 -- src/mesa/main/shader_query.cpp | 12 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/pipelineo