Before validating vertex arrays we need to check if a VBO is present.
Checking if vb-buffer is not NULL fixes the issue.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
src/gallium/drivers/nouveau/nv50/nv50_vbo.c | 5 +
1 file changed, 5 insertions(+)
diff --git
+ } else
+ if (!vb-buffer) {
Should the else and if be on the same line?
The general style elsewhere is to do it in this weird way. Can't say
I'm a big fan, but I prefer consistency.
I'd happily take a change that undid that oddity.
Odd, okay.
signature.asc
On Mon, Jul 6, 2015 at 7:50 PM, Dylan Baker baker.dyla...@gmail.com wrote:
On Mon, Jul 06, 2015 at 11:34:23PM +0200, Samuel Pitoiset wrote:
Before validating vertex arrays we need to check if a VBO is present.
Checking if vb-buffer is not NULL fixes the issue.
Signed-off-by: Samuel Pitoiset
On Mon, Jul 06, 2015 at 11:34:23PM +0200, Samuel Pitoiset wrote:
Before validating vertex arrays we need to check if a VBO is present.
Checking if vb-buffer is not NULL fixes the issue.
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
src/gallium/drivers/nouveau/nv50/nv50_vbo.c
On Mon, Jul 6, 2015 at 7:55 PM, Dylan Baker baker.dyla...@gmail.com wrote:
+ } else
+ if (!vb-buffer) {
Should the else and if be on the same line?
The general style elsewhere is to do it in this weird way. Can't say
I'm a big fan, but I prefer consistency.
I'd happily take
Reviewed-by: Ilia Mirkin imir...@alum.mit.edu
But please change the commit title to mention the actual effect, like
avoid segfault with enabled but unbound vertex attrib or something.
The piglit fix should be mentioned in the body of the message -- it's
a nice side-effect, but not really
