The assert checks whether pshader->num_arrays != 0, but the code
after the assert actually branches based on the same check.
Removing this assert fixes:
piglit spec@arb_gpu_shader5@execution@samplemaskin-indirect
---
src/gallium/drivers/r600/sb/sb_bc_parser.cpp | 2 --
1 file changed, 2 deletio
On 11 September 2017 at 15:39, Gert Wollny wrote:
> The assert checks whether pshader->num_arrays != 0, but the code
> after the assert actually branches based on the same check.
>
> Removing this assert fixes:
> piglit spec@arb_gpu_shader5@execution@samplemaskin-indirect
Both assert() and if (
On 09/11/2017 07:09 PM, Emil Velikov wrote:
On 11 September 2017 at 15:39, Gert Wollny wrote:
The assert checks whether pshader->num_arrays != 0, but the code
after the assert actually branches based on the same check.
Removing this assert fixes:
piglit spec@arb_gpu_shader5@execution@sample
Am Dienstag, den 12.09.2017, 09:56 +0300 schrieb Vadim Girlin:
> On 09/11/2017 07:09 PM, Emil Velikov wrote:
> Anyway, if num_arrays is 0 there, I suspect it can be a result of
> some other issue. At the very least it looks like a potential
> performance problem, because in that case we assume all
On 09/12/2017 12:49 PM, Gert Wollny wrote:
Am Dienstag, den 12.09.2017, 09:56 +0300 schrieb Vadim Girlin:
On 09/11/2017 07:09 PM, Emil Velikov wrote:
Anyway, if num_arrays is 0 there, I suspect it can be a result of
some other issue. At the very least it looks like a potential
performance pro
On Tue, 12 Sep 2017 19:25:18 +0200, Vadim Girlin wrote:
On 09/12/2017 12:49 PM, Gert Wollny wrote:
Am Dienstag, den 12.09.2017, 09:56 +0300 schrieb Vadim Girlin:
On 09/11/2017 07:09 PM, Emil Velikov wrote:
Anyway, if num_arrays is 0 there, I suspect it can be a result of
some other issue.
Am Dienstag, den 12.09.2017, 23:44 +0200 schrieb Glenn Kennard:
>
> Vadim is correct, the fix is to extend the check in the if case above
> to also exclude TGSI_FILE_SYSTEM_VALUE, and keep the assert in place.
> ie:
>
> if (pshader->indirect_files & ~((1 << TGSI_FILE_CONSTANT) | (1 <<
> TGSI_FI
On 09/13/2017 11:16 AM, Gert Wollny wrote:
Am Dienstag, den 12.09.2017, 23:44 +0200 schrieb Glenn Kennard:
Vadim is correct, the fix is to extend the check in the if case above
to also exclude TGSI_FILE_SYSTEM_VALUE, and keep the assert in place.
ie:
if (pshader->indirect_files & ~((1 << TG
