Re: [Mesa-dev] [PATCH] vbo: Clean up recalculate_input_bindings.

2012-01-02 Thread Kenneth Graunke
On 12/26/2011 11:51 PM, Mathias Fröhlich wrote: Hi, On Tuesday, December 27, 2011 00:17:09 Brian Paul wrote: LGTM. I presume you've done a piglit run and tested with a few other things? I have run piglit quick with classic swrast an piglit r600g on gallium rv670 with this change. Also

Re: [Mesa-dev] [PATCH] vbo: Clean up recalculate_input_bindings.

2011-12-27 Thread Brian Paul
2011/12/27 Mathias Fröhlich mathias.froehl...@gmx.net: Hi, On Tuesday, December 27, 2011 00:17:09 Brian Paul wrote: LGTM.  I presume you've done a piglit run and tested with a few other things? I have run piglit quick with classic swrast an piglit r600g on gallium rv670 with this change.

Re: [Mesa-dev] [PATCH] vbo: Clean up recalculate_input_bindings.

2011-12-26 Thread Brian Paul
2011/12/25 Mathias Fröhlich mathias.froehl...@gmx.net: Hi, I have posted a very similar patch already with the array object change series. But I have omitted applying this one because of a general issue that Brian pointed me to in a patch prior to this one in the series. But it turns out

Re: [Mesa-dev] [PATCH] vbo: Clean up recalculate_input_bindings.

2011-12-26 Thread Mathias Fröhlich
Hi, On Tuesday, December 27, 2011 00:17:09 Brian Paul wrote: LGTM. I presume you've done a piglit run and tested with a few other things? I have run piglit quick with classic swrast an piglit r600g on gallium rv670 with this change. Also I am pretty sure that I have started osgviewer and

[Mesa-dev] [PATCH] vbo: Clean up recalculate_input_bindings.

2011-12-25 Thread Mathias Fröhlich
Hi, I have posted a very similar patch already with the array object change series. But I have omitted applying this one because of a general issue that Brian pointed me to in a patch prior to this one in the series. But it turns out that this one should be still safe. Please review Thanks