Re: [Mesa-dev] [PATCH] vbo: signal _NEW_ARRAY when transitioning between glBegin/End, glDrawArrays

2011-12-25 Thread Mathias Fröhlich
Hi Brian, On Saturday, December 24, 2011 16:38:09 Brian Paul wrote: From: Brian Paul bri...@vmware.com This fixes a regression seen with the isosurf demo when switching between glBegin/End and glDrawArrays (do it several times). The problem was the driver wasn't getting _NEW_ARRAY when

Re: [Mesa-dev] [PATCH] vbo: signal _NEW_ARRAY when transitioning between glBegin/End, glDrawArrays

2011-12-24 Thread Brian Paul
2011/12/23 Mathias Fröhlich mathias.froehl...@gmx.net: Hi, On Thursday, December 22, 2011 18:30:44 Brian Paul wrote: I'm not sure if playback_vertex_list is more like DRAW_BEGIN_END or DRAW_ARRAYS. Maybe add a DRAW_DISPLAY_LIST enum value? It's more like begin/end I think. The begin/end

[Mesa-dev] [PATCH] vbo: signal _NEW_ARRAY when transitioning between glBegin/End, glDrawArrays

2011-12-24 Thread Brian Paul
From: Brian Paul bri...@vmware.com This fixes a regression seen with the isosurf demo when switching between glBegin/End and glDrawArrays (do it several times). The problem was the driver wasn't getting _NEW_ARRAY when the arrays were subtly changed: (vertex3f, normal3f) vs. (normal3f,

Re: [Mesa-dev] [PATCH] vbo: signal _NEW_ARRAY when transitioning between glBegin/End, glDrawArrays

2011-12-22 Thread Brian Paul
On Wed, Dec 21, 2011 at 10:36 AM, Marek Olšák mar...@gmail.com wrote: Hi Brian, Is there a reason to set _NEW_ARRAY when transitioning between DrawArrays and DrawElements? Probably not, actually. I was just being overly paranoid. I can fix that. -Brian

Re: [Mesa-dev] [PATCH] vbo: signal _NEW_ARRAY when transitioning between glBegin/End, glDrawArrays

2011-12-22 Thread Mathias Fröhlich
Hi, On Thursday, December 22, 2011 18:30:44 Brian Paul wrote: I'm not sure if playback_vertex_list is more like DRAW_BEGIN_END or DRAW_ARRAYS. Maybe add a DRAW_DISPLAY_LIST enum value? It's more like begin/end I think. The begin/end code just sets the array state below the state tracking of

Re: [Mesa-dev] [PATCH] vbo: signal _NEW_ARRAY when transitioning between glBegin/End, glDrawArrays

2011-12-21 Thread Jose Fonseca
Looks good to me Brian. I assume it is already impossible for the arrays to change in such subtle manner within a single draw method, without provoking _NEW_ARRAY to be set. Jose - Original Message - This fixes a regression seen with the isosurf demo when switching between

Re: [Mesa-dev] [PATCH] vbo: signal _NEW_ARRAY when transitioning between glBegin/End, glDrawArrays

2011-12-21 Thread Brian Paul
On Wed, Dec 21, 2011 at 4:16 AM, Jose Fonseca jfons...@vmware.com wrote: Looks good to me Brian. I assume it is already impossible for the arrays to change in such subtle manner within a single draw method, without provoking _NEW_ARRAY to be set. I believe so. When the VBO module builds

Re: [Mesa-dev] [PATCH] vbo: signal _NEW_ARRAY when transitioning between glBegin/End, glDrawArrays

2011-12-21 Thread Marek Olšák
Hi Brian, Is there a reason to set _NEW_ARRAY when transitioning between DrawArrays and DrawElements? Marek On Wed, Dec 21, 2011 at 1:58 AM, Brian Paul bri...@vmware.com wrote: This fixes a regression seen with the isosurf demo when switching between glBegin/End and glDrawArrays (do it

[Mesa-dev] [PATCH] vbo: signal _NEW_ARRAY when transitioning between glBegin/End, glDrawArrays

2011-12-20 Thread Brian Paul
This fixes a regression seen with the isosurf demo when switching between glBegin/End and glDrawArrays (do it several times). The problem was the driver wasn't getting _NEW_ARRAY when the arrays were subtly changed: (vertex3f, normal3f) vs. (normal3f, vertex3f). This patch fixes that by