On 2018-02-09 — 11:50, Aaron Watry wrote:
> No worries. I've been rebasing this series every time I've pulled
> mesa for the last few months, and this week is the first time I've had
> any real conflicts that need addressing. I'll see if I can find some
> time to address your comments and
No worries. I've been rebasing this series every time I've pulled
mesa for the last few months, and this week is the first time I've had
any real conflicts that need addressing. I'll see if I can find some
time to address your comments and re-organize the commits as you
suggested.
Jan also had
Hello Aaron,
Sorry for not having reviewed the updated series…
I will have a look at it over the weekend. If I understand correctly, patches 1
and 2 have been squashed together and upstreamed already, while patches 3
through 8 have not been merged yet. Is this series the latest version, or do
you
Hi,
I went through most of the series. I think the approach is OK. The
biggest issue I had is with the sequence:
1.) add an interface
2.) implement a feature
3.) change the interface
I gave my rb to 1 and 2, but you might want to consider changing them
as well, if returning int from the
I've dropped the first patch of the previous series for now. I'm not
withdrawing it completely, just going to see if there's anything about
the user_ptr stuff that could have been causing the issue instead, and
if I'm using too big a hammer in this patch. If I convince myself of its
correctness,
