Re: [Mesa-dev] [PATCH 02/10] mesa: remove M_PI, M_E, M_LOG2E macro definitions

2015-02-26 Thread Brian Paul
On 02/26/2015 05:07 AM, Jose Fonseca wrote: On 26/02/15 09:19, Erik Faye-Lund wrote: On Thu, Feb 26, 2015 at 10:10 AM, Erik Faye-Lund kusmab...@gmail.com wrote: On Thu, Feb 26, 2015 at 4:24 AM, Matt Turner matts...@gmail.com wrote: On Wed, Feb 25, 2015 at 5:29 PM, Brian Paul bri...@vmware.com

Re: [Mesa-dev] [PATCH 02/10] mesa: remove M_PI, M_E, M_LOG2E macro definitions

2015-02-26 Thread Jose Fonseca
On 26/02/15 15:39, Brian Paul wrote: On 02/26/2015 05:07 AM, Jose Fonseca wrote: On 26/02/15 09:19, Erik Faye-Lund wrote: On Thu, Feb 26, 2015 at 10:10 AM, Erik Faye-Lund kusmab...@gmail.com wrote: On Thu, Feb 26, 2015 at 4:24 AM, Matt Turner matts...@gmail.com wrote: On Wed, Feb 25, 2015 at

Re: [Mesa-dev] [PATCH 02/10] mesa: remove M_PI, M_E, M_LOG2E macro definitions

2015-02-26 Thread Erik Faye-Lund
On Thu, Feb 26, 2015 at 4:24 AM, Matt Turner matts...@gmail.com wrote: On Wed, Feb 25, 2015 at 5:29 PM, Brian Paul bri...@vmware.com wrote: Should be defined in math.h. If not, we can add them to c99_math.h And FWIW, the MSDN page [0] says that if you define _USE_MATH_DEFINES before

Re: [Mesa-dev] [PATCH 02/10] mesa: remove M_PI, M_E, M_LOG2E macro definitions

2015-02-26 Thread Erik Faye-Lund
On Thu, Feb 26, 2015 at 10:10 AM, Erik Faye-Lund kusmab...@gmail.com wrote: On Thu, Feb 26, 2015 at 4:24 AM, Matt Turner matts...@gmail.com wrote: On Wed, Feb 25, 2015 at 5:29 PM, Brian Paul bri...@vmware.com wrote: Should be defined in math.h. If not, we can add them to c99_math.h And FWIW,

Re: [Mesa-dev] [PATCH 02/10] mesa: remove M_PI, M_E, M_LOG2E macro definitions

2015-02-26 Thread Jose Fonseca
On 26/02/15 09:19, Erik Faye-Lund wrote: On Thu, Feb 26, 2015 at 10:10 AM, Erik Faye-Lund kusmab...@gmail.com wrote: On Thu, Feb 26, 2015 at 4:24 AM, Matt Turner matts...@gmail.com wrote: On Wed, Feb 25, 2015 at 5:29 PM, Brian Paul bri...@vmware.com wrote: Should be defined in math.h. If

Re: [Mesa-dev] [PATCH 02/10] mesa: remove M_PI, M_E, M_LOG2E macro definitions

2015-02-25 Thread Matt Turner
On Wed, Feb 25, 2015 at 5:29 PM, Brian Paul bri...@vmware.com wrote: Should be defined in math.h. If not, we can add them to c99_math.h And FWIW, the MSDN page [0] says that if you define _USE_MATH_DEFINES before including math.h, these will be defined for you. Not sure what versions of MSVC

[Mesa-dev] [PATCH 02/10] mesa: remove M_PI, M_E, M_LOG2E macro definitions

2015-02-25 Thread Brian Paul
Should be defined in math.h. If not, we can add them to c99_math.h --- src/mesa/main/compiler.h | 13 - 1 file changed, 13 deletions(-) diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h index 0884742..cf31ad1 100644 --- a/src/mesa/main/compiler.h +++