Re: [Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

2018-02-28 Thread Jonathan Gray
On Fri, Jan 19, 2018 at 12:51:30AM +0300, Greg V wrote: > On 01/18/2018 22:49, Dylan Baker wrote: > > Quoting Emil Velikov (2018-01-18 10:40:40) > > > On 18 January 2018 at 17:13, Dylan Baker wrote: > > > > I'm not sure how Emil feels about this (and the related patches) but

Re: [Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

2018-01-19 Thread Emil Velikov
On 18 January 2018 at 21:51, Greg V wrote: > On 01/18/2018 22:49, Dylan Baker wrote: >> >> Quoting Emil Velikov (2018-01-18 10:40:40) >>> >>> On 18 January 2018 at 17:13, Dylan Baker wrote: I'm not sure how Emil feels about this (and

Re: [Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

2018-01-19 Thread Greg V
On 01/18/2018 22:49, Dylan Baker wrote: Quoting Emil Velikov (2018-01-18 10:40:40) On 18 January 2018 at 17:13, Dylan Baker wrote: I'm not sure how Emil feels about this (and the related patches) but I think it might be better to handle this at the build system level, for

Re: [Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

2018-01-18 Thread Dylan Baker
Quoting Emil Velikov (2018-01-18 10:40:40) > On 18 January 2018 at 17:13, Dylan Baker wrote: > > I'm not sure how Emil feels about this (and the related patches) but I > > think it > > might be better to handle this at the build system level, for meson it would > > look

Re: [Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

2018-01-18 Thread Eric Anholt
Dylan Baker writes: > [ Unknown signature status ] > I'm not sure how Emil feels about this (and the related patches) but I think > it > might be better to handle this at the build system level, for meson it would > look something like (in the top level meson.build): > > if

Re: [Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

2018-01-18 Thread Emil Velikov
On 18 January 2018 at 17:13, Dylan Baker wrote: > I'm not sure how Emil feels about this (and the related patches) but I think > it > might be better to handle this at the build system level, for meson it would > look something like (in the top level meson.build): > > if

Re: [Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

2018-01-18 Thread Dylan Baker
Forgot to CC Emil... Quoting Dylan Baker (2018-01-18 09:13:13) > I'm not sure how Emil feels about this (and the related patches) but I think > it > might be better to handle this at the build system level, for meson it would > look something like (in the top level meson.build): > > if

Re: [Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

2018-01-18 Thread Dylan Baker
I'm not sure how Emil feels about this (and the related patches) but I think it might be better to handle this at the build system level, for meson it would look something like (in the top level meson.build): if cc.get_define('ETIME') == '' pre_args += '-DETIME=ETIMEDOUT' endif Which should be

[Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

2018-01-03 Thread Greg V
FreeBSD only has ETIMEDOUT, not ETIME --- src/gallium/drivers/vc4/vc4_bufmgr.c | 4 src/gallium/drivers/vc5/vc5_bufmgr.c | 4 2 files changed, 8 insertions(+) diff --git a/src/gallium/drivers/vc4/vc4_bufmgr.c b/src/gallium/drivers/vc4/vc4_bufmgr.c index 274c4c3120..cbc1e1ae1b 100644