Re: [Mesa-dev] [PATCH 1/2] glsl: Disallow float literals with the 'f' suffix but no point or exponent

The Mesa a patch and the piglit patch are both Reviewed-by: Ian Romanick On November 26, 2014 3:08:38 PM Neil Roberts wrote: According to the GLSL spec float literals like ‘1f’ shouldn't be allowed without adding a decimal point or an exponent. Apparently the AMD driver also disallows this

Re: [Mesa-dev] [PATCH 1/2] glsl: Disallow float literals with the 'f' suffix but no point or exponent

Thanks Neil! I was planning to fix this once I was done with the format conversion stuff, so you saved me some work :) I tested the patch and it fixes the following dEQP tests: dEQP-GLES3.functional.shaders.constants.float_int_f_suffix_0_vertex dEQP-GLES3.functional.shaders.constants.float_int_f_

Re: [Mesa-dev] [PATCH 1/2] glsl: Disallow float literals with the 'f' suffix but no point or exponent

On Wed, Nov 26, 2014 at 12:02 PM, Neil Roberts wrote: > According to the GLSL spec float literals like ‘1f’ shouldn't be allowed > without adding a decimal point or an exponent. Apparently the AMD driver also > disallows this so it seems unlikely that anything would be relying on it. > --- Thanks

[Mesa-dev] [PATCH 1/2] glsl: Disallow float literals with the 'f' suffix but no point or exponent

According to the GLSL spec float literals like ‘1f’ shouldn't be allowed without adding a decimal point or an exponent. Apparently the AMD driver also disallows this so it seems unlikely that anything would be relying on it. --- This was discussed here: http://lists.freedesktop.org/archives/mesa-