Re: [Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

2014-06-19 Thread Bruno Jimenez
On Thu, 2014-06-19 at 13:39 -0400, Jan Vesely wrote: > On Thu, 2014-06-19 at 18:22 +0200, Bruno Jimenez wrote: > > On Thu, 2014-06-19 at 11:58 -0400, Jan Vesely wrote: > > > On Thu, 2014-06-19 at 08:27 -0700, Tom Stellard wrote: > > > > On Thu, Jun 19, 2014 at 10:21:32AM -0400, Jan Vesely wrote: >

Re: [Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

2014-06-19 Thread Jan Vesely
On Thu, 2014-06-19 at 18:22 +0200, Bruno Jimenez wrote: > On Thu, 2014-06-19 at 11:58 -0400, Jan Vesely wrote: > > On Thu, 2014-06-19 at 08:27 -0700, Tom Stellard wrote: > > > On Thu, Jun 19, 2014 at 10:21:32AM -0400, Jan Vesely wrote: > > > > The important part is the change of the condition to <=

Re: [Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

2014-06-19 Thread Bruno Jimenez
On Thu, 2014-06-19 at 11:58 -0400, Jan Vesely wrote: > On Thu, 2014-06-19 at 08:27 -0700, Tom Stellard wrote: > > On Thu, Jun 19, 2014 at 10:21:32AM -0400, Jan Vesely wrote: > > > The important part is the change of the condition to <= 0. Otherwise the > > > loop > > > gets stuck never actually gr

Re: [Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

2014-06-19 Thread Jan Vesely
On Thu, 2014-06-19 at 08:27 -0700, Tom Stellard wrote: > On Thu, Jun 19, 2014 at 10:21:32AM -0400, Jan Vesely wrote: > > The important part is the change of the condition to <= 0. Otherwise the > > loop > > gets stuck never actually growing the pool. > > > > The change in the aux-need calculation

Re: [Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

2014-06-19 Thread Jan Vesely
On Thu, 2014-06-19 at 17:27 +0200, Bruno Jimenez wrote: > Hi, > > Thanks for catching this bug! > > Reviewed-by: Bruno Jiménez > > Also, could you please send me a copy of the tests? This got triggered by one of the gegl test. You'll need the attached patches to run gegl git[0] on mesa/clover/

Re: [Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

2014-06-19 Thread Bruno Jimenez
Hi, Thanks for catching this bug! Reviewed-by: Bruno Jiménez Also, could you please send me a copy of the tests? On Thu, 2014-06-19 at 10:21 -0400, Jan Vesely wrote: > The important part is the change of the condition to <= 0. Otherwise the loop > gets stuck never actually growing the pool. >

Re: [Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

2014-06-19 Thread Tom Stellard
On Thu, Jun 19, 2014 at 10:21:32AM -0400, Jan Vesely wrote: > The important part is the change of the condition to <= 0. Otherwise the loop > gets stuck never actually growing the pool. > > The change in the aux-need calculation guarantees max 2 iterations, and > avoids wasting memory in case a sm

[Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

2014-06-19 Thread Jan Vesely
The important part is the change of the condition to <= 0. Otherwise the loop gets stuck never actually growing the pool. The change in the aux-need calculation guarantees max 2 iterations, and avoids wasting memory in case a smaller item can't fit into a relatively larger pool. Signed-off-by: Ja