[Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

Callers of create_texture() will either pass target=0 or a validated GL texture target enum so no need to do another error check inside the loop. --- src/mesa/main/texobj.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/texobj.c

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

On 10/07/2015 04:47 PM, Mark Janes wrote: Brian Paul writes: On 10/05/2015 05:18 PM, Mark Janes wrote: I tested this patch and found: regressions: spec.arb_shader_storage_buffer_object.layout-std140-write-shader (BDW only) expected[1] = 1.00. Read value: 0.00

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

On Thu, Oct 8, 2015 at 7:20 AM, Brian Paul wrote: > Callers of create_texture() will either pass target=0 or a validated > GL texture target enum so no need to do another error check inside > the loop. > --- > src/mesa/main/texobj.c | 11 ++- > 1 file changed, 2

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

You tested with all 3 patches and everything's OK now? I guess I'd still like an R-b on the 3rd patch ("mesa,meta: move gl_texture_object::TargetIndex initializations") from someone before pushing. -Brian On 10/08/2015 11:57 AM, Mark Janes wrote: Tested-by: Mark Janes

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

Tested-by: Mark Janes Brian Paul writes: > Callers of create_texture() will either pass target=0 or a validated > GL texture target enum so no need to do another error check inside > the loop. > --- > src/mesa/main/texobj.c | 11 ++- > 1 file

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

Brian Paul writes: > On 10/07/2015 04:47 PM, Mark Janes wrote: >> Brian Paul writes: >> >>> On 10/05/2015 05:18 PM, Mark Janes wrote: I tested this patch and found: regressions:

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

Brian Paul writes: > You tested with all 3 patches and everything's OK now? Sorry, I should have been more clear: Series is Tested-by: Mark Janes > > I guess I'd still like an R-b on the 3rd patch ("mesa,meta: move > gl_texture_object::TargetIndex

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

On Thu, Oct 8, 2015 at 11:01 AM, Brian Paul wrote: > You tested with all 3 patches and everything's OK now? > > I guess I'd still like an R-b on the 3rd patch ("mesa,meta: move > gl_texture_object::TargetIndex initializations") from someone before > pushing. done. > > -Brian >

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

Brian Paul writes: > On 10/05/2015 05:18 PM, Mark Janes wrote: >> I tested this patch and found: >> >> regressions: >>spec.arb_shader_storage_buffer_object.layout-std140-write-shader (BDW >> only) >> expected[1] = 1.00. Read value: 0.00 >> >>

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

On 10/05/2015 05:18 PM, Mark Janes wrote: I tested this patch and found: regressions: spec.arb_shader_storage_buffer_object.layout-std140-write-shader (BDW only) expected[1] = 1.00. Read value: 0.00 spec.arb_copy_image.arb_copy_image-srgb-copy (assertion)

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

On 10/06/2015 09:31 AM, Mark Janes wrote: > Mark Janes writes: > >> I tested this patch and found: >> >> regressions: >> spec.arb_shader_storage_buffer_object.layout-std140-write-shader (BDW >> only) >> expected[1] = 1.00. Read value: 0.00 > > In subsequent

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

On 10/06/2015 10:31 AM, Mark Janes wrote: Mark Janes writes: I tested this patch and found: regressions: spec.arb_shader_storage_buffer_object.layout-std140-write-shader (BDW only) expected[1] = 1.00. Read value: 0.00 In subsequent testing I found this BDW

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

yes, the assertions are still accurate. I haven't been able to get a stack trace yet. If I don't get to it perhaps Tapani can take a look this evening. Ian Romanick writes: > On 10/06/2015 09:31 AM, Mark Janes wrote: >> Mark Janes writes: >> >>>

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

Mark Janes writes: > I tested this patch and found: > > regressions: > spec.arb_shader_storage_buffer_object.layout-std140-write-shader (BDW only) > expected[1] = 1.00. Read value: 0.00 In subsequent testing I found this BDW failure to be a pre-existing and

[Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

Callers of create_texture() will either pass target=0 or a validated GL texture target enum so no need to do another error check inside the loop. --- src/mesa/main/texobj.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/texobj.c

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

I tested this patch and found: regressions: spec.arb_shader_storage_buffer_object.layout-std140-write-shader (BDW only) expected[1] = 1.00. Read value: 0.00 spec.arb_copy_image.arb_copy_image-srgb-copy (assertion) arb_copy_image-srgb-copy: src/mesa/main/texobj.c:1739: