Re: [Mesa-dev] [PATCH 1/4] mesa/teximage: use correct extension for accept stencil texture.

2015-04-07 Thread Kenneth Graunke
On Monday, April 06, 2015 09:44:07 PM Pohjolainen, Topi wrote: > On Mon, Apr 06, 2015 at 11:37:08AM -0700, Ian Romanick wrote: > > On 04/06/2015 08:33 AM, Pohjolainen, Topi wrote: > > > On Sun, Apr 05, 2015 at 08:22:13PM +0300, Pohjolainen, Topi wrote: > > >> On Sun, Apr 05, 2015 at 08:06:50PM +030

Re: [Mesa-dev] [PATCH 1/4] mesa/teximage: use correct extension for accept stencil texture.

2015-04-06 Thread Pohjolainen, Topi
On Mon, Apr 06, 2015 at 11:37:08AM -0700, Ian Romanick wrote: > On 04/06/2015 08:33 AM, Pohjolainen, Topi wrote: > > On Sun, Apr 05, 2015 at 08:22:13PM +0300, Pohjolainen, Topi wrote: > >> On Sun, Apr 05, 2015 at 08:06:50PM +0300, Pohjolainen, Topi wrote: > >>> On Sun, Apr 05, 2015 at 08:46:16AM -0

Re: [Mesa-dev] [PATCH 1/4] mesa/teximage: use correct extension for accept stencil texture.

2015-04-06 Thread Ian Romanick
On 04/06/2015 08:33 AM, Pohjolainen, Topi wrote: > On Sun, Apr 05, 2015 at 08:22:13PM +0300, Pohjolainen, Topi wrote: >> On Sun, Apr 05, 2015 at 08:06:50PM +0300, Pohjolainen, Topi wrote: >>> On Sun, Apr 05, 2015 at 08:46:16AM -0400, Ilia Mirkin wrote: While this change is correct, the Intel g

Re: [Mesa-dev] [PATCH 1/4] mesa/teximage: use correct extension for accept stencil texture.

2015-04-06 Thread Ian Romanick
On 04/04/2015 11:48 PM, Dave Airlie wrote: > This was using the wrong extension, ARB_stencil_texturing > doesn't mention any changes in this area. Right... that extension only enables reading the stencil value from a GL_DEPTH_STENCIL texture. This patch is Reviewed-by: Ian Romanick > Signed-of

Re: [Mesa-dev] [PATCH 1/4] mesa/teximage: use correct extension for accept stencil texture.

2015-04-06 Thread Pohjolainen, Topi
On Mon, Apr 06, 2015 at 12:05:56PM -0400, Ilia Mirkin wrote: > On Mon, Apr 6, 2015 at 11:33 AM, Pohjolainen, Topi > wrote: > > On Sun, Apr 05, 2015 at 08:22:13PM +0300, Pohjolainen, Topi wrote: > >> On Sun, Apr 05, 2015 at 08:06:50PM +0300, Pohjolainen, Topi wrote: > >> > On Sun, Apr 05, 2015 at 0

Re: [Mesa-dev] [PATCH 1/4] mesa/teximage: use correct extension for accept stencil texture.

2015-04-06 Thread Ilia Mirkin
On Mon, Apr 6, 2015 at 11:33 AM, Pohjolainen, Topi wrote: > On Sun, Apr 05, 2015 at 08:22:13PM +0300, Pohjolainen, Topi wrote: >> On Sun, Apr 05, 2015 at 08:06:50PM +0300, Pohjolainen, Topi wrote: >> > On Sun, Apr 05, 2015 at 08:46:16AM -0400, Ilia Mirkin wrote: >> > > While this change is correct

Re: [Mesa-dev] [PATCH 1/4] mesa/teximage: use correct extension for accept stencil texture.

2015-04-06 Thread Pohjolainen, Topi
On Sun, Apr 05, 2015 at 08:22:13PM +0300, Pohjolainen, Topi wrote: > On Sun, Apr 05, 2015 at 08:06:50PM +0300, Pohjolainen, Topi wrote: > > On Sun, Apr 05, 2015 at 08:46:16AM -0400, Ilia Mirkin wrote: > > > While this change is correct, the Intel guys will yell at you, because > > > they're somehow

[Mesa-dev] [PATCH 1/4] mesa/teximage: use correct extension for accept stencil texture.

2015-04-05 Thread Dave Airlie
This was using the wrong extension, ARB_stencil_texturing doesn't mention any changes in this area. Signed-off-by: Dave Airlie --- src/mesa/main/teximage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 8d9d7cf..36e0b

Re: [Mesa-dev] [PATCH 1/4] mesa/teximage: use correct extension for accept stencil texture.

2015-04-05 Thread Pohjolainen, Topi
On Sun, Apr 05, 2015 at 08:06:50PM +0300, Pohjolainen, Topi wrote: > On Sun, Apr 05, 2015 at 08:46:16AM -0400, Ilia Mirkin wrote: > > While this change is correct, the Intel guys will yell at you, because > > they're somehow misusing this in meta for Broadwell, s.t. this will > > cause crashes when

Re: [Mesa-dev] [PATCH 1/4] mesa/teximage: use correct extension for accept stencil texture.

2015-04-05 Thread Pohjolainen, Topi
On Sun, Apr 05, 2015 at 08:46:16AM -0400, Ilia Mirkin wrote: > While this change is correct, the Intel guys will yell at you, because > they're somehow misusing this in meta for Broadwell, s.t. this will > cause crashes when blitting stencil. IMHO that's a problem that should > be fixed in their dr

Re: [Mesa-dev] [PATCH 1/4] mesa/teximage: use correct extension for accept stencil texture.

2015-04-05 Thread Ilia Mirkin
While this change is correct, the Intel guys will yell at you, because they're somehow misusing this in meta for Broadwell, s.t. this will cause crashes when blitting stencil. IMHO that's a problem that should be fixed in their driver and this can go on, but... it's also not my driver that's crashi

[Mesa-dev] [PATCH 1/4] mesa/teximage: use correct extension for accept stencil texture.

2015-04-04 Thread Dave Airlie
This was using the wrong extension, ARB_stencil_texturing doesn't mention any changes in this area. Signed-off-by: Dave Airlie --- src/mesa/main/teximage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 8d9d7cf..36e0b