Re: [Mesa-dev] [PATCH 1/6] glsl: finish up ARB_conservative_depth

2011-11-22 Thread Marek Olšák
On Mon, Nov 21, 2011 at 8:01 PM, Ian Romanick wrote: > On 11/19/2011 07:42 AM, Marek Olšák wrote: >> >> On Fri, Nov 18, 2011 at 9:44 PM, Ian Romanick  wrote: >>> >>> On 11/18/2011 11:27 AM, Marek Olšák wrote: >>> >>> This patch also needs to change the _mesa_glsl_supported_extensions table >>> in

Re: [Mesa-dev] [PATCH 1/6] glsl: finish up ARB_conservative_depth

2011-11-21 Thread Ian Romanick
On 11/19/2011 07:42 AM, Marek Olšák wrote: On Fri, Nov 18, 2011 at 9:44 PM, Ian Romanick wrote: On 11/18/2011 11:27 AM, Marek Olšák wrote: This patch also needs to change the _mesa_glsl_supported_extensions table in glsl_parser_extras.cpp. AMD_conservative_depth is used for both versions of t

Re: [Mesa-dev] [PATCH 1/6] glsl: finish up ARB_conservative_depth

2011-11-19 Thread Marek Olšák
On Fri, Nov 18, 2011 at 9:44 PM, Ian Romanick wrote: > On 11/18/2011 11:27 AM, Marek Olšák wrote: > > This patch also needs to change the _mesa_glsl_supported_extensions table in > glsl_parser_extras.cpp.  AMD_conservative_depth is used for both versions of > the extension in the table. But that

Re: [Mesa-dev] [PATCH 1/6] glsl: finish up ARB_conservative_depth

2011-11-18 Thread Kenneth Graunke
On 11/18/2011 01:23 PM, Marek Olšák wrote: > On Fri, Nov 18, 2011 at 10:14 PM, Kenneth Graunke > wrote: >> On 11/18/2011 11:27 AM, Marek Olšák wrote: >>> diff --git a/src/glsl/ir_clone.cpp b/src/glsl/ir_clone.cpp >>> index e8ac9fb..c63615c 100644 >>> --- a/src/glsl/ir_clone.cpp >>> +++ b/src/glsl

Re: [Mesa-dev] [PATCH 1/6] glsl: finish up ARB_conservative_depth

2011-11-18 Thread Marek Olšák
On Fri, Nov 18, 2011 at 10:14 PM, Kenneth Graunke wrote: > On 11/18/2011 11:27 AM, Marek Olšák wrote: >> diff --git a/src/glsl/ir_clone.cpp b/src/glsl/ir_clone.cpp >> index e8ac9fb..c63615c 100644 >> --- a/src/glsl/ir_clone.cpp >> +++ b/src/glsl/ir_clone.cpp >> @@ -51,6 +51,7 @@ ir_variable::clone

Re: [Mesa-dev] [PATCH 1/6] glsl: finish up ARB_conservative_depth

2011-11-18 Thread Kenneth Graunke
On 11/18/2011 11:27 AM, Marek Olšák wrote: > diff --git a/src/glsl/ir_clone.cpp b/src/glsl/ir_clone.cpp > index e8ac9fb..c63615c 100644 > --- a/src/glsl/ir_clone.cpp > +++ b/src/glsl/ir_clone.cpp > @@ -51,6 +51,7 @@ ir_variable::clone(void *mem_ctx, struct hash_table *ht) > const > var->pixel_

Re: [Mesa-dev] [PATCH 1/6] glsl: finish up ARB_conservative_depth

2011-11-18 Thread Ian Romanick
On 11/18/2011 11:27 AM, Marek Olšák wrote: This patch also needs to change the _mesa_glsl_supported_extensions table in glsl_parser_extras.cpp. AMD_conservative_depth is used for both versions of the extension in the table. I'm not super convinced that we even need separate enable flags. Bo

[Mesa-dev] [PATCH 1/6] glsl: finish up ARB_conservative_depth

2011-11-18 Thread Marek Olšák
--- src/glsl/ast_to_hir.cpp |7 +-- src/glsl/glsl_lexer.ll |1 + src/glsl/glsl_parser.yy |9 - src/glsl/ir_clone.cpp |1 + 4 files changed, 15 insertions(+), 3 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index ac090c3..51fec19 100644