Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-23 Thread Mike Lothian
The OCD side of me says it doesn't look right :P The lazy side of me says it's fine Either way it doesn't make much difference, it's only exposed with the extended output anyway On Fri, 23 Feb 2018 at 16:32 Brian Paul wrote: > On 02/23/2018 03:06 AM, Mike Lothian wrote: > > This still looks wro

Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-23 Thread Brian Paul
On 02/23/2018 03:06 AM, Mike Lothian wrote: This still looks wrong, there's now two 4.3 sections: Yeah, but I guess I don't see it as a big deal. Fixing it would involve a bit of a hack. While processing the big list of queries, I'd have to check for extension=="4.3" and call a function to

Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-23 Thread Mike Lothian
This still looks wrong, there's now two 4.3 sections: 4.3: GL_MAX_ELEMENT_INDEX = 2147483647 GL_MAX_COMPUTE_UNIFORM_BLOCKS = 14 GL_MAX_COMPUTE_TEXTURE_IMAGE_UNITS = 32 GL_MAX_COMPUTE_IMAGE_UNIFORMS = 32 GL_MAX_COMPUTE_SHARED_MEMORY_SIZE = 65536 GL_MAX_COMPUTE_UNIFORM_COMP

Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-22 Thread Andreas Boll
Reviewed-by: Andreas Boll 2018-02-21 21:09 GMT+01:00 Brian Paul : > v2: fix indentation, prefix with "4.3:" like other sections. > --- > src/xdemos/glinfo_common.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinfo_common.c > i

[Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-21 Thread Brian Paul
v2: fix indentation, prefix with "4.3:" like other sections. --- src/xdemos/glinfo_common.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinfo_common.c index efa96e6..3668026 100644 --- a/src/xdemos/glinfo_common.c +++ b/src/xdemos/gl

Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-21 Thread Brian Paul
On 02/21/2018 09:43 AM, Mike Lothian wrote: It also seems to have an off by one error The empty line is actually a valid result of the glGetStringi(GL_SHADING_LANGUAGE_VERSION) query. Per the GL 4.3 spec, page 628: "An empty string indicates support for OpenGL Shading Language 1.10, which

Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-21 Thread Brian Paul
On 02/21/2018 09:41 AM, Mike Lothian wrote: This doesn't show as default and seems to be tucked away underĀ GL_ARB_transform_feedback3 I copied the indentation used for the texture compression formats code above. That needs to be fixed. I'll fix that in another patch and update this one. -

Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-21 Thread Mike Lothian
It also seems to have an off by one error On Wed, 21 Feb 2018 at 16:41 Mike Lothian wrote: > This doesn't show as default and seems to be tucked away > under GL_ARB_transform_feedback3 > > GL_ARB_transform_feedback3: > GL_MAX_TRANSFORM_FEEDBACK_BUFFERS = 4 > GL_MAX_VERTEX_STREAMS = 4 >

Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-21 Thread Mike Lothian
This doesn't show as default and seems to be tucked away under GL_ARB_transform_feedback3 GL_ARB_transform_feedback3: GL_MAX_TRANSFORM_FEEDBACK_BUFFERS = 4 GL_MAX_VERTEX_STREAMS = 4 GL_NUM_SHADING_LANGUAGE_VERSIONS = 16 450 440 430 420 410

[Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-21 Thread Brian Paul
--- src/xdemos/glinfo_common.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/xdemos/glinfo_common.c b/src/xdemos/glinfo_common.c index 0411891..c36cff1 100644 --- a/src/xdemos/glinfo_common.c +++ b/src/xdemos/glinfo_common.c @@ -794,6 +794,19 @@ print_limits(const char *ex