Re: [Mesa-dev] [PATCH 2/3] glsl: fix conversions from uint to bool and from float/bool to uint

2011-04-18 Thread Bryan Cain
On 04/18/2011 06:06 PM, Ian Romanick wrote: > On 04/17/2011 11:39 PM, Bryan Cain wrote: > > This one looks good. > > Reviewed-by: Ian Romanick > > Since I don't think you have commit access, so I'll go ahead and commit > this. Thanks, although I don't see it in master yet. > > > --- > > src/gls

Re: [Mesa-dev] [PATCH 2/3] glsl: fix conversions from uint to bool and from float/bool to uint

2011-04-18 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/17/2011 11:39 PM, Bryan Cain wrote: This one looks good. Reviewed-by: Ian Romanick Since I don't think you have commit access, so I'll go ahead and commit this. > --- > src/glsl/ir_validate.cpp |6 +++--- > 1 files changed, 3 insertions

Re: [Mesa-dev] [PATCH 2/3] glsl: fix conversions from uint to bool and from float/bool to uint

2011-04-18 Thread Kenneth Graunke
On 04/17/2011 11:39 PM, Bryan Cain wrote: --- src/glsl/ir_validate.cpp |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/glsl/ir_validate.cpp b/src/glsl/ir_validate.cpp index f3fceb2..41ffdfd 100644 --- a/src/glsl/ir_validate.cpp +++ b/src/glsl/ir_validate.cpp @

[Mesa-dev] [PATCH 2/3] glsl: fix conversions from uint to bool and from float/bool to uint

2011-04-17 Thread Bryan Cain
--- src/glsl/ir_validate.cpp |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/glsl/ir_validate.cpp b/src/glsl/ir_validate.cpp index f3fceb2..41ffdfd 100644 --- a/src/glsl/ir_validate.cpp +++ b/src/glsl/ir_validate.cpp @@ -254,7 +254,7 @@ ir_validate::visit_leave(ir