Re: [Mesa-dev] [PATCH 5/6] glsl: Create an accessor for the built-in function shader.

2013-11-27 Thread Ian Romanick
On 11/27/2013 10:47 AM, Kenneth Graunke wrote: > On 11/23/2013 05:45 PM, Kenneth Graunke wrote: >> On 11/23/2013 04:03 PM, Ian Romanick wrote: >>> Would it be better to just make _mesa_glsl_get_builtin_function_shader a >>> friend? >> >> In this case, I don't think it makes much practical differenc

Re: [Mesa-dev] [PATCH 5/6] glsl: Create an accessor for the built-in function shader.

2013-11-27 Thread Kenneth Graunke
On 11/23/2013 05:45 PM, Kenneth Graunke wrote: > On 11/23/2013 04:03 PM, Ian Romanick wrote: >> Would it be better to just make _mesa_glsl_get_builtin_function_shader a >> friend? > > In this case, I don't think it makes much practical difference - the > builtin_builder class is entirely contained

Re: [Mesa-dev] [PATCH 5/6] glsl: Create an accessor for the built-in function shader.

2013-11-23 Thread Kenneth Graunke
On 11/23/2013 04:03 PM, Ian Romanick wrote: > Would it be better to just make _mesa_glsl_get_builtin_function_shader a > friend? In this case, I don't think it makes much practical difference - the builtin_builder class is entirely contained within the builtin_functions.cpp file. So making this p

Re: [Mesa-dev] [PATCH 5/6] glsl: Create an accessor for the built-in function shader.

2013-11-23 Thread Ian Romanick
Would it be better to just make _mesa_glsl_get_builtin_function_shader a friend? On 11/23/2013 01:43 PM, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/glsl/builtin_functions.cpp | 12 ++-- > src/glsl/ir.h | 3 +++ > 2 files changed, 13 insertions(+

[Mesa-dev] [PATCH 5/6] glsl: Create an accessor for the built-in function shader.

2013-11-23 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/glsl/builtin_functions.cpp | 12 ++-- src/glsl/ir.h | 3 +++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 8cb75e5..e768685 100644 --- a/src/gls