Re: [Mesa-dev] [PATCH 5/6] radeonsi: fix TEX writemask

2012-08-02 Thread Tom Stellard
On Thu, Aug 02, 2012 at 11:33:43AM +0200, Christian König wrote: > On 02.08.2012 11:21, Michel Dänzer wrote: > >On Don, 2012-08-02 at 11:05 +0200, Christian König wrote: > >>On 02.08.2012 07:51, Michel Dänzer wrote: > >>>On Mit, 2012-08-01 at 23:28 +0200, Christian König wrote: > Using the writ

Re: [Mesa-dev] [PATCH 5/6] radeonsi: fix TEX writemask

2012-08-02 Thread Michel Dänzer
On Don, 2012-08-02 at 11:57 +0200, Christian König wrote: > On 02.08.2012 11:46, Michel Dänzer wrote: > > On Don, 2012-08-02 at 11:33 +0200, Christian König wrote: > >> On 02.08.2012 11:21, Michel Dänzer wrote: > >>> On Don, 2012-08-02 at 11:05 +0200, Christian König wrote: > On 02.08.2012 07

Re: [Mesa-dev] [PATCH 5/6] radeonsi: fix TEX writemask

2012-08-02 Thread Christian König
On 02.08.2012 11:46, Michel Dänzer wrote: On Don, 2012-08-02 at 11:33 +0200, Christian König wrote: On 02.08.2012 11:21, Michel Dänzer wrote: On Don, 2012-08-02 at 11:05 +0200, Christian König wrote: On 02.08.2012 07:51, Michel Dänzer wrote: Couldn't this incorrectly clobber components of the

Re: [Mesa-dev] [PATCH 5/6] radeonsi: fix TEX writemask

2012-08-02 Thread Michel Dänzer
On Don, 2012-08-02 at 11:33 +0200, Christian König wrote: > On 02.08.2012 11:21, Michel Dänzer wrote: > > On Don, 2012-08-02 at 11:05 +0200, Christian König wrote: > >> On 02.08.2012 07:51, Michel Dänzer wrote: > > > >>> Couldn't this incorrectly clobber components of the destination which > >>> w

Re: [Mesa-dev] [PATCH 5/6] radeonsi: fix TEX writemask

2012-08-02 Thread Christian König
On 02.08.2012 11:21, Michel Dänzer wrote: On Don, 2012-08-02 at 11:05 +0200, Christian König wrote: On 02.08.2012 07:51, Michel Dänzer wrote: On Mit, 2012-08-01 at 23:28 +0200, Christian König wrote: Using the writemask in the sampler results in packet VGPRS. What does that mean? The instruc

Re: [Mesa-dev] [PATCH 5/6] radeonsi: fix TEX writemask

2012-08-02 Thread Michel Dänzer
On Don, 2012-08-02 at 11:05 +0200, Christian König wrote: > On 02.08.2012 07:51, Michel Dänzer wrote: > > On Mit, 2012-08-01 at 23:28 +0200, Christian König wrote: > >> Using the writemask in the sampler results in packet > >> VGPRS. > > What does that mean? > > The instructions with a destinatio

Re: [Mesa-dev] [PATCH 5/6] radeonsi: fix TEX writemask

2012-08-02 Thread Christian König
On 02.08.2012 07:51, Michel Dänzer wrote: On Mit, 2012-08-01 at 23:28 +0200, Christian König wrote: Using the writemask in the sampler results in packet VGPRS. What does that mean? The instructions with a destination mask are packing their results, e.g. when you sample RGBA you get: R in VG

Re: [Mesa-dev] [PATCH 5/6] radeonsi: fix TEX writemask

2012-08-02 Thread Michel Dänzer
On Mit, 2012-08-01 at 23:28 +0200, Christian König wrote: > Using the writemask in the sampler results in packet > VGPRS. What does that mean? > For now just sample all components and let llvm chose the right one. > > Signed-off-by: Christian König > --- > src/gallium/drivers/radeonsi/radeon

[Mesa-dev] [PATCH 5/6] radeonsi: fix TEX writemask

2012-08-01 Thread Christian König
Using the writemask in the sampler results in packet VGPRS. For now just sample all components and let llvm chose the right one. Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/radeonsi_shader.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/galliu