Re: [Mesa-dev] [PATCH 6/6] draw: fix/improve dirty state validation

2012-12-08 Thread Jose Fonseca
Reviewed-by: Jose Fonseca jfons...@vmware.com Series looks excellent Brian. Thanks for nailing this issue. I never stop to be amazed on how state derivation bugs go unnoticed for so long, just because most apps ends up touch a lot of state at the same time. One could try to write piglit tests

Re: [Mesa-dev] [PATCH 6/6] draw: fix/improve dirty state validation

2012-12-08 Thread Brian Paul
On 12/08/2012 03:48 AM, Jose Fonseca wrote: Reviewed-by: Jose Fonsecajfons...@vmware.com Series looks excellent Brian. Thanks for nailing this issue. I never stop to be amazed on how state derivation bugs go unnoticed for so long, just because most apps ends up touch a lot of state at the

[Mesa-dev] [PATCH 6/6] draw: fix/improve dirty state validation

2012-12-07 Thread Brian Paul
This patch does two things: 1. Constant buffer state changes were broken (but happened to work by dumb luck). The problem is we weren't calling draw_do_flush() in draw_set_mapped_constant_buffer() when we changed that state. All the other draw_set_foo() functions were calling