Re: [Mesa-dev] [PATCH v10 12/20] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

2019-01-09 Thread Dylan Baker
Quoting Pierre Moreau (2019-01-09 11:24:12) > > thanks! Just FYI, our meson build uses - in option names, not _. And, I'd > > prefer > > just "opencl-spirv". > > Err right, I meant with '-' in the option name. I am fine with > "opencl-spirv"; > I was initially going with "gallium-opencl-spirv"

Re: [Mesa-dev] [PATCH v10 12/20] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

2019-01-09 Thread Pierre Moreau
> thanks! Just FYI, our meson build uses - in option names, not _. And, I'd > prefer > just "opencl-spirv". Err right, I meant with '-' in the option name. I am fine with "opencl-spirv"; I was initially going with "gallium-opencl-spirv" since the other clover-related command was named

Re: [Mesa-dev] [PATCH v10 12/20] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

2019-01-09 Thread Dylan Baker
Quoting Pierre Moreau (2019-01-09 10:54:52) > On 2019-01-08 — 15:18, Dylan Baker wrote: > [snip] > > >dep_clc = dependency('libclc') > > > + dep_spirv_tools = dependency('SPIRV-Tools', required : false, version > > > : '>= 2018.0') > > > + # LLVMSPIRVLib is available at > > >

Re: [Mesa-dev] [PATCH v10 12/20] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

2019-01-09 Thread Pierre Moreau
On 2019-01-08 — 15:18, Dylan Baker wrote: [snip] > >dep_clc = dependency('libclc') > > + dep_spirv_tools = dependency('SPIRV-Tools', required : false, version : > > '>= 2018.0') > > + # LLVMSPIRVLib is available at > > https://github.com/KhronosGroup/SPIRV-LLVM-Translator > > +

Re: [Mesa-dev] [PATCH v10 12/20] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

2019-01-08 Thread Dylan Baker
Quoting Pierre Moreau (2019-01-08 13:11:01) > Reviewed-by: Dylan Baker > > Changes since: > * v7: > - Properly align LLVMSPIRVLib comment (Dylan Baker) > - Only define CLOVER_ALLOW_SPIRV when **both** dependencies are found: > autotools was only requiring one or the other. > * v6:

[Mesa-dev] [PATCH v10 12/20] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

2019-01-08 Thread Pierre Moreau
Reviewed-by: Dylan Baker Changes since: * v7: - Properly align LLVMSPIRVLib comment (Dylan Baker) - Only define CLOVER_ALLOW_SPIRV when **both** dependencies are found: autotools was only requiring one or the other. * v6: Replace the llvm-spirv repository by the new official