Re: [Mesa-dev] [PATCH v2 05/23] glsl: Fail to link if inter-stage input/outputs are not assigned to stream 0

2015-07-30 Thread Iago Toral
On Wed, 2015-07-29 at 21:58 +0200, Marek Olšák wrote: Hi, Where does the spec say we should fail to link? I don't see such a statement there. I have reviewed ARB_gpu_shader5 and I don't see any specific mentions to what should be done in this particular case. That said, isn't this the

Re: [Mesa-dev] [PATCH v2 05/23] glsl: Fail to link if inter-stage input/outputs are not assigned to stream 0

2015-07-30 Thread Marek Olšák
On Thu, Jul 30, 2015 at 8:49 AM, Iago Toral ito...@igalia.com wrote: On Wed, 2015-07-29 at 21:58 +0200, Marek Olšák wrote: Hi, Where does the spec say we should fail to link? I don't see such a statement there. I have reviewed ARB_gpu_shader5 and I don't see any specific mentions to what

Re: [Mesa-dev] [PATCH v2 05/23] glsl: Fail to link if inter-stage input/outputs are not assigned to stream 0

2015-07-30 Thread Iago Toral
On Thu, 2015-07-30 at 09:43 +0200, Marek Olšák wrote: On Thu, Jul 30, 2015 at 8:49 AM, Iago Toral ito...@igalia.com wrote: On Wed, 2015-07-29 at 21:58 +0200, Marek Olšák wrote: Hi, Where does the spec say we should fail to link? I don't see such a statement there. I have reviewed

Re: [Mesa-dev] [PATCH v2 05/23] glsl: Fail to link if inter-stage input/outputs are not assigned to stream 0

2015-07-29 Thread Marek Olšák
Hi, Where does the spec say we should fail to link? I don't see such a statement there. It looks like varyings with stream 0 should not be linked with the fragment shader. Marek On Wed, Jun 18, 2014 at 11:51 AM, Iago Toral Quiroga ito...@igalia.com wrote: Outputs that are linked to inputs in

[Mesa-dev] [PATCH v2 05/23] glsl: Fail to link if inter-stage input/outputs are not assigned to stream 0

2014-06-18 Thread Iago Toral Quiroga
Outputs that are linked to inputs in the next stage must be output to stream 0, otherwise we should fail to link. --- src/glsl/link_varyings.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index 9725a43..3b20594 100644 ---

Re: [Mesa-dev] [PATCH v2 05/23] glsl: Fail to link if inter-stage input/outputs are not assigned to stream 0

2014-06-18 Thread Ian Romanick
Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: Outputs that are linked to inputs in the next stage must be output to stream 0, otherwise we should fail to link. --- src/glsl/link_varyings.cpp | 8 1 file changed, 8