Re: [Mesa-dev] [PATCH v2 3/3] glsl/cs: Initialize gl_GlobalInvocationID in main()

2015-09-11 Thread Jordan Justen
On 2015-09-10 05:48:50, Alejandro Piñeiro wrote: > Not a full review, but a comment. See inline. > > On 23/08/15 09:09, Jordan Justen wrote: > > We initialize gl_GlobalInvocationID based on the extension spec > > formula: > > > > gl_GlobalInvocationID = > > gl_WorkGroupID * gl_WorkGrou

Re: [Mesa-dev] [PATCH v2 3/3] glsl/cs: Initialize gl_GlobalInvocationID in main()

2015-09-10 Thread Alejandro Piñeiro
Not a full review, but a comment. See inline. On 23/08/15 09:09, Jordan Justen wrote: > We initialize gl_GlobalInvocationID based on the extension spec > formula: > > gl_GlobalInvocationID = > gl_WorkGroupID * gl_WorkGroupSize + gl_LocalInvocationID > > https://www.opengl.org/registry/

[Mesa-dev] [PATCH v2 3/3] glsl/cs: Initialize gl_GlobalInvocationID in main()

2015-08-23 Thread Jordan Justen
We initialize gl_GlobalInvocationID based on the extension spec formula: gl_GlobalInvocationID = gl_WorkGroupID * gl_WorkGroupSize + gl_LocalInvocationID https://www.opengl.org/registry/specs/ARB/compute_shader.txt Signed-off-by: Jordan Justen Cc: Ilia Mirkin --- src/glsl/builtin_