Re: [Mesa-dev] [PATCH v3] dri3: For 1.2, use root window instead of pixmap drawable

2018-07-31 Thread Adam Jackson
On Fri, 2018-07-27 at 16:16 +0200, Olivier Fourdan wrote: > Hi, > > On Thu, 26 Jul 2018 at 19:53, Eric Anholt wrote: > > > > Olivier Fourdan writes: > > > > > get_supported_modifiers() and pixmap_from_buffers() requests both > > > expect a window as drawable, passing a pixmap will fail as the

Re: [Mesa-dev] [PATCH v3] dri3: For 1.2, use root window instead of pixmap drawable

2018-07-27 Thread Olivier Fourdan
Hi, On Thu, 26 Jul 2018 at 19:53, Eric Anholt wrote: > > Olivier Fourdan writes: > > > get_supported_modifiers() and pixmap_from_buffers() requests both > > expect a window as drawable, passing a pixmap will fail as the Xserver > > will fail to match the given drawable to a window. > > > > That

Re: [Mesa-dev] [PATCH v3] dri3: For 1.2, use root window instead of pixmap drawable

2018-07-26 Thread Eric Anholt
Olivier Fourdan writes: > get_supported_modifiers() and pixmap_from_buffers() requests both > expect a window as drawable, passing a pixmap will fail as the Xserver > will fail to match the given drawable to a window. > > That leads to dri3_alloc_render_buffer() to return NULL and breaks >

Re: [Mesa-dev] [PATCH v3] dri3: For 1.2, use root window instead of pixmap drawable

2018-07-26 Thread Daniel Stone
On Thu, 26 Jul 2018 at 08:46, Olivier Fourdan wrote: > get_supported_modifiers() and pixmap_from_buffers() requests both > expect a window as drawable, passing a pixmap will fail as the Xserver > will fail to match the given drawable to a window. > > That leads to dri3_alloc_render_buffer() to

[Mesa-dev] [PATCH v3] dri3: For 1.2, use root window instead of pixmap drawable

2018-07-26 Thread Olivier Fourdan
get_supported_modifiers() and pixmap_from_buffers() requests both expect a window as drawable, passing a pixmap will fail as the Xserver will fail to match the given drawable to a window. That leads to dri3_alloc_render_buffer() to return NULL and breaks rendering when using GLX_DOUBLEBUFFER on