Reviewed-by: Karol Herbst
On Tue, Nov 13, 2018 at 3:51 AM Jason Ekstrand wrote:
>
> On Mon, Nov 12, 2018 at 6:10 PM Karol Herbst wrote:
>>
>> it shouldn't make a difference. This pass lowers load_derefs into
>> whatever we want here. If we handle the system value explicitly
>> "sysval" gets set.
On Mon, Nov 12, 2018 at 6:10 PM Karol Herbst wrote:
> it shouldn't make a difference. This pass lowers load_derefs into
> whatever we want here. If we handle the system value explicitly
> "sysval" gets set. If not, we fetch the op through
> nir_intrinsic_from_system_value and do the load based on
it shouldn't make a difference. This pass lowers load_derefs into
whatever we want here. If we handle the system value explicitly
"sysval" gets set. If not, we fetch the op through
nir_intrinsic_from_system_value and do the load based on that. We just
take a different path, but fundamentally we do
I think we still want to skip the lowering of SYSTEM_VALUE_LOCAL_GROUP_SIZE
when that flag is set. I think this works, but we'll end up deleting one
load_local_group_size intrinsic and replacing it with another which is
pointless.
--Jason
On Mon, Nov 12, 2018 at 4:02 PM Plamena Manolova <
plamen
If the local work group size is variable it won't be available
at compile time so we can't lower it in nir_lower_system_values().
Signed-off-by: Plamena Manolova
---
src/compiler/nir/nir_lower_system_values.c | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff -
