Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-07 Thread Marek Olšák
On Mon, May 7, 2018 at 8:17 AM, Nicolai Hähnle wrote: > On 01.05.2018 22:48, Marek Olšák wrote: > >> +**nr_color_samples**: This is the number of color samples for >> EQAA, while >> +``nr_samples`` is the number of coverage samples. If the format >>

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-07 Thread Nicolai Hähnle
On 01.05.2018 22:48, Marek Olšák wrote: +**nr_color_samples**: This is the number of color samples for EQAA, while +``nr_samples`` is the number of coverage samples. If the format is Z/S, +``nr_color_samples`` is ignored. Constraints: +*

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Marek Olšák
On Tue, May 1, 2018 at 5:53 PM, Roland Scheidegger wrote: > Am 01.05.2018 um 22:49 schrieb Marek Olšák: > > On Tue, May 1, 2018 at 10:48 AM, Roland Scheidegger > > wrote: > > > > Am 01.05.2018 um 01:43 schrieb Marek Olšák:

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Roland Scheidegger
Am 01.05.2018 um 22:49 schrieb Marek Olšák: > On Tue, May 1, 2018 at 10:48 AM, Roland Scheidegger > wrote: > > Am 01.05.2018 um 01:43 schrieb Marek Olšák: > > From: Marek Olšák > > > >

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Marek Olšák
We need a way to distinguish between AA and no AA even if color samples == 1. nr_samples is currently used for that purpose, so it makes sense to use nr_samples for coverage samples. color samples == 1 means that you can store 1 color sample per pixel and other samples are flagged as undefined and

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Marek Olšák
The maximum config is: - 16 coverage samples - 8 Z/S samples - 8 color samples The minimum config is: - 1-16 coverage samples - 1 Z/S sample - 1 color sample The coverage buffer (each color buffer has one) remembers undefined samples if color samples < coverage samples, and the resolve shader

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Marek Olšák
On Tue, May 1, 2018 at 10:51 AM, Axel Davy wrote: > Hi, > > > On 01/05/2018 01:43, Marek Olšák wrote: > >> From: Marek Olšák >> >> This is a hypothetical interface for EQAA (a superset of CSAA). CSAA >> could be >> exposed via

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Marek Olšák
On Tue, May 1, 2018 at 10:48 AM, Roland Scheidegger wrote: > Am 01.05.2018 um 01:43 schrieb Marek Olšák: > > From: Marek Olšák > > > > This is a hypothetical interface for EQAA (a superset of CSAA). CSAA > could be > > exposed via

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Marek Olšák
On Tue, May 1, 2018 at 5:35 AM, Nicolai Hähnle wrote: > On 01.05.2018 01:43, Marek Olšák wrote: > >> From: Marek Olšák >> >> This is a hypothetical interface for EQAA (a superset of CSAA). CSAA >> could be >> exposed via

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Roland Scheidegger
Am 01.05.2018 um 17:18 schrieb Nicolai Hähnle: > On 01.05.2018 16:48, Roland Scheidegger wrote: >>> -**nr_samples** the nr of msaa samples. 0 (or 1) specifies a resource >>> -which isn't multisampled. >>> +**nr_samples**: For Z/S, this is the number of samples. For color, >>> if EQAA >>> +is

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Roland Scheidegger
Am 01.05.2018 um 16:51 schrieb Axel Davy: > Hi, > > On 01/05/2018 01:43, Marek Olšák wrote: >> From: Marek Olšák >> >> This is a hypothetical interface for EQAA (a superset of CSAA). CSAA >> could be >> exposed via GL_NV_framebuffer_multisample_coverage. EQAA additionally >>

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Nicolai Hähnle
On 01.05.2018 16:48, Roland Scheidegger wrote: -**nr_samples** the nr of msaa samples. 0 (or 1) specifies a resource -which isn't multisampled. +**nr_samples**: For Z/S, this is the number of samples. For color, if EQAA +is unsupported, this is the number of both coverage samples and color

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Axel Davy
Hi, On 01/05/2018 01:43, Marek Olšák wrote: From: Marek Olšák This is a hypothetical interface for EQAA (a superset of CSAA). CSAA could be exposed via GL_NV_framebuffer_multisample_coverage. EQAA additionally removes the restriction that the number of samples in all FBO

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Roland Scheidegger
Am 01.05.2018 um 01:43 schrieb Marek Olšák: > From: Marek Olšák > > This is a hypothetical interface for EQAA (a superset of CSAA). CSAA could be > exposed via GL_NV_framebuffer_multisample_coverage. EQAA additionally removes > the restriction that the number of samples in

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Nicolai Hähnle
On 01.05.2018 01:43, Marek Olšák wrote: From: Marek Olšák This is a hypothetical interface for EQAA (a superset of CSAA). CSAA could be exposed via GL_NV_framebuffer_multisample_coverage. EQAA additionally removes the restriction that the number of samples in all FBO

[Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-04-30 Thread Marek Olšák
From: Marek Olšák This is a hypothetical interface for EQAA (a superset of CSAA). CSAA could be exposed via GL_NV_framebuffer_multisample_coverage. EQAA additionally removes the restriction that the number of samples in all FBO attachments must match, which means it allows