Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-07 Thread Tapani
Hi; On 11/06/2013 07:35 PM, Erik Faye-Lund wrote: Sorry for the late reply. On Fri, Nov 1, 2013 at 4:14 PM, Tapani wrote: On 11/01/2013 03:31 PM, Erik Faye-Lund wrote: That won't help for programs that maintain their own (explicit) shader-cache, which was the intention of introducing binar

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-06 Thread Erik Faye-Lund
On Wed, Nov 6, 2013 at 9:19 PM, Paul Berry wrote: > On 6 November 2013 11:24, Erik Faye-Lund wrote: >> >> On Wed, Nov 6, 2013 at 7:49 PM, Paul Berry >> wrote: >> > On 6 November 2013 09:35, Erik Faye-Lund wrote: >> >> >> >> Sorry for the late reply. >> >> >> >> On Fri, Nov 1, 2013 at 4:14 PM, T

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-06 Thread Paul Berry
On 6 November 2013 11:24, Erik Faye-Lund wrote: > On Wed, Nov 6, 2013 at 7:49 PM, Paul Berry > wrote: > > On 6 November 2013 09:35, Erik Faye-Lund wrote: > >> > >> Sorry for the late reply. > >> > >> On Fri, Nov 1, 2013 at 4:14 PM, Tapani wrote: > >> > On 11/01/2013 03:31 PM, Erik Faye-Lund wr

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-06 Thread Paul Berry
On 6 November 2013 11:24, Erik Faye-Lund wrote: > On Wed, Nov 6, 2013 at 7:49 PM, Paul Berry > wrote: > > On 6 November 2013 09:35, Erik Faye-Lund wrote: > >> > >> Sorry for the late reply. > >> > >> On Fri, Nov 1, 2013 at 4:14 PM, Tapani wrote: > >> > On 11/01/2013 03:31 PM, Erik Faye-Lund wr

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-06 Thread Erik Faye-Lund
On Wed, Nov 6, 2013 at 7:49 PM, Paul Berry wrote: > On 6 November 2013 09:35, Erik Faye-Lund wrote: >> >> Sorry for the late reply. >> >> On Fri, Nov 1, 2013 at 4:14 PM, Tapani wrote: >> > On 11/01/2013 03:31 PM, Erik Faye-Lund wrote: >> >> >> >> >> >> Won't using the git-sha1 as a compatibility

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-06 Thread Paul Berry
On 6 November 2013 09:35, Erik Faye-Lund wrote: > Sorry for the late reply. > > On Fri, Nov 1, 2013 at 4:14 PM, Tapani wrote: > > On 11/01/2013 03:31 PM, Erik Faye-Lund wrote: > >> > >> > >> Won't using the git-sha1 as a compatibility-criteria cause issues for > >> developers with local changes?

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-06 Thread Erik Faye-Lund
Sorry for the late reply. On Fri, Nov 1, 2013 at 4:14 PM, Tapani wrote: > On 11/01/2013 03:31 PM, Erik Faye-Lund wrote: >> >> >> Won't using the git-sha1 as a compatibility-criteria cause issues for >> developers with local changes? I'm not so worried about this for >> OES_get_program_binary itse

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-05 Thread Tapani Pälli
On 11/06/2013 12:14 AM, Paul Berry wrote: On 1 November 2013 05:08, Tapani Pälli > wrote: On 11/01/2013 12:38 PM, Erik Faye-Lund wrote: On Fri, Nov 1, 2013 at 11:35 AM, Tapani Pälli mailto:tapani.pa...@intel.com>> wrote: On 11/01/2

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-05 Thread Paul Berry
On 1 November 2013 05:08, Tapani Pälli wrote: > On 11/01/2013 12:38 PM, Erik Faye-Lund wrote: > >> On Fri, Nov 1, 2013 at 11:35 AM, Tapani Pälli >> wrote: >> >>> On 11/01/2013 12:21 PM, Erik Faye-Lund wrote: >>> Won't using the git-sha1 as a compatibility-criteria cause issues for

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-01 Thread Tapani
On 11/01/2013 03:31 PM, Erik Faye-Lund wrote: Won't using the git-sha1 as a compatibility-criteria cause issues for developers with local changes? I'm not so worried about this for OES_get_program_binary itself, but once the shader-cache is in place it sounds like a potential source of difficult

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-01 Thread Erik Faye-Lund
On Fri, Nov 1, 2013 at 1:08 PM, Tapani Pälli wrote: > On 11/01/2013 12:38 PM, Erik Faye-Lund wrote: >> >> On Fri, Nov 1, 2013 at 11:35 AM, Tapani Pälli >> wrote: >>> >>> On 11/01/2013 12:21 PM, Erik Faye-Lund wrote: On Fri, Nov 1, 2013 at 10:16 AM, Tapani Pälli wrote: > >

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-01 Thread Tapani Pälli
On 11/01/2013 12:38 PM, Erik Faye-Lund wrote: On Fri, Nov 1, 2013 at 11:35 AM, Tapani Pälli wrote: On 11/01/2013 12:21 PM, Erik Faye-Lund wrote: On Fri, Nov 1, 2013 at 10:16 AM, Tapani Pälli wrote: Signed-off-by: Tapani Pälli --- src/mesa/main/shaderapi.c | 46 +++

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-01 Thread Erik Faye-Lund
On Fri, Nov 1, 2013 at 11:35 AM, Tapani Pälli wrote: > On 11/01/2013 12:21 PM, Erik Faye-Lund wrote: >> >> On Fri, Nov 1, 2013 at 10:16 AM, Tapani Pälli >> wrote: >>> >>> Signed-off-by: Tapani Pälli >>> --- >>> src/mesa/main/shaderapi.c | 46 >>> +++--- >

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-01 Thread Tapani Pälli
On 11/01/2013 12:21 PM, Erik Faye-Lund wrote: On Fri, Nov 1, 2013 at 10:16 AM, Tapani Pälli wrote: Signed-off-by: Tapani Pälli --- src/mesa/main/shaderapi.c | 46 +++--- 1 file changed, 39 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/shad

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-01 Thread Erik Faye-Lund
On Fri, Nov 1, 2013 at 10:16 AM, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > --- > src/mesa/main/shaderapi.c | 46 +++--- > 1 file changed, 39 insertions(+), 7 deletions(-) > > diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c > in

[Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

2013-11-01 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/mesa/main/shaderapi.c | 46 +++--- 1 file changed, 39 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 7da860d..67aee6b 100644 --- a/src/mesa/main/shaderapi.c +++ b/s