Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-13 Thread Brian Paul
On 06/13/2016 10:04 AM, Marek Olšák wrote: On Mon, Jun 13, 2016 at 5:17 PM, Roland Scheidegger wrote: Am 13.06.2016 um 14:53 schrieb Marek Olšák: On Mon, Jun 13, 2016 at 1:14 PM, Jose Fonseca wrote: On 10/06/16 15:40, Roland Scheidegger wrote: Am 10.06.2016 um 12:38 schrieb Marek Olšák:

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-13 Thread Marek Olšák
On Mon, Jun 13, 2016 at 5:17 PM, Roland Scheidegger wrote: > Am 13.06.2016 um 14:53 schrieb Marek Olšák: >> On Mon, Jun 13, 2016 at 1:14 PM, Jose Fonseca wrote: >>> On 10/06/16 15:40, Roland Scheidegger wrote: Am 10.06.2016 um 12:38 schrieb Marek Olšák: > > On Fri, Jun 10, 2016

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-13 Thread Roland Scheidegger
Am 13.06.2016 um 14:53 schrieb Marek Olšák: > On Mon, Jun 13, 2016 at 1:14 PM, Jose Fonseca wrote: >> On 10/06/16 15:40, Roland Scheidegger wrote: >>> >>> Am 10.06.2016 um 12:38 schrieb Marek Olšák: On Fri, Jun 10, 2016 at 6:19 AM, Roland Scheidegger wrote: > > Am 10.06.201

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-13 Thread Marek Olšák
On Mon, Jun 13, 2016 at 1:14 PM, Jose Fonseca wrote: > On 10/06/16 15:40, Roland Scheidegger wrote: >> >> Am 10.06.2016 um 12:38 schrieb Marek Olšák: >>> >>> On Fri, Jun 10, 2016 at 6:19 AM, Roland Scheidegger >>> wrote: Am 10.06.2016 um 05:14 schrieb Ilia Mirkin: > > On Thu, Ju

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-13 Thread Jose Fonseca
On 10/06/16 15:40, Roland Scheidegger wrote: Am 10.06.2016 um 12:38 schrieb Marek Olšák: On Fri, Jun 10, 2016 at 6:19 AM, Roland Scheidegger wrote: Am 10.06.2016 um 05:14 schrieb Ilia Mirkin: On Thu, Jun 9, 2016 at 11:13 PM, Roland Scheidegger wrote: Am 10.06.2016 um 04:58 schrieb Roland Sc

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-10 Thread Roland Scheidegger
Am 10.06.2016 um 12:38 schrieb Marek Olšák: > On Fri, Jun 10, 2016 at 6:19 AM, Roland Scheidegger > wrote: >> Am 10.06.2016 um 05:14 schrieb Ilia Mirkin: >>> On Thu, Jun 9, 2016 at 11:13 PM, Roland Scheidegger >>> wrote: Am 10.06.2016 um 04:58 schrieb Roland Scheidegger: > Am 10.06.201

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-10 Thread Marek Olšák
On Fri, Jun 10, 2016 at 6:19 AM, Roland Scheidegger wrote: > Am 10.06.2016 um 05:14 schrieb Ilia Mirkin: >> On Thu, Jun 9, 2016 at 11:13 PM, Roland Scheidegger >> wrote: >>> Am 10.06.2016 um 04:58 schrieb Roland Scheidegger: Am 10.06.2016 um 03:11 schrieb Ilia Mirkin: > On Thu, Jun 9, 2

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-09 Thread Ilia Mirkin
On Fri, Jun 10, 2016 at 12:19 AM, Roland Scheidegger wrote: > Am 10.06.2016 um 05:14 schrieb Ilia Mirkin: >> On Thu, Jun 9, 2016 at 11:13 PM, Roland Scheidegger >> wrote: >>> Am 10.06.2016 um 04:58 schrieb Roland Scheidegger: Am 10.06.2016 um 03:11 schrieb Ilia Mirkin: > On Thu, Jun 9,

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-09 Thread Roland Scheidegger
Am 10.06.2016 um 05:14 schrieb Ilia Mirkin: > On Thu, Jun 9, 2016 at 11:13 PM, Roland Scheidegger > wrote: >> Am 10.06.2016 um 04:58 schrieb Roland Scheidegger: >>> Am 10.06.2016 um 03:11 schrieb Ilia Mirkin: On Thu, Jun 9, 2016 at 9:07 PM, Ilia Mirkin wrote: > On Wed, Jun 8, 2016 at 5:

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-09 Thread Ilia Mirkin
On Thu, Jun 9, 2016 at 11:13 PM, Roland Scheidegger wrote: > Am 10.06.2016 um 04:58 schrieb Roland Scheidegger: >> Am 10.06.2016 um 03:11 schrieb Ilia Mirkin: >>> On Thu, Jun 9, 2016 at 9:07 PM, Ilia Mirkin wrote: On Wed, Jun 8, 2016 at 5:48 PM, Fredrik Höglund wrote: > On Wednesday 08

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-09 Thread Roland Scheidegger
Am 10.06.2016 um 04:58 schrieb Roland Scheidegger: > Am 10.06.2016 um 03:11 schrieb Ilia Mirkin: >> On Thu, Jun 9, 2016 at 9:07 PM, Ilia Mirkin wrote: >>> On Wed, Jun 8, 2016 at 5:48 PM, Fredrik Höglund wrote: On Wednesday 08 June 2016, Ilia Mirkin wrote: > Glancing at the code (I don't

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-09 Thread Ilia Mirkin
On Thu, Jun 9, 2016 at 10:58 PM, Roland Scheidegger wrote: > Am 10.06.2016 um 03:11 schrieb Ilia Mirkin: >> On Thu, Jun 9, 2016 at 9:07 PM, Ilia Mirkin wrote: >>> On Wed, Jun 8, 2016 at 5:48 PM, Fredrik Höglund wrote: On Wednesday 08 June 2016, Ilia Mirkin wrote: > Glancing at the code

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-09 Thread Roland Scheidegger
Am 10.06.2016 um 03:11 schrieb Ilia Mirkin: > On Thu, Jun 9, 2016 at 9:07 PM, Ilia Mirkin wrote: >> On Wed, Jun 8, 2016 at 5:48 PM, Fredrik Höglund wrote: >>> On Wednesday 08 June 2016, Ilia Mirkin wrote: Glancing at the code (I don't even have a piglit checkout here): static void

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-09 Thread Ilia Mirkin
On Thu, Jun 9, 2016 at 9:07 PM, Ilia Mirkin wrote: > On Wed, Jun 8, 2016 at 5:48 PM, Fredrik Höglund wrote: >> On Wednesday 08 June 2016, Ilia Mirkin wrote: >>> Glancing at the code (I don't even have a piglit checkout here): >>> >>> static void >>> set_ubo_binding(struct gl_context *ctx, ...) >>

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-09 Thread Ilia Mirkin
On Wed, Jun 8, 2016 at 5:48 PM, Fredrik Höglund wrote: > On Wednesday 08 June 2016, Ilia Mirkin wrote: >> Glancing at the code (I don't even have a piglit checkout here): >> >> static void >> set_ubo_binding(struct gl_context *ctx, ...) >> ... >>/* If this is a real buffer object, mark it has

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-08 Thread Fredrik Höglund
On Wednesday 08 June 2016, Ilia Mirkin wrote: > Glancing at the code (I don't even have a piglit checkout here): > > static void > set_ubo_binding(struct gl_context *ctx, ...) > ... >/* If this is a real buffer object, mark it has having been used > * at some point as a UBO. > */ >

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-08 Thread Ilia Mirkin
Glancing at the code (I don't even have a piglit checkout here): static void set_ubo_binding(struct gl_context *ctx, ...) ... /* If this is a real buffer object, mark it has having been used * at some point as a UBO. */ if (size >= 0) bufObj->UsageHistory |= USAGE_UNIFORM_BUFFE

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-08 Thread Ilia Mirkin
Hm, that's odd. I guess the buffer usage doesn't get set properly? I won't be able to look at this until tonight at the earliest, feel free to revert the change in the meanwhile. -ilia On Wed, Jun 8, 2016 at 1:25 PM, Brian Paul wrote: > Ilia, this patch causes a regression in the piglit > arb_

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-08 Thread Brian Paul
Ilia, this patch causes a regression in the piglit arb_uniform_buffer_object-rendering-dsa test with llvmpipe (at least). I haven't debugged it at all. -Brian On 06/07/2016 08:29 PM, Ilia Mirkin wrote: Module: Mesa Branch: master Commit: 6e6fd911da8a1d9cd62fe0a8a4cc0fb7bdccfe02 URL: https