On Wed, 4 May 2011 18:21:20 -0700, Jesse Barnes jbar...@virtuousgeek.org
wrote:
On Thu, 5 May 2011 11:17:02 +1000
Dave Airlie airl...@gmail.com wrote:
So I wasn't watching and glproto broke its interface, and I think its bad.
Why?
You can no longer bisect things across this point
On Wed, 4 May 2011 21:29:23 -0700
Jeremy Huddleston jerem...@freedesktop.org wrote:
Yeah... so considering the comments in mesa-dev earlier today, I was really
surprised to see that glproto and dri2proto were tagged today. I think we
need to brownbag retract and rethink this.
Damnit; right
Why is sbc a 32bit field in xGLXBufferSwapComplete2 and
xDRI2BufferSwapComplete2 when it is a 64bit field in GLXBufferSwapComplete?
The hunk at the bottom will result in casting a 64bit int to a 32bit int. If
you're going to change this, shouldn't you also change GLXBufferSwapComplete,
On Thu, 5 May 2011 10:07:24 -0700
Jeremy Huddleston jerem...@freedesktop.org wrote:
Why is sbc a 32bit field in xGLXBufferSwapComplete2 and
xDRI2BufferSwapComplete2 when it is a 64bit field in GLXBufferSwapComplete?
The hunk at the bottom will result in casting a 64bit int to a 32bit int.
So I wasn't watching and glproto broke its interface, and I think its bad.
Why?
You can no longer bisect things across this point without now moving glproto.
glxproto.h:xGLXBufferSwapComplete was a released header file
definition, you cannot go back and change history.
This should have been
On Thu, 5 May 2011 11:17:02 +1000
Dave Airlie airl...@gmail.com wrote:
So I wasn't watching and glproto broke its interface, and I think its bad.
Why?
You can no longer bisect things across this point without now moving glproto.
glxproto.h:xGLXBufferSwapComplete was a released header file
Yeah... so considering the comments in mesa-dev earlier today, I was really
surprised to see that glproto and dri2proto were tagged today. I think we need
to brownbag retract and rethink this.
These changes break API. I'm all for fixing the structs, but anything that
breaks API (or worse,