Re: [Mesa-dev] [PATCH 1/3] i965: Don't forget the cube map padding on gen5+.

2013-10-08 Thread Eric Anholt
Kenneth Graunke writes: > On 10/08/2013 10:36 AM, Eric Anholt wrote: >> We had a fixup for gen4's 3d-layout cubemaps (which, iirc, we'd >> experimentally found to be necessary!), but while the spec still requires >> it on gen5, we'd been missing it in the array-layout cubemaps. > > Ah, I see it n

Re: [Mesa-dev] [PATCH 1/3] i965: Don't forget the cube map padding on gen5+.

2013-10-08 Thread Chad Versace
On 10/08/2013 10:36 AM, Eric Anholt wrote: We had a fixup for gen4's 3d-layout cubemaps (which, iirc, we'd experimentally found to be necessary!), but while the spec still requires it on gen5, we'd been missing it in the array-layout cubemaps. Cc: "9.1 9.2" --- src/mesa/drivers/dri/i965/brw_t

Re: [Mesa-dev] [PATCH 1/3] i965: Don't forget the cube map padding on gen5+.

2013-10-08 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/08/2013 01:28 PM, Eric Anholt wrote: > Ian Romanick writes: > >> On 10/08/2013 10:36 AM, Eric Anholt wrote: >>> We had a fixup for gen4's 3d-layout cubemaps (which, iirc, >>> we'd experimentally found to be necessary!), but while the spec >>> s

Re: [Mesa-dev] [PATCH 1/3] i965: Don't forget the cube map padding on gen5+.

2013-10-08 Thread Kenneth Graunke
On 10/08/2013 10:36 AM, Eric Anholt wrote: > We had a fixup for gen4's 3d-layout cubemaps (which, iirc, we'd > experimentally found to be necessary!), but while the spec still requires > it on gen5, we'd been missing it in the array-layout cubemaps. Ah, I see it now: >From the Sandybridge PRM, Vo

Re: [Mesa-dev] [PATCH 1/3] i965: Don't forget the cube map padding on gen5+.

2013-10-08 Thread Kenneth Graunke
On 10/08/2013 11:22 AM, Ian Romanick wrote: > On 10/08/2013 10:36 AM, Eric Anholt wrote: >> We had a fixup for gen4's 3d-layout cubemaps (which, iirc, we'd >> experimentally found to be necessary!), but while the spec still requires >> it on gen5, we'd been missing it in the array-layout cubemaps.

Re: [Mesa-dev] [PATCH 1/3] i965: Don't forget the cube map padding on gen5+.

2013-10-08 Thread Eric Anholt
Ian Romanick writes: > On 10/08/2013 10:36 AM, Eric Anholt wrote: >> We had a fixup for gen4's 3d-layout cubemaps (which, iirc, we'd >> experimentally found to be necessary!), but while the spec still requires >> it on gen5, we'd been missing it in the array-layout cubemaps. > > I think we didn't

Re: [Mesa-dev] [PATCH 1/3] i965: Don't forget the cube map padding on gen5+.

2013-10-08 Thread Ian Romanick
On 10/08/2013 10:36 AM, Eric Anholt wrote: > We had a fixup for gen4's 3d-layout cubemaps (which, iirc, we'd > experimentally found to be necessary!), but while the spec still requires > it on gen5, we'd been missing it in the array-layout cubemaps. I think we didn't bother with that patch because