Re: [Mesa-dev] [PATCH 08/64] i965/blorp: Only set src_z for gen8+ 3D textures

2016-06-17 Thread Jason Ekstrand
On Thu, Jun 16, 2016 at 10:08 AM, Chad Versace wrote: > On Sat 11 Jun 2016, Jason Ekstrand wrote: > > Otherwise, we end up with a bogus value in the third component. On > gen6-7 > > where we always use 2D textures, this can cause problems if the > > SurfaceArray bit is

Re: [Mesa-dev] [PATCH] glcpp: Only expose ARB_enhanced_layouts if it's supported.

2016-06-17 Thread Dylan Baker
Quoting Jason Ekstrand (2016-06-17 11:15:54) > > On Jun 17, 2016 11:07 AM, "Dylan Baker" wrote: > > > > Quoting Ian Romanick (2016-06-16 20:07:14) > > > This patch is > > > > > > Reviewed-by: Ian Romanick > > > > > > On 06/16/2016 06:15 PM, Dylan

[Mesa-dev] [PATCH] wayland-drm: add missing NULL check

2016-06-17 Thread Frank Binns
Although malloc is unlikely to fail check its return value nevertheless. Signed-off-by: Frank Binns --- src/egl/wayland/wayland-drm/wayland-drm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/egl/wayland/wayland-drm/wayland-drm.c

[Mesa-dev] [PATCH] loader: fix sysfs uevent file parsing

2016-06-17 Thread Frank Binns
When trying to get a device name for an fd using sysfs, it would always fail as it was expecting key/value pairs to be delimited by '\0', which is not the case. Signed-off-by: Frank Binns --- src/loader/loader.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

Re: [Mesa-dev] [PATCH] glcpp: Only expose ARB_enhanced_layouts if it's supported.

2016-06-17 Thread Dylan Baker
Quoting Ian Romanick (2016-06-16 20:07:14) > This patch is > > Reviewed-by: Ian Romanick > > On 06/16/2016 06:15 PM, Dylan Baker wrote: > > This fixes the following piglit tests: > > spec/arb_enhanced_layouts/preprocessor/disabled-defined-core.* > > > > Signed-off-by:

Re: [Mesa-dev] [PATCH] glcpp: Only expose ARB_enhanced_layouts if it's supported.

2016-06-17 Thread Jason Ekstrand
On Jun 17, 2016 11:07 AM, "Dylan Baker" wrote: > > Quoting Ian Romanick (2016-06-16 20:07:14) > > This patch is > > > > Reviewed-by: Ian Romanick > > > > On 06/16/2016 06:15 PM, Dylan Baker wrote: > > > This fixes the following piglit tests: > > >

Re: [Mesa-dev] [PATCH 2/2] radeonsi: use trapezoid distribution for tess on Fiji and Polaris

2016-06-17 Thread Alex Deucher
On Fri, Jun 17, 2016 at 2:10 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This yields a small performance improvement in Unigine Heaven. For the series: Reviewed-by: Alex Deucher > --- >

Re: [Mesa-dev] [RFC 7/7] radeon: remove screen ref counting

2016-06-17 Thread Emil Velikov
On 17 June 2016 at 18:45, Rob Herring wrote: > Now that the pipe-loader is reference counting the screen creation, it > is unnecessary to do in it the winsys/driver. > > Signed-off-by: Rob Herring > Cc: "Marek Olšák" > Cc: Ilia Mirkin

Re: [Mesa-dev] [PATCH 25/64] isl/state: Use TILEWALK_XMAJOR for linear surfaces on gen7

2016-06-17 Thread Chad Versace
Patches 24 and 25 are Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Mesa-stable] [PATCH] swr: switch from overriding -march to selecting features

2016-06-17 Thread Rowley, Timothy O
> On Jun 17, 2016, at 2:25 PM, Emil Velikov wrote: > > On 17 June 2016 at 14:06, Chuck Atkins wrote: >> Using these adjusted flags, I can verify SWR running on Intel SandyBridge, >> Intel Haswell, and AMD Interlagos. >> > Not only building

[Mesa-dev] [PATCH 1/5] anv/dump: Take an aspect in dump_image_to_ppm

2016-06-17 Thread Jason Ekstrand
--- src/intel/vulkan/anv_dump.c| 10 -- src/intel/vulkan/anv_private.h | 3 ++- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_dump.c b/src/intel/vulkan/anv_dump.c index 63ad2cd..307e501 100644 --- a/src/intel/vulkan/anv_dump.c +++

[Mesa-dev] [PATCH 04/11] anv/pipeline: Do invariance propagation on SPIR-V shaders

2016-06-17 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" Cc: Kenneth Graunke --- src/intel/vulkan/anv_pipeline.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/vulkan/anv_pipeline.c

[Mesa-dev] [PATCH 08/11] anv: Add proper support for depth clamping

2016-06-17 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" Cc: Kenneth Graunke --- src/intel/vulkan/anv_device.c | 2 +- src/intel/vulkan/anv_meta_clear.c | 1 + src/intel/vulkan/anv_pipeline.c| 2 ++

[Mesa-dev] [PATCH 07/11] anv/cmd_buffer: Split emit_viewport in two

2016-06-17 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" Cc: Kenneth Graunke --- src/intel/vulkan/anv_private.h | 1 + src/intel/vulkan/gen8_cmd_buffer.c | 38 ++

[Mesa-dev] [PATCH 03/11] nir/alu_to_scalar: Respect the exact ALU operation qualifier

2016-06-17 Thread Jason Ekstrand
Just setting builder->exact isn't sufficient because that only applies to instructions that are built with the builder but instructions created manually and only inserted using the builder are left alone. Signed-off-by: Jason Ekstrand Cc: "12.0"

[Mesa-dev] [PATCH 05/11] anv/cmd_buffer: Don't crash if push constants are provided for missing stages

2016-06-17 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/intel/vulkan/anv_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_cmd_buffer.c b/src/intel/vulkan/anv_cmd_buffer.c index

[Mesa-dev] [PATCH 06/11] anv/cmd_buffer: Set depth/stencil extent based on the image

2016-06-17 Thread Jason Ekstrand
It used to be based on the framebuffer which isn't quite right. Signed-off-by: Jason Ekstrand Cc: Chad Versace Cc: "12.0" --- src/intel/vulkan/genX_cmd_buffer.c | 10 +- 1 file changed, 5 insertions(+), 5

Re: [Mesa-dev] [PATCH 05/14] swr: [rasterizer jitter] cleanup supporting different llvm versions

2016-06-17 Thread Emil Velikov
Hi Tim, Does this commit allows us to have generic generated files or it's solely workaround the VPERMD intrinsic argument swap ? On 17 June 2016 at 20:25, Tim Rowley wrote: > @@ -31,8 +31,8 @@ > #pragma warning(disable: 4800 4146 4244 4267 4355 4996) > #endif > >

Re: [Mesa-dev] [Mesa-stable] [PATCH] mapi: Export all GLES 3.1 functions in libGLESv2.so

2016-06-17 Thread Emil Velikov
On 17 June 2016 at 21:12, Mike Gorchak wrote: > Please understand me right, we are not talking about desktop hardware and > libraries, only about embedded in case of GL ES. GLES hasn't been "embedded only" for a while I believe. > What's common for desktop > usually

[Mesa-dev] [PATCH] vc4: add hash table look-up for exported dmabufs

2016-06-17 Thread Rob Herring
It is necessary to reuse existing BOs when dmabufs are imported. There are 2 cases that need to be handled. dmabufs can be created/exported and imported by the same process and can be imported multiple times. Copying other drivers, add a hash table to track exported BOs so the BOs get reused. Cc:

Re: [Mesa-dev] [PATCH] swr: Update screen->context pointer with multiple contexts.

2016-06-17 Thread Cherniak, Bruce
> On Jun 17, 2016, at 8:56 AM, Rowley, Timothy O > wrote: > > >> On Jun 17, 2016, at 8:58 AM, Bruce Cherniak wrote: >> >> A pipe pointer in the screen allows for access to current device context >> in flush_frontbuffer and

Re: [Mesa-dev] [PATCH] swr: Update screen->context pointer with multiple contexts.

2016-06-17 Thread Chuck Atkins
Hey, we've all made those commits at one point or another. +1 for code review! - Chuck On Fri, Jun 17, 2016 at 10:18 AM, Cherniak, Bruce wrote: > > > On Jun 17, 2016, at 8:56 AM, Rowley, Timothy O < > timothy.o.row...@intel.com> wrote: > > > > > >> On Jun 17, 2016,

Re: [Mesa-dev] [PATCH] mesa: remove remaining tabs in api_validate.c

2016-06-17 Thread
Hello. Are you editing those files by hand? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 3/3] radeonsi: emit PA_SC_RASTER_CONFIG_1 only once

2016-06-17 Thread Nicolai Hähnle
From: Nicolai Hähnle It is the same for all SEs. --- src/gallium/drivers/radeonsi/si_state.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c

Re: [Mesa-dev] [PATCH v4] gallium: add API for setting window rectangles

2016-06-17 Thread Nicolai Hähnle
FYI, in case you haven't heard: the corresponding hardware feature on Radeon allows four rectangles, and specifying an arbitrary logic function over them. That is, there are 2^4 = 16 bits specifying when fragments are discarded. If we wanted to expose that at some point, we'd have to uglify

Re: [Mesa-dev] [PATCH v4] gallium: add API for setting window rectangles

2016-06-17 Thread Ilia Mirkin
On Fri, Jun 17, 2016 at 12:02 PM, Nicolai Hähnle wrote: > FYI, in case you haven't heard: the corresponding hardware feature on Radeon > allows four rectangles, and specifying an arbitrary logic function over > them. That is, there are 2^4 = 16 bits specifying when fragments

Re: [Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

2016-06-17 Thread Jose Fonseca
On 16/06/16 18:15, Brian Paul wrote: To match what's done in the automake build. v2: Use git rev-parse to get a 10-character hash ID Fix Python imports --- src/SConscript | 49 - src/mesa/SConscript | 45

Re: [Mesa-dev] [RFC] New dma_buf -> EGLImage EGL extension - Final spec published!

2016-06-17 Thread Rob Clark
On Fri, Jun 17, 2016 at 9:31 AM, Pekka Paalanen wrote: > On Fri, 17 Jun 2016 08:26:04 -0400 > Rob Clark wrote: > >> On Fri, Jun 17, 2016 at 3:59 AM, Pekka Paalanen wrote: >> > On Thu, 16 Jun 2016 10:40:51 -0400 >> > Rob Clark

Re: [Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

2016-06-17 Thread Christian König
Really nice work. I now understand where your problem is with the scaled surface. Please see the further comments below. Am 16.06.2016 um 20:15 schrieb Nayan Deshmukh: v2: fix a typo and add a newline to code Signed-off-by: Nayan Deshmukh ---

Re: [Mesa-dev] [PATCH 0/7] st/mesa: glReadPixels cache

2016-06-17 Thread Nicolai Hähnle
On 15.06.2016 17:16, Brian Paul wrote: On 06/15/2016 02:38 AM, Nicolai Hähnle wrote: Hi, some applications use successive calls to glReadPixels to read data back. This typically involves a GPU-based blit for each call for de-tiling or format conversions (e.g. BGRA -> RGBA). Even when the

Re: [Mesa-dev] [PATCH 1/3] radeonsi: raise SI_PM4_MAX_DW

2016-06-17 Thread Alex Deucher
On Fri, Jun 17, 2016 at 10:09 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The old limit, introduced in commit afa752d3f03ac6697581ff5d324e8ac0512ef513, > was exceeded by 4 SE configurations which hit > si_write_harvested_raster_configs. > >

[Mesa-dev] [PATCH v2] swr: push/pop DEBUG macro around llvm includes

2016-06-17 Thread Tim Rowley
llvm redefines DEBUG; adding push/pop prevents a undefined reference to debug_refcnt_state in llvm-3.7+. v2: add undef DEBUG --- src/gallium/drivers/swr/swr_shader.cpp | 10 +++--- src/gallium/drivers/swr/swr_state.cpp | 7 ++- 2 files changed, 13 insertions(+), 4 deletions(-) diff

Re: [Mesa-dev] [RFC 7/7] radeon: remove screen ref counting

2016-06-17 Thread Rob Herring
On Fri, Jun 17, 2016 at 2:49 PM, Emil Velikov wrote: > On 17 June 2016 at 20:05, Rob Herring wrote: >> On Fri, Jun 17, 2016 at 1:45 PM, Emil Velikov >> wrote: >>> On 17 June 2016 at 18:45, Rob Herring wrote:

Re: [Mesa-dev] [Mesa-stable] [PATCH] mapi: Export all GLES 3.1 functions in libGLESv2.so

2016-06-17 Thread Jason Ekstrand
On Fri, Jun 17, 2016 at 2:09 PM, Emil Velikov wrote: > On 17 June 2016 at 21:12, Mike Gorchak wrote: > > Please understand me right, we are not talking about desktop hardware and > > libraries, only about embedded in case of GL ES. > GLES

Re: [Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

2016-06-17 Thread Eric Engestrom
On Thu, Jun 16, 2016 at 11:15:55AM -0600, Brian Paul wrote: > To match what's done in the automake build. > > v2: Use git rev-parse to get a 10-character hash ID > Fix Python imports > --- Perfect, thanks! Reviewed-by: Eric Engestrom

Re: [Mesa-dev] [PATCH] mesa: remove remaining tabs in api_validate.c

2016-06-17 Thread Eric Engestrom
On Fri, Jun 17, 2016 at 04:09:55PM +0200, ⚛ wrote: > Hello. Are you editing those files by hand? Yup, editing everything by hand. You just need a magnetized needle and a steady hand. I'm still learning to use C-x M-c M-butterfly though, haven't mastered that yet.

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Fix single-precision to double-precision conversions for CHV/BSW

2016-06-17 Thread Kenneth Graunke
On Wednesday, June 15, 2016 9:25:44 AM PDT Samuel Iglesias Gonsálvez wrote: > From: Iago Toral Quiroga > > From the Cherryview PRM, Volume 7, 3D Media GPGPU Engine, > Register Region Restrictions: > >"When source or destination is 64b (...), regioning in Align1 > must

Re: [Mesa-dev] [RFC] New dma_buf -> EGLImage EGL extension - Final spec published!

2016-06-17 Thread Pekka Paalanen
On Thu, 16 Jun 2016 10:40:51 -0400 Rob Clark wrote: > So, if we wanted to extend this to support the fourcc-modifiers that > we have on the kernel side for compressed/tiled/etc formats, what > would be the right approach? > > A new version of the existing extension or a new

<    1   2