[Mesa-dev] [RFC 00/13] Start using Khronos XML for generators

2018-11-23 Thread Dylan Baker
Currently we have two XML sources in mesa, the khronos xml, and the mesa xml. The mesa xml is incredibly inaccurate (look at the number of commits to fix it), has to be hand rolled for each extension, and has to be tracked individually by build systems. The mesa xml is also problematic because it c

[Mesa-dev] [RFC 03/13] glapi/gen: Add some helpers that will be used generators

2018-11-23 Thread Dylan Baker
This is mostly mako related stuff. --- src/mapi/glapi/gen/helpers.py | 33 + src/mapi/glapi/gen/templates/copyright.mako | 25 src/mapi/glapi/gen/templates/helpers.mako | 29 ++ 3 files changed, 87 insertions(+) create mode 1006

[Mesa-dev] [RFC 12/13] fixup! wip

2018-11-23 Thread Dylan Baker
--- src/mapi/glapi/gen/khr_xml.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/khr_xml.py b/src/mapi/glapi/gen/khr_xml.py index 7909afb922d..c3efa5007d9 100644 --- a/src/mapi/glapi/gen/khr_xml.py +++ b/src/mapi/glapi/gen/khr_xml.py @@ -182,7 +182,7 @@ clas

[Mesa-dev] [RFC 08/13] mapi/glapi/gen: Use new infastructure for gl_marshal_h.py

2018-11-23 Thread Dylan Baker
This is identical, except for 240 new entries that weren't generated. I believe this is a bug in the current implementation because the mesa XML is wrong (surprise!), namely that it lacks metadata for a number of functions that take arrays about the length of those arrays. --- src/mapi/glapi/gen/M

[Mesa-dev] [RFC 04/13] gl.xml: update to git commit 58fcee1918e90cb817693c6df8c1f8d3e4f3e48e

2018-11-23 Thread Dylan Baker
--- src/mapi/glapi/registry/gl.xml | 4332 +++- 1 file changed, 3193 insertions(+), 1139 deletions(-) diff --git a/src/mapi/glapi/registry/gl.xml b/src/mapi/glapi/registry/gl.xml index 13882eff7bb..3b7805e9400 100644 --- a/src/mapi/glapi/registry/gl.xml +++ b/src/mapi/

[Mesa-dev] [RFC 02/13] glapi/gen: use main function in gl_marshal_h.py

2018-11-23 Thread Dylan Baker
It's more idiomatic python. --- src/mapi/glapi/gen/gl_marshal_h.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_marshal_h.py b/src/mapi/glapi/gen/gl_marshal_h.py index d870bba5ed6..619754e05c6 100644 --- a/src/mapi/glapi/gen/gl_marshal_h.py +++ b/

[Mesa-dev] [RFC 13/13] wip: use new generator for marshal.c

2018-11-23 Thread Dylan Baker
--- src/mapi/glapi/gen/gl_marshal_h.py | 4 ++-- src/mapi/glapi/gen/meson.build | 10 ++ 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/mapi/glapi/gen/gl_marshal_h.py b/src/mapi/glapi/gen/gl_marshal_h.py index 91948177e33..76dd4f17108 100644 --- a/src/mapi/glapi/g

Re: [Mesa-dev] [RFC 12/13] fixup! wip

2018-11-23 Thread Jason Ekstrand
That is the lamest commit message I think I've ever seen. On Fri, Nov 23, 2018 at 4:29 PM Dylan Baker wrote: > --- > src/mapi/glapi/gen/khr_xml.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mapi/glapi/gen/khr_xml.py b/src/mapi/glapi/gen/khr_xml.py > index 7909a

[Mesa-dev] [PATCH] radeonsi: clean up primitive binning enablement

2018-11-23 Thread Marek Olšák
From: Marek Olšák no change in behavior. --- src/gallium/drivers/radeonsi/si_pipe.c | 27 +++--- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index c487ef43b52..9080de1ceca 100

[Mesa-dev] [PATCH 3/7] winsys/amdgpu: optimize slab allocation for 2 MB amdgpu page tables

2018-11-23 Thread Marek Olšák
From: Marek Olšák - the slab buffer size increased from 128 KB to 2 MB (PTE fragment size) - the max suballocated buffer size increased from 64 KB to 256 KB, this increases memory usage because it wastes memory - the number of suballocators increased from 1 to 3 and they are layered on top of

[Mesa-dev] [PATCH 2/7] radeonsi: generalize the slab allocator code to allow layered slab allocators

2018-11-23 Thread Marek Olšák
From: Marek Olšák There is no change in behavior. It just makes it easier to change the number of slab allocators. --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 60 +++ src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 40 + src/gallium/winsys/amdgpu/drm/amdgpu_wi

[Mesa-dev] [PATCH 4/7] winsys/amdgpu: clean up code around BO VM alignment

2018-11-23 Thread Marek Olšák
From: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c index a9271c33ee9..36e2c4ec0dc 100644 --- a/src/gallium/winsys/amdgp

[Mesa-dev] [PATCH 6/7] winsys/amdgpu: increase the VM alignment to the MSB of the size for Gfx9

2018-11-23 Thread Marek Olšák
From: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c index dd6c56600b7..3fc1da8b0b8 100644 --- a/src/gallium/winsys/a

[Mesa-dev] [PATCH 0/7] winsys/amdgpu: slab allocators and tweaks for address translation

2018-11-23 Thread Marek Olšák
Hi, This series changes the slab allocation to 3 slab allocators layered on top of each other, and increases the max slab entry size to 256 KB and the max slab size to 2 MB. There are also tweaks for faster address translation, though we don't know whether it helps anything. Please review. Tha

[Mesa-dev] [PATCH 1/7] winsys/amdgpu: always reclaim/release slabs if there is not enough memory

2018-11-23 Thread Marek Olšák
From: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c index 3ee38b8a79f..49de30bb57c 100644 --- a/src/gallium

[Mesa-dev] [PATCH 5/7] winsys/amdgpu: use >= instead of > for VM address alignment

2018-11-23 Thread Marek Olšák
From: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c index 36e2c4ec0dc..dd6c56600b7 100644 --- a/src/gallium/winsys/amdgpu/drm/amd

[Mesa-dev] [PATCH 7/7] winsys/amdgpu: overallocate buffers for faster address translation on Gfx9

2018-11-23 Thread Marek Olšák
From: Marek Olšák Sadly, the 3 games I tested (DeusEx:MD, DiRT Rally, DOTA 2) are unaffected by the overallocation, because I guess their buffers don't fall into the small range below a power-of-two size. --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 24 +++ 1 file changed,

Re: [Mesa-dev] [RFC 12/13] fixup! wip

2018-11-23 Thread Dylan Baker
Ah, but you only *think* it's the lamest message you've ever seen! Quoting Jason Ekstrand (2018-11-23 15:12:25) > That is the lamest commit message I think I've ever seen. > > On Fri, Nov 23, 2018 at 4:29 PM Dylan Baker wrote: > > --- >  src/mapi/glapi/gen/khr_xml.py | 2 +- >  1 fil

Re: [Mesa-dev] Lets talk about autotools

2018-11-23 Thread Marek Olšák
On Fri, Nov 16, 2018 at 11:05 PM Dylan Baker wrote: > Quoting Dylan Baker (2018-09-17 09:44:07) > > I feel like for !windows meson is in good enough shape at this point > that we > > can start having the discussion about deleting the autotools build. So, > is there > > anything left that autotool

Re: [Mesa-dev] [RFC 3/5] amd/nir: Implement the new ordered/unordered comparisons

2018-11-23 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Nov 22, 2018 at 1:47 PM Jason Ekstrand wrote: > They map directly to LLVM opcodes so it's really easy. > --- > src/amd/common/ac_nir_to_llvm.c | 16 ++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/src/amd/common/ac_ni

Re: [Mesa-dev] [PATCH v2] winsys/amdgpu: explicitly declare whether buffer_map is permanent or not

2018-11-23 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Nov 22, 2018 at 6:32 AM Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Introduce a new driver-private transfer flag RADEON_TRANSFER_TEMPORARY > that specifies whether the caller will use buffer_unmap or not. The > default behavior is set to permanent m

Re: [Mesa-dev] [PATCH 0/6] Use common code for gallium array setup.

2018-11-23 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Fri, Nov 23, 2018 at 3:08 AM wrote: > From: Mathias Fröhlich > > Hi, > > The series unifies functions for array setup into gallium. > Instead of just walking all VAO attributes we can make use of > the enabled and required attribute arrays al

<    1   2